serial_preference 1.0.1 → 1.1.0

data/README.md

@@ -68,8 +68,8 @@ Or install it yourself as:
     # something you can customize in your form perhaps?
     Company.preference_groups.each do |pg| # => returns an array of preference groups
       # pg.name => Name of Preference Group as specified in map e.g. Preferred Ledgers
-      # pg.preferences => Hash of Preference Definitions keyed by Preference Name e.g. :taxable, :vat_no etc.
-      pg.preferences.values.each do |preference|
+      # pg.preferences => Array of Preference Definitions
+      pg.preferences.each do |preference|
         # preference => PreferenceDefinition
         f.input preference.name, required: preference.required?, placeholder: preference.default, as: preference.field_type
       end

data/lib/serial_preference/has_preference_map.rb

@@ -21,6 +21,10 @@ module SerialPreference
         build_preference_definitions
       end
 
+      def preference_definition(name)
+        _preference_map.definition_for(name)
+      end
+
       private
 
       def build_preference_definitions
@@ -30,12 +34,12 @@ module SerialPreference
 
           key = preference.name
           define_method("#{key}=") do |value|
-            write_preference_attribute(_preferences_attribute,key,preference.value(value))
+            write_preference_attribute(_preferences_attribute,key,preference_definition(key).value(value))
           end
 
           define_method(key) do
             value = read_preference_attribute(_preferences_attribute,key)
-            preference.value(value)
+            preference_definition(key).value(value)
           end
 
           if preference.boolean?

data/lib/serial_preference/preferenzer.rb

@@ -48,7 +48,7 @@ module SerialPreference
     end
 
     def all_preference_definitions
-      preference_groups.map{|x|x.preferences.values}.flatten
+      @preference_names_cache.values
     end
 
     def all_preference_names
@@ -59,6 +59,10 @@ module SerialPreference
       @preference_groups.map{|x|x.name}
     end
 
+    def definition_for(name)
+      @preference_names_cache[name]
+    end
+
     private
 
     def activate_group(group_name = :base)
@@ -66,8 +70,8 @@ module SerialPreference
     end
 
     def push_preference(preference)
-      @preference_names_cache[preference.name] = 1
-      @current_group.preferences[preference.name] = preference
+      @preference_names_cache[preference.name] = preference
+      @current_group.preferences.push(preference)
     end
 
     def find_or_create_group(name)
@@ -79,7 +83,7 @@ module SerialPreference
     end
 
     def create_group(name = :base)
-      PreferenceGroup.new(name,{}).tap do |pg|
+      PreferenceGroup.new(name,[]).tap do |pg|
         @preference_groups.push(pg)
       end
     end

data/lib/serial_preference/version.rb

@@ -1,3 +1,3 @@
 module SerialPreference
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

data/spec/preferenzer_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe SerialPreference::Preferenzer do
 
   before(:each) do
-    @base = described_class::PreferenceGroup.new(:base,{})
+    @base = described_class::PreferenceGroup.new(:base,[])
     @preferenzer = described_class.new
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: serial_preference
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -130,7 +130,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4069385045996576704
+      hash: -3242840560395450762
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -139,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4069385045996576704
+      hash: -3242840560395450762
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24