sequential_workflow 0.0.3 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44813cdc0ed419b3cdb33f0bf07bbb5256431506
-  data.tar.gz: d6b8161462fa64ae7e24a692485e3c4c27c1bb2b
+  metadata.gz: 4560cdb72eede9486d425b49e056c3af117dee2b
+  data.tar.gz: 6c8020fa67b523c4728592f427a01ee68c7f9144
 SHA512:
-  metadata.gz: 2ac844182ad358d44f9aa1ab65b7b3cbc0ebef8d164f0986446d6edf13cc370ddff0b93296ea834cc2b5dd82c6448fa37bf4baf655b8e0c8488df425bb089cde
-  data.tar.gz: ae6c0e96f738c6bd8dfb7635fd18371dae54f643e5e810ee0e441ad5505449975771c4500938250110d0464c377c3cdff288edbc6954394c934ab117e4895d51
+  metadata.gz: 62ab68344fa9689ab19bfe1499826b2bd2848e3b72c1b86589fad0602af4a6dc36ea407b5e8cea20e96c7f9e23389373664afb39bca119047b5f5cfda046547b
+  data.tar.gz: 23420f2c44edc2d3be24d2c4a7f190a78490cfb8a458d070ad9690cc6294b1e834e7dbb557e79734d7ffa91f913cd7d4c8b2376da94db958095d6da16841f3b1

data/lib/sequential_workflow/version.rb

@@ -1,3 +1,3 @@
 module SequentialWorkflow
-  VERSION = "0.0.3"
+  VERSION = "0.0.5"
 end

data/lib/sequential_workflow.rb

@@ -12,20 +12,20 @@ module SequentialWorkflow
   end
 
   def catch(catch_with)
-    method(catch_with).call(@reason)
+    method(catch_with).call(@reason) if rejected?
   end
 
-  def then(on_success, rescue_with)
+  def then(on_success, rescue_with = nil)
     case workflow_state
     when :fulfilled
       result = method(on_success).call(@value)
       fulfill result
     when :rejected
-      method(rescue_with).call(@reason)
+      method(rescue_with).call(@reason) if rescue_with
       self
     end
   rescue => e
-    reject(e)
+    reject e
   end
 
   def fulfill(value)
@@ -39,4 +39,8 @@ module SequentialWorkflow
     @reason = e
     self
   end
+
+  def rejected?
+    @workflow_state == :rejected
+  end
 end

data/spec/sequential_workflow_spec.rb

@@ -5,18 +5,26 @@ RSpec.describe 'SequentialWorkflow' do
 
     def execute_workflow
       start(:bar)
-        .then(:first_method, nil)
-        .then(:second_method, :handle_previous_error)
-        .catch(:catch_method)
+      .then(:one)
+      .then(:two)
+      .then(:three, :handle_previous_error)
+      .then(:four)
+      .catch(:catch_method)
     end
 
     def bar
     end
 
-    def first_method(value)
+    def one(value)
     end
 
-    def second_method(value)
+    def two(value)
+    end
+
+    def three(value)
+    end
+
+    def four(value)
     end
 
     def handle_previous_error(e)
@@ -42,14 +50,14 @@ RSpec.describe 'SequentialWorkflow' do
       end
 
       it 'calls the next method with @value' do
-        expect(foo).to receive(:first_method).with(value)
+        expect(foo).to receive(:one).with(value)
         foo.execute_workflow
       end
     end
 
     context 'on rejection' do
       before do
-        allow(foo).to receive(:first_method).and_raise('Error')
+        allow(foo).to receive(:one).and_raise('Error')
       end
 
       it 'calls the rescue method' do
@@ -63,15 +71,28 @@ RSpec.describe 'SequentialWorkflow' do
       end
 
       it "doesn't call subsequent methods" do
+        expect(foo).not_to receive(:two)
+        foo.execute_workflow
+      end
+    end
+
+  end
+  describe '#catch' do
+    context 'on :rejected' do
+      before do
+        allow(foo).to receive(:one).and_raise('Error')
+      end
+
+      it 'runs the catch method' do
+        expect(foo).to receive(:catch_method).with(RuntimeError)
         foo.execute_workflow
-        expect(foo).not_to receive(:second_method)
       end
     end
 
-    describe '#catch' do
-      it 'runs if :rejected' do
+    context 'on :fulfilled' do
+      it 'does not run the catch method' do
+        expect(foo).not_to receive(:catch_method)
         foo.execute_workflow
-        expect(foo).not_to receive(:catch_method).with(RuntimeError)
       end
     end
   end

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: sequential_workflow
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - Dinshaw
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-20 00:00:00.000000000 Z
+date: 2014-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
-  prerelease: false
-  type: :development
 - !ruby/object:Gem::Dependency
   name: rake
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
-  prerelease: false
-  type: :development
 - !ruby/object:Gem::Dependency
   name: rspec
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-  prerelease: false
-  type: :development
 description: Manage sequential work-flows.
 email:
 - gobhai@gmail.com
@@ -59,7 +59,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -72,24 +72,24 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.1.9
-signing_key:
+rubyforge_project: 
+rubygems_version: 2.2.2
+signing_key: 
 specification_version: 4
 summary: Partial implementation of the Promise pattern.
 test_files: