sequelizer 0.1.4 → 0.1.6

data/.rubocop.yml

@@ -0,0 +1,167 @@
+plugins:
+  - rubocop-minitest
+
+AllCops:
+  TargetRubyVersion: 3.2
+  NewCops: enable
+  Exclude:
+    - 'vendor/**/*'
+    - 'bin/**/*'
+    - 'tmp/**/*'
+
+# Style Configuration to match existing project standards
+
+# Indentation: 2 spaces (matches existing code)
+Layout/IndentationWidth:
+  Width: 2
+
+# String quotes: prefer single quotes (matches existing code)
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+
+# Allow both single and double quotes in string interpolation contexts
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+# Method definitions: allow no parentheses for no arguments (matches existing code)
+Style/DefWithParentheses:
+  Enabled: false
+
+# Method calls: allow no parentheses for no arguments (matches existing code)
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: true
+
+# Hash syntax: prefer symbols (matches existing code)
+
+# Line length: be reasonable but not too strict for a Ruby gem
+Layout/LineLength:
+  Max: 120
+  AllowedPatterns: ['\A\s*#']
+  Exclude:
+    - '*.gemspec'
+    - 'test/**/*'
+
+# Documentation: don't require class/module documentation for this gem type
+Style/Documentation:
+  Enabled: false
+
+# Frozen string literal: don't enforce for compatibility
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Allow both proc and lambda
+Style/Lambda:
+  Enabled: false
+
+# Allow multiple assignment
+Style/ParallelAssignment:
+  Enabled: false
+
+# Allow guard clauses
+Style/GuardClause:
+  Enabled: true
+
+# Allow both if and unless modifiers
+Style/IfUnlessModifier:
+  Enabled: true
+
+# Method length: be reasonable for small gem
+Metrics/MethodLength:
+  Max: 25
+
+# Class length: be reasonable for small gem
+Metrics/ClassLength:
+  Max: 200
+
+# Module length: be reasonable for small gem
+Metrics/ModuleLength:
+  Max: 200
+
+# Block length: allow longer blocks for tests and configuration
+Metrics/BlockLength:
+  Max: 50
+  Exclude:
+    - 'test/**/*'
+    - '*.gemspec'
+    - 'Rakefile'
+
+# Allow both foo.empty? and foo.size == 0
+Style/ZeroLengthPredicate:
+  Enabled: false
+
+# Allow memoized variables with different names (e.g., @_sequelizer_db for @db)
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# Allow short parameter names (common in Ruby for simple methods)
+Naming/MethodParameterName:
+  MinNameLength: 1
+
+# Allow multi-line block chains (common in Ruby data processing)
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Relax complexity metrics for existing code
+Metrics/AbcSize:
+  Max: 35
+  Exclude:
+    - 'test/**/*'
+
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+Metrics/PerceivedComplexity:
+  Max: 12
+
+Metrics/BlockNesting:
+  Max: 4
+
+# Allow set_ prefixed methods (common pattern)
+Naming/AccessorMethodName:
+  Enabled: false
+
+# Allow both string and symbol keys in same hash for configuration
+Style/HashSyntax:
+  EnforcedStyle: ruby19
+  EnforcedShorthandSyntax: either
+
+# Minitest specific rules
+Minitest/AssertEqual:
+  Enabled: true
+
+Minitest/RefuteEqual:
+  Enabled: true
+
+# Layout rules that match existing code
+Layout/EmptyLinesAroundClassBody:
+  EnforcedStyle: empty_lines_except_namespace
+
+Layout/EmptyLinesAroundModuleBody:
+  EnforcedStyle: empty_lines_except_namespace
+
+# Allow trailing commas in multiline structures
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+# Disable gemspec-specific rules that don't apply to this project
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
+# Disable some style rules for tests to allow more flexibility
+Style/HashLikeCase:
+  Exclude:
+    - 'test/**/*'
+
+Lint/DuplicateBranch:
+  Exclude:
+    - 'test/**/*'
+
+Style/StringConcatenation:
+  Exclude:
+    - 'test/**/*'

data/CHANGELOG.md

@@ -1,6 +1,30 @@
 # Changelog
+
 All notable changes to this project will be documented in this file.
 
+## 0.1.6
+
+### Removed
+- JDBC adapter support (jdbc_hive2, jdbc_impala, jdbc_postgres) - not needed for foreseeable future
+- Native Impala adapter support - not needed for foreseeable future
+- Kerberos authentication functionality for enterprise databases
+- CGI dependency used for URL escaping in JDBC connections
+- 16 test methods related to JDBC and Impala adapters
+
+### Added
+- pg gem as development dependency to support PostgreSQL testing
+
+### Changed
+- Simplified ConnectionMaker class by removing adapter-specific configuration methods
+- Improved test coverage from 84.95% to 93.54% by removing unused code paths
+- Updated documentation to reflect focus on standard Sequel adapters
+
+## 0.1.5
+
+### Changed
+
+- Better handling of multiple directories of files for make_ready
+
 ## [0.1.0] - 2016-11-08
 
 ### Added

data/CLAUDE.md

@@ -0,0 +1,219 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+Sequelizer is a Ruby gem that simplifies database connections using Sequel. It allows users to configure database connections via config/database.yml or .env files, providing an easy-to-use interface for establishing database connections without hardcoding sensitive information.
+
+The gem includes:
+
+- A main module that provides `db` (cached connection) and `new_db` (fresh connection) methods
+- CLI commands for configuration management and Gemfile updating
+- Support for multiple database adapters including PostgreSQL, Impala, and Hive2
+- Sequel extensions for enhanced functionality
+
+## Development Commands
+
+### Testing
+
+```bash
+# Run all tests
+bundle exec rake test
+
+# Run tests with coverage report (generates coverage/index.html)
+bundle exec rake coverage
+
+# Run specific test file
+bundle exec ruby -I lib test/lib/sequelizer/test_connection_maker.rb
+```
+
+### Linting and Formatting
+
+```bash
+# Check code style and lint issues
+bundle exec rake lint
+bundle exec rubocop
+
+# Auto-fix safe linting issues  
+bundle exec rake lint_fix
+bundle exec rubocop --auto-correct
+
+# Auto-fix all issues (including unsafe corrections)
+bundle exec rake format
+bundle exec rubocop --auto-correct-all
+
+# Run linter on specific files
+bundle exec rubocop lib/sequelizer.rb
+```
+
+### Pre-commit Hooks
+
+```bash
+# Install pre-commit hooks (done automatically after bundle install)
+bundle exec overcommit --install
+
+# Sign configuration (if you modify .overcommit.yml)
+bundle exec overcommit --sign
+
+# Run pre-commit hooks manually
+bundle exec overcommit --run
+
+# Skip hooks for a specific commit (use sparingly)
+git commit --no-verify -m "commit message"
+```
+
+The pre-commit hooks automatically run:
+
+- RuboCop linting with auto-correction
+- Full test suite
+- YAML/JSON syntax validation
+- Trailing whitespace and merge conflict checks
+- Commit message formatting validation
+
+### Build and Release
+
+```bash
+# Build gem
+bundle exec rake build
+
+# Release gem
+bundle exec rake release
+```
+
+### CLI Commands
+
+```bash
+# Show current configuration
+bundle exec sequelizer config
+
+# Update Gemfile with database adapter
+bundle exec sequelizer update_gemfile
+
+# Initialize .env file
+bundle exec sequelizer init_env --adapter postgres --host localhost --database mydb
+```
+
+## Architecture
+
+### Core Components
+
+- **Sequelizer module** (`lib/sequelizer.rb`): Main interface providing `db` and `new_db` methods
+- **ConnectionMaker** (`lib/sequelizer/connection_maker.rb`): Handles database connection logic and adapter-specific configurations
+- **Options** (`lib/sequelizer/options.rb`): Manages configuration from multiple sources with precedence order
+- **CLI** (`lib/sequelizer/cli.rb`): Thor-based command line interface
+
+### Configuration Sources (in precedence order)
+
+1. Passed options
+2. .env file
+3. Environment variables
+4. config/database.yml
+5. ~/.config/sequelizer/database.yml
+
+### Sequel Extensions
+
+Located in `lib/sequel/extensions/`:
+
+- **db_opts**: Database-specific options handling
+- **make_readyable**: Readiness checking functionality
+- **settable**: Dynamic property setting
+- **sqls**: SQL statement management
+- **usable**: Connection usability features
+
+### Database Support
+
+The gem supports various database adapters with special handling for:
+
+- PostgreSQL (including search_path/schema management)
+- JDBC-based connections (Hive2, Impala, PostgreSQL)
+- Kerberos authentication for enterprise databases
+
+### Test Structure
+
+- Tests use Minitest framework
+- Located in `test/` directory with subdirectories mirroring `lib/` structure
+- Helper utilities in `test_helper.rb` including constant stubbing for testing
+
+## Coding Standards
+
+This project follows standard Ruby community conventions enforced by RuboCop, emphasizing readability, consistency, and Ruby idioms.
+
+### Style Conventions
+
+**Indentation & Formatting:**
+
+- 2-space indentation (no tabs)
+- Single-line method definitions when appropriate: `def e(v)`
+- Method parameters without parentheses when no arguments: `def connection`
+- Method parameters with parentheses when there are arguments: `def initialize(options = nil)`
+
+**Naming:**
+
+- Module/Class names: PascalCase (`Sequelizer`, `ConnectionMaker`)
+- Method names: snake_case (`new_db`, `find_cached`, `after_connect`)
+- Variable names: snake_case (`sequelizer_options`, `db_config`)
+- Instance variables: snake_case with `@` prefix (`@options`, `@_sequelizer_db`)
+- Constants: SCREAMING_SNAKE_CASE (`VERSION`)
+
+**Strings:**
+
+- Single quotes for simple strings: `'postgres'`, `'mock'`
+- Double quotes for interpolation: `"SET #{key}=#{value}"`
+
+### Code Organization
+
+**File Structure:**
+
+- One main class/module per file
+- Nested modules follow directory structure: `lib/sequelizer/connection_maker.rb`
+- Private methods grouped at bottom with `private` keyword
+
+**Dependencies:**
+
+- Use `require_relative` for internal dependencies: `require_relative 'sequelizer/version'`
+- Use `require` for external gems: `require 'sequel'`, `require 'thor'`
+- Group requires at top of files
+
+### Documentation
+
+**Comments:**
+
+- Use `#` for single-line comments
+- Extensive method documentation with parameter descriptions
+- Minimal inline comments, used for clarification of complex logic
+
+### Ruby Idioms
+
+**Patterns Used:**
+
+- Memoization: `@_sequelizer_db ||= new_db(options)`
+- Conditional assignment: `||=` for defaults
+- Metaprogramming with `define_method` for dynamic method creation
+- Symbol keys in hashes: `{ adapter: 'postgres' }`
+- Method chaining kept readable
+
+**Testing Patterns:**
+
+- Test methods prefixed with `test_`: `def test_accepts_options_as_params`
+- Extensive use of stubbing and mocking for isolated testing
+- Custom helper methods for common setup patterns
+
+## Ruby Sequel as Lodestone
+
+- Refer frequently to GitHub's jeremyevans/sequel repository for:
+  - Examples of great documenation
+  - Good code organization
+  - Great commit messages
+  - Wonderful changelog messages
+
+## Development Memories
+
+- Ensure that bundler is used for all ruby/rake related cli invocations
+- Read-only operations (exploration, testing) can be done in main directory
+- Refer to Ruby Sequel for code style, test frameworks, and general guidance
+- To test CLI, just call bundle exec bin/sequelizer without installing binstubs
+- **IMPORTANT**: Commands like `docker build`, `devcontainer build`, and `bundle install` can take more than 10 minutes to complete and should be run with extended timeout (e.g., 20 minutes / 1200000ms)
+- **Wait for explicit instructions before reading files or creating plans - do not be proactive**
+- When pushing to github or making pull requests, remember you have a PAT in GITHUB_TOKEN you can use for authentication
+- When making a pull request, push to the "github" remote

data/Gemfile

@@ -3,6 +3,10 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in sequelizer.gemspec
 gemspec
 
+group :development do
+  gem 'overcommit', '~> 0.60'
+end
+
 group :test do
-  gem "sequel-hexspace", github: "outcomesinsights/sequel-hexspace", branch: "master"
-end
+  gem 'sequel-hexspace', github: 'outcomesinsights/sequel-hexspace', branch: 'master'
+end

data/Gemfile.lock

@@ -0,0 +1,158 @@
+GIT
+  remote: https://github.com/outcomesinsights/sequel-hexspace.git
+  revision: d041282798332227bbdf0a48a07c0494b2b54931
+  branch: master
+  specs:
+    sequel-hexspace (1.0.0)
+      hexspace
+      sequel (~> 5.0)
+
+PATH
+  remote: .
+  specs:
+    sequelizer (0.1.6)
+      activesupport (~> 7.0)
+      dotenv (~> 2.1)
+      hashie (~> 3.2)
+      sequel (~> 5.93)
+      thor (~> 1.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (7.2.2.1)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
+    childprocess (5.1.0)
+      logger (~> 1.5)
+    coderay (1.1.3)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
+    docile (1.4.1)
+    dotenv (2.7.5)
+    drb (2.2.3)
+    ffi (1.16.3)
+    formatador (1.1.0)
+    guard (2.18.1)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.13.0)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-minitest (2.4.6)
+      guard-compat (~> 1.2)
+      minitest (>= 3.0)
+    hashie (3.6.0)
+    hexspace (0.2.1)
+      thrift (>= 0.18)
+    i18n (1.14.7)
+      concurrent-ruby (~> 1.0)
+    iniparse (1.5.0)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    listen (3.8.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    logger (1.7.0)
+    lumberjack (1.2.10)
+    method_source (1.0.0)
+    minitest (5.21.2)
+    nenv (0.3.0)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    overcommit (0.67.1)
+      childprocess (>= 0.6.3, < 6)
+      iniparse (~> 1.4)
+      rexml (>= 3.3.9)
+    parallel (1.27.0)
+    parser (3.3.8.0)
+      ast (~> 2.4.1)
+      racc
+    pg (1.6.2-x86_64-linux)
+    prism (1.4.0)
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (12.3.3)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    regexp_parser (2.10.0)
+    rexml (3.4.1)
+    rubocop (1.76.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.45.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.45.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-minitest (0.38.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
+    sequel (5.93.0)
+      bigdecimal
+    shellany (0.0.1)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.1)
+    simplecov_json_formatter (0.1.4)
+    thor (1.3.0)
+    thrift (0.19.0)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+
+PLATFORMS
+  x86_64-linux
+
+DEPENDENCIES
+  bundler (~> 2.0)
+  guard (~> 2.0)
+  guard-minitest (~> 2.3)
+  minitest (~> 5.3)
+  overcommit (~> 0.60)
+  pg (~> 1.0)
+  rake (~> 12.0)
+  rubocop (~> 1.0)
+  rubocop-minitest (~> 0.25)
+  sequel-hexspace!
+  sequelizer!
+  simplecov (~> 0.22)
+
+BUNDLED WITH
+   2.4.7

data/Guardfile

@@ -3,7 +3,7 @@
 
 guard :minitest do
   # with Minitest::Unit
-  watch(%r{^test/(.*)\/?test_(.*)\.rb$})
+  watch(%r{^test/(.*)/?test_(.*)\.rb$})
   watch(%r{^lib/(.*/)?([^/]+)\.rb$})     { |m| "test/#{m[1]}test_#{m[2]}.rb" }
   watch(%r{^test/test_helper\.rb$})      { 'test' }
 

data/Rakefile

@@ -1,10 +1,35 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 Rake::TestTask.new do |t|
-  t.libs = ["lib"]
+  t.libs = %w[lib test]
   t.warning = true
   t.test_files = FileList['test/**/test_*.rb']
 end
 
+begin
+  require 'rubocop/rake_task'
+
+  RuboCop::RakeTask.new(:lint) do |task|
+    task.options = ['--display-cop-names']
+  end
+
+  RuboCop::RakeTask.new(:format) do |task|
+    task.options = ['--auto-correct-all']
+  end
+
+  desc 'Run RuboCop with safe autocorrect'
+  task :lint_fix do
+    system('bundle exec rubocop --autocorrect')
+  end
+rescue LoadError
+  # RuboCop not available
+end
+
+desc 'Run tests with coverage report'
+task :coverage do
+  ENV['COVERAGE'] = 'true'
+  Rake::Task[:test].invoke
+end
+
 task default: :test