sequel_transaction 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 174154719f975c73fece96b0f0e8ff3fc0f41ac4
-  data.tar.gz: 9622bebee29e723db29015b71edf7705491d58d6
+  metadata.gz: 3a6564ae557f5c934bd0243367f8f14b75167871
+  data.tar.gz: 4690ced67caa966276bf977dc1b9a8a8adfda5ed
 SHA512:
-  metadata.gz: c49db55af0f1c8ac5126e238e15c47fa4b9b4692bdc89699c3b6f7ee999d9ca0e508bea9a84c3a74660388bb74dbd56d4cce95a8c2845fe9ae382ebe85213a5e
-  data.tar.gz: a0217bf3fb26f1c5d88c3805773190460a700436453bd4a5673639e4e787f67a26a2583440af592de07b177ad78a7b443195b116c30b385a0fba0001742a5269
+  metadata.gz: ce76146f852a7370306a9534f82d561c6f837562799a3eb2ba3ea631aabe225ab9e2986557c4776b280e3a5a5ed5747fde7c2ddd3077b84e3a929a75ef890bed
+  data.tar.gz: fb9b1e64c07fdca63d8aaf90260079afb23a55069e93e33924694b9de6134db5882a286cd3f21dabb6cd45ecf0b5c769fb02eea9ab9d827b0df834cc1adefc40

data/lib/sequel_transaction/rack/middleware.rb

@@ -6,15 +6,20 @@ module Rack
     end
 
     def call(env)
-      @connection.transaction do
-        result = @inner.call env
-        response = Response.new([], result[0])
-        err = env['sinatra.error']
+      req = Request.new env
+      if req.get? || req.head? || req.options?
+        @inner.call env
+      else
+        @connection.transaction do
+          result = @inner.call env
+          response = Response.new [], result[0]
+          err = env['sinatra.error']
 
-        if err || response.client_error? || response.server_error?
-          raise Sequel::Rollback
+          if err || response.client_error? || response.server_error?
+            raise Sequel::Rollback
+          end
+          result
         end
-        result
       end
     end
   end

data/lib/sequel_transaction/version.rb

@@ -1,3 +1,3 @@
 module SequelTransaction
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/sequel_transaction/rack/middleware_spec.rb

@@ -44,7 +44,7 @@ describe Rack::SequelTransaction do
     dataset.wont_be :empty?
   end
 
-  it 'rolls back if sinatra exception' do
+  it 'rolls back on sinatra error' do
     expect_call 200
     env['sinatra.error'] = StandardError.new 'snap'
     subject.call env
@@ -62,4 +62,37 @@ describe Rack::SequelTransaction do
     subject.call env
     dataset.must_be :empty?
   end
+
+  %w{ GET HEAD OPTIONS }.each do |method|
+    # shouldn't be modifying anything on these types of requests; modifying for assertion purposes
+
+    describe "on #{method} request" do
+      before { env['REQUEST_METHOD'] = method }
+
+      it 'returns result' do
+        expect_call 200
+        result = subject.call(env)
+        result.must_equal [200, {}, []]
+      end
+
+      it 'wont rollback on sinatra error' do
+        expect_call 200
+        env['sinatra.error'] = StandardError.new 'snap'
+        subject.call env
+        dataset.wont_be :empty?
+      end
+
+      it 'wont rollback on server error' do
+        expect_call 500
+        subject.call env
+        dataset.wont_be :empty?
+      end
+
+      it 'wont rollback on client error' do
+        expect_call 400
+        subject.call env
+        dataset.wont_be :empty?
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sequel_transaction
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - vyrak.bunleang@gmail.com