sequel_pg 1.6.11 → 1.6.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b51b8daa124c0b93c8210122caa04300bf38ede
-  data.tar.gz: 04aaec8db5cbf4ae2ac00fa345ef3ced573674cf
+  metadata.gz: e9f33b8c063b997f88c569ae9a480f7575f766be
+  data.tar.gz: e0e64e1c8c71b7aa7bb5cf1f64c6becbb6cb1e22
 SHA512:
-  metadata.gz: 8c19df266a6b88ea412e68c0ce8d08eadaab22d7532ddc20d7c0794afd6a3f02cf35f418443425f5f3fdda734697a8d044c396a4b7afc97e9ad256a361742ea7
-  data.tar.gz: 12b88db37b2b1366098893dc87fe53b76dc081d5aa82671adfaac3002ef98c77c0ac2e3b4dd20f85a47ea9ca2cec19a6621afc200788fac48ae652c0e57b13bf
+  metadata.gz: 429c0c48d6237fd29b6e264a9f3f784aceba55c63080013007bac52a72e1732ceb3b994b769b520d7ab18be2677d420012576620801186588607215a6bdac518
+  data.tar.gz: 840839a0691d1c6ed99841065da6394d25dae91fb7af17bc67bb5d6ad848b19000704620e270a2e17f7e54623e8067e158be3dc7c61e9066cd8a2f03b99588fd

data/CHANGELOG

@@ -1,3 +1,7 @@
+=== 1.6.12 (2015-03-23)
+
+* Fix segfault when Dataset#yield_hash_rows is passed a nil value when using ruby pg 0.18+ (jeremyevans) (#19)
+
 === 1.6.11 (2014-11-04)
 
 * Work with ruby pg 0.18+ (currently a prerelease) (jeremyevans)

data/README.rdoc

@@ -96,11 +96,6 @@ for general use.
 
   gem install sequel_pg
 
-The standard gem requires compiling from source, so you need a working
-compiler toolchain.  Since few Windows users have a working compiler
-toolchain, a windows binary gem is available that works on both 1.8
-and 1.9.
-
 Note that by default sequel_pg only supports result sets with up to
 256 columns. If you will have a result set with more than 256 columns,
 you should modify the maximum supported number of columns via:
@@ -112,6 +107,10 @@ can find the PostgreSQL shared library and header files.  Alternatively,
 you can use the POSTGRES_LIB and POSTGRES_INCLUDE environment
 variables to specify the shared library and header directories.
 
+While previous versions of this gem supported Windows, the current
+version does not, due to the need to call C functions defined
+in the pg gem.
+
 == Running the specs
 
 sequel_pg doesn't ship with it's own specs.  It's designed to
@@ -153,30 +152,11 @@ requirements:
 
 sequel_pg has been tested on the following:
 
-=== Operating Systems/Platforms
-
-* Linux (i386)
-* OpenBSD (amd64, i386)
-* Windows XP (i386)
-
-=== Compiler Versions
-
-* gcc (3.3.5, 4.2.1, 4.4.3)
-
-=== Supported Ruby Versions
-
 * ruby 1.8.7
-* ruby 1.9.2
 * ruby 1.9.3
 * ruby 2.0.0
-* rbx 1.2.4
-
-If your platform, compiler version, or ruby version is not listed
-above, please test and send me a report including:
-
-  * Your operating system and platform (e.g. i386, x86_64/amd64)
-  * Your compiler
-  * Your ruby version
+* ruby 2.1.4
+* rbx 2.2.9
 
 == Known Issues
 
@@ -195,6 +175,14 @@ above, please test and send me a report including:
 
     gem 'sequel_pg', :require=>'sequel'
 
+* sequel_pg currently calls functions defined in the pg gem, which
+  does not work on Windows and does not work in some unix-like
+  operating systems that disallow undefined functions in shared
+  libraries.  If <tt>RbConfig::Config['LDFLAGS']</tt> contains
+  <tt>-Wl,--no-undefined</tt>, you'll probably have issues installing
+  sequel_pg.  You should probably fix <tt>RbConfig::Config['LDFLAGS']</tt>
+  in that case.
+
 == Author
 
 Jeremy Evans <code@jeremyevans.net>

data/ext/sequel_pg/sequel_pg.c

@@ -51,8 +51,8 @@ PGconn* pg_get_pgconn(VALUE);
 PGresult* pgresult_get(VALUE);
 
 /* Normalize access to data objects for both old and new versions of pg gem */
-#define GetPGconn(_val, _var) if (unwrap_structs) {_var = pg_get_pgconn(_val);} else {Data_Get_Struct(_val, PGconn, _var);}
-#define GetPGresult(_val, _var) if (unwrap_structs) {_var = pgresult_get(_val);} else {Data_Get_Struct(_val, PGresult, _var);}
+#define GetPGconn(_val, _var) if (unwrap_structs) {Check_Type(_val, T_DATA); _var = pg_get_pgconn(_val);} else {Data_Get_Struct(_val, PGconn, _var);}
+#define GetPGresult(_val, _var) if (unwrap_structs) {Check_Type(_val, T_DATA); _var = pgresult_get(_val);} else {Data_Get_Struct(_val, PGresult, _var);}
 
 static VALUE spg_Sequel;
 static VALUE spg_Blob;
@@ -620,12 +620,16 @@ static VALUE spg_yield_hash_rows(VALUE self, VALUE rres, VALUE ignore) {
   VALUE pg_value;
   char type = SPG_YIELD_NORMAL;
 
+  if (!RTEST(rres)) {
+    return self;
+  }
+  GetPGresult(rres, res);
+
 #ifdef SPG_ENCODING
   int enc_index;
   enc_index = enc_get_index(rres);
 #endif
 
-  GetPGresult(rres, res);
   ntuples = PQntuples(res);
   nfields = PQnfields(res);
   if (nfields > SPG_MAX_FIELDS) {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel_pg
 version: !ruby/object:Gem::Version
-  version: 1.6.11
+  version: 1.6.12
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2015-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -91,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Faster SELECTs when using Sequel with pg