sequel_bitemporal 0.8.8 → 0.8.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc21e82b40ea8f3f5dc15e28ed49dfd2d5cb9b1d
-  data.tar.gz: b96f3457b381585ba37c2b81825c3d387225fabd
+  metadata.gz: 68ac021c3521e98f78d3f9bc44c21267cc07c60a
+  data.tar.gz: fa89baf10e99cbed3ed83b2072a1c2e5b2a73ca8
 SHA512:
-  metadata.gz: 2c0883049c494836a9579c2442c194e79100587fa2f187ef5a99a8f96e938979e09bf64f2c807e1543a4d4ba2c4f430ce4c14e8700263df9e54f1097a3319c28
-  data.tar.gz: 98d110e00b4f2d4f075f338820bcfbf717790c4447cc87f6049f9b99276fbe159ce8f27cb373a252c1a16a586e8e5ea8a36333d2900d63de00d29a029a7528d8
+  metadata.gz: 18a5b6e13d4c74e905262dd6844db54b5550f8f626bfad46aff2093d82bc06217294f1cef60ca25361d6fd6604c48a1fdfb29531ea448a6de9f802075e6cfa1c
+  data.tar.gz: 132614240d0c4244938b136a7b5be58bd741368cd616c6fcd9335f4c4fc3156bd79fe1df1c4e4392a11988ca117ff690c5cde95c8e3e30fb7bb7f9ac46a97cbe

data/lib/sequel/plugins/bitemporal.rb

@@ -501,7 +501,8 @@ module Sequel
           updated_by = (send(self.class.audit_updated_by_method) if audited?)
           previous_values = @current_version_values || {}
           current_version_values = {}
-          pending_version.columns.each do |column|
+          columns = pending_version.columns - excluded_columns_for_changes
+          columns.each do |column|
             current_version_values[column] = pending_version.public_send(column)
           end
 
@@ -588,9 +589,10 @@ module Sequel
           return false unless @pending_version
           return true unless current_version?
           @current_version_values = current_version.values
-          pending_version.columns.detect do |key|
-            new_value = pending_version.send key
-            case key
+          columns = pending_version.columns - excluded_columns_for_changes
+          columns.detect do |column|
+            new_value = pending_version.send column
+            case column
             when :id, :master_id, :created_at, :expired_at
               false
             when :valid_from
@@ -607,12 +609,12 @@ module Sequel
             else
               if model.version_uses_string_nilifier
                 if current_version.respond_to? :nil_string?
-                  new_value = nil if current_version.nil_string? key, new_value
-                elsif !model.version_class.skip_input_transformer?(:string_nilifier, key)
+                  new_value = nil if current_version.nil_string? column, new_value
+                elsif !model.version_class.skip_input_transformer?(:string_nilifier, column)
                   new_value = model.version_class.input_transformers[:string_nilifier].call(new_value)
                 end
               end
-              current_version.send(key)!=new_value
+              current_version.send(column)!=new_value
             end
           end
         end
@@ -621,6 +623,10 @@ module Sequel
           self.class.excluded_columns
         end
 
+        def excluded_columns_for_changes
+          []
+        end
+
         def initial_version
           @initial_version ||= model.version_class.new
         end

data/sequel_bitemporal.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "sequel_bitemporal"
-  s.version     = "0.8.8"
+  s.version     = "0.8.9"
   s.authors     = ["Joseph HALTER", "Jonathan TRON"]
   s.email       = ["joseph.halter@thetalentbox.com", "jonathan.tron@thetalentbox.com"]
   s.homepage    = "https://github.com/TalentBox/sequel_bitemporal"

data/spec/bitemporal_date_spec.rb

@@ -762,6 +762,33 @@ describe "Sequel::Plugins::Bitemporal" do
     master = @master_class.with_current_version.all.first
     expect( master.current_version.master.object_id ).not_to eq master.object_id
   end
+  it "allow defining columns which must be ignored when checking for changes" do
+    closure = @version_class
+    with_excluded_columns = Class.new Sequel::Model do
+      set_dataset :rooms
+      plugin :bitemporal, version_class: closure
+      def excluded_columns_for_changes
+        [:name, :price]
+      end
+    end
+    master = with_excluded_columns.new
+    master.update_attributes name: "Single Standard", price: 98
+    expect(master).to have_versions %Q{
+      | name            | price | created_at | expired_at | valid_from | valid_to   | current |
+      | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 | MAX DATE   | true    |
+    }
+    master.update_attributes name: "King Size", price: 94
+    expect(master).to have_versions %Q{
+      | name            | price | created_at | expired_at | valid_from | valid_to   | current |
+      | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 | MAX DATE   | true    |
+    }
+    master.update_attributes length: 1
+    expect(master).to have_versions %Q{
+      | name            | price | length | created_at | expired_at | valid_from | valid_to   | current |
+      | Single Standard | 98    |        | 2009-11-28 | 2009-11-28 | 2009-11-28 | MAX DATE   |         |
+      | King Size       | 94    | 1      | 2009-11-28 |            | 2009-11-28 | MAX DATE   | true    |
+    }
+  end
 end
 
 describe "Sequel::Plugins::Bitemporal", "with audit" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sequel_bitemporal
 version: !ruby/object:Gem::Version
-  version: 0.8.8
+  version: 0.8.9
 platform: ruby
 authors:
 - Joseph HALTER
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-09 00:00:00.000000000 Z
+date: 2017-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel