sequel_bitemporal 0.6.9 → 0.6.10

data/.travis.yml

@@ -1,5 +1,5 @@
 rvm:
-  - 1.9.2
   - 1.9.3
+  - 2.0.0
 notifications:
-  disabled: true
+  disabled: true

data/lib/sequel/plugins/bitemporal.rb

@@ -378,12 +378,13 @@ module Sequel
           return false unless @pending_version
           return true unless current_version?
           @current_version_values = current_version.values
-          pending_version.values.detect do |key, new_value|
+          pending_version.columns.detect do |key|
+            new_value = pending_version.send key
             case key
             when :id, :master_id, :created_at, :expired_at
               false
             when :valid_from
-              new_value && (
+              pending_version.values.has_key?(:valid_from) && (
                 new_value<current_version.valid_from ||
                 (
                   current_version.valid_to &&
@@ -391,7 +392,8 @@ module Sequel
                 )
               )
             when :valid_to
-              new_value || new_value!=current_version.valid_to
+              pending_version.values.has_key?(:valid_to) &&
+                new_value!=current_version.valid_to
             else
               if model.version_uses_string_nilifier
                 new_value = nil if current_version.nil_string? key, new_value

data/sequel_bitemporal.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "sequel_bitemporal"
-  s.version     = "0.6.9"
+  s.version     = "0.6.10"
   s.authors     = ["Joseph HALTER", "Jonathan TRON"]
   s.email       = ["joseph.halter@thetalentbox.com", "jonathan.tron@thetalentbox.com"]
   s.homepage    = "https://github.com/TalentBox/sequel_bitemporal"

data/spec/bitemporal_serialization_spec.rb

@@ -0,0 +1,37 @@
+require "spec_helper"
+require "json"
+
+describe "Sequel::Plugins::Bitemporal" do
+  include DbHelpers
+  before :all do
+    db_setup
+    @version_class.instance_eval do
+      plugin :serialization
+      serialize_attributes :json, :name
+    end
+  end
+  subject{ @master_class.new.update_attributes name: {test: 1}, price: 18 }
+  it "serializes as expected" do
+    subject.name.should == {"test" => 1}
+  end
+  it "doesn't create a new version when value hasn't changed" do
+    name = subject.name.dup
+    name["test"] = 1
+    subject.attributes = {name: name}
+    lambda{ subject.save }.should_not change(@version_class, :count)
+  end
+  it "doesn't create a new version when value is the same" do
+    subject.attributes = {name: {"test" => 1}}
+    lambda{ subject.save }.should_not change(@version_class, :count)
+  end
+  it "does create a new version when value has changed" do
+    name = subject.name.dup
+    name["test"] = 0
+    subject.attributes = {name: name}
+    lambda{ subject.save }.should change(@version_class, :count).by 1
+  end
+  it "does create a new version when value is not the same" do
+    subject.attributes = {name: {"test" => 0}}
+    lambda{ subject.save }.should change(@version_class, :count).by 1
+  end
+end

data/spec/bitemporal_time_spec.rb

@@ -1,4 +1,3 @@
-ENV["TZ"]="UTC"
 require "spec_helper"
 
 describe "Sequel::Plugins::Bitemporal" do

data/spec/spec_helper.rb

@@ -3,3 +3,4 @@ require "timecop"
 require "pry"
 DB = Sequel.sqlite
 Dir[File.expand_path("../support/*.rb", __FILE__)].each{|f| require f}
+ENV["TZ"]="UTC"

metadata

@@ -2,7 +2,7 @@
 name: sequel_bitemporal
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.6.9
+  version: 0.6.10
 platform: ruby
 authors:
 - Joseph HALTER
@@ -109,6 +109,7 @@ files:
 - lib/sequel_bitemporal.rb
 - sequel_bitemporal.gemspec
 - spec/bitemporal_date_spec.rb
+- spec/bitemporal_serialization_spec.rb
 - spec/bitemporal_time_spec.rb
 - spec/spec_helper.rb
 - spec/support/bitemporal_matchers.rb
@@ -125,7 +126,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -620684269279135882
+      hash: 334151624443386652
       version: '0'
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -134,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -620684269279135882
+      hash: 334151624443386652
       version: '0'
   none: false
 requirements: []
@@ -145,6 +146,7 @@ specification_version: 3
 summary: Bitemporal versioning for sequel.
 test_files:
 - spec/bitemporal_date_spec.rb
+- spec/bitemporal_serialization_spec.rb
 - spec/bitemporal_time_spec.rb
 - spec/spec_helper.rb
 - spec/support/bitemporal_matchers.rb