sequel_bitemporal 0.5.1 → 0.5.2

data/lib/sequel/plugins/bitemporal.rb

@@ -158,9 +158,11 @@ module Sequel
             @current_version_values = current_version.values
           end
           attributes.delete :id
-          @pending_version ||= model.version_class.new
-          pending_version.set attributes
-          pending_version.master_id = id unless new?
+          if attributes_hold_changes? attributes
+            @pending_version ||= model.version_class.new
+            pending_version.set attributes
+            pending_version.master_id = id unless new?
+          end
         end
 
         def update_attributes(attributes={})
@@ -329,6 +331,26 @@ module Sequel
           propagated.save validate: false
           propagated
         end
+
+        def attributes_hold_changes?(attributes)
+          if new? || !current_version
+            attributes.any?
+          else
+            attributes.detect do |key, new_value|
+              case key
+              when :master_id, :created_at, :expired_at
+                false
+              when :valid_from
+                new_value && new_value<current_version.valid_from
+              when :valid_to
+                new_value || new_value!=current_version.valid_to
+              else
+                current_version.send(key)!=new_value
+              end
+            end
+          end
+        end
+
       end
     end
   end

data/sequel_bitemporal.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "sequel_bitemporal"
-  s.version     = "0.5.1"
+  s.version     = "0.5.2"
   s.authors     = ["Joseph HALTER", "Jonathan TRON"]
   s.email       = ["joseph.halter@thetalentbox.com", "jonathan.tron@thetalentbox.com"]
   s.homepage    = "https://github.com/TalentBox/sequel_bitemporal"

data/spec/bitemporal_date_spec.rb

@@ -144,7 +144,31 @@ describe "Sequel::Plugins::Bitemporal" do
     # | Single Standard | 98    | 2009-11-28 | 2009-11-29 | 2009-11-28 | 2009-11-30 |         |
     # | Single Standard | 98    | 2009-11-29 |            | 2009-11-28 | MAX DATE   | true    |
   end
-  xit "doesn't do anything if unchanged" do
+  it "don't create any new version without change" do
+    master = @master_class.new
+    master.update_attributes name: "Single Standard", price: 98
+    master.update_attributes price: 98, partial_update: true
+    master.update_attributes name: "Single Standard", price: 98
+    master.should have_versions %Q{
+      | name            | price | created_at | expired_at | valid_from | valid_to | current |
+      | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 | MAX DATE | true    |
+    }
+  end
+  it "change in validity still creates a new version (SEE COMMENTS FOR IMPROVEMENTS)" do
+    master = @master_class.new
+    master.update_attributes name: "Single Standard", price: 98
+    Timecop.freeze Date.today+1
+    master.update_attributes price: 98, partial_update: true, valid_from: Date.today-2
+    master.update_attributes price: 98, partial_update: true, valid_from: Date.today+1
+    master.should have_versions %Q{
+      | name            | price | created_at | expired_at | valid_from | valid_to   | current |
+      | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 | MAX DATE   | true    |
+      | Single Standard | 98    | 2009-11-29 |            | 2009-11-27 | 2009-11-28 |         |
+    }
+    # would be even better if it could be:
+    # | name            | price | created_at | expired_at | valid_from | valid_to   | current |
+    # | Single Standard | 98    | 2009-11-28 | 2009-11-29 | 2009-11-28 | MAX DATE   |         |
+    # | Single Standard | 98    | 2009-11-29 |            | 2009-11-27 | MAX DATE   | true    |
   end
   it "overrides no future versions" do
     master = @master_class.new
@@ -598,7 +622,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit" do
       Date.today,
       author
     )
-    master.update_attributes name: "King size", price: 98 
+    master.update_attributes name: "King size", price: 98
   end
   it "generates a new audit on partial update" do
     master = @master_class.new
@@ -611,7 +635,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit" do
       Date.today,
       author
     )
-    master.update_attributes partial_update: true, name: "King size", price: 98 
+    master.update_attributes partial_update: true, name: "King size", price: 98
   end
   it "generate a new audit for each future version update when propagating changes" do
     propagate_per_column = @master_class.propagate_per_column
@@ -694,7 +718,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit, specifying how to get the a
       Date.today,
       author
     )
-    master.update_attributes name: "King size", price: 98 
+    master.update_attributes name: "King size", price: 98
   end
   it "generates a new audit on partial update" do
     master = @master_class.new
@@ -707,7 +731,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit, specifying how to get the a
       Date.today,
       author
     )
-    master.update_attributes partial_update: true, name: "King size", price: 98 
+    master.update_attributes partial_update: true, name: "King size", price: 98
   end
 end
 

data/spec/bitemporal_time_spec.rb

@@ -144,7 +144,31 @@ describe "Sequel::Plugins::Bitemporal" do
     # | Single Standard | 98    | 2009-11-28 10:00:00 +0000 | 2009-11-28 11:00:00 +0000 | 2009-11-28 10:00:00 +0000 | 2009-11-28 12:00:00 +0000 |         |
     # | Single Standard | 98    | 2009-11-28 11:00:00 +0000 |                           | 2009-11-28 10:00:00 +0000 | MAX TIME                  | true    |
   end
-  xit "doesn't do anything if unchanged" do
+  it "don't create any new version without change " do
+    master = @master_class.new
+    master.update_attributes name: "Single Standard", price: 98
+    master.update_attributes price: 98, partial_update: true
+    master.update_attributes name: "Single Standard", price: 98
+    master.should have_versions %Q{
+      | name            | price | created_at                | expired_at | valid_from               | valid_to | current |
+      | Single Standard | 98    | 2009-11-28 10:00:00 +0000 |            | 2009-11-28 10:00:00 +0000| MAX TIME | true    |
+    }
+  end
+  it "change in validity still creates a new version (SEE COMMENTS FOR IMPROVEMENTS)" do
+    master = @master_class.new
+    master.update_attributes name: "Single Standard", price: 98
+    Timecop.freeze Time.now+hour
+    master.update_attributes price: 98, partial_update: true, valid_from: Time.now-2*hour
+    master.update_attributes price: 98, partial_update: true, valid_from: Time.now+1*hour
+    master.should have_versions %Q{
+      | name            | price | created_at                | expired_at | valid_from                | valid_to                  | current |
+      | Single Standard | 98    | 2009-11-28 10:00:00 +0000 |            | 2009-11-28 10:00:00 +0000 | MAX TIME                  | true    |
+      | Single Standard | 98    | 2009-11-28 11:00:00 +0000 |            | 2009-11-28 09:00:00 +0000 | 2009-11-28 10:00:00 +0000 |         |
+    }
+    # would be even better if it could be:
+    # | name            | price | created_at                | expired_at                | valid_from                | valid_to                  | current |
+    # | Single Standard | 98    | 2009-11-28 10:00:00 +0000 | 2009-11-28 11:00:00 +0000 | 2009-11-28 10:00:00 +0000 | MAX TIME                  |         |
+    # | Single Standard | 98    | 2009-11-28 11:00:00 +0000 |                           | 2009-11-28 09:00:00 +0000 | MAX TIME                  | true    |
   end
   it "overrides no future versions" do
     master = @master_class.new
@@ -390,7 +414,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit" do
       Time.now,
       author
     )
-    master.update_attributes name: "King size", price: 98 
+    master.update_attributes name: "King size", price: 98
   end
   it "generates a new audit on partial update" do
     master = @master_class.new
@@ -404,7 +428,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit" do
       Time.now,
       author
     )
-    master.update_attributes partial_update: true, name: "King size", price: 98 
+    master.update_attributes partial_update: true, name: "King size", price: 98
   end
 end
 
@@ -445,7 +469,7 @@ describe "Sequel::Plugins::Bitemporal", "with audit, specifying how to get the a
       Time.now,
       author
     )
-    master.update_attributes name: "King size", price: 98 
+    master.update_attributes name: "King size", price: 98
   end
   it "generates a new audit on partial update" do
     master = @master_class.new

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sequel_bitemporal
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-21 00:00:00.000000000 Z
+date: 2013-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
@@ -125,18 +125,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1918973659452831064
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1918973659452831064
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24