sequel_bitemporal 0.1.2 → 0.1.3

data/lib/sequel/plugins/bitemporal.rb

@@ -56,6 +56,7 @@ module Sequel
           if !new? && attributes.delete(:partial_update) && current_version
             current_attributes = current_version.values.dup
             current_attributes.delete :id
+            current_attributes.delete :valid_from
             attributes = current_attributes.merge attributes
           end
           self.attributes = attributes
@@ -109,7 +110,7 @@ module Sequel
         def prepare_pending_version
           point_in_time = Time.now
           pending_version.created_at = point_in_time
-          pending_version.valid_from = point_in_time if !pending_version.valid_from || pending_version.valid_from.to_time<point_in_time
+          pending_version.valid_from ||= point_in_time
         end
 
         def save_pending_version

data/sequel_bitemporal.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "sequel_bitemporal"
-  s.version     = "0.1.2"
+  s.version     = "0.1.3"
   s.authors     = ["Joseph HALTER"]
   s.email       = ["joseph.halter@thetalentbox.com"]
   s.homepage    = "https://github.com/TalentBox/sequel_bitemporal"

data/spec/bitemporal_spec.rb

@@ -70,12 +70,12 @@ describe "Sequel::Plugins::Bitemporal" do
       | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 |          | true    |
     }
   end
-  it "prevents creating a new version in the past" do
+  it "allows creating a new version in the past" do
     master = @master_class.new
     master.update_attributes name: "Single Standard", price: 98, valid_from: Date.today-1
     master.should have_versions %Q{
       | name            | price | created_at | expired_at | valid_from | valid_to | current |
-      | Single Standard | 98    | 2009-11-28 |            | 2009-11-28 |          | true    |
+      | Single Standard | 98    | 2009-11-28 |            | 2009-11-27 |          | true    |
     }
   end
   it "allows creating a new version in the future" do
@@ -168,6 +168,8 @@ describe "Sequel::Plugins::Bitemporal" do
     # | Single Standard | 98    | 2009-11-28 | 2009-11-29 | 2009-11-28 | 2009-11-30 |         |
     # | Single Standard | 98    | 2009-11-29 |            | 2009-11-28 |            | true    |
   end
+  xit "doesn't do anything if unchanged" do
+  end
   it "overrides no future versions" do
     master = @master_class.new
     master.update_attributes name: "Single Standard", price: 98, valid_to: Date.today+2
@@ -217,8 +219,6 @@ describe "Sequel::Plugins::Bitemporal" do
       | King Size       | 98    | 2009-11-29 |            | 2009-11-29 |            | true    |
     }
   end
-  xit "doesn't do anything if unchanged" do
-  end
   it "allows deleting current version" do
     master = @master_class.new
     master.update_attributes name: "Single Standard", price: 98

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sequel_bitemporal
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-11-02 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2154275980 !ruby/object:Gem::Requirement
+  requirement: &2157973260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154275980
+  version_requirements: *2157973260
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2154275540 !ruby/object:Gem::Requirement
+  requirement: &2157972820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154275540
+  version_requirements: *2157972820
 - !ruby/object:Gem::Dependency
   name: timecop
-  requirement: &2154302740 !ruby/object:Gem::Requirement
+  requirement: &2158000040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154302740
+  version_requirements: *2158000040
 - !ruby/object:Gem::Dependency
   name: sequel
-  requirement: &2154302320 !ruby/object:Gem::Requirement
+  requirement: &2157999620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2154302320
+  version_requirements: *2157999620
 description: Bitemporal versioning for sequel, fully tested.
 email:
 - joseph.halter@thetalentbox.com