sequel 5.9.0 → 5.10.0

data/spec/bin_spec.rb

@@ -23,6 +23,8 @@ File.delete(BIN_SPEC_DB2) if File.file?(BIN_SPEC_DB2)
 DB = Sequel.connect("#{CONN_PREFIX}#{BIN_SPEC_DB}", :test=>false)
 DB2 = Sequel.connect("#{CONN_PREFIX}#{BIN_SPEC_DB2}", :test=>false)
 
+ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
+gem 'minitest'
 require 'minitest/autorun'
 
 describe "bin/sequel" do

data/spec/core/dataset_spec.rb

@@ -1729,7 +1729,7 @@ describe "Dataset#with_extend" do
     m2 = Module.new{def a; 3 end}
     d.with_extend(m1, m2){def a; 4**super end}.a.must_equal 65536
     d.respond_to?(:a).must_equal false
-    ds = d.freeze.with_extend(m1, m2){def a; 4**super end}
+    ds = d.with_extend(m1, m2){def a; 4**super end}
     ds.a.must_equal 65536
     ds.frozen?.must_equal true
   end
@@ -1865,7 +1865,7 @@ describe "Dataset#with_row_proc" do
     l = lambda{|r| r}
     d.with_row_proc(l).row_proc.must_equal l
     d.row_proc.must_be_nil
-    ds = d.freeze.with_row_proc(l)
+    ds = d.with_row_proc(l)
     ds.frozen?.must_equal true
     ds.row_proc.must_equal l
   end
@@ -2094,7 +2094,7 @@ end
 describe "Dataset#count" do
   before do
     @db = Sequel.mock(:fetch=>{:count=>1})
-    @dataset = @db.from(:test).columns(:count).freeze
+    @dataset = @db.from(:test).columns(:count)
   end
   
   it "should format SQL properly" do
@@ -2656,7 +2656,7 @@ end
 
 describe "Dataset aggregate methods" do
   before do
-    @d = Sequel.mock(:fetch=>proc{|s| {1=>s}})[:test].freeze
+    @d = Sequel.mock(:fetch=>proc{|s| {1=>s}})[:test]
   end
   
   it "should include min" do
@@ -2715,15 +2715,25 @@ describe "Dataset #first and #last" do
   end
   
   it "should return a single record if no argument is given" do
-    ds = @d.order(:a).freeze
+    ds = @d.order(:a)
     3.times do
       ds.first.must_equal(:s=>'SELECT * FROM test ORDER BY a LIMIT 1')
       ds.last.must_equal(:s=>'SELECT * FROM test ORDER BY a DESC LIMIT 1')
     end
   end
 
+  it "should handle empty arrays and hashes" do
+    ds = @d.order(:a)
+    3.times do
+      ds.first({}).must_equal(:s=>'SELECT * FROM test ORDER BY a LIMIT 1')
+      ds.last({}).must_equal(:s=>'SELECT * FROM test ORDER BY a DESC LIMIT 1')
+      ds.first([]).must_equal(:s=>'SELECT * FROM test ORDER BY a LIMIT 1')
+      ds.last([]).must_equal(:s=>'SELECT * FROM test ORDER BY a DESC LIMIT 1')
+    end
+  end
+
   it "should return the first/last matching record if argument is not an Integer" do
-    ds = @d.order(:a).freeze
+    ds = @d.order(:a)
     5.times do
       ds.first(:z => 26).must_equal(:s=>'SELECT * FROM test WHERE (z = 26) ORDER BY a LIMIT 1')
       ds.first([[:z, 15]]).must_equal(:s=>'SELECT * FROM test WHERE (z = 15) ORDER BY a LIMIT 1')
@@ -2733,7 +2743,7 @@ describe "Dataset #first and #last" do
   end
   
   it "should set the limit and return an array of records if the given number is > 1" do
-    ds = @d.order(:a).freeze
+    ds = @d.order(:a)
     5.times do
       i = rand(10) + 10
       ds.first(i).must_equal [{:s=>"SELECT * FROM test ORDER BY a LIMIT #{i}"}]
@@ -2742,7 +2752,7 @@ describe "Dataset #first and #last" do
   end
   
   it "should return the first matching record if a block is given without an argument" do
-    ds = @d.order(:name).freeze
+    ds = @d.order(:name)
     5.times do
       @d.first{z > 26}.must_equal(:s=>'SELECT * FROM test WHERE (z > 26) LIMIT 1')
       ds.last{z > 26}.must_equal(:s=>'SELECT * FROM test WHERE (z > 26) ORDER BY name DESC LIMIT 1')
@@ -2750,7 +2760,7 @@ describe "Dataset #first and #last" do
   end
   
   it "should combine block and standard argument filters if argument is not an Integer" do
-    ds = @d.order(:name).freeze
+    ds = @d.order(:name)
     5.times do
       @d.first(:y=>25){z > 26}.must_equal(:s=>'SELECT * FROM test WHERE ((y = 25) AND (z > 26)) LIMIT 1')
       ds.last(:y=>16){z > 26}.must_equal(:s=>'SELECT * FROM test WHERE ((y = 16) AND (z > 26)) ORDER BY name DESC LIMIT 1')
@@ -2758,7 +2768,7 @@ describe "Dataset #first and #last" do
   end
   
   it "should combine block and standard argument filters if argument is a literal string" do
-    ds = @d.order(:name).freeze
+    ds = @d.order(:name)
     5.times do
       @d.first(Sequel.lit('y = 25')){z > 26}.must_equal(:s=>'SELECT * FROM test WHERE ((y = 25) AND (z > 26)) LIMIT 1')
       ds.last(Sequel.lit('y = 16')){z > 26}.must_equal(:s=>'SELECT * FROM test WHERE ((y = 16) AND (z > 26)) ORDER BY name DESC LIMIT 1')
@@ -2768,7 +2778,7 @@ describe "Dataset #first and #last" do
   end
 
   it "should filter and return an array of records if an Integer argument is provided and a block is given" do
-    ds = @d.order(:a).freeze
+    ds = @d.order(:a)
     5.times do
       i = rand(10) + 10
       ds.first(i){z > 26}.must_equal [{:s=>"SELECT * FROM test WHERE (z > 26) ORDER BY a LIMIT #{i}"}]
@@ -3038,7 +3048,7 @@ describe "Dataset#get" do
   end
   
   it "should select the specified column and fetch its value" do
-    @d.freeze
+    @d
     5.times do
       @d.get(:name).must_equal "SELECT name FROM test LIMIT 1"
       @d.get(:abc).must_equal "SELECT abc FROM test LIMIT 1"
@@ -3050,14 +3060,14 @@ describe "Dataset#get" do
   end
   
   it "should work with aliased fields" do
-    @d.freeze
+    @d
     5.times do
       @d.get(Sequel.expr(Sequel[:x][:b]).as(:name)).must_equal "SELECT x.b AS name FROM test LIMIT 1"
     end
   end
   
   it "should work with plain strings" do
-    @d.freeze
+    @d
     5.times do
       @d.get('a').must_equal "SELECT 'a' AS v FROM test LIMIT 1"
     end
@@ -5225,33 +5235,20 @@ end
 
 describe "Frozen Datasets" do
   before do
-    @ds = Sequel.mock[:test].freeze
+    @ds = Sequel.mock[:test]
   end
 
-  it "should be returned by Dataset#freeze" do
+  it "datasets should be frozen by default" do
     @ds.must_be :frozen?
   end
 
   it "should have Dataset#freeze return receiver" do
-    @ds = Sequel.mock[:test]
-    @ds.freeze.must_be_same_as(@ds)
-  end
-
-  it "should have Dataset#freeze be a no-op" do
     @ds.freeze.must_be_same_as(@ds)
   end
 
   it "should have clones be frozen" do
     @ds.clone.must_be :frozen?
   end
-
-  it "should be equal to unfrozen ones" do
-    @ds.must_equal @ds.db[:test]
-  end
-
-  it "should not raise an error when calling query methods" do
-    @ds.select(:a).sql.must_equal 'SELECT a FROM test'
-  end
 end
 
 describe "Dataset emulated complex expression operators" do
@@ -5379,7 +5376,7 @@ end
 
 describe "Dataset#where_all"  do
   before do
-    @ds = Sequel.mock(:fetch=>{:id=>1})[:items].freeze
+    @ds = Sequel.mock(:fetch=>{:id=>1})[:items]
   end
 
   it "should filter dataset with condition, and return related rows" do
@@ -5389,6 +5386,15 @@ describe "Dataset#where_all"  do
     end
   end
 
+  it "should handle empty arrays and hashes" do
+    5.times do
+      @ds.where_all([]).must_equal [{:id=>1}]
+      @ds.db.sqls.must_equal ['SELECT * FROM items']
+      @ds.where_all({}).must_equal [{:id=>1}]
+      @ds.db.sqls.must_equal ['SELECT * FROM items']
+    end
+  end
+
   it "should yield each row to the given block" do
     5.times do
       a = []
@@ -5401,7 +5407,18 @@ end
 
 describe "Dataset#where_each"  do
   before do
-    @ds = Sequel.mock(:fetch=>{:id=>1})[:items].freeze
+    @ds = Sequel.mock(:fetch=>{:id=>1})[:items]
+  end
+
+  it "should handle empty arrays and hashes" do
+    [[], {}].each do |arg|
+      5.times do
+        a = []
+        @ds.where_each(arg){|r| a << r}
+        a.must_equal [{:id=>1}]
+        @ds.db.sqls.must_equal ['SELECT * FROM items']
+      end
+    end
   end
 
   it "should yield each row to the given block" do
@@ -5418,7 +5435,16 @@ describe "Dataset#where_single_value"  do
   before do
     @ds = Sequel.mock(:fetch=>{:id=>1})[:items].with_extend do
       select :only_id, :id
-    end.freeze
+    end
+  end
+
+  it "should handle empty arrays and hashes" do
+    [[], {}].each do |arg|
+      5.times do
+        @ds.only_id.where_single_value(arg).must_equal 1
+        @ds.db.sqls.must_equal ['SELECT id FROM items LIMIT 1']
+      end
+    end
   end
 
   it "should return single value" do

data/spec/core/expression_filters_spec.rb

@@ -503,6 +503,12 @@ describe "Blockless Ruby Filters" do
     end
     dsc.new(@d.db).literal(Sequel.trim(:a)).must_equal 'trimFOO(lower(a))'
   end
+
+  it "should endless ranges" do
+    endless = eval('1..')
+    @d.l{x =~ endless}.must_equal '(x >= 1)'
+    @d.l(:x => endless).must_equal '(x >= 1)'
+  end if RUBY_VERSION >= '2.6'
 end
 
 describe Sequel::SQL::VirtualRow do
@@ -1140,6 +1146,16 @@ describe "Sequel::SQLTime" do
     Sequel::SQLTime.create(1, 2, 3).strftime('%Y-%m-%d').must_equal Date.new(2000).strftime('%Y-%m-%d')
   end
 
+  it ".parse should respect SQLTime.date setting" do
+    Sequel::SQLTime.date = Date.new(2000, 2, 3)
+    Sequel::SQLTime.parse('10:11:12').strftime('%F').must_equal "2000-02-03"
+  end
+
+  it ".parse should respect application_timezone setting" do
+    Sequel::application_timezone = :utc
+    Sequel::SQLTime.parse('10:11:12').utc_offset.must_equal 0
+  end
+
   it "#inspect should show class and time by default" do
     Sequel::SQLTime.create(1, 2, 3).inspect.must_equal "#<Sequel::SQLTime 01:02:03>"
     Sequel::SQLTime.create(13, 24, 35).inspect.must_equal "#<Sequel::SQLTime 13:24:35>"

data/spec/core/spec_helper.rb

@@ -8,6 +8,7 @@ end
 $:.unshift(File.join(File.dirname(File.expand_path(__FILE__)), "../../lib/"))
 require_relative "../../lib/sequel/core"
 
+ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
 gem 'minitest'
 require 'minitest/autorun'
 require 'minitest/hooks/default'

data/spec/core_extensions_spec.rb

@@ -14,6 +14,7 @@ Sequel.extension :core_extensions
 Sequel.extension :symbol_aref
 Sequel.extension :virtual_row_method_block
 
+ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
 gem 'minitest'
 require 'minitest/autorun'
 require 'minitest/hooks/default'

data/spec/extensions/list_spec.rb

@@ -17,6 +17,8 @@ describe "List plugin" do
     @o = @c.load(:id=>7, :position=>3)
     @sc = klass(:scope=>:scope_id)
     @so = @sc.load(:id=>7, :position=>3, :scope_id=>5)
+    @tc = klass(:top=>0)
+    @to = @tc.load(:id=>7, :position=>3)
     @db.reset
   end
 
@@ -43,6 +45,14 @@ describe "List plugin" do
     klass(:scope=>proc{|o| o.model.dataset.filter(:active).filter(:scope_id=>o.scope_id)}).new(:scope_id=>4).list_dataset.sql.must_equal 'SELECT * FROM items WHERE (active AND (scope_id = 4)) ORDER BY position'
   end
 
+  it "should default top of the list to 1" do
+    @c.top_of_list.must_equal 1
+  end
+
+  it "should accept a :top option to set top of the list" do
+    @tc.top_of_list.must_equal 0
+  end
+
   it "should modify the order when using the plugin" do
     c = Class.new(Sequel::Model(:items))
     c.dataset.sql.must_equal 'SELECT * FROM items'
@@ -199,6 +209,12 @@ describe "List plugin" do
       "UPDATE items SET position = 1 WHERE (id = 7)"]
   end
 
+  it "should have move_to_top use position 0 when :top_of_list is 0" do
+    @to.move_to_top
+    @db.sqls.must_equal ["UPDATE items SET position = (position + 1) WHERE ((position >= 0) AND (position < 3))",
+      "UPDATE items SET position = 0 WHERE (id = 7)"]
+  end
+
   it "should have move_up without an argument move up a single position" do
     @o.move_up.must_equal @o
     @o.position.must_equal 2

data/spec/extensions/pg_array_associations_spec.rb

@@ -72,7 +72,7 @@ describe Sequel::Model, "pg_array_associations" do
 
   it "should allowing filtering by associations with :conditions" do
     @c1.filter(:a_tags=>@o2).sql.must_equal "SELECT * FROM artists WHERE coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id = 2)))), false)"
-    @c2.filter(:a_artists=>@o1).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id = 1))))"
+    @c2.filter(:a_artists=>@o1).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id = 1))))"
   end
 
   it "should allowing excluding by associations" do
@@ -82,7 +82,7 @@ describe Sequel::Model, "pg_array_associations" do
 
   it "should allowing excluding by associations with :conditions" do
     @c1.exclude(:a_tags=>@o2).sql.must_equal "SELECT * FROM artists WHERE (NOT coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id = 2)))), false) OR (artists.tag_ids IS NULL))"
-    @c2.exclude(:a_artists=>@o1).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id = 1)))) OR (tags.id IS NULL))"
+    @c2.exclude(:a_artists=>@o1).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id = 1)))) OR (tags.id IS NULL))"
   end
 
   it "should allowing filtering by multiple associations" do
@@ -92,7 +92,7 @@ describe Sequel::Model, "pg_array_associations" do
 
   it "should allowing filtering by multiple associations with :conditions" do
     @c1.filter(:a_tags=>[@c2.load(:id=>1), @c2.load(:id=>2)]).sql.must_equal "SELECT * FROM artists WHERE coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id IN (1, 2))))), false)"
-    @c2.filter(:a_artists=>[@c1.load(:id=>7, :tag_ids=>Sequel.pg_array([3, 4])), @c1.load(:id=>8, :tag_ids=>Sequel.pg_array([4, 5]))]).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (7, 8)))))"
+    @c2.filter(:a_artists=>[@c1.load(:id=>7, :tag_ids=>Sequel.pg_array([3, 4])), @c1.load(:id=>8, :tag_ids=>Sequel.pg_array([4, 5]))]).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (7, 8)))))"
   end
 
   it "should allowing excluding by multiple associations" do
@@ -102,7 +102,7 @@ describe Sequel::Model, "pg_array_associations" do
 
   it "should allowing excluding by multiple associations with :conditions" do
     @c1.exclude(:a_tags=>[@c2.load(:id=>1), @c2.load(:id=>2)]).sql.must_equal "SELECT * FROM artists WHERE (NOT coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id IN (1, 2))))), false) OR (artists.tag_ids IS NULL))"
-    @c2.exclude(:a_artists=>[@c1.load(:id=>7, :tag_ids=>Sequel.pg_array([3, 4])), @c1.load(:id=>8, :tag_ids=>Sequel.pg_array([4, 5]))]).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (7, 8))))) OR (tags.id IS NULL))"
+    @c2.exclude(:a_artists=>[@c1.load(:id=>7, :tag_ids=>Sequel.pg_array([3, 4])), @c1.load(:id=>8, :tag_ids=>Sequel.pg_array([4, 5]))]).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (7, 8))))) OR (tags.id IS NULL))"
   end
 
   it "should allowing filtering/excluding associations with NULL or empty values" do
@@ -120,22 +120,22 @@ describe Sequel::Model, "pg_array_associations" do
 
   it "should allowing filtering by association datasets" do
     @c1.filter(:tags=>@c2.where(:id=>1)).sql.must_equal "SELECT * FROM artists WHERE coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE (id = 1))), false)"
-    @c2.filter(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT unnest(artists.tag_ids) FROM artists WHERE (id = 1)))"
+    @c2.filter(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (EXISTS (SELECT 1 FROM (SELECT artists.tag_ids AS key FROM artists WHERE (id = 1)) AS t1 WHERE (tags.id = any(key))))"
   end
 
   it "should allowing filtering by association datasets with :conditions" do
     @c1.filter(:a_tags=>@c2.where(:id=>1)).sql.must_equal "SELECT * FROM artists WHERE coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id IN (SELECT tags.id FROM tags WHERE (id = 1)))))), false)"
-    @c2.filter(:a_artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (SELECT artists.id FROM artists WHERE (id = 1))))))"
+    @c2.filter(:a_artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (tags.id IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (SELECT artists.id FROM artists WHERE (id = 1))))))"
   end
 
   it "should allowing excluding by association datasets" do
     @c1.exclude(:tags=>@c2.where(:id=>1)).sql.must_equal "SELECT * FROM artists WHERE (NOT coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE (id = 1))), false) OR (artists.tag_ids IS NULL))"
-    @c2.exclude(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT unnest(artists.tag_ids) FROM artists WHERE (id = 1))) OR (tags.id IS NULL))"
+    @c2.exclude(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (NOT (EXISTS (SELECT 1 FROM (SELECT artists.tag_ids AS key FROM artists WHERE (id = 1)) AS t1 WHERE (tags.id = any(key)))) OR (tags.id IS NULL))"
   end
 
   it "should allowing excluding by association datasets with :conditions" do
     @c1.exclude(:a_tags=>@c2.where(:id=>1)).sql.must_equal "SELECT * FROM artists WHERE (NOT coalesce((artists.tag_ids && (SELECT array_agg(tags.id) FROM tags WHERE ((name = 'A') AND (tags.id IS NOT NULL) AND (tags.id IN (SELECT tags.id FROM tags WHERE (id = 1)))))), false) OR (artists.tag_ids IS NULL))"
-    @c2.exclude(:a_artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT unnest(artists.tag_ids) FROM artists WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (SELECT artists.id FROM artists WHERE (id = 1)))))) OR (tags.id IS NULL))"
+    @c2.exclude(:a_artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE ((tags.id NOT IN (SELECT _smtopgaa_key_ FROM artists CROSS JOIN unnest(artists.tag_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE ((name = 'A') AND (artists.tag_ids IS NOT NULL) AND (artists.id IN (SELECT artists.id FROM artists WHERE (id = 1)))))) OR (tags.id IS NULL))"
   end
 
   it "filter by associations should respect key options" do 
@@ -146,7 +146,7 @@ describe Sequel::Model, "pg_array_associations" do
     @c1.filter(:tags=>@o2).sql.must_equal "SELECT * FROM artists WHERE (artists.tag_ids[1:2] @> ARRAY[6]::integer[])"
     @c2.filter(:artists=>@o1).sql.must_equal "SELECT * FROM tags WHERE ((tags.id * 3) IN (3, 6, 9))"
     @c1.filter(:tags=>@c2.where(:id=>1)).sql.must_equal "SELECT * FROM artists WHERE coalesce((artists.tag_ids[1:2] && (SELECT array_agg((tags.id * 3)) FROM tags WHERE (id = 1))), false)"
-    @c2.filter(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE ((tags.id * 3) IN (SELECT unnest(artists.tag_ids[1:2]) FROM artists WHERE (id = 1)))"
+    @c2.filter(:artists=>@c1.where(:id=>1)).sql.must_equal "SELECT * FROM tags WHERE (EXISTS (SELECT 1 FROM (SELECT artists.tag_ids[1:2] AS key FROM artists WHERE (id = 1)) AS t1 WHERE ((tags.id * 3) = any(key))))"
   end
   
   it "should raise an error if associated model does not have a primary key, and :primary_key is not specified" do
@@ -793,7 +793,7 @@ describe "Sequel::Model.finalize_associations" do
     r[:_dataset].sql.must_equal "SELECT * FROM items"
     r[:associated_eager_dataset].sql.must_equal  "SELECT * FROM items"
     r.fetch(:_eager_limit_strategy).must_be_nil
-    r[:filter_by_associations_conditions_dataset].sql.must_equal "SELECT unnest(items.foo_ids) FROM items WHERE (items.foo_ids IS NOT NULL)"
+    r[:filter_by_associations_conditions_dataset].sql.must_equal "SELECT _smtopgaa_key_ FROM items CROSS JOIN unnest(items.foo_ids) AS _smtopgaa_(_smtopgaa_key_) WHERE (items.foo_ids IS NOT NULL)"
     r[:predicate_key].must_equal Sequel.qualify(:items, :foo_ids)
     r[:predicate_keys].must_equal [Sequel.qualify(:items, :foo_ids)]
     r[:reciprocal].must_equal :foos

data/spec/extensions/pg_range_spec.rb

@@ -16,6 +16,8 @@ describe "pg_range extension" do
     @db.extension(:pg_array, :pg_range)
   end
 
+  endless_range_support = RUBY_VERSION >= '2.6'
+
   it "should set up conversion procs correctly" do
     cp = @db.conversion_procs
     cp[3904].call("[1,2]").must_equal @R.new(1,2, :exclude_begin=>false, :exclude_end=>false, :db_type=>'int4range')
@@ -48,6 +50,10 @@ describe "pg_range extension" do
     @db.literal(''..'()[]",\\2').must_equal "'[\"\",\\(\\)\\[\\]\\\"\\,\\\\2]'"
   end
 
+  it "should literalize endless Range instances to strings correctly" do
+    @db.literal(eval('1..')).must_equal "'[1,]'"
+  end if endless_range_support
+
   it "should literalize PGRange instances to strings correctly" do
     @db.literal(@R.new(1, 2)).must_equal "'[1,2]'"
     @db.literal(@R.new(true, false)).must_equal "'[true,false]'"
@@ -71,6 +77,10 @@ describe "pg_range extension" do
     @db.bound_variable_arg(1..2, nil).must_equal "[1,2]"
   end
 
+  it "should support using endless Range instances as bound variables" do
+    @db.bound_variable_arg(eval('1..'), nil).must_equal "[1,]"
+  end if endless_range_support
+
   it "should support using PGRange instances as bound variables" do
     @db.bound_variable_arg(@R.new(1, 2), nil).must_equal "[1,2]"
   end
@@ -79,6 +89,10 @@ describe "pg_range extension" do
     @db.bound_variable_arg([1..2,2...3], nil).must_equal '{"[1,2]","[2,3)"}'
   end
 
+  it "should support using arrays of endless Range instances as bound variables" do
+    @db.bound_variable_arg([eval('1..'), eval('2..')], nil).must_equal '{"[1,]","[2,]"}'
+  end if endless_range_support
+
   it "should support using PGRange instances as bound variables" do
     @db.bound_variable_arg([@R.new(1, 2),@R.new(2, 3)], nil).must_equal '{"[1,2]","[2,3]"}'
   end
@@ -415,6 +429,14 @@ describe "pg_range extension" do
       @R.new(nil, nil).wont_be :==, (1..2)
     end
 
+    it "should consider PGRanges equal with a endless Range they represent" do
+      @R.new(1, nil).must_be :==, eval('1..')
+    end if endless_range_support
+
+    it "should not consider a PGRange equal with a Range if it can't be expressed as a range" do
+      @R.new(1, nil).wont_be :==, eval('2..')
+    end if endless_range_support
+
     it "should not consider a PGRange equal to other objects" do
       @R.new(nil, nil).wont_equal 1
     end
@@ -450,7 +472,6 @@ describe "pg_range extension" do
 
     it "should have #to_range raise an exception if the PGRange cannot be represented by a Range" do
       proc{@R.new(nil, 1).to_range}.must_raise(Sequel::Error)
-      proc{@R.new(1, nil).to_range}.must_raise(Sequel::Error)
       proc{@R.new(0, 1, :exclude_begin=>true).to_range}.must_raise(Sequel::Error)
       proc{@R.empty.to_range}.must_raise(Sequel::Error)
     end
@@ -459,6 +480,14 @@ describe "pg_range extension" do
       @r1.to_range.must_be :==, (1..2)
     end
 
+    it "should have #to_range return the represented range for endless ranges" do
+      @R.new(1, nil).to_range.must_be :==, eval('1..')
+    end if endless_range_support
+
+    it "should have #to_range raise an exception for endless ranges" do
+      proc{@R.new(1, nil).to_range}.must_raise(Sequel::Error)
+    end unless endless_range_support
+
     it "should have #to_range cache the returned value" do
       @r1.to_range.must_be_same_as(@r1.to_range)
     end
@@ -479,9 +508,12 @@ describe "pg_range extension" do
 
     it "should have #valid_ruby_range? return false if the PGRange cannot be represented as a Range" do
       @R.new(nil, 1).valid_ruby_range?.must_equal false
-      @R.new(1, nil).valid_ruby_range?.must_equal false
       @R.new(0, 1, :exclude_begin=>true).valid_ruby_range?.must_equal false
       @R.empty.valid_ruby_range?.must_equal false
     end
+
+   it "should have #valid_ruby_range return #{endless_range_support} for endless ranges" do
+      @R.new(1, nil).valid_ruby_range?.must_equal(endless_range_support)
+    end
   end
 end