sequel 5.29.0 → 5.34.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (387) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG +70 -1922
  3. data/README.rdoc +1 -1
  4. data/doc/advanced_associations.rdoc +4 -4
  5. data/doc/association_basics.rdoc +3 -3
  6. data/doc/code_order.rdoc +12 -2
  7. data/doc/model_dataset_method_design.rdoc +1 -1
  8. data/doc/postgresql.rdoc +71 -0
  9. data/doc/release_notes/5.30.0.txt +20 -0
  10. data/doc/release_notes/5.31.0.txt +148 -0
  11. data/doc/release_notes/5.32.0.txt +46 -0
  12. data/doc/release_notes/5.33.0.txt +24 -0
  13. data/doc/release_notes/5.34.0.txt +40 -0
  14. data/doc/testing.rdoc +1 -1
  15. data/lib/sequel/adapters/shared/access.rb +6 -6
  16. data/lib/sequel/adapters/shared/mssql.rb +5 -5
  17. data/lib/sequel/adapters/shared/mysql.rb +9 -9
  18. data/lib/sequel/adapters/shared/oracle.rb +16 -16
  19. data/lib/sequel/adapters/shared/postgres.rb +169 -14
  20. data/lib/sequel/adapters/shared/sqlanywhere.rb +9 -9
  21. data/lib/sequel/adapters/shared/sqlite.rb +32 -5
  22. data/lib/sequel/connection_pool/sharded_single.rb +4 -1
  23. data/lib/sequel/connection_pool/sharded_threaded.rb +12 -12
  24. data/lib/sequel/connection_pool/single.rb +1 -1
  25. data/lib/sequel/connection_pool/threaded.rb +2 -2
  26. data/lib/sequel/core.rb +318 -314
  27. data/lib/sequel/database/connecting.rb +1 -1
  28. data/lib/sequel/database/misc.rb +16 -10
  29. data/lib/sequel/database/query.rb +3 -1
  30. data/lib/sequel/database/schema_generator.rb +0 -1
  31. data/lib/sequel/database/schema_methods.rb +15 -16
  32. data/lib/sequel/database/transactions.rb +12 -13
  33. data/lib/sequel/dataset/placeholder_literalizer.rb +3 -7
  34. data/lib/sequel/dataset/query.rb +4 -3
  35. data/lib/sequel/deprecated.rb +2 -0
  36. data/lib/sequel/exceptions.rb +2 -0
  37. data/lib/sequel/extensions/connection_expiration.rb +2 -2
  38. data/lib/sequel/extensions/connection_validator.rb +2 -2
  39. data/lib/sequel/extensions/fiber_concurrency.rb +24 -0
  40. data/lib/sequel/extensions/index_caching.rb +9 -7
  41. data/lib/sequel/extensions/integer64.rb +2 -0
  42. data/lib/sequel/extensions/migration.rb +1 -1
  43. data/lib/sequel/extensions/pg_enum.rb +5 -2
  44. data/lib/sequel/extensions/pg_hstore.rb +6 -0
  45. data/lib/sequel/extensions/pg_inet.rb +13 -5
  46. data/lib/sequel/extensions/pg_interval.rb +2 -0
  47. data/lib/sequel/extensions/pg_range.rb +2 -0
  48. data/lib/sequel/extensions/pg_timestamptz.rb +2 -0
  49. data/lib/sequel/extensions/run_transaction_hooks.rb +72 -0
  50. data/lib/sequel/extensions/schema_dumper.rb +10 -4
  51. data/lib/sequel/extensions/server_block.rb +3 -3
  52. data/lib/sequel/model.rb +2 -0
  53. data/lib/sequel/model/associations.rb +30 -18
  54. data/lib/sequel/model/base.rb +64 -55
  55. data/lib/sequel/model/plugins.rb +3 -3
  56. data/lib/sequel/plugins/association_lazy_eager_option.rb +66 -0
  57. data/lib/sequel/plugins/association_multi_add_remove.rb +2 -0
  58. data/lib/sequel/plugins/association_pks.rb +57 -16
  59. data/lib/sequel/plugins/association_proxies.rb +2 -0
  60. data/lib/sequel/plugins/boolean_subsets.rb +4 -1
  61. data/lib/sequel/plugins/class_table_inheritance.rb +26 -26
  62. data/lib/sequel/plugins/dirty.rb +13 -13
  63. data/lib/sequel/plugins/forbid_lazy_load.rb +214 -0
  64. data/lib/sequel/plugins/json_serializer.rb +3 -7
  65. data/lib/sequel/plugins/rcte_tree.rb +2 -2
  66. data/lib/sequel/plugins/single_table_inheritance.rb +15 -15
  67. data/lib/sequel/plugins/skip_saving_columns.rb +108 -0
  68. data/lib/sequel/plugins/subclasses.rb +2 -0
  69. data/lib/sequel/timezones.rb +6 -4
  70. data/lib/sequel/version.rb +1 -1
  71. metadata +17 -368
  72. data/Rakefile +0 -151
  73. data/doc/release_notes/4.0.0.txt +0 -262
  74. data/doc/release_notes/4.1.0.txt +0 -85
  75. data/doc/release_notes/4.10.0.txt +0 -226
  76. data/doc/release_notes/4.11.0.txt +0 -147
  77. data/doc/release_notes/4.12.0.txt +0 -105
  78. data/doc/release_notes/4.13.0.txt +0 -169
  79. data/doc/release_notes/4.14.0.txt +0 -68
  80. data/doc/release_notes/4.15.0.txt +0 -56
  81. data/doc/release_notes/4.16.0.txt +0 -36
  82. data/doc/release_notes/4.17.0.txt +0 -38
  83. data/doc/release_notes/4.18.0.txt +0 -36
  84. data/doc/release_notes/4.19.0.txt +0 -45
  85. data/doc/release_notes/4.2.0.txt +0 -129
  86. data/doc/release_notes/4.20.0.txt +0 -79
  87. data/doc/release_notes/4.21.0.txt +0 -94
  88. data/doc/release_notes/4.22.0.txt +0 -72
  89. data/doc/release_notes/4.23.0.txt +0 -65
  90. data/doc/release_notes/4.24.0.txt +0 -99
  91. data/doc/release_notes/4.25.0.txt +0 -181
  92. data/doc/release_notes/4.26.0.txt +0 -44
  93. data/doc/release_notes/4.27.0.txt +0 -78
  94. data/doc/release_notes/4.28.0.txt +0 -57
  95. data/doc/release_notes/4.29.0.txt +0 -41
  96. data/doc/release_notes/4.3.0.txt +0 -40
  97. data/doc/release_notes/4.30.0.txt +0 -37
  98. data/doc/release_notes/4.31.0.txt +0 -57
  99. data/doc/release_notes/4.32.0.txt +0 -132
  100. data/doc/release_notes/4.33.0.txt +0 -88
  101. data/doc/release_notes/4.34.0.txt +0 -86
  102. data/doc/release_notes/4.35.0.txt +0 -130
  103. data/doc/release_notes/4.36.0.txt +0 -116
  104. data/doc/release_notes/4.37.0.txt +0 -50
  105. data/doc/release_notes/4.38.0.txt +0 -67
  106. data/doc/release_notes/4.39.0.txt +0 -127
  107. data/doc/release_notes/4.4.0.txt +0 -92
  108. data/doc/release_notes/4.40.0.txt +0 -179
  109. data/doc/release_notes/4.41.0.txt +0 -77
  110. data/doc/release_notes/4.42.0.txt +0 -221
  111. data/doc/release_notes/4.43.0.txt +0 -87
  112. data/doc/release_notes/4.44.0.txt +0 -125
  113. data/doc/release_notes/4.45.0.txt +0 -370
  114. data/doc/release_notes/4.46.0.txt +0 -404
  115. data/doc/release_notes/4.47.0.txt +0 -56
  116. data/doc/release_notes/4.48.0.txt +0 -293
  117. data/doc/release_notes/4.49.0.txt +0 -222
  118. data/doc/release_notes/4.5.0.txt +0 -34
  119. data/doc/release_notes/4.6.0.txt +0 -30
  120. data/doc/release_notes/4.7.0.txt +0 -103
  121. data/doc/release_notes/4.8.0.txt +0 -175
  122. data/doc/release_notes/4.9.0.txt +0 -190
  123. data/spec/adapter_spec.rb +0 -4
  124. data/spec/adapters/db2_spec.rb +0 -170
  125. data/spec/adapters/mssql_spec.rb +0 -828
  126. data/spec/adapters/mysql_spec.rb +0 -1060
  127. data/spec/adapters/oracle_spec.rb +0 -371
  128. data/spec/adapters/postgres_spec.rb +0 -4476
  129. data/spec/adapters/spec_helper.rb +0 -44
  130. data/spec/adapters/sqlanywhere_spec.rb +0 -97
  131. data/spec/adapters/sqlite_spec.rb +0 -652
  132. data/spec/bin_spec.rb +0 -278
  133. data/spec/core/connection_pool_spec.rb +0 -1250
  134. data/spec/core/database_spec.rb +0 -2915
  135. data/spec/core/dataset_spec.rb +0 -5544
  136. data/spec/core/deprecated_spec.rb +0 -70
  137. data/spec/core/expression_filters_spec.rb +0 -1498
  138. data/spec/core/mock_adapter_spec.rb +0 -722
  139. data/spec/core/object_graph_spec.rb +0 -336
  140. data/spec/core/placeholder_literalizer_spec.rb +0 -166
  141. data/spec/core/schema_generator_spec.rb +0 -214
  142. data/spec/core/schema_spec.rb +0 -1844
  143. data/spec/core/spec_helper.rb +0 -24
  144. data/spec/core/version_spec.rb +0 -14
  145. data/spec/core_extensions_spec.rb +0 -763
  146. data/spec/core_model_spec.rb +0 -2
  147. data/spec/core_spec.rb +0 -1
  148. data/spec/deprecation_helper.rb +0 -30
  149. data/spec/extensions/accessed_columns_spec.rb +0 -51
  150. data/spec/extensions/active_model_spec.rb +0 -99
  151. data/spec/extensions/after_initialize_spec.rb +0 -28
  152. data/spec/extensions/any_not_empty_spec.rb +0 -23
  153. data/spec/extensions/arbitrary_servers_spec.rb +0 -109
  154. data/spec/extensions/association_dependencies_spec.rb +0 -125
  155. data/spec/extensions/association_multi_add_remove_spec.rb +0 -1041
  156. data/spec/extensions/association_pks_spec.rb +0 -423
  157. data/spec/extensions/association_proxies_spec.rb +0 -100
  158. data/spec/extensions/auto_literal_strings_spec.rb +0 -205
  159. data/spec/extensions/auto_validations_spec.rb +0 -229
  160. data/spec/extensions/blacklist_security_spec.rb +0 -95
  161. data/spec/extensions/blank_spec.rb +0 -69
  162. data/spec/extensions/boolean_readers_spec.rb +0 -93
  163. data/spec/extensions/boolean_subsets_spec.rb +0 -47
  164. data/spec/extensions/caching_spec.rb +0 -273
  165. data/spec/extensions/caller_logging_spec.rb +0 -52
  166. data/spec/extensions/class_table_inheritance_spec.rb +0 -750
  167. data/spec/extensions/column_conflicts_spec.rb +0 -75
  168. data/spec/extensions/column_select_spec.rb +0 -129
  169. data/spec/extensions/columns_introspection_spec.rb +0 -90
  170. data/spec/extensions/columns_updated_spec.rb +0 -35
  171. data/spec/extensions/composition_spec.rb +0 -248
  172. data/spec/extensions/connection_expiration_spec.rb +0 -151
  173. data/spec/extensions/connection_validator_spec.rb +0 -144
  174. data/spec/extensions/constant_sql_override_spec.rb +0 -24
  175. data/spec/extensions/constraint_validations_plugin_spec.rb +0 -300
  176. data/spec/extensions/constraint_validations_spec.rb +0 -439
  177. data/spec/extensions/core_refinements_spec.rb +0 -528
  178. data/spec/extensions/csv_serializer_spec.rb +0 -183
  179. data/spec/extensions/current_datetime_timestamp_spec.rb +0 -27
  180. data/spec/extensions/dataset_associations_spec.rb +0 -365
  181. data/spec/extensions/dataset_source_alias_spec.rb +0 -51
  182. data/spec/extensions/date_arithmetic_spec.rb +0 -181
  183. data/spec/extensions/datetime_parse_to_time_spec.rb +0 -169
  184. data/spec/extensions/def_dataset_method_spec.rb +0 -100
  185. data/spec/extensions/defaults_setter_spec.rb +0 -150
  186. data/spec/extensions/delay_add_association_spec.rb +0 -73
  187. data/spec/extensions/dirty_spec.rb +0 -222
  188. data/spec/extensions/duplicate_columns_handler_spec.rb +0 -104
  189. data/spec/extensions/eager_each_spec.rb +0 -62
  190. data/spec/extensions/eager_graph_eager_spec.rb +0 -100
  191. data/spec/extensions/empty_array_consider_nulls_spec.rb +0 -24
  192. data/spec/extensions/empty_failure_backtraces_spec.rb +0 -60
  193. data/spec/extensions/error_splitter_spec.rb +0 -18
  194. data/spec/extensions/error_sql_spec.rb +0 -20
  195. data/spec/extensions/escaped_like_spec.rb +0 -40
  196. data/spec/extensions/eval_inspect_spec.rb +0 -81
  197. data/spec/extensions/exclude_or_null_spec.rb +0 -15
  198. data/spec/extensions/finder_spec.rb +0 -260
  199. data/spec/extensions/force_encoding_spec.rb +0 -126
  200. data/spec/extensions/freeze_datasets_spec.rb +0 -31
  201. data/spec/extensions/graph_each_spec.rb +0 -113
  202. data/spec/extensions/hook_class_methods_spec.rb +0 -402
  203. data/spec/extensions/identifier_mangling_spec.rb +0 -201
  204. data/spec/extensions/implicit_subquery_spec.rb +0 -58
  205. data/spec/extensions/index_caching_spec.rb +0 -66
  206. data/spec/extensions/inflector_spec.rb +0 -183
  207. data/spec/extensions/input_transformer_spec.rb +0 -69
  208. data/spec/extensions/insert_conflict_spec.rb +0 -103
  209. data/spec/extensions/insert_returning_select_spec.rb +0 -72
  210. data/spec/extensions/instance_filters_spec.rb +0 -79
  211. data/spec/extensions/instance_hooks_spec.rb +0 -246
  212. data/spec/extensions/integer64_spec.rb +0 -22
  213. data/spec/extensions/inverted_subsets_spec.rb +0 -33
  214. data/spec/extensions/json_serializer_spec.rb +0 -346
  215. data/spec/extensions/lazy_attributes_spec.rb +0 -183
  216. data/spec/extensions/list_spec.rb +0 -291
  217. data/spec/extensions/looser_typecasting_spec.rb +0 -43
  218. data/spec/extensions/many_through_many_spec.rb +0 -2177
  219. data/spec/extensions/migration_spec.rb +0 -864
  220. data/spec/extensions/modification_detection_spec.rb +0 -93
  221. data/spec/extensions/mssql_optimistic_locking_spec.rb +0 -92
  222. data/spec/extensions/named_timezones_spec.rb +0 -218
  223. data/spec/extensions/nested_attributes_spec.rb +0 -815
  224. data/spec/extensions/null_dataset_spec.rb +0 -85
  225. data/spec/extensions/optimistic_locking_spec.rb +0 -127
  226. data/spec/extensions/pagination_spec.rb +0 -116
  227. data/spec/extensions/pg_array_associations_spec.rb +0 -802
  228. data/spec/extensions/pg_array_ops_spec.rb +0 -144
  229. data/spec/extensions/pg_array_spec.rb +0 -398
  230. data/spec/extensions/pg_auto_constraint_validations_spec.rb +0 -209
  231. data/spec/extensions/pg_enum_spec.rb +0 -118
  232. data/spec/extensions/pg_extended_date_support_spec.rb +0 -126
  233. data/spec/extensions/pg_hstore_ops_spec.rb +0 -238
  234. data/spec/extensions/pg_hstore_spec.rb +0 -219
  235. data/spec/extensions/pg_inet_ops_spec.rb +0 -102
  236. data/spec/extensions/pg_inet_spec.rb +0 -72
  237. data/spec/extensions/pg_interval_spec.rb +0 -103
  238. data/spec/extensions/pg_json_ops_spec.rb +0 -356
  239. data/spec/extensions/pg_json_spec.rb +0 -451
  240. data/spec/extensions/pg_loose_count_spec.rb +0 -23
  241. data/spec/extensions/pg_range_ops_spec.rb +0 -60
  242. data/spec/extensions/pg_range_spec.rb +0 -600
  243. data/spec/extensions/pg_row_ops_spec.rb +0 -61
  244. data/spec/extensions/pg_row_plugin_spec.rb +0 -60
  245. data/spec/extensions/pg_row_spec.rb +0 -363
  246. data/spec/extensions/pg_static_cache_updater_spec.rb +0 -93
  247. data/spec/extensions/pg_timestamptz_spec.rb +0 -17
  248. data/spec/extensions/prepared_statements_safe_spec.rb +0 -66
  249. data/spec/extensions/prepared_statements_spec.rb +0 -177
  250. data/spec/extensions/pretty_table_spec.rb +0 -123
  251. data/spec/extensions/query_spec.rb +0 -94
  252. data/spec/extensions/rcte_tree_spec.rb +0 -387
  253. data/spec/extensions/round_timestamps_spec.rb +0 -39
  254. data/spec/extensions/s_spec.rb +0 -60
  255. data/spec/extensions/schema_caching_spec.rb +0 -64
  256. data/spec/extensions/schema_dumper_spec.rb +0 -870
  257. data/spec/extensions/select_remove_spec.rb +0 -38
  258. data/spec/extensions/sequel_4_dataset_methods_spec.rb +0 -121
  259. data/spec/extensions/serialization_modification_detection_spec.rb +0 -98
  260. data/spec/extensions/serialization_spec.rb +0 -365
  261. data/spec/extensions/server_block_spec.rb +0 -135
  262. data/spec/extensions/server_logging_spec.rb +0 -45
  263. data/spec/extensions/sharding_spec.rb +0 -197
  264. data/spec/extensions/shared_caching_spec.rb +0 -151
  265. data/spec/extensions/single_table_inheritance_spec.rb +0 -347
  266. data/spec/extensions/singular_table_names_spec.rb +0 -22
  267. data/spec/extensions/skip_create_refresh_spec.rb +0 -18
  268. data/spec/extensions/spec_helper.rb +0 -70
  269. data/spec/extensions/split_array_nil_spec.rb +0 -24
  270. data/spec/extensions/split_values_spec.rb +0 -57
  271. data/spec/extensions/sql_comments_spec.rb +0 -33
  272. data/spec/extensions/sql_expr_spec.rb +0 -59
  273. data/spec/extensions/static_cache_cache_spec.rb +0 -35
  274. data/spec/extensions/static_cache_spec.rb +0 -471
  275. data/spec/extensions/string_agg_spec.rb +0 -90
  276. data/spec/extensions/string_date_time_spec.rb +0 -95
  277. data/spec/extensions/string_stripper_spec.rb +0 -68
  278. data/spec/extensions/subclasses_spec.rb +0 -79
  279. data/spec/extensions/subset_conditions_spec.rb +0 -38
  280. data/spec/extensions/symbol_aref_refinement_spec.rb +0 -28
  281. data/spec/extensions/symbol_as_refinement_spec.rb +0 -21
  282. data/spec/extensions/synchronize_sql_spec.rb +0 -124
  283. data/spec/extensions/table_select_spec.rb +0 -83
  284. data/spec/extensions/tactical_eager_loading_spec.rb +0 -402
  285. data/spec/extensions/thread_local_timezones_spec.rb +0 -67
  286. data/spec/extensions/throw_failures_spec.rb +0 -74
  287. data/spec/extensions/timestamps_spec.rb +0 -209
  288. data/spec/extensions/to_dot_spec.rb +0 -153
  289. data/spec/extensions/touch_spec.rb +0 -226
  290. data/spec/extensions/tree_spec.rb +0 -334
  291. data/spec/extensions/typecast_on_load_spec.rb +0 -86
  292. data/spec/extensions/unlimited_update_spec.rb +0 -21
  293. data/spec/extensions/update_or_create_spec.rb +0 -83
  294. data/spec/extensions/update_primary_key_spec.rb +0 -105
  295. data/spec/extensions/update_refresh_spec.rb +0 -59
  296. data/spec/extensions/uuid_spec.rb +0 -101
  297. data/spec/extensions/validate_associated_spec.rb +0 -52
  298. data/spec/extensions/validation_class_methods_spec.rb +0 -1040
  299. data/spec/extensions/validation_contexts_spec.rb +0 -31
  300. data/spec/extensions/validation_helpers_spec.rb +0 -525
  301. data/spec/extensions/whitelist_security_spec.rb +0 -157
  302. data/spec/extensions/xml_serializer_spec.rb +0 -213
  303. data/spec/files/bad_down_migration/001_create_alt_basic.rb +0 -4
  304. data/spec/files/bad_down_migration/002_create_alt_advanced.rb +0 -4
  305. data/spec/files/bad_timestamped_migrations/1273253849_create_sessions.rb +0 -9
  306. data/spec/files/bad_timestamped_migrations/1273253851_create_nodes.rb +0 -9
  307. data/spec/files/bad_timestamped_migrations/1273253853_3_create_users.rb +0 -3
  308. data/spec/files/bad_up_migration/001_create_alt_basic.rb +0 -4
  309. data/spec/files/bad_up_migration/002_create_alt_advanced.rb +0 -3
  310. data/spec/files/convert_to_timestamp_migrations/001_create_sessions.rb +0 -9
  311. data/spec/files/convert_to_timestamp_migrations/002_create_nodes.rb +0 -9
  312. data/spec/files/convert_to_timestamp_migrations/003_3_create_users.rb +0 -4
  313. data/spec/files/convert_to_timestamp_migrations/1273253850_create_artists.rb +0 -9
  314. data/spec/files/convert_to_timestamp_migrations/1273253852_create_albums.rb +0 -9
  315. data/spec/files/double_migration/001_create_sessions.rb +0 -9
  316. data/spec/files/double_migration/002_create_nodes.rb +0 -19
  317. data/spec/files/double_migration/003_3_create_users.rb +0 -4
  318. data/spec/files/duplicate_integer_migrations/001_create_alt_advanced.rb +0 -4
  319. data/spec/files/duplicate_integer_migrations/001_create_alt_basic.rb +0 -4
  320. data/spec/files/duplicate_timestamped_migrations/1273253849_create_sessions.rb +0 -9
  321. data/spec/files/duplicate_timestamped_migrations/1273253853_create_nodes.rb +0 -9
  322. data/spec/files/duplicate_timestamped_migrations/1273253853_create_users.rb +0 -4
  323. data/spec/files/empty_migration/001_create_sessions.rb +0 -9
  324. data/spec/files/empty_migration/002_create_nodes.rb +0 -0
  325. data/spec/files/empty_migration/003_3_create_users.rb +0 -4
  326. data/spec/files/integer_migrations/001_create_sessions.rb +0 -9
  327. data/spec/files/integer_migrations/002_create_nodes.rb +0 -9
  328. data/spec/files/integer_migrations/003_3_create_users.rb +0 -4
  329. data/spec/files/interleaved_timestamped_migrations/1273253849_create_sessions.rb +0 -9
  330. data/spec/files/interleaved_timestamped_migrations/1273253850_create_artists.rb +0 -9
  331. data/spec/files/interleaved_timestamped_migrations/1273253851_create_nodes.rb +0 -9
  332. data/spec/files/interleaved_timestamped_migrations/1273253852_create_albums.rb +0 -9
  333. data/spec/files/interleaved_timestamped_migrations/1273253853_3_create_users.rb +0 -4
  334. data/spec/files/missing_integer_migrations/001_create_alt_basic.rb +0 -4
  335. data/spec/files/missing_integer_migrations/003_create_alt_advanced.rb +0 -4
  336. data/spec/files/missing_timestamped_migrations/1273253849_create_sessions.rb +0 -9
  337. data/spec/files/missing_timestamped_migrations/1273253853_3_create_users.rb +0 -4
  338. data/spec/files/reversible_migrations/001_reversible.rb +0 -5
  339. data/spec/files/reversible_migrations/002_reversible.rb +0 -5
  340. data/spec/files/reversible_migrations/003_reversible.rb +0 -5
  341. data/spec/files/reversible_migrations/004_reversible.rb +0 -5
  342. data/spec/files/reversible_migrations/005_reversible.rb +0 -10
  343. data/spec/files/reversible_migrations/006_reversible.rb +0 -10
  344. data/spec/files/reversible_migrations/007_reversible.rb +0 -10
  345. data/spec/files/timestamped_migrations/1273253849_create_sessions.rb +0 -9
  346. data/spec/files/timestamped_migrations/1273253851_create_nodes.rb +0 -9
  347. data/spec/files/timestamped_migrations/1273253853_3_create_users.rb +0 -4
  348. data/spec/files/transaction_specified_migrations/001_create_alt_basic.rb +0 -4
  349. data/spec/files/transaction_specified_migrations/002_create_basic.rb +0 -4
  350. data/spec/files/transaction_unspecified_migrations/001_create_alt_basic.rb +0 -3
  351. data/spec/files/transaction_unspecified_migrations/002_create_basic.rb +0 -3
  352. data/spec/files/uppercase_timestamped_migrations/1273253849_CREATE_SESSIONS.RB +0 -9
  353. data/spec/files/uppercase_timestamped_migrations/1273253851_CREATE_NODES.RB +0 -9
  354. data/spec/files/uppercase_timestamped_migrations/1273253853_3_CREATE_USERS.RB +0 -4
  355. data/spec/guards_helper.rb +0 -59
  356. data/spec/integration/associations_test.rb +0 -2597
  357. data/spec/integration/database_test.rb +0 -113
  358. data/spec/integration/dataset_test.rb +0 -2037
  359. data/spec/integration/eager_loader_test.rb +0 -687
  360. data/spec/integration/migrator_test.rb +0 -262
  361. data/spec/integration/model_test.rb +0 -203
  362. data/spec/integration/plugin_test.rb +0 -2423
  363. data/spec/integration/prepared_statement_test.rb +0 -405
  364. data/spec/integration/schema_test.rb +0 -903
  365. data/spec/integration/spec_helper.rb +0 -71
  366. data/spec/integration/timezone_test.rb +0 -86
  367. data/spec/integration/transaction_test.rb +0 -603
  368. data/spec/integration/type_test.rb +0 -127
  369. data/spec/model/association_reflection_spec.rb +0 -803
  370. data/spec/model/associations_spec.rb +0 -4738
  371. data/spec/model/base_spec.rb +0 -875
  372. data/spec/model/class_dataset_methods_spec.rb +0 -146
  373. data/spec/model/dataset_methods_spec.rb +0 -198
  374. data/spec/model/eager_loading_spec.rb +0 -2377
  375. data/spec/model/hooks_spec.rb +0 -370
  376. data/spec/model/inflector_spec.rb +0 -26
  377. data/spec/model/model_spec.rb +0 -956
  378. data/spec/model/plugins_spec.rb +0 -429
  379. data/spec/model/record_spec.rb +0 -2118
  380. data/spec/model/spec_helper.rb +0 -46
  381. data/spec/model/validations_spec.rb +0 -220
  382. data/spec/model_no_assoc_spec.rb +0 -1
  383. data/spec/model_spec.rb +0 -1
  384. data/spec/plugin_spec.rb +0 -1
  385. data/spec/sequel_coverage.rb +0 -15
  386. data/spec/sequel_warning.rb +0 -5
  387. data/spec/spec_config.rb +0 -12
@@ -1,34 +0,0 @@
1
- = New Features
2
-
3
- * An mssql_optimistic_locking plugin has been added. This is similar
4
- to the regular optimistic_locking plugin, but instead of using an
5
- integer lock column, it uses a timestamp/rowversion lock column.
6
-
7
- * Database#create_table with the :temp=>true option on PostgreSQL now
8
- supports an :on_commit option. This option can be set to :drop or
9
- :delete_rows to either drop or empty the temporary table on
10
- transaction commit.
11
-
12
- = Other Improvements
13
-
14
- * Dataset#insert no longer errors on PostgreSQL if the related table
15
- is a placeholder literal string.
16
-
17
- * Unique constraints are now copied when emulating alter_table
18
- operations on SQLite.
19
-
20
- * Clob column values are no longer returned as SQL::Blob instances
21
- by the db2 and ibmdb adapters unless use_clob_as_blob is true.
22
-
23
- * SQL::Blob objects now work correctly as prepared statement
24
- arguments in the jdbc/db2 adapter if use_clob_as_blob is false.
25
-
26
- = Backwards Compatibility
27
-
28
- * The Model.primary_key array for models with composite keys is now
29
- frozen.
30
-
31
- * On DB2, use_clob_as_blob now defaults to false instead of true.
32
-
33
- * Sequel no longer uses RubyForge. The Sequel website is now located
34
- at http://sequel.jeremyevans.net.
@@ -1,30 +0,0 @@
1
- = New Features
2
-
3
- * Database#call_mssql_sproc is now available for calling
4
- stored procedures on Microsoft SQL Server, including the use
5
- of output parameters.
6
-
7
- * The Database#{commit,rollback}_prepared_transaction methods now
8
- support a :server option for the server on which to operate.
9
-
10
- = Other Improvements
11
-
12
- * On Microsoft SQL Server 2012, the native OFFSET/FETCH support
13
- is now used for offsets, instead of emulating support via the
14
- ROW_NUMBER window function.
15
-
16
- * Eager loading is now skipped when doing eager(...).naked.all on
17
- a model dataset, instead of raising an error. This can fix issues
18
- when the eager_each plugin is used.
19
-
20
- * A couple additional disconnection errors are now detected in the
21
- jdbc/postgresql adapter.
22
-
23
- * The tinytds adapter now handles returning rows when the fields
24
- are not immediately available.
25
-
26
- * RuntimeErrors raised by oci8 are now handled correctly in the
27
- oracle adapter.
28
-
29
- * Sequel's specs now work with RSpec 3, while still running
30
- correctly on RSpec 1.3 and 2.
@@ -1,103 +0,0 @@
1
- = New Features
2
-
3
- * Alternatives for the more complex virtual row method calls have
4
- been added:
5
-
6
- # Window Functions using SQL::Function#over
7
- # before: select{sum(:over, :args=>:col1, :partition=>:col2){}}
8
- select{sum(:col1).over(:partition=>:col2)}
9
-
10
- # count(*) using SQL::Function#*
11
- # before: select{count(:*){}}
12
- select{count{}.*}
13
-
14
- # count(distinct col) using SQL::Function#distinct
15
- # before: select{count(:distinct, :col){}}
16
- select{count(:col).distinct}
17
-
18
- Additionally, schema qualified functions are now supported via
19
- SQL::QualifiedIdentifier#function, and quoted functions are now
20
- supported via SQL::Identifier#function on some databases:
21
-
22
- # "func"("col")
23
- select{func.function(:col)}
24
-
25
- # "schema"."func"("col1")
26
- select{schema__func.function(:col1)}
27
-
28
- If the database does not support quoting function names, then
29
- Sequel will not quote them.
30
-
31
- * An update_or_create plugin has been added, for updating a matching
32
- object if one exists, or creating an object if it does not. For
33
- example, the following code will update the number of copies sold
34
- for album with the name 'Hello', or it will create an album with
35
- the name 'Hello' and 1000 number of copies sold:
36
-
37
- Album.plugin :update_or_create
38
- Album.update_or_create(:name=>'Hello') do |album|
39
- album.num_copies_sold = 1000
40
- end
41
-
42
- You can also use a shorter form of this, with two hashes:
43
-
44
- Album.update_or_create({:name=>'Hello'}, {:num_copies_sold=>1000})
45
-
46
- This plugin also adds a method named find_or_new, which does the
47
- same thing as update_or_create, except it doesn't persist any
48
- changes.
49
-
50
- * A :raise_on_save_failure option has been added for one_to_many,
51
- pg_array_to_many, and many_to_pg_array associations. This mirrors
52
- the Model.raise_on_save_failure setting, and if set to false, it
53
- will make the add/remove methods return nil instead of raising
54
- an error if there is a validation/hook error when saving the
55
- associated record.
56
-
57
- * The validates_unique validation in validation_helpers now supports a
58
- :dataset option to provide the base dataset to use to check
59
- uniqueness. This is useful when the model itself uses a filtered
60
- dataset, but the unique index in the database is on an unfiltered
61
- dataset.
62
-
63
- The auto_validations plugin uses this option to ensure that unique
64
- validations are setup correctly in subclasses using single table
65
- inheritance.
66
-
67
- = Other Improvements
68
-
69
- * Sequel now automatically rolls back transactions in killed threads
70
- on ruby 2.0+. It is still impossible to do so on ruby 1.9.
71
-
72
- * In the instance_hooks plugin, validation instance hooks are now
73
- not cleared until after a successful save.
74
-
75
- * Composite unique key constraint violations are now recognized
76
- and raised as Sequel::UniqueConstraintViolation on SQLite.
77
-
78
- * Primary key unique constraint violations are now recognized and
79
- and raised as Sequel::UniqueConstraintViolation on Microsoft
80
- SQL Server and SQLAnywhere.
81
-
82
- * If an exception occurs when using a cursor in the postgres adapter,
83
- and an exception also occurs when closing the cursor when cleaning
84
- up, the initial exception is now raised.
85
-
86
- * You can now get tables in a specific schema in the jdbc adapter
87
- using the :schema option to Database#tables. This was already
88
- supported in most jdbc subadapters because they implement #tables
89
- using database specific code instead of looking at the JDBC
90
- metadata, but it should now work for all jdbc subadapters.
91
-
92
- * Sequel::SQLTime#to_s is now defined and returns a string in
93
- HH:MM:SS format (leaving off the date).
94
-
95
- = Backwards Compatibility
96
-
97
- * The odbc adapter's :driver option is no longer deprecated, as reports
98
- were received that it still works.
99
-
100
- * If you were re-adding instance validation hooks using instance_hooks
101
- after a save failure, and then retrying the save, you may now end up
102
- with duplicate validations. You no longer need to re-add validation
103
- hooks unless the object was saved successfully.
@@ -1,175 +0,0 @@
1
- = New Features
2
-
3
- * A one_through_one association type has been added. This is similar
4
- to the many_to_many association type in that it uses a join table,
5
- but it returns a single record instead of an array of records.
6
- This is designed for cases where the foreign key in the join table
7
- that references the current table has a unique constraint, or where
8
- you want to use an order to just pick the first matching record.
9
-
10
- Similarly, the many_through_many plugin now also offers a
11
- one_through_many association.
12
-
13
- * An association_join method has been added to model datasets, for
14
- setting up joins based on associations. This basically does the
15
- same join that eager_graph would do, but does not make the other
16
- changes that eager_graph makes.
17
-
18
- Unlike eager_graph (which uses LEFT OUTER JOINs by default),
19
- association_join uses INNER JOINs, but there are also
20
- association_*_join methods (e.g. association_left_join) for
21
- using different join types.
22
-
23
- Similar to eager_graph, you can use cascading of associations or
24
- multiple associations.
25
-
26
- Album.association_join(:artist, :tracks)
27
- Artist.association_left_join(:albums=>:tracks)
28
-
29
- * Dataset#eager_graph_with_options has been added for model
30
- datasets. It currently supports a :join_type option, for
31
- overriding the type of join to use on a per-call basis, as well
32
- as a :limit_strategy option. The API is similar to eager_graph,
33
- except that the associations to eagerly load are passed in as
34
- a single argument, and it takes an options hash.
35
-
36
- The :limit_strategy option works similarly to the
37
- :eager_limit_strategy option when eagerly loading. If set to
38
- true and the database supports window functions, it will join
39
- the current dataset to a subquery that uses a window function
40
- to correctly restrict the join to only those objects that fall
41
- within the association's limit/offset.
42
-
43
- The :limit_strategy option is not on by default. It is possible
44
- for it to perform significantly worse than the default strategy
45
- (which uses array slicing in ruby). The :limit_strategy
46
- significantly changes the SQL used, and can change the results
47
- of the query if any filters/orders related to the association
48
- are used.
49
-
50
- It's recommended you only use the :limit_strategy option if you
51
- are experiencing a bottleneck and you have benchmarked that it
52
- is faster and still produces the desired results.
53
-
54
- Artist.eager_graph_with_options(:first_10_albums,
55
- :limit_strategy=>true)
56
- # SELECT artists.id, artists.name,
57
- # first_10_albums.id AS first_10_albums_id,
58
- # first_10_albums.name AS first_10_albums_name,
59
- # first_10_albums.artist_id,
60
- # first_10_albums.release_date
61
- # FROM artists
62
- # LEFT OUTER JOIN (
63
- # SELECT id, name, artist_id, release_date
64
- # FROM (
65
- # SELECT *, row_number() OVER (PARTITION BY tracks.album_id)
66
- # AS x_sequel_row_number_x
67
- # FROM albums
68
- # ) AS t1 WHERE (x_sequel_row_number_x <= 10)
69
- # ) AS first_10_albums ON (first_10_albums.artist_id = artists.id)
70
-
71
- * Dataset#full_text_search on PostgreSQL now supports :plain and
72
- :phrase options. :plain takes the search terms as a single
73
- string, and searches for rows where all terms are used.
74
- :phrase is similar to :plain, but also adds a substring search
75
- to ensure that the string given appears verbatim in the text.
76
-
77
- * A :graph_order association option has been added, for using a
78
- different order when using eager_graph. This is mostly
79
- designed for cases where :order should be qualified in other
80
- cases, but using a qualification breaks eager_graph because the
81
- correct qualifier is not known until runtime.
82
-
83
- * SQL::AliasedExpression#alias has been added as an alias for #aliaz.
84
-
85
- = Other Improvements
86
-
87
- * Sequel will now automatically use an eager limit strategy for
88
- *_one associations that use an :order option. For associations
89
- that are truly one-to-one, an :order option is not needed, so it
90
- only makes sense to have an :order option if the association
91
- could theoretically return multiple results (in which case an
92
- eager limit strategy is helpful).
93
-
94
- * The queries that Sequel uses to filter by associations when
95
- those associations have conditions are now simpler and easier
96
- for the database to execute.
97
-
98
- * The queries that Sequel uses for dataset associations now handle
99
- cases where unqualified identifiers were used in the receiving
100
- dataset that would be made ambiguous by a join.
101
-
102
- * A limit strategy is now used when filtering by associations if
103
- the association has a limit and the database supports window
104
- functions. This allows Sequel to setup a correct filter in
105
- such cases.
106
-
107
- Artist.where(:first_10_albums=>Album[1]).all
108
- # SELECT *
109
- # FROM artists
110
- # WHERE (artists.id IN (
111
- # SELECT albums.artist_id
112
- # FROM albums
113
- # WHERE ((albums.artist_id IS NOT NULL) AND (albums.id IN (
114
- # SELECT id FROM (
115
- # SELECT albums.id, row_number() OVER
116
- # (PARTITION BY albums.artist_id ORDER BY release_date)
117
- # AS x_sequel_row_number_x
118
- # FROM albums
119
- # ) AS t1
120
- # WHERE (x_sequel_row_number_x <= 10)
121
- # )) AND (albums.id = 1))))
122
-
123
- * A limit strategy is now used in the dataset_associations plugin
124
- if the association has a limit and the database supports window
125
- functions. This makes the resulting datasets return correct
126
- results.
127
-
128
- Artist.first_10_albums
129
- # SELECT *
130
- # FROM albums
131
- # WHERE ((albums.artist_id IN (
132
- # SELECT artists.id FROM artists)
133
- # ) AND (albums.id IN (
134
- # SELECT id FROM (
135
- # SELECT albums.id, row_number() OVER
136
- # (PARTITION BY albums.artist_id ORDER BY release_date)
137
- # AS x_sequel_row_number_x
138
- # FROM albums
139
- # ) AS t1
140
- # WHERE (x_sequel_row_number_x <= 10)
141
- # )))
142
- # ORDER BY release_date
143
-
144
- * You can now pass symbols with embedded qualifiers or aliases,
145
- as well as SQL::Identifier, SQL::QualifiedIdentifier, and
146
- SQL::AliasedExpression objects as the first argument to
147
- Dataset#graph.
148
-
149
- * The nested_attributes plugin now automatically handles presence
150
- validations on foreign keys when creating associated objects.
151
- It now sets the foreign key value (or a placeholder value)
152
- before validating such objects.
153
-
154
- * Offsets on *_one associations are now respected when using
155
- eager_graph.
156
-
157
- * eager graphing *_many associations with offsets no longer breaks
158
- if there are no associated results.
159
-
160
- * Database#register_array_type in the pg_array extension now works
161
- correctly if there is no existing scalar conversion proc for
162
- the type.
163
-
164
- * Unique, foreign key, and not null constraint violations are now
165
- recognized correctly on SQLite 3.8.2+.
166
-
167
- * The odbc adapter now returns fractional seconds in timestamps.
168
-
169
- * The obdc/mssql adapter now inputs timestamps with 3 decimal
170
- places.
171
-
172
- = Backwards Compatibility
173
-
174
- * The private Model.apply_window_function_eager_limit_strategy
175
- method has been removed.
@@ -1,190 +0,0 @@
1
- = Performance Enhancements
2
-
3
- * Dataset::PlaceholderLiteralizer has been added as an optimization
4
- framework. This allows you to record changes to a given dataset
5
- using placeholder arguments, and later quickly execute the query
6
- providing values for the placeholders. This is similar in idea
7
- to prepared statements, except that the SQL for each query can
8
- change depending on the values for the placeholders.
9
-
10
- Using this optimization framework, generating the SQL for query
11
- is about 3x faster, and since SQL generation time is a significant
12
- portion of total time for simple queries, simple queries can
13
- execute up to 50% faster.
14
-
15
- There are two APIs for this optimization framework. There is a
16
- lower level dataset API:
17
-
18
- loader = Sequel::Dataset::PlaceholderLiteralizer.
19
- loader(DB[:items]) do |pl, ds|
20
- ds.where(:id=>pl.arg).exclude(:name=>pl.arg).limit(1)
21
- end
22
-
23
- loader.first(1, "foo")
24
- # SELECT * FROM items WHERE ((id = 1) AND (name != 'foo')) LIMIT 1
25
-
26
- loader.first([1, 2], %w"foo bar")
27
- # SELECT * FROM items WHERE ((id IN (1, 2)) AND
28
- # (name NOT IN ('foo', 'bar'))) LIMIT 1
29
-
30
- There is also a higher level model API (Model.finder):
31
-
32
- class Item < Sequel::Model
33
- # Given class method that returns a dataset
34
- def self.by_id_and_not_name(id, not_name)
35
- where(:id=>id).exclude(:name=>not_name)
36
- end
37
-
38
- # Create optimized method that returns first value
39
- finder :by_id_and_not_name
40
- end
41
-
42
- # Call optimized method
43
- Album.first_by_id_and_not_name(1, 'foo')
44
- # SELECT * FROM items WHERE ((id = 1) AND (name != 'foo')) LIMIT 1
45
-
46
- Model.finder defaults to creating a method that returns the first
47
- matching row, but using the :type option you can create methods
48
- that call each, all, or get. There is also an option to choose the
49
- method name (:name), as well as one to specify the number of
50
- arguments to use if the method doesn't take a fixed number
51
- (:arity).
52
-
53
- Finally, Model.find, .first, and .first! now automatically use an
54
- optimized finder if given a single argument. Model.[] uses an
55
- optimized finder if given a single hash, and Model.[], .with_pk,
56
- and .with_pk! use an optimized finder if the model has a composite
57
- primary key. In all of these cases, these methods are about 50%
58
- faster than before.
59
-
60
- * The pure-ruby PostgreSQL array parser that ships with Sequel has
61
- been replaced with a strscan-based parser. This parser avoids
62
- O(n^2) performance for arrays with multibyte strings, and in general
63
- is much faster. Parsing an array with a single string with 100,000
64
- multibyte characters is about 1000x faster, and now about half the
65
- speed of the C implementation in sequel_pg.
66
-
67
- * Dataset#paged_each now has a :strategy=>:filter option that
68
- dramatically improves performance, especially if the columns
69
- being ordered by are indexed.
70
-
71
- Unfortunately, there are enough corner cases to this approach
72
- that it cannot be used by default. At the least, the dataset
73
- needs to be selecting the columns it is ordering by, not aliasing
74
- the columns it is ordering by in the SELECT clause, not have
75
- NULLs in any of the columns being ordered by, and not itself use
76
- a limit or offset.
77
-
78
- If you are ordering by expressions that are not simple column
79
- values, you can provide a :filter_value option proc that takes the
80
- last retrieved row and array of order by expressions, and returns
81
- an array of values in the last retrieved row for those order by
82
- expressions.
83
-
84
- * In the postgres adapter, Dataset#paged_each now automatically uses
85
- a cursor for improved performance.
86
-
87
- * In the mysql2 adapter, Dataset#paged_each now automatically uses
88
- streaming for improved performance, if streaming is supported.
89
-
90
- * Dataset#with_sql_{each,all,first,single_value,insert,update}
91
- have been added. These methods take specific SQL and execute
92
- it on the database, returning the appropriate value. They
93
- are significantly faster than the previous approach of
94
- with_sql(SQL).{each,all,first,single_value,insert,update},
95
- as they don't require cloning the dataset.
96
-
97
- = New Features
98
-
99
- * Database#create_join_table! and #create_join_table? have been added,
100
- for consistency with #create_table! and #create_table?.
101
-
102
- * A :hold option has been added to Dataset#use_cursor in the postgres
103
- adapter, which uses WITH HOLD in the query, allowing for usage of
104
- the cursor outside the enclosing transaction. When :hold is used,
105
- Sequel does not automatically use a transaction around the cursor
106
- call.
107
-
108
- * Dataset#where_current_of has been added to the postgres adapter,
109
- for updating rows based on a cursor's current position. This can
110
- be used to update a large dataset where new values depend on
111
- some ruby method, without keeping all rows in memory.
112
-
113
- ds = DB[:huge_table]
114
- ds.use_cursor(:rows_per_fetch=>1).each do |row|
115
- ds.where_current_of.update(:column=>ruby_method(row))
116
- end
117
-
118
- * A current_datetime_timestamp extension has been added, for
119
- creating Time/DateTime instances that are literalized as
120
- CURRENT_TIMESTAMP. When the dataset uses this extension, models
121
- that use the touch and timestamps plugins will use
122
- CURRENT_TIMESTAMP for the timestamps.
123
-
124
- * The jdbc adapter now supports a :driver option, useful when
125
- Sequel doesn't have direct support for the underlying driver, and
126
- where java.sql.DriverManager.getConnection does not work
127
- correctly due to Java class loading issues.
128
-
129
- = Other Improvements
130
-
131
- * Multiple corner cases in Dataset#eager_graph have been fixed.
132
-
133
- * Calling Dataset#columns when using the eager_each plugin no
134
- longer triggers eager loading.
135
-
136
- * Database#column_schema_to_ruby_default is now a public method
137
- in the schema_dumper extension.
138
-
139
- * When validating associated objects for one_to_many and one_to_one
140
- associations in the nested_attributes plugin, don't remove column
141
- values if the association's foreign key is the associated model's
142
- primary key.
143
-
144
- * On PostgreSQL, Dataset#disable_insert_returning has been added
145
- back. This disables the automatic use of RETURNING for INSERTs
146
- for the dataset. This is necessary in cases where INSERT
147
- RETURNING doesn't work, such as PostgreSQL <8.2 (or PostgreSQL
148
- variants that forked before 8.2), or when using partitioning
149
- with trigger functions, or conditional rules.
150
-
151
- Note that if you use disable_insert_returning, insert will not
152
- return the autoincremented primary key. You need to call
153
- currval or lastval manually using the same connection to get
154
- the value, or use nextval to get the value to use before
155
- inserting.
156
-
157
- * The pg_array extension now uses the correct database type when
158
- typecasting values for smallint, oid, real, character, and varchar
159
- arrays. Previously, Sequel did not use the correct database type
160
- in some cases (e.g. text[] for a varchar[]), which resulted in
161
- errors if the value was used in a filter expression.
162
-
163
- * Additional unique constraint violations are now recognized on
164
- SQLite.
165
-
166
- * Check constraint violations are now recognized on SQLite >=3.8.2.
167
-
168
- * Adapters that emulate bitwise operators now do so using an append
169
- only design, similar to how all other queries are built in Sequel.
170
-
171
- = Backwards Compatibility
172
-
173
- * In some cases Sequel no longer adds superfluous parentheses when
174
- constructing SQL strings. If you are testing for specific SQL,
175
- this can cause test failures.
176
-
177
- * The pg_array extension no longer recognizes the :typecast_method
178
- option when registering an array type. The option allowed reuse
179
- of an existing typecast method, but as that results in an incorrect
180
- type at the database level, the option was fundementally broken.
181
-
182
- * The internals of the PostgreSQL array parser have changed. If you
183
- were relying on them, you'll need to update your code.
184
-
185
- * Dataset#complex_expression_arg_pairs private method now returns
186
- nested expression objects instead of an already literalized string
187
- in some cases. Custom adapters that call this method will probably
188
- need to be changed. It's recommended that such adapters switch to
189
- using the new Dataset#complex_expression_emulate_append method if
190
- possible.