sequel 5.22.0 → 5.27.0

data/spec/adapters/sqlite_spec.rb

@@ -623,7 +623,7 @@ describe "SQLite", 'INSERT ON CONFLICT' do
     @ds.insert_conflict(:target=>:a).insert(1, 3, 4, false)
     @ds.insert_conflict(:target=>:c, :conflict_where=>:c_is_unique).insert(11, 12, 3, true)
     @ds.all.must_equal [{:a=>1, :b=>2, :c=>3, :c_is_unique=>false}, {:a=>10, :b=>11, :c=>3, :c_is_unique=>true}]
-  end
+  end unless DB.adapter_scheme == :amalgalite
 
   it "Dataset#insert_ignore and insert_conflict should work with multi_insert/import" do
     @ds.insert(1, 2, 3, false)

data/spec/bin_spec.rb

@@ -25,7 +25,7 @@ DB2 = Sequel.connect("#{CONN_PREFIX}#{BIN_SPEC_DB2}", :test=>false)
 
 ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
 gem 'minitest'
-require 'minitest/autorun'
+require 'minitest/global_expectations/autorun'
 
 describe "bin/sequel" do
   def bin(opts={})
@@ -86,7 +86,7 @@ Begin creating indexes
 Finished creating indexes
 Begin adding foreign key constraints
 Finished adding foreign key constraints
-Database copy finished in \\d\\.\\d+ seconds
+Database copy finished in \\d+\\.\\d+ seconds
 END
     DB2.tables.sort_by{|t| t.to_s}.must_equal [:a, :b]
     DB[:a].all.must_equal [{:a=>1, :name=>'foo'}]

data/spec/core/database_spec.rb

@@ -264,6 +264,25 @@ describe "Database#log_connection_yield" do
     @o.logs.first.first.must_equal :info
     @o.logs.first.last.must_match(/\A\(\d\.\d{6}s\) blah; \[1, 2\]\z/)
   end
+
+  it "should log without a logger defined by forcing skip_logging? to return false" do
+    @db.logger = nil
+    @db.extend(Module.new do
+      def skip_logging?
+        false
+      end
+
+      def log_duration(*)
+        self.did_log = true
+      end
+
+      attr_accessor :did_log
+    end)
+
+    @db.log_connection_yield('some sql', @conn) {}
+
+    @db.did_log.must_equal true
+  end
 end
 
 describe "Database#uri" do
@@ -2073,6 +2092,18 @@ describe "Database#typecast_value" do
     proc{@db.typecast_value(:datetime, 4)}.must_raise(Sequel::InvalidValue)
   end
 
+  it "should raise an InvalidValue when given an invalid timezone value" do
+    begin
+      Sequel.default_timezone = :blah
+      proc{@db.typecast_value(:datetime, [2019, 2, 3, 4, 5, 6])}.must_raise(Sequel::InvalidValue)
+      Sequel.datetime_class = DateTime
+      proc{@db.typecast_value(:datetime, [2019, 2, 3, 4, 5, 6])}.must_raise(Sequel::InvalidValue)
+    ensure
+      Sequel.default_timezone = nil
+      Sequel.datetime_class = Time
+    end
+  end
+
   it "should handle integers with leading 0 as base 10" do
     @db.typecast_value(:integer, "013").must_equal 13
     @db.typecast_value(:integer, "08").must_equal 8
@@ -2317,6 +2348,17 @@ describe "Database#typecast_value" do
       @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14).must_equal Time.local(2011, 10, 11, 12, 13, 14)
       @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'nanos'=>500000000).must_equal Time.local(2011, 10, 11, 12, 13, 14, 500000)
 
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :offset=>Rational(1, 2)).must_equal Time.new(2011, 10, 11, 12, 13, 14, 43200)
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :nanos=>500000000, :offset=>Rational(1, 2)).must_equal Time.new(2011, 10, 11, 12, 13, 14.5, 43200)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'offset'=>Rational(1, 2)).must_equal Time.new(2011, 10, 11, 12, 13, 14, 43200)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'nanos'=>500000000, 'offset'=>Rational(1, 2)).must_equal Time.new(2011, 10, 11, 12, 13, 14.5, 43200)
+
+      Sequel.default_timezone = :utc
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14).must_equal Time.utc(2011, 10, 11, 12, 13, 14)
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :nanos=>500000000).must_equal Time.utc(2011, 10, 11, 12, 13, 14, 500000)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14).must_equal Time.utc(2011, 10, 11, 12, 13, 14)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'nanos'=>500000000).must_equal Time.utc(2011, 10, 11, 12, 13, 14, 500000)
+
       Sequel.datetime_class = DateTime
       @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14).must_equal DateTime.civil(2011, 10, 11, 12, 13, 14)
       @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :nanos=>500000000).must_equal DateTime.civil(2011, 10, 11, 12, 13, Rational(29, 2))
@@ -2326,8 +2368,16 @@ describe "Database#typecast_value" do
       @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :nanos=>500000000, :offset=>Rational(1, 2)).must_equal DateTime.civil(2011, 10, 11, 12, 13, Rational(29, 2), Rational(1, 2))
       @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'offset'=>Rational(1, 2)).must_equal DateTime.civil(2011, 10, 11, 12, 13, 14, Rational(1, 2))
       @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'nanos'=>500000000, 'offset'=>Rational(1, 2)).must_equal DateTime.civil(2011, 10, 11, 12, 13, Rational(29, 2), Rational(1, 2))
+
+      Sequel.default_timezone = :local
+      offset = Rational(Time.local(2011, 10, 11, 12, 13, 14).utc_offset, 86400)
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14).must_equal DateTime.civil(2011, 10, 11, 12, 13, 14, offset)
+      @db.typecast_value(:datetime, :year=>2011, :month=>10, :day=>11, :hour=>12, :minute=>13, :second=>14, :nanos=>500000000).must_equal DateTime.civil(2011, 10, 11, 12, 13, Rational(29, 2), offset)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14).must_equal DateTime.civil(2011, 10, 11, 12, 13, 14, offset)
+      @db.typecast_value(:datetime, 'year'=>2011, 'month'=>10, 'day'=>11, 'hour'=>12, 'minute'=>13, 'second'=>14, 'nanos'=>500000000).must_equal DateTime.civil(2011, 10, 11, 12, 13, Rational(29, 2), offset)
     ensure
       Sequel.datetime_class = Time
+      Sequel.default_timezone = nil
     end
   end
 

data/spec/core/dataset_spec.rb

@@ -3725,7 +3725,7 @@ end
 
 describe "Dataset default #fetch_rows, #insert, #update, #delete, #truncate, #execute" do
   before do
-    @db = Sequel.mock(:servers=>{:read_only=>{}}, :autoid=>1)
+    @db = Sequel.mock(:servers=>{:read_only=>{}, :r1=>{}}, :autoid=>1)
     @ds = @db[:items]
   end
 
@@ -3763,6 +3763,18 @@ describe "Dataset default #fetch_rows, #insert, #update, #delete, #truncate, #ex
     @ds.for_update.send(:execute, 'SELECT 1')
     @db.sqls.must_equal ["SELECT 1"]
   end
+  
+  [:execute, :execute_dui, :execute_insert, :execute_ddl].each do |meth|
+    it "##{meth} should respect explicit :server option" do
+      @ds.send(meth, 'SELECT 1', :server=>:r1)
+      @db.sqls.must_equal ["SELECT 1 -- r1"]
+    end
+    
+    it "##{meth} should respect dataset's :server option if :server option not given" do
+      @ds.server(:r1).send(meth, 'SELECT 1')
+      @db.sqls.must_equal ["SELECT 1 -- r1"]
+    end
+  end
 end
 
 describe "Dataset#with_sql_*" do
@@ -4493,6 +4505,16 @@ describe "Sequel timezone support" do
     proc{Sequel.database_to_application_timestamp(Object.new)}.must_raise(Sequel::InvalidValue)
   end
 
+  it "should raise an InvalidValue error when the Time class is used and when a bad application timezone is used when attempting to convert timestamps" do
+    Sequel.application_timezone = :blah
+    proc{Sequel.database_to_application_timestamp('2009-06-01 10:20:30')}.must_raise(Sequel::InvalidValue)
+  end
+  
+  it "should raise an InvalidValue error when the Time class is used and when a bad database timezone is used when attempting to convert timestamps" do
+    Sequel.database_timezone = :blah
+    proc{Sequel.database_to_application_timestamp('2009-06-01 10:20:30')}.must_raise(Sequel::InvalidValue)
+  end
+
   it "should raise an InvalidValue error when the DateTime class is used and when a bad application timezone is used when attempting to convert timestamps" do
     Sequel.application_timezone = :blah
     Sequel.datetime_class = DateTime

data/spec/core/expression_filters_spec.rb

@@ -214,8 +214,13 @@ describe "Blockless Ruby Filters" do
     @d.lit(1 + Sequel.lit('?', :x)).must_equal '(1 + x)'
   end
 
-  it "should raise a NoMethodError if coerce is called with a non-Numeric" do
-    proc{Sequel.expr(:x).coerce(:a)}.must_raise NoMethodError
+  it "should not break Date/DateTime equality" do
+    (Date.today == Sequel.expr(:x)).must_equal false
+    (DateTime.now == Sequel.expr(:x)).must_equal false
+  end
+
+  it "should have coerce return array if called on a non-numeric" do
+    Sequel.expr(:x).coerce(:a).must_equal [Sequel.expr(:x), :a]
   end
 
   it "should support AND conditions via &" do
@@ -348,6 +353,11 @@ describe "Blockless Ruby Filters" do
     @d.l({:x => Sequel::FALSE}).must_equal '(x IS FALSE)'
     @d.l({:x => Sequel::SQLTRUE}).must_equal '(x IS TRUE)'
     @d.l({:x => Sequel::SQLFALSE}).must_equal '(x IS FALSE)'
+
+    @d.l({:x => Sequel::CURRENT_DATE}).must_equal '(x = CURRENT_DATE)'
+    @d.l({:x => Sequel::CURRENT_TIME}).must_equal '(x = CURRENT_TIME)'
+    @d.l({:x => Sequel::CURRENT_TIMESTAMP}).must_equal '(x = CURRENT_TIMESTAMP)'
+    @d.l({:x => Sequel::DEFAULT}).must_equal '(x = DEFAULT)'
   end
   
   it "should support negation of SQL::Constants" do
@@ -736,14 +746,23 @@ describe Sequel::SQL::VirtualRow do
     @d.l{mode.function.within_group(:a, :b)}.must_equal 'mode() WITHIN GROUP (ORDER BY "a", "b")' 
   end
 
+  it "should handle emualted filtered aggregate function calls" do
+    @d.l{count.function.*.filter(Sequel.&(:a, :b))}.must_equal 'count((CASE WHEN ("a" AND "b") THEN 1 ELSE NULL END))' 
+    @d.l{count.function.*.filter(:a=>1)}.must_equal 'count((CASE WHEN ("a" = 1) THEN 1 ELSE NULL END))'
+    @d.l{count(:a).filter{b > 1}}.must_equal 'count((CASE WHEN ("b" > 1) THEN "a" ELSE NULL END))'
+    @d.l{count(:a).filter(:a=>1){b > 1}}.must_equal 'count((CASE WHEN (("a" = 1) AND ("b" > 1)) THEN "a" ELSE NULL END))'
+  end
+
   it "should handle filtered aggregate function calls" do
+    @d = @d.with_extend{def supports_filtered_aggregates?; true end}
     @d.l{count.function.*.filter(Sequel.&(:a, :b))}.must_equal 'count(*) FILTER (WHERE ("a" AND "b"))' 
     @d.l{count.function.*.filter(:a=>1)}.must_equal 'count(*) FILTER (WHERE ("a" = 1))'
     @d.l{count.function.*.filter{b > 1}}.must_equal 'count(*) FILTER (WHERE ("b" > 1))'
     @d.l{count.function.*.filter(:a=>1){b > 1}}.must_equal 'count(*) FILTER (WHERE (("a" = 1) AND ("b" > 1)))'
   end
 
-  it "should handle fitlered ordered-set and hypothetical-set function calls" do
+  it "should handle filtered ordered-set and hypothetical-set function calls" do
+    @d = @d.with_extend{def supports_filtered_aggregates?; true end}
     @d.l{mode.function.within_group(:a).filter(:a=>1)}.must_equal 'mode() WITHIN GROUP (ORDER BY "a") FILTER (WHERE ("a" = 1))' 
   end
 

data/spec/core/schema_spec.rb

@@ -240,6 +240,24 @@ describe "DB#create_table" do
     @db.sqls.must_equal ["CREATE TABLE cats (id integer, name text, UNIQUE (name) DEFERRABLE INITIALLY IMMEDIATE)"]
   end
   
+  it "should handle deferred unique column constraints" do
+    @db.create_table(:cats) do
+      integer :id, :unique=>true, :unique_deferrable=>true
+      integer :i, :unique=>true, :unique_deferrable=>:immediate
+      integer :j, :unique=>true, :unique_deferrable=>false
+    end
+    @db.sqls.must_equal ["CREATE TABLE cats (id integer UNIQUE DEFERRABLE INITIALLY DEFERRED, i integer UNIQUE DEFERRABLE INITIALLY IMMEDIATE, j integer UNIQUE NOT DEFERRABLE)"]
+  end
+  
+  it "should handle deferred primary key column constraints" do
+    @db.create_table(:cats) do
+      integer :id, :primary_key=>true, :primary_key_deferrable=>true
+      integer :i, :primary_key=>true, :primary_key_deferrable=>:immediate
+      integer :j, :primary_key=>true, :primary_key_deferrable=>false
+    end
+    @db.sqls.must_equal ["CREATE TABLE cats (id integer PRIMARY KEY DEFERRABLE INITIALLY DEFERRED, i integer PRIMARY KEY DEFERRABLE INITIALLY IMMEDIATE, j integer PRIMARY KEY NOT DEFERRABLE)"]
+  end
+  
   it "should accept unsigned definition" do
     @db.create_table(:cats) do
       integer :value, :unsigned => true

data/spec/core/spec_helper.rb

@@ -10,7 +10,7 @@ require_relative "../../lib/sequel/core"
 
 ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
 gem 'minitest'
-require 'minitest/autorun'
+require 'minitest/global_expectations/autorun'
 require 'minitest/hooks/default'
 require 'minitest/shared_description'
 

data/spec/core_extensions_spec.rb

@@ -16,7 +16,7 @@ Sequel.extension :virtual_row_method_block
 
 ENV['MT_NO_PLUGINS'] = '1' # Work around stupid autoloading of plugins
 gem 'minitest'
-require 'minitest/autorun'
+require 'minitest/global_expectations/autorun'
 require 'minitest/hooks/default'
 
 require_relative "deprecation_helper.rb"

data/spec/extensions/association_multi_add_remove_spec.rb

@@ -0,0 +1,1041 @@
+require_relative "spec_helper"
+
+describe "association_multi_add_remove plugin - one_to_many" do
+  before do
+    @c1 = Class.new(Sequel::Model(:attributes)) do
+      unrestrict_primary_key
+      columns :id, :node_id, :y, :z
+    end
+
+    @c2 = Class.new(Sequel::Model(:nodes)) do
+      plugin :association_multi_add_remove
+
+      def _refresh(ds); end
+      unrestrict_primary_key
+      attr_accessor :xxx
+
+      def self.name; 'Node'; end
+      def self.to_s; 'Node'; end
+
+      columns :id, :x
+    end
+    @dataset = @c2.dataset = @c2.dataset.with_fetch({})
+    @c1.dataset = @c1.dataset.with_fetch(proc { |sql| sql =~ /SELECT 1/ ? { a: 1 } : {} })
+    DB.reset
+  end
+
+  it "should define an add_*s method that works on existing records" do
+    @c2.one_to_many :attributes, class: @c1
+
+    n = @c2.load(id: 1234)
+    a1 = @c1.load(id: 2345)
+    a2 = @c1.load(id: 3456)
+    [a1, a2].must_equal n.add_attributes([a1, a2])
+    a1.values.must_equal(:node_id => 1234, id: 2345)
+    a2.values.must_equal(:node_id => 1234, id: 3456)
+    DB.sqls.must_equal [
+      'BEGIN',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 2345)',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 3456)',
+      'COMMIT'
+    ]
+  end
+
+  it "should not define add/remove methods with the same name as the ones defined by default " do
+    @c2.one_to_many :sheep, class: @c1, :key=>:node_id
+
+    n = @c2.load(id: 1234)
+    a1 = @c1.load(id: 2345)
+    a1.must_be_same_as n.add_sheep(a1)
+    a1.values.must_equal(:node_id => 1234, id: 2345)
+    DB.sqls.must_equal ['UPDATE attributes SET node_id = 1234 WHERE (id = 2345)']
+    a1.must_be_same_as n.remove_sheep(a1)
+    a1.values.must_equal(:node_id => nil, id: 2345)
+    DB.sqls.must_equal [
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 2345)) LIMIT 1",
+      'UPDATE attributes SET node_id = NULL WHERE (id = 2345)',
+    ]
+    n.respond_to?(:sheep=).must_equal false
+  end
+
+  it "should support :multi_add_method" do
+    @c2.one_to_many :attributes, class: @c1, :multi_add_method=>:add_multiple_attributes
+
+    n = @c2.load(id: 1234)
+    a1 = @c1.load(id: 2345)
+    a2 = @c1.load(id: 3456)
+    [a1, a2].must_equal n.add_multiple_attributes([a1, a2])
+    a1.values.must_equal(:node_id => 1234, id: 2345)
+    a2.values.must_equal(:node_id => 1234, id: 3456)
+    DB.sqls.must_equal [
+      'BEGIN',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 2345)',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 3456)',
+      'COMMIT'
+    ]
+  end
+
+  it "should define an add_*s method that works on new records" do
+    @c2.one_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 1234)
+    a1 = @c1.new(:id => 234)
+    a2 = @c1.new(:id => 345)
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :id=>234, :node_id=>1234 }], [{ :id=>345, :node_id=>1234 }]
+    ])
+    [a1, a2].must_equal n.add_attributes([a1, a2])
+    DB.sqls.must_equal [
+      'BEGIN',
+      "INSERT INTO attributes (id, node_id) VALUES (234, 1234)",
+      "SELECT * FROM attributes WHERE id = 234",
+      "INSERT INTO attributes (id, node_id) VALUES (345, 1234)",
+      "SELECT * FROM attributes WHERE id = 345",
+      'COMMIT'
+    ]
+    a1.values.must_equal(:node_id => 1234, :id => 234)
+    a2.values.must_equal(:node_id => 1234, :id => 345)
+  end
+
+  it "should define a remove_*s method that works on existing records" do
+    @c2.one_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 1234)
+    a1 = @c1.load(:id => 2345, :node_id => 1234)
+    a2 = @c1.load(:id => 3456, :node_id => 1234)
+    [a1, a2].must_equal n.remove_attributes([a1, a2])
+    a1.values.must_equal(:node_id => nil, :id => 2345)
+    a2.values.must_equal(:node_id => nil, :id => 3456)
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 2345)) LIMIT 1",
+      'UPDATE attributes SET node_id = NULL WHERE (id = 2345)',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 3456)) LIMIT 1",
+      'UPDATE attributes SET node_id = NULL WHERE (id = 3456)',
+      'COMMIT'
+    ]
+  end
+
+  it "should support :multi_remove_method" do
+    @c2.one_to_many :attributes, :class => @c1, :multi_remove_method=>:remove_multiple_attributes
+
+    n = @c2.load(:id => 1234)
+    a1 = @c1.load(:id => 2345, :node_id => 1234)
+    a2 = @c1.load(:id => 3456, :node_id => 1234)
+    [a1, a2].must_equal n.remove_multiple_attributes([a1, a2])
+    a1.values.must_equal(:node_id => nil, :id => 2345)
+    a2.values.must_equal(:node_id => nil, :id => 3456)
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 2345)) LIMIT 1",
+      'UPDATE attributes SET node_id = NULL WHERE (id = 2345)',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 3456)) LIMIT 1",
+      'UPDATE attributes SET node_id = NULL WHERE (id = 3456)',
+      'COMMIT'
+    ]
+  end
+
+  it "should have the remove_*s method raise an error if the passed objects are not already associated" do
+    @c2.one_to_many :attributes, :class => @c1
+
+    n = @c2.new(:id => 1234)
+    a1 = @c1.load(:id => 2345, :node_id => 1234)
+    a2 = @c1.load(:id => 3456, :node_id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([])
+    proc{n.remove_attributes([a1, a2])}.must_raise(Sequel::Error)
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 2345)) LIMIT 1",
+      'ROLLBACK'
+    ]
+  end
+
+  it "should accept hashes for the add_*s method and create a new records" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    DB.reset
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :node_id => 1234, :id => 234 }], [{ :node_id => 1234, :id => 345 }]
+    ])
+    n.add_attributes([{ :id => 234 }, { :id => 345 }]).must_equal [
+      @c1.load(:node_id => 1234, :id => 234),
+      @c1.load(:node_id => 1234, :id => 345)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "INSERT INTO attributes (id, node_id) VALUES (234, 1234)",
+      "SELECT * FROM attributes WHERE id = 234",
+      "INSERT INTO attributes (id, node_id) VALUES (345, 1234)",
+      "SELECT * FROM attributes WHERE id = 345",
+      'COMMIT'
+    ]
+  end
+
+  it "should accept primary keys for the add_*s method" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :node_id => nil, :id => 234 }], [{ :node_id => nil, :id => 345 }]
+    ])
+    n.add_attributes([234, 345]).must_equal [
+      @c1.load(:node_id => 1234, :id => 234),
+      @c1.load(:node_id => 1234, :id => 345)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE id = 234",
+      "UPDATE attributes SET node_id = 1234 WHERE (id = 234)",
+      "SELECT * FROM attributes WHERE id = 345",
+      "UPDATE attributes SET node_id = 1234 WHERE (id = 345)",
+      'COMMIT'
+    ]
+  end
+
+  it "should raise an error if the primary key passed to the add_*s method does not match an existing record" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([])
+    proc{n.add_attributes([234, 345])}.must_raise(Sequel::NoMatchingRow)
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE id = 234",
+      'ROLLBACK'
+    ]
+  end
+
+  it "should raise an error in the add_*s method if the passed associated objects are not of the correct type" do
+    @c2.one_to_many :attributes, :class => @c1
+    proc{@c2.new(:id => 1234).add_attributes([@c2.new, @c2.new])}.must_raise(Sequel::Error)
+  end
+
+  it "should accept primary keys for the remove_*s method and remove existing records" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :id=>234, :node_id=>1234 }], [{ :id=>345, :node_id=>1234 }]
+    ])
+    n.remove_attributes([234, 345]).must_equal [
+      @c1.load(:node_id => nil, :id => 234),
+      @c1.load(:node_id => nil, :id => 345)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'SELECT * FROM attributes WHERE ((attributes.node_id = 1234) AND (attributes.id = 234)) LIMIT 1',
+      'UPDATE attributes SET node_id = NULL WHERE (id = 234)',
+      'SELECT * FROM attributes WHERE ((attributes.node_id = 1234) AND (attributes.id = 345)) LIMIT 1',
+      'UPDATE attributes SET node_id = NULL WHERE (id = 345)',
+      'COMMIT'
+    ]
+  end
+
+  it "should raise an error in the remove_*s method if the passed associated objects are not of the correct type" do
+    @c2.one_to_many :attributes, :class => @c1
+    proc{@c2.new(:id => 1234).remove_attributes([@c2.new, @c2.new])}.must_raise(Sequel::Error)
+  end
+
+  it "should have add_*s method respect the :primary_key option" do
+    @c2.one_to_many :attributes, :class => @c1, :primary_key=>:xxx
+
+    n = @c2.new(:id => 1234, :xxx=>5)
+    a1 = @c1.load(:id => 2345)
+    a2 = @c1.load(:id => 3456)
+    n.add_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'UPDATE attributes SET node_id = 5 WHERE (id = 2345)',
+      'UPDATE attributes SET node_id = 5 WHERE (id = 3456)',
+      'COMMIT'
+    ]
+  end
+
+  it "should have add_*s method not add the same objects to the cached association array if the objects are already in the array" do
+    @c2.one_to_many :attributes, :class => @c1
+
+    n = @c2.new(:id => 1234)
+    a1 = @c1.load(:id => 2345)
+    a2 = @c1.load(:id => 3456)
+    n.associations[:attributes] = []
+    [a1, a2].must_equal n.add_attributes([a1, a2])
+    [a1, a2].must_equal n.add_attributes([a1, a2])
+    a1.values.must_equal(:node_id => 1234, :id => 2345)
+    a2.values.must_equal(:node_id => 1234, :id => 3456)
+    n.attributes.must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 2345)',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 3456)',
+      'COMMIT'
+    ] * 2
+  end
+
+  it "should have add_*s method respect composite keys" do
+    @c2.one_to_many :attributes, :class => @c1, :key =>[:node_id, :y], :primary_key=>[:id, :x]
+
+    n = @c2.load(:id => 1234, :x=>5)
+    a1 = @c1.load(:id => 2345)
+    a2 = @c1.load(:id => 3456)
+    n.add_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "UPDATE attributes SET node_id = 1234, y = 5 WHERE (id = 2345)",
+      "UPDATE attributes SET node_id = 1234, y = 5 WHERE (id = 3456)",
+      'COMMIT'
+    ]
+  end
+
+  it "should have add_*s method accept composite keys" do
+    @c1.dataset = @c1.dataset.with_fetch([
+       [{ :id=>2345, :node_id=>1234, :z=>8, :y=>5 }],
+       [{ :id=>3456, :node_id=>1234, :z=>9, :y=>5 }]
+    ])
+    @c1.set_primary_key [:id, :z]
+    @c2.one_to_many :attributes, :class => @c1, :key =>[:node_id, :y], :primary_key=>[:id, :x]
+
+    n = @c2.load(:id => 1234, :x=>5)
+    a1 = @c1.load(:id => 2345, :z => 8, :node_id => 1234, :y=>5)
+    a2 = @c1.load(:id => 3456, :z => 9, :node_id => 1234, :y=>5)
+    n.add_attributes([[2345, 8], [3456, 9]]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE ((id = 2345) AND (z = 8)) LIMIT 1",
+      "UPDATE attributes SET node_id = 1234, y = 5 WHERE ((id = 2345) AND (z = 8))",
+      "SELECT * FROM attributes WHERE ((id = 3456) AND (z = 9)) LIMIT 1",
+      "UPDATE attributes SET node_id = 1234, y = 5 WHERE ((id = 3456) AND (z = 9))",
+      'COMMIT'
+    ]
+  end
+
+  it "should have remove_*s method respect composite keys" do
+    @c2.one_to_many :attributes, :class => @c1, :key =>[:node_id, :y], :primary_key=>[:id, :x]
+    
+    n = @c2.load(:id => 1234, :x=>5)
+    a1 = @c1.load(:id => 2345, :node_id=>1234, :y=>5)
+    a2 = @c1.load(:id => 3456, :node_id=>1234, :y=>5)
+    n.remove_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (attributes.y = 5) AND (id = 2345)) LIMIT 1",
+      "UPDATE attributes SET node_id = NULL, y = NULL WHERE (id = 2345)",
+      "SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (attributes.y = 5) AND (id = 3456)) LIMIT 1",
+      "UPDATE attributes SET node_id = NULL, y = NULL WHERE (id = 3456)",
+      'COMMIT'
+    ]
+  end
+
+  it "should accept a array of composite primary keys values for the remove_*s method and remove existing records" do
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :id=>234, :node_id=>123, :y=>5 }], [{ :id=>345, :node_id=>123, :y=>6 }]
+    ])
+    @c1.set_primary_key [:id, :y]
+    @c2.one_to_many :attributes, :class => @c1, :key=>:node_id, :primary_key=>:id
+    n = @c2.new(:id => 123)
+    n.remove_attributes([[234, 5], [345, 6]]).must_equal [
+      @c1.load(:node_id => nil, :y => 5, :id => 234),
+      @c1.load(:node_id => nil, :y => 6, :id => 345)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE ((attributes.node_id = 123) AND (attributes.id = 234) AND (attributes.y = 5)) LIMIT 1",
+      "UPDATE attributes SET node_id = NULL WHERE ((id = 234) AND (y = 5))",
+      "SELECT * FROM attributes WHERE ((attributes.node_id = 123) AND (attributes.id = 345) AND (attributes.y = 6)) LIMIT 1",
+      "UPDATE attributes SET node_id = NULL WHERE ((id = 345) AND (y = 6))",
+      'COMMIT'
+    ]
+  end
+
+  it "should raise an error in add_*s and remove_*s if the passed objects return false to save (are not valid)" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    a1 = @c1.new(:id => 2345)
+    a2 = @c1.new(:id => 3456)
+    def a1.validate() errors.add(:id, 'foo') end
+    def a2.validate() errors.add(:id, 'bar') end
+    proc{n.add_attributes([a1, a2])}.must_raise(Sequel::ValidationFailed)
+    proc{n.remove_attributes([a1, a2])}.must_raise(Sequel::ValidationFailed)
+  end
+
+  it "should not validate the associated objects in add_*s and remove_*s if the :validate=>false option is used" do
+    @c2.one_to_many :attributes, :class => @c1, :validate=>false
+    n = @c2.new(:id => 1234)
+    a1 = @c1.new(:id => 2345)
+    a2 = @c1.new(:id => 3456)
+    def a1.validate() errors.add(:id, 'foo') end
+    def a2.validate() errors.add(:id, 'bar') end
+    n.add_attributes([a1, a2]).must_equal [a1, a2]
+    n.remove_attributes([a1, a2]).must_equal [a1, a2]
+  end
+
+  it "should not raise exception in add_*s and remove_*s if the :raise_on_save_failure=>false option is used" do
+    @c2.one_to_many :attributes, :class => @c1, :raise_on_save_failure=>false
+    n = @c2.new(:id => 1234)
+    a1 = @c1.new(:id => 2345)
+    a2 = @c1.new(:id => 3456)
+    def a1.validate() errors.add(:id, 'foo') end
+    def a2.validate() errors.add(:id, 'bar') end
+    n.associations[:attributes] = []
+    n.add_attributes([a1, a2]).must_equal []
+    n.associations[:attributes].must_equal []
+    n.remove_attributes([a1, a2]).must_equal []
+    n.associations[:attributes].must_equal []
+  end
+
+  it "should add item to cache if it exists when calling add_*s" do
+    @c2.one_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 123)
+    a1 = @c1.load(:id => 234)
+    a2 = @c1.load(:id => 345)
+    arr = []
+    n.associations[:attributes] = arr
+    n.add_attributes([a1, a2])
+    arr.must_equal [a1, a2]
+  end
+
+  it "should set object to item's reciprocal cache when calling add_*s" do
+    @c2.one_to_many :attributes, :class => @c1
+    @c1.many_to_one :node, :class => @c2
+
+    n = @c2.new(:id => 123)
+    a1 = @c1.new(:id => 234)
+    a2 = @c1.new(:id => 345)
+    n.add_attributes([a1, a2])
+    a1.node.must_equal n
+    a2.node.must_equal n
+  end
+
+  it "should remove item from cache if it exists when calling remove_*s" do
+    @c2.one_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 123)
+    a1 = @c1.load(:id => 234)
+    a2 = @c1.load(:id => 345)
+    arr = [a1, a2]
+    n.associations[:attributes] = arr
+    n.remove_attributes([a1, a2])
+    arr.must_equal []
+  end
+
+  it "should remove item's reciprocal cache calling remove_*s" do
+    @c2.one_to_many :attributes, :class => @c1
+    @c1.many_to_one :node, :class => @c2
+
+    n = @c2.new(:id => 123)
+    a1 = @c1.new(:id => 234)
+    a2 = @c1.new(:id => 345)
+    a1.associations[:node] = n
+    a2.associations[:node] = n
+    a1.node.must_equal n
+    a2.node.must_equal n
+    n.remove_attributes([a1, a2])
+    a1.node.must_be_nil
+    a2.node.must_be_nil
+  end
+
+  it "should not create the add_*s or remove_*s methods if :read_only option is used" do
+    @c2.one_to_many :attributes, :class => @c1, :read_only=>true
+    im = @c2.instance_methods
+    im.wont_include(:add_attributes)
+    im.wont_include(:remove_attributes)
+  end
+
+  it "should not add associations methods directly to class" do
+    @c2.one_to_many :attributes, :class => @c1
+    im = @c2.instance_methods
+    im.must_include(:add_attributes)
+    im.must_include(:remove_attributes)
+    im2 = @c2.instance_methods(false)
+    im2.wont_include(:add_attributes)
+    im2.wont_include(:remove_attributes)
+  end
+
+  it "should call an _add_ method internally to add attributes" do
+    @c2.one_to_many :attributes, :class => @c1
+    @c2.private_instance_methods.must_include(:_add_attribute)
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._add_attribute(x)
+      (@x ||= []) << x
+    end
+    def c1._node_id=; raise; end
+    def c2._node_id=; raise; end
+    p.add_attributes([c1, c2])
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+  end
+
+  it "should allow additional arguments given to the add_*s method and pass them onwards to the _add_ method" do
+    @c2.one_to_many :attributes, :class => @c1
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._add_attribute(x,*y)
+      (@x ||= []) << x
+      (@y ||= []) << y
+    end
+    def c1._node_id=; raise; end
+    def c2._node_id=; raise; end
+    p.add_attributes([c1, c2], :foo, :bar=>:baz)
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+    p.instance_variable_get(:@y).must_equal [
+      [:foo,{:bar=>:baz}], [:foo,{:bar=>:baz}]
+    ]
+  end
+
+  it "should call a _remove_ method internally to remove attributes" do
+    @c2.one_to_many :attributes, :class => @c1
+    @c2.private_instance_methods.must_include(:_remove_attribute)
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._remove_attribute(x)
+      (@x ||= []) << x
+    end
+    def c1._node_id=; raise; end
+    def c2._node_id=; raise; end
+    p.remove_attributes([c1, c2])
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+  end
+
+  it "should allow additional arguments given to the remove_*s method and pass them onwards to the _remove_ method" do
+    @c2.one_to_many :attributes, :class => @c1, :reciprocal=>nil
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._remove_attribute(x,*y)
+      (@x ||= []) << x
+      (@y ||= []) << y
+    end
+    def c1._node_id=; raise; end
+    def c2._node_id=; raise; end
+    p.remove_attributes([c1, c2], :foo, :bar=>:baz)
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+    p.instance_variable_get(:@y).must_equal [
+      [:foo,{:bar=>:baz}], [:foo,{:bar=>:baz}]
+    ]
+  end
+
+  it "should support (before|after)_(add|remove) callbacks for (add|remove)_*s methods" do
+    h = []
+    @c2.one_to_many :attributes, :class => @c1, :before_add=>[proc{|x,y| h << x.pk; h << -y.pk}, :blah], :after_add=>proc{h << 3}, :before_remove=>:blah, :after_remove=>[:blahr]
+    @c2.class_eval do
+      self::Foo = h
+      def _add_attribute(v)
+        model::Foo << 4
+      end
+      def _remove_attribute(v)
+        model::Foo << 5
+      end
+      def blah(x)
+        model::Foo << x.pk
+      end
+      def blahr(x)
+        model::Foo << 6
+      end
+    end
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    h.must_equal []
+    p.add_attributes([c1, c2])
+    h.must_equal [
+      10, -123, 123, 4, 3,
+      10, -234, 234, 4, 3
+    ]
+    p.remove_attributes([c1, c2])
+    h.must_equal [
+      10, -123, 123, 4, 3,
+      10, -234, 234, 4, 3,
+      123, 5, 6,
+      234, 5, 6
+    ]
+  end
+
+  it "should raise error and not call internal add_*s or remove_*s method if before callback calls cancel_action if raise_on_save_failure is true" do
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    @c2.one_to_many :attributes, :class => @c1, :before_add=>:ba, :before_remove=>:br
+    def p.ba(o); cancel_action; end
+    def p._add_attribute; raise; end
+    def p._remove_attribute; raise; end
+    p.associations[:attributes] = []
+    proc{p.add_attributes([c1, c2])}.must_raise(Sequel::HookFailed)
+    p.attributes.must_equal []
+    p.associations[:attributes] = [c1, c2]
+    def p.br(o); cancel_action; end
+    proc{p.remove_attributes([c1, c2])}.must_raise(Sequel::HookFailed)
+    p.attributes.must_equal [c1, c2]
+  end
+
+  it "should return nil and not call internal add_*s or remove_*s method if before callback calls cancel_action if raise_on_save_failure is false" do
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    p.raise_on_save_failure = false
+    @c2.one_to_many :attributes, :class => @c1, :before_add=>:ba, :before_remove=>:br
+    def p.ba(o); cancel_action; end
+    def p._add_attribute; raise; end
+    def p._remove_attribute; raise; end
+    p.associations[:attributes] = []
+    p.add_attributes([c1, c2]).must_equal []
+    p.attributes.must_equal []
+    p.associations[:attributes] = [c1, c2]
+    def p.br(o); cancel_action; end
+    p.remove_attributes([c1, c2]).must_equal []
+    p.attributes.must_equal [c1, c2]
+  end
+
+  it "should define a setter that works on existing records" do
+    @c2.one_to_many :attributes, class: @c1
+  
+    n = @c2.load(id: 1234)
+    a1 = @c1.load(id: 2345, node_id: 1234)
+    a2 = @c1.load(id: 3456, node_id: 1234)
+    a3 = @c1.load(id: 4567)
+
+    n.associations[:attributes] = [a1, a2]
+
+    [a2, a3].must_equal(n.attributes = [a2, a3])
+    a1.values.must_equal(node_id: nil, id: 2345)
+    a2.values.must_equal(node_id: 1234, id: 3456)
+    a3.values.must_equal(node_id: 1234, id: 4567)
+    DB.sqls.must_equal [
+      'BEGIN',
+      'SELECT 1 AS one FROM attributes WHERE ((attributes.node_id = 1234) AND (id = 2345)) LIMIT 1',
+      'UPDATE attributes SET node_id = NULL WHERE (id = 2345)',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 4567)',
+      'COMMIT'
+    ]
+  end
+end
+
+describe "association_multi_add_remove plugin - many_to_many" do
+  before do
+    @c1 = Class.new(Sequel::Model(:attributes)) do
+      unrestrict_primary_key
+      attr_accessor :yyy
+      def self.name; 'Attribute'; end
+      def self.to_s; 'Attribute'; end
+      columns :id, :y, :z
+    end
+
+    @c2 = Class.new(Sequel::Model(:nodes)) do
+      unrestrict_primary_key
+
+      plugin :association_multi_add_remove
+
+      attr_accessor :xxx
+
+      def self.name; 'Node'; end
+      def self.to_s; 'Node'; end
+      columns :id, :x
+    end
+    @dataset = @c2.dataset
+    @c1.dataset = @c1.dataset.with_autoid(1)
+
+    [@c1, @c2].each{|c| c.dataset = c.dataset.with_fetch({})}
+    DB.reset
+  end
+
+  it "should define an add_*s method that works on existing records" do
+    @c2.many_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 1234)
+    a1 = @c1.load(:id => 2345)
+    a2 = @c1.load(:id => 3456)
+    n.add_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 2345)",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 3456)",
+      'COMMIT'
+    ]
+  end
+
+  it "should define an add_*s method that works with a primary key" do
+    @c2.many_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 1234)
+    a1 = @c1.load(:id => 2345)
+    a2 = @c1.load(:id => 3456)
+    @c1.dataset = @c1.dataset.with_fetch([[{ :id=>2345 }], [{ :id=>3456 }]])
+    n.add_attributes([2345, 3456]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE id = 2345",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 2345)",
+      "SELECT * FROM attributes WHERE id = 3456",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 3456)",
+      'COMMIT'
+    ]
+  end
+
+  it "should allow passing hashes to the add_*s method which creates new records" do
+    @c2.many_to_many :attributes, :class => @c1
+
+    n = @c2.load(:id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([[{ :id=>1 }], [{ :id=>2 }]])
+    n.add_attributes([{ :id => 1 }, { :id => 2 }]).must_equal [
+      @c1.load(:id => 1), @c1.load(:id => 2)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'INSERT INTO attributes (id) VALUES (1)',
+      "SELECT * FROM attributes WHERE id = 1",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 1)",
+      'INSERT INTO attributes (id) VALUES (2)',
+      "SELECT * FROM attributes WHERE id = 2",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 2)",
+      'COMMIT'
+    ]
+  end
+
+  it "should define a remove_*s method that works on existing records" do
+    @c2.many_to_many :attributes, :class => @c1
+
+    n = @c2.new(:id => 1234)
+    a1 = @c1.new(:id => 2345)
+    a2 = @c1.new(:id => 3456)
+    n.remove_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 2345))',
+      'DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 3456))',
+      'COMMIT'
+    ]
+  end
+
+  it "should accept primary keys for the remove_*s method and remove existing records" do
+    @c2.many_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    @c1.dataset = @c1.dataset.with_fetch([[{ :id=>234 }], [{ :id=>345 }]])
+    n.remove_attributes([234, 345]).must_equal [
+      @c1.load(:id => 234), @c1.load(:id => 345)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT attributes.* FROM attributes INNER JOIN attributes_nodes ON (attributes_nodes.attribute_id = attributes.id) WHERE ((attributes_nodes.node_id = 1234) AND (attributes.id = 234)) LIMIT 1",
+      "DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 234))",
+      "SELECT attributes.* FROM attributes INNER JOIN attributes_nodes ON (attributes_nodes.attribute_id = attributes.id) WHERE ((attributes_nodes.node_id = 1234) AND (attributes.id = 345)) LIMIT 1",
+      "DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 345))",
+      'COMMIT'
+    ]
+  end
+
+  it "should have the add_*s method respect the :left_primary_key and :right_primary_key options" do
+    @c2.many_to_many :attributes, :class => @c1, :left_primary_key=>:xxx, :right_primary_key=>:yyy
+
+    n = @c2.load(:id => 1234).set(:xxx=>5)
+    a1 = @c1.load(:id => 2345).set(:yyy=>8)
+    a2 = @c1.load(:id => 3456).set(:yyy=>9)
+    n.add_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (5, 8)",
+      "INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (5, 9)",
+      'COMMIT'
+    ]
+  end
+
+  it "should have the add_*s method respect composite keys" do
+    @c2.many_to_many :attributes, :class => @c1, :left_key=>[:l1, :l2], :right_key=>[:r1, :r2], :left_primary_key=>[:id, :x], :right_primary_key=>[:id, :z]
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :id=>2345, :z=>8 }], [{ :id=>3456, :z=>9 }]
+    ])
+    @c1.set_primary_key [:id, :z]
+    n = @c2.load(:id => 1234, :x=>5)
+    a1 = @c1.load(:id => 2345, :z=>8)
+    a2 = @c1.load(:id => 3456, :z=>9)
+    n.add_attributes([[2345, 8], [3456, 9]]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT * FROM attributes WHERE ((id = 2345) AND (z = 8)) LIMIT 1",
+      "INSERT INTO attributes_nodes (l1, l2, r1, r2) VALUES (1234, 5, 2345, 8)",
+      "SELECT * FROM attributes WHERE ((id = 3456) AND (z = 9)) LIMIT 1",
+      "INSERT INTO attributes_nodes (l1, l2, r1, r2) VALUES (1234, 5, 3456, 9)",
+      'COMMIT'
+    ]
+  end
+
+  it "should have the remove_*s method respect the :left_primary_key and :right_primary_key options" do
+    @c2.many_to_many :attributes, :class => @c1, :left_primary_key=>:xxx, :right_primary_key=>:yyy
+
+    n = @c2.new(:id => 1234, :xxx=>5)
+    a1 = @c1.new(:id => 2345, :yyy=>8)
+    a2 = @c1.new(:id => 3456, :yyy=>9)
+    n.remove_attributes([a1, a2]).must_equal [a1, a2]
+    DB.sqls.must_equal [
+      'BEGIN',
+      'DELETE FROM attributes_nodes WHERE ((node_id = 5) AND (attribute_id = 8))',
+      'DELETE FROM attributes_nodes WHERE ((node_id = 5) AND (attribute_id = 9))',
+      'COMMIT'
+    ]
+  end
+
+  it "should have the remove_*s method respect composite keys" do
+    @c2.many_to_many :attributes, :class => @c1, :left_key=>[:l1, :l2], :right_key=>[:r1, :r2], :left_primary_key=>[:id, :x], :right_primary_key=>[:id, :z]
+    n = @c2.load(:id => 1234, :x=>5)
+    a1 = @c1.load(:id => 2345, :z=>8)
+    a2 = @c1.load(:id => 3456, :z=>9)
+    [a1, a2].must_equal n.remove_attributes([a1, a2])
+    DB.sqls.must_equal [
+      'BEGIN',
+      "DELETE FROM attributes_nodes WHERE ((l1 = 1234) AND (l2 = 5) AND (r1 = 2345) AND (r2 = 8))",
+      "DELETE FROM attributes_nodes WHERE ((l1 = 1234) AND (l2 = 5) AND (r1 = 3456) AND (r2 = 9))",
+      'COMMIT'
+    ]
+  end
+
+  it "should accept an array of arrays of composite primary key values for the remove_*s method and remove existing records" do
+    @c1.dataset = @c1.dataset.with_fetch([
+      [{ :id=>234, :y=>8 }], [{ :id=>345, :y=>9 }]
+    ])
+    @c1.set_primary_key [:id, :y]
+    @c2.many_to_many :attributes, :class => @c1
+    n = @c2.new(:id => 1234)
+    n.remove_attributes([[234, 8], [345, 9]]).must_equal [
+      @c1.load(:id => 234, :y=>8), @c1.load(:id => 345, :y=>9)
+    ]
+    DB.sqls.must_equal [
+      'BEGIN',
+      "SELECT attributes.* FROM attributes INNER JOIN attributes_nodes ON (attributes_nodes.attribute_id = attributes.id) WHERE ((attributes_nodes.node_id = 1234) AND (attributes.id = 234) AND (attributes.y = 8)) LIMIT 1",
+      "DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 234))",
+      "SELECT attributes.* FROM attributes INNER JOIN attributes_nodes ON (attributes_nodes.attribute_id = attributes.id) WHERE ((attributes_nodes.node_id = 1234) AND (attributes.id = 345) AND (attributes.y = 9)) LIMIT 1",
+      "DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 345))",
+      'COMMIT'
+    ]
+  end
+
+  it "should raise an error if trying to remove model objects that don't have valid primary keys" do
+    @c2.many_to_many :attributes, :class => @c1
+    n = @c2.new
+    a1 = @c1.load(:id=>123)
+    a2 = @c1.load(:id=>234)
+    proc { n.remove_attributes([a1, a2]) }.must_raise(Sequel::Error)
+  end
+
+  it "should remove items from cache if they exist when calling remove_*s" do
+    @c2.many_to_many :attributes, :class => @c1
+
+    n = @c2.new(:id => 1234)
+    a1 = @c1.load(:id => 345)
+    a2 = @c1.load(:id => 456)
+    arr = [a1, a2]
+    n.associations[:attributes] = arr
+    n.remove_attributes([a1, a2])
+    arr.must_equal []
+  end
+
+  it "should remove items from reciprocal's if they exist when calling remove_*s" do
+    @c2.many_to_many :attributes, :class => @c1
+    @c1.many_to_many :nodes, :class => @c2
+
+    n = @c2.new(:id => 1234)
+    a1 = @c1.new(:id => 345)
+    a2 = @c1.new(:id => 456)
+    a1.associations[:nodes] = [n]
+    a2.associations[:nodes] = [n]
+    n.remove_attributes([a1, a2])
+    a1.nodes.must_equal []
+    a2.nodes.must_equal []
+  end
+
+  it "should not create the add_*s or remove_*s methods if :read_only option is used" do
+    @c2.many_to_many :attributes, :class => @c1, :read_only=>true
+    im = @c2.instance_methods
+    im.wont_include(:add_attributes)
+    im.wont_include(:remove_attributes)
+  end
+
+  it "should not add associations methods directly to class" do
+    @c2.many_to_many :attributes, :class => @c1
+    im = @c2.instance_methods
+    im.must_include(:add_attributes)
+    im.must_include(:remove_attributes)
+    im2 = @c2.instance_methods(false)
+    im2.wont_include(:add_attributes)
+    im2.wont_include(:remove_attributes)
+  end
+
+  it "should call a _remove_*s method internally to remove attributes" do
+    @c2.many_to_many :attributes, :class => @c1
+    @c2.private_instance_methods.must_include(:_remove_attribute)
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._remove_attribute(x)
+      (@x ||= []) << x
+    end
+    p.remove_attributes([c1, c2])
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+    DB.sqls.must_equal ['BEGIN', 'COMMIT']
+  end
+
+  it "should support a :remover option for defining the _remove_*s method" do
+    @c2.many_to_many :attributes, :class => @c1,
+      :remover=>proc { |x| (@x ||= []) << x }
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    p.remove_attributes([c1, c2])
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+    DB.sqls.must_equal ['BEGIN', 'COMMIT']
+  end
+
+  it "should allow additional arguments given to the remove_*s method and pass them onwards to the _remove_ method" do
+    @c2.many_to_many :attributes, :class => @c1
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    def p._remove_attribute(x,*y)
+      (@x ||= []) << x
+      (@y ||= []) << y
+    end
+    p.remove_attributes([c1, c2], :foo, :bar=>:baz)
+    p.instance_variable_get(:@x).must_equal [c1, c2]
+    p.instance_variable_get(:@y).must_equal [
+      [:foo, { :bar=>:baz }], [:foo, { :bar=>:baz }]
+    ]
+  end
+
+  it "should raise an error in the remove_*s method if the passed associated objects are not of the correct type" do
+    @c2.many_to_many :attributes, :class => @c1
+    proc do
+      @c2.new(:id => 1234).remove_attributes([@c2.new, @c2.new])
+    end
+      .must_raise(Sequel::Error)
+  end
+
+  it "should support (before|after)_(add|remove) callbacks for (add|remove)_* methods" do
+    h = []
+    @c2.many_to_many :attributes, :class => @c1, :before_add=>[proc{|x,y| h << x.pk; h << -y.pk}, :blah], :after_add=>proc{h << 3}, :before_remove=>:blah, :after_remove=>[:blahr]
+    @c2.class_eval do
+      self::Foo = h
+      def _add_attribute(v)
+        model::Foo << 4
+      end
+      def _remove_attribute(v)
+        model::Foo << 5
+      end
+      def blah(x)
+        model::Foo << x.pk
+      end
+      def blahr(x)
+        model::Foo << 6
+      end
+    end
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    h.must_equal []
+    p.add_attributes([c1, c2])
+    h.must_equal [
+      10, -123, 123, 4, 3,
+      10, -234, 234, 4, 3
+    ]
+    p.remove_attributes([c1, c2])
+    h.must_equal [
+      10, -123, 123, 4, 3,
+      10, -234, 234, 4, 3,
+      123, 5, 6,
+      234, 5, 6
+    ]
+  end
+
+  it "should raise error and not call internal add_*s or remove_*s method if before callback calls cancel_action if raise_on_save_failure is true" do
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    @c2.many_to_many :attributes, :class => @c1, :before_add=>:ba, :before_remove=>:br
+    def p.ba(o) cancel_action end
+    def p._add_attribute; raise; end
+    def p._remove_attribute; raise; end
+    p.associations[:attributes] = []
+    p.raise_on_save_failure = true
+    proc{p.add_attributes([c1, c2])}.must_raise(Sequel::HookFailed)
+    p.attributes.must_equal []
+    p.associations[:attributes] = [c1, c2]
+    def p.br(o) cancel_action end
+    proc { p.remove_attributes([c1, c2]) }.must_raise(Sequel::HookFailed)
+    p.attributes.must_equal [c1, c2]
+  end
+
+  it "should return nil and not call internal add_*s or remove_*s method if before callback calls cancel_action if raise_on_save_failure is false" do
+    p = @c2.load(:id=>10)
+    c1 = @c1.load(:id=>123)
+    c2 = @c1.load(:id=>234)
+    p.raise_on_save_failure = false
+    @c2.many_to_many :attributes, :class => @c1, :before_add=>:ba, :before_remove=>:br
+    def p.ba(o) cancel_action end
+    def p._add_attribute; raise; end
+    def p._remove_attribute; raise; end
+    p.associations[:attributes] = []
+    p.add_attributes([c1, c2]).must_equal []
+    p.attributes.must_equal []
+    p.associations[:attributes] = [c1, c2]
+    def p.br(o) cancel_action end
+    p.remove_attributes([c1, c2]).must_equal []
+    p.attributes.must_equal [c1, c2]
+  end
+
+  it "should define a setter that works on existing records" do
+    @c2.many_to_many :attributes, class: @c1
+
+    n = @c2.load(id: 1234)
+    a1 = @c1.load(id: 2345)
+    a2 = @c1.load(id: 3456)
+    a3 = @c1.load(id: 4567)
+
+    n.associations[:attributes] = [a1, a2]
+
+    [a2, a3].must_equal(n.attributes = [a2, a3])
+    DB.sqls.must_equal [
+      'BEGIN',
+      'DELETE FROM attributes_nodes WHERE ((node_id = 1234) AND (attribute_id = 2345))',
+      'INSERT INTO attributes_nodes (node_id, attribute_id) VALUES (1234, 4567)',
+      'COMMIT'
+    ]
+  end
+end
+
+describe "association_multi_add_remove plugin - sharding" do
+  before do
+    @db = Sequel.mock(:servers=>{:a=>{}}, :numrows=>1)
+    @c1 = Class.new(Sequel::Model(@db[:attributes])) do
+      unrestrict_primary_key
+      columns :id, :node_id, :y, :z
+    end
+
+    @c2 = Class.new(Sequel::Model(@db[:nodes])) do
+      plugin :association_multi_add_remove
+
+      def _refresh(ds); end
+      unrestrict_primary_key
+      attr_accessor :xxx
+
+      def self.name; 'Node'; end
+      def self.to_s; 'Node'; end
+
+      columns :id, :x
+    end
+    @dataset = @c2.dataset = @c2.dataset.with_fetch({})
+    @c1.dataset = @c1.dataset.with_fetch(proc { |sql| sql =~ /SELECT 1/ ? { a: 1 } : {} })
+    @db.sqls
+  end
+
+  it "should handle servers correctly" do
+    @c2.one_to_many :attributes, class: @c1
+
+    n = @c2.load(id: 1234).set_server(:a)
+    a1 = @c1.load(id: 2345).set_server(:a)
+    a2 = @c1.load(id: 3456).set_server(:a)
+    [a1, a2].must_equal n.add_attributes([a1, a2])
+    a1.values.must_equal(:node_id => 1234, id: 2345)
+    a2.values.must_equal(:node_id => 1234, id: 3456)
+    @db.sqls.must_equal [
+      'BEGIN -- a',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 2345) -- a',
+      'UPDATE attributes SET node_id = 1234 WHERE (id = 3456) -- a',
+      'COMMIT -- a'
+    ]
+  end
+end