sequel 5.107.0 → 5.109.0

data/lib/sequel/database/transactions.rb

@@ -50,7 +50,7 @@ module Sequel
     # Options:
     # :savepoint :: If currently inside a savepoint, run this hook immediately when
     #               any enclosing savepoint is rolled back, which may be before the transaction
-    #               commits or rollsback.
+    #               commits or rolls back.
     # :server :: The server/shard to use.
     def after_rollback(opts=OPTS, &block)
       raise Error, "must provide block to after_rollback" unless block
@@ -69,7 +69,7 @@ module Sequel
     # When exiting the transaction block through methods other than an exception
     # (e.g. normal exit, non-local return, or throw), set the current transaction
     # to rollback instead of committing.  This is designed for use in cases where
-    # you want to preform a non-local return but also want to rollback instead of
+    # you want to perform a non-local return but also want to rollback instead of
     # committing.
     # Options:
     # :cancel :: Cancel the current rollback_on_exit setting, so exiting will commit instead
@@ -246,7 +246,7 @@ module Sequel
     # Internal generic transaction method.  Any exception raised by the given
     # block will cause the transaction to be rolled back.  If the exception is
     # not a Sequel::Rollback, the error will be reraised. If no exception occurs
-    # inside the block, the transaction is commited.
+    # inside the block, the transaction is committed.
     def _transaction(conn, opts=OPTS)
       rollback = opts[:rollback]
       begin
@@ -374,9 +374,7 @@ module Sequel
 
     # Whether to commit the current transaction. Thread.current.status is
     # checked because Thread#kill skips rescue blocks (so exception would be
-    # nil), but the transaction should still be rolled back. On Ruby 1.9 (but
-    # not 2.0+), the thread status will still be "run", so Thread#kill
-    # will erroneously commit the transaction, and there isn't a workaround.
+    # nil), but the transaction should still be rolled back.
     def commit_or_rollback_transaction(exception, conn, opts)
       if exception
         false
@@ -538,7 +536,7 @@ module Sequel
     end
 
     # Finish a subtransaction.  If savepoints are supported, pops the current
-    # tansaction off the savepoint stack.
+    # transaction off the savepoint stack.
     def transaction_finished?(conn)
       if supports_savepoints?
         stack = _trans(conn)[:savepoints]

data/lib/sequel/dataset/actions.rb

@@ -242,7 +242,7 @@ module Sequel
         end
       when 1
         arg = args[0]
-        if arg.is_a?(Integer)
+        if arg.is_a?(Integer) && arg >= 0
           res = if block
             if loader = cached_placeholder_literalizer(:_first_integer_cond_loader) do |pl|
                 where(pl.arg).limit(pl.arg)
@@ -1343,7 +1343,7 @@ module Sequel
       Sequel.|(*cond)
     end
 
-    # Downcase identifiers by default when outputing them from the database.
+    # Downcase identifiers by default when outputting them from the database.
     def output_identifier(v)
       v = 'untitled' if v == ''
       v.to_s.downcase.to_sym

data/lib/sequel/dataset/features.rb

@@ -25,7 +25,7 @@ module Sequel
       false
     end
 
-    # :nocov:
+    # simplecov:disable
 
     # Whether the dataset requires SQL standard datetimes. False by default,
     # as most allow strings with ISO 8601 format. Only for backwards compatibility,
@@ -34,7 +34,7 @@ module Sequel
       # SEQUEL6: Remove
       false
     end
-    # :nocov:
+    # simplecov:enable
 
     # Whether type specifiers are required for prepared statement/bound
     # variable argument placeholders (i.e. :bv__integer), false by default.
@@ -188,14 +188,14 @@ module Sequel
       true
     end
 
-    # :nocov:
+    # simplecov:disable
 
     # Whether the dataset supports timezones in literal timestamps, false by default.
     def supports_timestamp_timezones?
       # SEQUEL6: Remove
       false
     end
-    # :nocov:
+    # simplecov:enable
     
     # Whether the dataset supports fractional seconds in literal timestamps, true by default.
     def supports_timestamp_usecs?

data/lib/sequel/dataset/graph.rb

@@ -165,7 +165,7 @@ module Sequel
               # columns in the subselect, qualified by the subselect alias.
               Sequel.qualify(qualifier, Sequel.identifier(column))
             else
-              # Initial dataset not wrapped in subslect, just make
+              # Initial dataset not wrapped in subselect, just make
               # sure columns are qualified in some way.
               qualified_expression(sel, qualifier)
             end

data/lib/sequel/dataset/misc.rb

@@ -76,7 +76,7 @@ module Sequel
         super
       end
     else
-      # :nocov:
+      # simplecov:disable
       def freeze # :nodoc:
         self
       end
@@ -84,7 +84,7 @@ module Sequel
       def frozen?  # :nodoc:
         true
       end
-      # :nocov:
+      # simplecov:enable
     end
    
     # Alias of +first_source_alias+
@@ -259,7 +259,7 @@ module Sequel
     # underscore are reserved for internal use.
     attr_reader :cache
 
-    # Retreive a value from the dataset's cache in a thread safe manner.
+    # Retrieve a value from the dataset's cache in a thread safe manner.
     def cache_get(k)
       Sequel.synchronize{@cache[k]}
     end

data/lib/sequel/dataset/prepared_statements.rb

@@ -206,9 +206,9 @@ module Sequel
         when :insert_pk, :single_value
           with_sql_single_value(prepared_sql)
         when Array
-          # :nocov:
+          # simplecov:disable
           case type[0]
-          # :nocov:
+          # simplecov:enable
           when :map, :as_hash, :to_hash, :to_hash_groups
             force_prepared_sql.public_send(*type, &block) 
           end

data/lib/sequel/dataset/query.rb

@@ -98,7 +98,7 @@ module Sequel
         c.freeze
       end
     else
-      # :nocov:
+      # simplecov:disable
       def clone(opts = OPTS) # :nodoc:
         c = super()
         c.opts.merge!(opts)
@@ -108,7 +108,7 @@ module Sequel
         c.opts.freeze
         c
       end
-      # :nocov:
+      # simplecov:enable
     end
 
     # Returns a copy of the dataset with the SQL DISTINCT clause. The DISTINCT
@@ -213,13 +213,13 @@ module Sequel
         end
       end
     else
-      # :nocov:
+      # simplecov:disable
       def extension(*exts) # :nodoc:
         c = clone
         c.send(:_extension!, exts)
         c
       end
-      # :nocov:
+      # simplecov:enable
     end
 
     # Alias for where.
@@ -1250,14 +1250,14 @@ module Sequel
         o.freeze
       end
     else
-      # :nocov:
+      # simplecov:disable
       def with_extend(*mods, &block) # :nodoc:
         c = clone
         c.extend(*mods) unless mods.empty?
         c.extend(DatasetModule.new(&block)) if block
         c
       end
-      # :nocov:
+      # simplecov:enable
     end
 
     # Returns a cloned dataset with the given row_proc.
@@ -1354,7 +1354,7 @@ module Sequel
 
     private
 
-    # :nocov:
+    # simplecov:disable
     unless TRUE_FREEZE
       # Load the extensions into the receiver, without checking if the receiver is frozen.
       def _extension!(exts)
@@ -1373,7 +1373,7 @@ module Sequel
         self
       end
     end
-    # :nocov:
+    # simplecov:enable
 
     # A frozen array for the currently selected columns.
     def _current_select(allow_plain_wildcard)

data/lib/sequel/dataset/sql.rb

@@ -1022,11 +1022,19 @@ module Sequel
     # order if not. Also removes the row_proc, which isn't needed
     # for aggregate calculations.
     def aggregate_dataset
-      (aggreate_dataset_use_from_self? ? from_self : unordered).naked
+      (aggregate_dataset_use_from_self? ? from_self : unordered).naked
+    end
+
+    def aggreate_dataset_use_from_self? # :nodoc:
+      # SEQUEL6: Remove
+      # simplecov:disable
+      Sequel::Deprecation.deprecate("Dataset#aggreate_dataset_use_from_self", "Use #aggregate_dataset_use_from_self? instead")
+      aggregate_dataset_use_from_self?
+      # simplecov:enable
     end
 
     # Whether to use from_self for an aggregate dataset.
-    def aggreate_dataset_use_from_self?
+    def aggregate_dataset_use_from_self?
       options_overlap(COUNT_FROM_SELF_OPTS)
     end
 
@@ -1120,9 +1128,9 @@ module Sequel
     # operators unsupported by some databases. Used by adapters for databases
     # that don't support the operators natively.
     def complex_expression_emulate_append(sql, op, args)
-      # :nocov:
+      # simplecov:disable
       case op
-      # :nocov:
+      # simplecov:enable
       when :%
         complex_expression_arg_pairs_append(sql, args){|a, b| Sequel.function(:MOD, a, b)}
       when :>>
@@ -1204,7 +1212,7 @@ module Sequel
       end
     end
 
-    # Append literalization of array of grouping elements to SQL string, seperating them with commas.
+    # Append literalization of array of grouping elements to SQL string, separating them with commas.
     def grouping_element_list_append(sql, columns)
       c = false
       co = ', '
@@ -1229,7 +1237,7 @@ module Sequel
       db.from_application_timestamp(v).strftime(default_timestamp_format)
     end
     
-    # :nocov:
+    # simplecov:disable
 
     # Return the SQL timestamp fragment to use for the fractional time part.
     # Should start with the decimal point.  Uses 6 decimal places by default.
@@ -1240,7 +1248,7 @@ module Sequel
       end
       sprintf(".%0#{ts}d", usec)
     end
-    # :nocov:
+    # simplecov:enable
 
     # Append literalization of identifier to SQL string, considering regular strings
     # as SQL identifiers instead of SQL strings.
@@ -1338,10 +1346,21 @@ module Sequel
     alias delete_returning_sql insert_returning_sql
     alias update_returning_sql insert_returning_sql
 
-    # SQL fragment specifying a JOIN type, converts underscores to
-    # spaces and upcases.
+    JOIN_TYPE_SQL = {}
+    (CONDITIONED_JOIN_TYPES + UNCONDITIONED_JOIN_TYPES + %i[natural_inner natural_left_outer natural_right_outer natural_full_outer]).each do |join_type|
+      JOIN_TYPE_SQL[join_type] = "#{join_type.to_s.tr('_', ' ').upcase} JOIN".freeze
+    end
+    JOIN_TYPE_SQL[nil] = "JOIN"
+    JOIN_TYPE_SQL.freeze
+    private_constant :JOIN_TYPE_SQL
+
+    # SQL fragment for join type
     def join_type_sql(join_type)
-      "#{join_type.to_s.tr('_', ' ').upcase} JOIN"
+      JOIN_TYPE_SQL.fetch(join_type) do
+        # SEQUEL6: Raise error
+        Sequel::Deprecation.deprecate("Unrecognized join type used: #{join_type.inspect}. This will raise an error starting in Sequel 6.")
+        "#{join_type.to_s.tr('_', ' ').upcase} JOIN"
+      end
     end
 
     # Append USING clause for JOIN USING
@@ -1372,7 +1391,7 @@ module Sequel
       literal_string_append(sql, v)
     end
 
-    # Append literalization of dataset to SQL string.  Does a subselect inside parantheses.
+    # Append literalization of dataset to SQL string.  Does a subselect inside parentheses.
     def literal_dataset_append(sql, v)
       sql << 'LATERAL ' if v.opts[:lateral]
       sql << '('
@@ -1438,7 +1457,7 @@ module Sequel
     # Append a literalization of the object to the given SQL string.
     # Calls +sql_literal_append+ if object responds to it, otherwise
     # calls +sql_literal+ if object responds to it, otherwise raises an error.
-    # If a database specific type is allowed, this should be overriden in a subclass.
+    # If a database specific type is allowed, this should be overridden in a subclass.
     def literal_other_append(sql, v)
       if v.respond_to?(:sql_literal_append)
         v.sql_literal_append(self, sql)
@@ -1559,7 +1578,7 @@ module Sequel
     end
 
     # Modify the sql to add a dataset to the via an EXCEPT, INTERSECT, or UNION clause.
-    # This uses a subselect for the compound datasets used, because using parantheses doesn't
+    # This uses a subselect for the compound datasets used, because using parentheses doesn't
     # work on all databases.
     def select_compounds_sql(sql)
       return unless c = @opts[:compounds]

data/lib/sequel/dataset.rb

@@ -54,7 +54,7 @@ module Sequel
   require_relative "dataset/placeholder_literalizer"
   require_relative "dataset/dataset_module"
 
-  # :nocov:
+  # simplecov:disable
   require_relative "dataset/deprecated_singleton_class_methods" if Dataset::TRUE_FREEZE
-  # :nocov:
+  # simplecov:enable
 end

data/lib/sequel/deprecated.rb

@@ -60,9 +60,9 @@ module Sequel
     # If using ruby 2.3+, use Module#deprecate_constant to deprecate the constant,
     # otherwise do nothing as the ruby implementation does not support constant deprecation.
     def self.deprecate_constant(mod, constant)
-      # :nocov:
+      # simplecov:disable
       if RUBY_VERSION > '2.3'
-      # :nocov:
+      # simplecov:enable
         mod.deprecate_constant(constant)
       end
     end

data/lib/sequel/exceptions.rb

@@ -8,9 +8,9 @@ module Sequel
     # exception is held here.
     attr_accessor :wrapped_exception
 
-    # :nocov:
+    # simplecov:disable
     if RUBY_VERSION >= '2.1'
-    # :nocov:
+    # simplecov:enable
       # Returned the wrapped exception if one exists, otherwise use
       # ruby's default behavior.
       def cause

data/lib/sequel/extensions/_pretty_table.rb

@@ -74,7 +74,7 @@ module Sequel
       String.new << '|' << columns.map {|c| "%-#{sizes[c]}s" % c.to_s}.join('|') << '|'
     end
 
-    # String for separtor line
+    # String for separator line
     def self.separator_line(columns, sizes) # :nodoc:
       String.new << '+' << columns.map {|c| '-' * sizes[c]}.join('+') << '+'
     end

data/lib/sequel/extensions/async_thread_pool.rb

@@ -78,7 +78,7 @@
 #
 #   # ...
 #   if result 
-#     # will always execute this banch, since result is a proxy object
+#     # will always execute this branch, since result is a proxy object
 #   end
 #
 # In this case, you can call the +__value+ method to return the actual
@@ -244,9 +244,9 @@ module Sequel
       def method_missing(*args, &block)
         __value.public_send(*args, &block)
       end
-      # :nocov:
+      # simplecov:disable
       ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
-      # :nocov:
+      # simplecov:enable
 
       # Delegate respond_to? calls to the returned result.
       def respond_to_missing?(*args)

data/lib/sequel/extensions/auto_cast_date_and_time.rb

@@ -45,7 +45,7 @@
 #
 module Sequel
   module AutoCastDateAndTime
-    # :nocov:
+    # simplecov:disable
 
     # Mark the datasets as requiring sql standard date times.  This is only needed
     # for backwards compatibility.  
@@ -53,7 +53,7 @@ module Sequel
       # SEQUEL6: Remove
       true
     end
-    # :nocov:
+    # simplecov:enable
 
     private
 

data/lib/sequel/extensions/blank.rb

@@ -7,11 +7,11 @@
 #   Sequel.extension :blank
 
 [FalseClass, Object, NilClass, Numeric, String, TrueClass].each do |klass|
-  # :nocov:
+  # simplecov:disable
   if klass.method_defined?(:blank?)
     klass.send(:alias_method, :blank?, :blank?)
   end
-  # :nocov:
+  # simplecov:enable
 end
 
 class FalseClass

data/lib/sequel/extensions/constraint_validations.rb

@@ -95,7 +95,7 @@
 #   integers, and a range of integers.
 # * There are like and ilike validations, which are similar to the format
 #   validation but use a case sensitive or case insensitive LIKE pattern. LIKE
-#   patters are very simple, so many regexp patterns cannot be expressed by
+#   patterns are very simple, so many regexp patterns cannot be expressed by
 #   them, but only a couple databases (PostgreSQL and MySQL) support regexp
 #   patterns.
 # * The operator validation only supports >, >=, <, and <= operators, and the

data/lib/sequel/extensions/core_refinements.rb

@@ -10,14 +10,11 @@
 #
 #   using Sequel::CoreRefinements
 
-# :nocov:
-raise(Sequel::Error, "Refinements require ruby 2.0.0 or greater") unless RUBY_VERSION >= '2.0.0'
-# :nocov:
-
+#
 module Sequel::CoreRefinements
-  # :nocov:
+  # simplecov:disable
   include_meth = RUBY_VERSION >= '3.1' ? :import_methods : :include
-  # :nocov:
+  # simplecov:enable
   INCLUDE_METH = include_meth
   private_constant :INCLUDE_METH
 
@@ -201,16 +198,16 @@ module Sequel::CoreRefinements
     send include_meth, Sequel::SQL::BooleanMethods
     send include_meth, Sequel::SQL::NumericMethods
 
-    # :nocov:
+    # simplecov:disable
     remove_method :* if RUBY_VERSION >= '3.1'
-    # :nocov:
+    # simplecov:enable
 
     send include_meth, Sequel::SQL::QualifyingMethods
     send include_meth, Sequel::SQL::StringMethods
     send include_meth, Sequel::SQL::SubscriptMethods
     send include_meth, Sequel::SQL::ComplexExpressionMethods
 
-    # :nocov:
+    # simplecov:disable
     if RUBY_VERSION >= '3.1'
       remove_method :*
       def *(ce=(arg=false;nil))
@@ -222,7 +219,7 @@ module Sequel::CoreRefinements
       end
 
     end
-    # :nocov:
+    # simplecov:enable
 
     # Returns receiver wrapped in an <tt>Sequel::SQL::Identifier</tt>.
     #

data/lib/sequel/extensions/date_arithmetic.rb

@@ -1,7 +1,7 @@
 # frozen-string-literal: true
 #
 # The date_arithmetic extension adds the ability to perform database-independent
-# addition/substraction of intervals to/from dates and timestamps.
+# addition/subtraction of intervals to/from dates and timestamps.
 #
 # First, you need to load the extension into the database:
 #

data/lib/sequel/extensions/datetime_parse_to_time.rb

@@ -20,10 +20,10 @@ module Sequel::DateTimeParseToTime
   # be in UTC and there is no offset information in the string.
   def convert_input_timestamp(v, input_timezone)
     if v.is_a?(String) && datetime_class == Time && input_timezone == :utc && !_date_parse(v).has_key?(:offset)
-      # :nocov:
+      # simplecov:disable
       # Whether this is fully branch covered depends on the order in which the specs are run.
       v = handle_date_parse_input(v) if respond_to?(:handle_date_parse_input, true)
-      # :nocov:
+      # simplecov:enable
       t = DateTime.parse(v).to_time
       case application_timezone
       when nil, :local

data/lib/sequel/extensions/duplicate_columns_handler.rb

@@ -40,9 +40,7 @@
 
 module Sequel
   module DuplicateColumnsHandler
-    # :nocov:
-    CALLER_ARGS = (RUBY_VERSION >= '2.0' ? [0,1] : [0]).freeze
-    # :nocov:
+    CALLER_ARGS = [0,1].freeze
 
     # Customize handling of duplicate columns for this dataset.
     def on_duplicate_columns(handler = (raise Error, "Must provide either an argument or a block to on_duplicate_columns" unless defined?(yield); nil), &block)

data/lib/sequel/extensions/graph_each.rb

@@ -43,7 +43,7 @@ module Sequel
     private
 
     # Fetch the rows, split them into component table parts,
-    # tranform and run the row_proc on each part (if applicable),
+    # transform and run the row_proc on each part (if applicable),
     # and yield a hash of the parts.
     def graph_each(sql=select_sql)
       # Reject tables with nil datasets, as they are excluded from

data/lib/sequel/extensions/index_caching.rb

@@ -14,7 +14,7 @@
 #
 #   # load model files
 #
-# Then, whenever database indicies are modified, write a new cached
+# Then, whenever database indices are modified, write a new cached
 # file.  You can do that with <tt>bin/sequel</tt>'s -X option:
 #
 #   bin/sequel -X /path/to/index_cache.dump postgres://...

data/lib/sequel/extensions/inflector.rb

@@ -31,7 +31,7 @@ class String
     @plurals, @singulars, @uncountables = [], [], []
 
     class << self
-      # Array of 2 element arrays, first containing a regex, and the second containing a substitution pattern, used for plurization.
+      # Array of 2 element arrays, first containing a regex, and the second containing a substitution pattern, used for pluralization.
       attr_reader :plurals
 
       # Array of 2 element arrays, first containing a regex, and the second containing a substitution pattern, used for singularization.
@@ -107,11 +107,11 @@ class String
   end
   
   %w'classify constantize dasherize demodulize foreign_key humanize pluralize singularize tableize underscore'.each do |m|
-    # :nocov:
+    # simplecov:disable
     if method_defined?(m)
       alias_method(m, m)
     end
-    # :nocov:
+    # simplecov:enable
   end
 
   # By default, camelize converts the string to UpperCamelCase. If the argument to camelize
@@ -212,8 +212,8 @@ class String
   # Examples
   #   "posts".singularize #=> "post"
   #   "octopi".singularize #=> "octopus"
-  #   "sheep".singluarize #=> "sheep"
-  #   "word".singluarize #=> "word"
+  #   "sheep".singularize #=> "sheep"
+  #   "word".singularize #=> "word"
   #   "the blue mailmen".singularize #=> "the blue mailman"
   #   "CamelOctopi".singularize #=> "CamelOctopus"
   def singularize

data/lib/sequel/extensions/is_distinct_from.rb

@@ -124,7 +124,7 @@ module Sequel
   Dataset.register_extension(:is_distinct_from, SQL::IsDistinctFrom::DatasetMethods)
 end
 
-# :nocov:
+# simplecov:disable
 if Sequel.core_extensions?
   class Symbol
     include Sequel::SQL::IsDistinctFrom::Methods
@@ -138,4 +138,4 @@ if defined?(Sequel::CoreRefinements)
     end
   end
 end
-# :nocov:
+# simplecov:enable

data/lib/sequel/extensions/lit_require_frozen.rb

@@ -46,16 +46,16 @@ module Sequel
   class LiteralString
     # The string used when creating the literal string (first argument to
     # Sequel::LiteralString.new). This may be nil if no string was provided,
-    # or if the litral string was created before this extension was required.
+    # or if the literal string was created before this extension was required.
     attr_reader :source
 
     def initialize(*a)
       @source = a.first
       super
     end
-    # :nocov:
+    # simplecov:disable
     ruby2_keywords :initialize if respond_to?(:ruby2_keywords, true)
-    # :nocov:
+    # simplecov:enable
   end
 
   module LitRequireFrozen
@@ -63,6 +63,20 @@ module Sequel
     class Error < Sequel::Error
     end
 
+    module BooleanExpressionClassMethods
+      private
+
+      # Do not freeze literal strings in value pairs, so they don't skip
+      # the frozen checks.
+      def from_value_pair(l, r)
+        if LiteralString === r
+          new(:'=', l, r)
+        else
+          super
+        end
+      end
+    end
+
     module DatabaseMethods
       def self.extended(db)
         db.extend_datasets(DatasetMethods)
@@ -105,7 +119,7 @@ module Sequel
       def _check_unfrozen_literal_string(str)
         return if !str.is_a?(String) || str.frozen?
 
-        if str.is_a?(LiteralString)
+        if str.is_a?(LiteralString) && str == str.source
           _check_unfrozen_literal_string(str.source)
         else
           raise Error, "cannot treat unfrozen string as literal SQL: #{str.inspect}"
@@ -126,6 +140,8 @@ module Sequel
     end
   end
 
+  SQL::BooleanExpression.extend(LitRequireFrozen::BooleanExpressionClassMethods)
+
   Dataset.register_extension(:lit_require_frozen, LitRequireFrozen::DatasetMethods)
   Database.register_extension(:lit_require_frozen, LitRequireFrozen::DatabaseMethods)
 end