sequel 4.49.0 → 5.3.0

data/lib/sequel/adapters/shared/sqlanywhere.rb

@@ -4,53 +4,17 @@ module Sequel
   module SqlAnywhere
     Sequel::Database.set_shared_adapter_scheme(:sqlanywhere, self)
 
-    # SEQUEL5: Remove
-    @convert_smallint_to_bool = true
-    class << self
-      def convert_smallint_to_bool
-        Sequel::Deprecation.deprecate("Sequel::SqlAnywhere.convert_smallint_to_bool", "Call this method on the Database instance")
-        @convert_smallint_to_bool
-      end
-      def convert_smallint_to_bool=(v)
-        Sequel::Deprecation.deprecate("Sequel::SqlAnywhere.convert_smallint_to_bool=", "Call this method on the Database instance")
-        @convert_smallint_to_bool = v
-      end
-    end
-
     module DatabaseMethods
       attr_reader :conversion_procs
 
-      # Override the default SqlAnywhere.convert_smallint_to_bool setting for this database.
-      attr_writer :convert_smallint_to_bool
-
-      AUTO_INCREMENT = 'IDENTITY'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :AUTO_INCREMENT)
-      SQL_BEGIN = "BEGIN TRANSACTION".freeze
-      Sequel::Deprecation.deprecate_constant(self, :SQL_BEGIN)
-      SQL_COMMIT = "COMMIT TRANSACTION".freeze
-      Sequel::Deprecation.deprecate_constant(self, :SQL_COMMIT)
-      SQL_ROLLBACK = "IF @@TRANCOUNT > 0 ROLLBACK TRANSACTION".freeze
-      Sequel::Deprecation.deprecate_constant(self, :SQL_ROLLBACK)
-      TEMPORARY = "GLOBAL TEMPORARY ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :TEMPORARY)
-      SMALLINT_RE = /smallint/i.freeze
-      Sequel::Deprecation.deprecate_constant(self, :SMALLINT_RE)
-      DECIMAL_TYPE_RE = /numeric/i
-      Sequel::Deprecation.deprecate_constant(self, :DECIMAL_TYPE_RE)
-
-      # Whether to convert smallint to boolean arguments for this dataset.
-      # Defaults to the SqlAnywhere module setting.
-      def convert_smallint_to_bool
-        defined?(@convert_smallint_to_bool) ? @convert_smallint_to_bool : (@convert_smallint_to_bool = ::Sequel::SqlAnywhere.instance_variable_get(:@convert_smallint_to_bool)) # true) # SEQUEL5
-      end
+      # Set whether to convert smallint type to boolean for this Database instance
+      attr_accessor :convert_smallint_to_bool
 
-      # Sysbase Server uses the :sqlanywhere type.
       def database_type
         :sqlanywhere
       end
 
       def freeze
-        convert_smallint_to_bool
         @conversion_procs.freeze
         super
       end
@@ -172,22 +136,18 @@ module Sequel
         false
       end
 
-      # SQL fragment for marking a table as temporary
       def temporary_table_sql
         "GLOBAL TEMPORARY "
       end
 
-      # SQL to BEGIN a transaction.
       def begin_transaction_sql
         "BEGIN TRANSACTION"
       end
 
-      # SQL to ROLLBACK a transaction.
       def rollback_transaction_sql
         "IF @@TRANCOUNT > 0 ROLLBACK TRANSACTION"
       end
 
-      # SQL to COMMIT a transaction.
       def commit_transaction_sql
         "COMMIT TRANSACTION"
       end
@@ -214,7 +174,6 @@ module Sequel
         :image
       end
 
-      # Sybase specific syntax for altering tables.
       def alter_table_sql(table, op)
         case op[:op]
         when :add_column
@@ -278,58 +237,9 @@ module Sequel
     end
 
     module DatasetMethods
-      BOOL_TRUE = '1'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :BOOL_TRUE)
-      BOOL_FALSE = '0'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :BOOL_FALSE)
-      WILDCARD = LiteralString.new('%').freeze
-      Sequel::Deprecation.deprecate_constant(self, :WILDCARD)
-      TOP = " TOP ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :TOP)
-      START_AT = " START AT ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :START_AT)
-      SQL_WITH_RECURSIVE = "WITH RECURSIVE ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :SQL_WITH_RECURSIVE)
-      DATE_FUNCTION = 'today()'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :DATE_FUNCTION)
-      NOW_FUNCTION = 'now()'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :NOW_FUNCTION)
-      DATEPART = 'datepart'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :DATEPART)
-      REGEXP = 'REGEXP'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :REGEXP)
-      NOT_REGEXP = 'NOT REGEXP'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :NOT_REGEXP)
-      APOS = "'".freeze
-      Sequel::Deprecation.deprecate_constant(self, :APOS)
-      APOS_RE = /'/.freeze
-      Sequel::Deprecation.deprecate_constant(self, :APOS_RE)
-      DOUBLE_APOS = "''".freeze
-      Sequel::Deprecation.deprecate_constant(self, :DOUBLE_APOS)
-      BACKSLASH_RE = /\\/.freeze
-      Sequel::Deprecation.deprecate_constant(self, :BACKSLASH_RE)
-      QUAD_BACKSLASH = "\\\\\\\\".freeze
-      Sequel::Deprecation.deprecate_constant(self, :QUAD_BACKSLASH)
-      BLOB_START = "0x".freeze
-      Sequel::Deprecation.deprecate_constant(self, :BLOB_START)
-      HSTAR = "H*".freeze
-      Sequel::Deprecation.deprecate_constant(self, :HSTAR)
-      CROSS_APPLY = 'CROSS APPLY'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :CROSS_APPLY)
-      OUTER_APPLY = 'OUTER APPLY'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :OUTER_APPLY)
-      ONLY_OFFSET = " TOP 2147483647".freeze
-      Sequel::Deprecation.deprecate_constant(self, :ONLY_OFFSET)
-
       Dataset.def_sql_method(self, :insert, %w'with insert into columns values')
       Dataset.def_sql_method(self, :select, %w'with select distinct limit columns into from join where group having compounds order lock')
 
-      # Override the default IBMDB.convert_smallint_to_bool setting for this dataset.
-      def convert_smallint_to_bool=(v)
-        Sequel::Deprecation.deprecate("Sequel::SqlAnywhere::Dataset#convert_smallint_to_bool=", "Call with_convert_smallint_to_bool instead, which returns a modified copy instead of modifying the object")
-        @opts[:convert_smallint_to_bool] = v
-      end
-
       # Whether to convert smallint to boolean arguments for this dataset.
       # Defaults to the IBMDB module setting.
       def convert_smallint_to_bool
@@ -380,7 +290,6 @@ module Sequel
         true
       end
 
-      # SQLAnywhere uses + for string concatenation, and LIKE is case insensitive by default.
       def complex_expression_sql_append(sql, op, args)
         case op
         when :'||'
@@ -437,7 +346,7 @@ module Sequel
         string.gsub(/[\\%_\[]/){|m| "\\#{m}"}
       end
 
-      # Use today() and Now() for CURRENT_DATE and CURRENT_TIMESTAMP
+      # Use today() for CURRENT_DATE and now() for CURRENT_TIMESTAMP and CURRENT_TIME
       def constant_sql_append(sql, constant)
         case constant
         when :CURRENT_DATE
@@ -492,8 +401,7 @@ module Sequel
         end
       end
 
-      # Sybase uses TOP N for limit.  For Sybase TOP (N) is used
-      # to allow the limit to be a bound variable.
+      # Sybase uses TOP N for limit.
       def select_limit_sql(sql)
         l = @opts[:limit]
         o = @opts[:offset]

data/lib/sequel/adapters/shared/sqlite.rb

@@ -1,13 +1,14 @@
 # frozen-string-literal: true
 
-Sequel.require %w'replace unmodified_identifiers', 'adapters/utils'
+require_relative '../utils/replace'
+require_relative '../utils/unmodified_identifiers'
 
 module Sequel
   module SQLite
     Sequel::Database.set_shared_adapter_scheme(:sqlite, self)
 
     def self.mock_adapter_setup(db)
-      db.instance_eval do
+      db.instance_exec do
         @sqlite_version = 30903
       end
     end
@@ -18,13 +19,6 @@ module Sequel
     module DatabaseMethods
       include UnmodifiedIdentifiers::DatabaseMethods
 
-      PRIMARY_KEY_INDEX_RE = /\Asqlite_autoindex_/.freeze
-      Sequel::Deprecation.deprecate_constant(self, :PRIMARY_KEY_INDEX_RE)
-      TABLES_FILTER = Sequel.~(:name=>'sqlite_sequence'.freeze) & {:type => 'table'.freeze}
-      Sequel::Deprecation.deprecate_constant(self, :TABLES_FILTER)
-      VIEWS_FILTER = {:type => 'view'.freeze}.freeze
-      Sequel::Deprecation.deprecate_constant(self, :VIEWS_FILTER)
-
       AUTO_VACUUM = [:none, :full, :incremental].freeze
       SYNCHRONOUS = [:off, :normal, :full].freeze
       TEMP_STORE = [:default, :file, :memory].freeze
@@ -56,46 +50,6 @@ module Sequel
         :sqlite
       end
       
-      # SEQUEL5: Remove
-      def auto_vacuum
-        AUTO_VACUUM[pragma_get(:auto_vacuum).to_i]
-      end
-      def auto_vacuum=(value)
-        value = AUTO_VACUUM.index(value) || (raise Error, "Invalid value for auto_vacuum option. Please specify one of :none, :full, :incremental.")
-        pragma_set(:auto_vacuum, value)
-      end
-      def case_sensitive_like=(value)
-        pragma_set(:case_sensitive_like, !!value ? 'on' : 'off') if sqlite_version >= 30203
-      end
-      def foreign_keys
-        pragma_get(:foreign_keys).to_i == 1 if sqlite_version >= 30619
-      end
-      def foreign_keys=(value)
-        pragma_set(:foreign_keys, !!value ? 'on' : 'off') if sqlite_version >= 30619
-      end
-      def pragma_get(name)
-        Sequel::Deprecation.deprecate('Database#{pragma_get,auto_vacuum,case_sensitive_like,foreign_keys,synchronous,temp_store} on SQLite', "These methods may not be safe when using multiple connections, call fetch(#{"PRAGMA #{name}".inspect}).single_value if you really want to get the pragma value")
-        self["PRAGMA #{name}"].single_value
-      end
-      def pragma_set(name, value)
-        Sequel::Deprecation.deprecate('Database#{pragma_set,auto_vacuum=,case_sensitive_like=,foreign_keys=,synchronous=,temp_store=} on SQLite', "These methods are not thread safe or safe when using multiple connections, pass the appropriate option when connecting to set the pragma correctly for all connections")
-        execute_ddl("PRAGMA #{name} = #{value}")
-      end
-      def synchronous
-        SYNCHRONOUS[pragma_get(:synchronous).to_i]
-      end
-      def synchronous=(value)
-        value = SYNCHRONOUS.index(value) || (raise Error, "Invalid value for synchronous option. Please specify one of :off, :normal, :full.")
-        pragma_set(:synchronous, value)
-      end
-      def temp_store
-        TEMP_STORE[pragma_get(:temp_store).to_i]
-      end
-      def temp_store=(value)
-        value = TEMP_STORE.index(value) || (raise Error, "Invalid value for temp_store option. Please specify one of :default, :file, :memory.")
-        pragma_set(:temp_store, value)
-      end
-
       # Set the integer_booleans option using the passed in :integer_boolean option.
       def set_integer_booleans
         @integer_booleans = @opts.has_key?(:integer_booleans) ? typecast_value_boolean(@opts[:integer_booleans]) : true
@@ -203,7 +157,7 @@ module Sequel
       # Creates a dataset that uses the VALUES clause:
       #
       #   DB.values([[1, 2], [3, 4]])
-      #   VALUES ((1, 2), (3, 4))
+      #   # VALUES ((1, 2), (3, 4))
       def values(v)
         @default_dataset.clone(:values=>v)
       end
@@ -527,7 +481,6 @@ module Sequel
       end
     end
     
-    # Instance methods for datasets that connect to an SQLite database
     module DatasetMethods
       include Dataset::Replace
       include UnmodifiedIdentifiers::DatasetMethods
@@ -535,50 +488,9 @@ module Sequel
       # The allowed values for insert_conflict
       INSERT_CONFLICT_RESOLUTIONS = %w'ROLLBACK ABORT FAIL IGNORE REPLACE'.each(&:freeze).freeze
 
-      CONSTANT_MAP = {:CURRENT_DATE=>"date(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIMESTAMP=>"datetime(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIME=>"time(CURRENT_TIMESTAMP, 'localtime')".freeze}#.freeze # SEQUEL5
-      EXTRACT_MAP = {:year=>"'%Y'", :month=>"'%m'", :day=>"'%d'", :hour=>"'%H'", :minute=>"'%M'", :second=>"'%f'"}#.freeze # SEQUEL5
-      #EXTRACT_MAP.each_value(&:freeze) # SEQUEL5
-
-      NOT_SPACE = 'NOT '.freeze
-      Sequel::Deprecation.deprecate_constant(self, :NOT_SPACE)
-      COMMA = ', '.freeze
-      Sequel::Deprecation.deprecate_constant(self, :COMMA)
-      PAREN_CLOSE = ')'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :PAREN_CLOSE)
-      AS = ' AS '.freeze
-      Sequel::Deprecation.deprecate_constant(self, :AS)
-      APOS = "'".freeze
-      Sequel::Deprecation.deprecate_constant(self, :APOS)
-      EXTRACT_OPEN = "CAST(strftime(".freeze
-      Sequel::Deprecation.deprecate_constant(self, :EXTRACT_OPEN)
-      EXTRACT_CLOSE = ') AS '.freeze
-      Sequel::Deprecation.deprecate_constant(self, :EXTRACT_CLOSE)
-      NUMERIC = 'NUMERIC'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :NUMERIC)
-      INTEGER = 'INTEGER'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :INTEGER)
-      BACKTICK = '`'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :BACKTICK)
-      BACKTICK_RE = /`/.freeze
-      Sequel::Deprecation.deprecate_constant(self, :BACKTICK_RE)
-      DOUBLE_BACKTICK = '``'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :DOUBLE_BACKTICK)
-      BLOB_START = "X'".freeze
-      Sequel::Deprecation.deprecate_constant(self, :BLOB_START)
-      HSTAR = "H*".freeze
-      Sequel::Deprecation.deprecate_constant(self, :HSTAR)
-      DATE_OPEN = "date(".freeze
-      Sequel::Deprecation.deprecate_constant(self, :DATE_OPEN)
-      DATETIME_OPEN = "datetime(".freeze
-      Sequel::Deprecation.deprecate_constant(self, :DATETIME_OPEN)
-      ONLY_OFFSET = " LIMIT -1 OFFSET ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :ONLY_OFFSET)
-      OR = " OR ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :OR)
-      SELECT_VALUES = "VALUES ".freeze
-      Sequel::Deprecation.deprecate_constant(self, :SELECT_VALUES)
-      EMULATED_FUNCTION_MAP = {:char_length=>'length'.freeze}
-      Sequel::Deprecation.deprecate_constant(self, :EMULATED_FUNCTION_MAP)
+      CONSTANT_MAP = {:CURRENT_DATE=>"date(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIMESTAMP=>"datetime(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIME=>"time(CURRENT_TIMESTAMP, 'localtime')".freeze}.freeze
+      EXTRACT_MAP = {:year=>"'%Y'", :month=>"'%m'", :day=>"'%d'", :hour=>"'%H'", :minute=>"'%M'", :second=>"'%f'"}.freeze
+      EXTRACT_MAP.each_value(&:freeze)
 
       Dataset.def_sql_method(self, :delete, [['if db.sqlite_version >= 30803', %w'with delete from where'], ["else", %w'delete from where']])
       Dataset.def_sql_method(self, :insert, [['if db.sqlite_version >= 30803', %w'with insert conflict into columns values'], ["else", %w'insert conflict into columns values']])
@@ -600,7 +512,7 @@ module Sequel
       end
 
       # SQLite doesn't support a NOT LIKE b, you need to use NOT (a LIKE b).
-      # It doesn't support xor or the extract function natively, so those have to be emulated.
+      # It doesn't support xor, power, or the extract function natively, so those have to be emulated.
       def complex_expression_sql_append(sql, op, args)
         case op
         when :"NOT LIKE", :"NOT ILIKE"
@@ -703,15 +615,14 @@ module Sequel
       #
       # Examples:
       #
-      #   DB[:table].insert_conflict.insert(:a=>1, :b=>2)
+      #   DB[:table].insert_conflict.insert(a: 1, b: 2)
       #   # INSERT OR IGNORE INTO TABLE (a, b) VALUES (1, 2)
       #
-      #   DB[:table].insert_conflict(:replace).insert(:a=>1, :b=>2)
+      #   DB[:table].insert_conflict(:replace).insert(a: 1, b: 2)
       #   # INSERT OR REPLACE INTO TABLE (a, b) VALUES (1, 2)
       def insert_conflict(resolution = :ignore)
         unless INSERT_CONFLICT_RESOLUTIONS.include?(resolution.to_s.upcase)
-          Sequel::Deprecation.deprecate("Passing #{resolution.inspect} argument to Dataset#insert_conflict", "The allowed values are: :rollback, :abort, :fail, :ignore, or :replace")
-          # raise Error, "Invalid value passed to Dataset#insert_conflict: #{resolution.inspect}.  The allowed values are: :rollback, :abort, :fail, :ignore, or :replace"
+          raise Error, "Invalid value passed to Dataset#insert_conflict: #{resolution.inspect}.  The allowed values are: :rollback, :abort, :fail, :ignore, or :replace"
         end
         clone(:insert_conflict => resolution)
       end
@@ -719,7 +630,7 @@ module Sequel
       # Ignore uniqueness/exclusion violations when inserting, using INSERT OR IGNORE.
       # Exists mostly for compatibility to MySQL's insert_ignore. Example:
       #
-      #   DB[:table].insert_ignore.insert(:a=>1, :b=>2)
+      #   DB[:table].insert_ignore.insert(a: 1, b: 2)
       #   # INSERT OR IGNORE INTO TABLE (a, b) VALUES (1, 2)
       def insert_ignore
         insert_conflict(:ignore)
@@ -730,6 +641,11 @@ module Sequel
         db.sqlite_version >= 30803
       end
 
+      # SQLite supports CTEs in subqueries if it supports CTEs.
+      def supports_cte_in_subqueries?
+        supports_cte?
+      end
+
       # SQLite does not support table aliases with column aliases
       def supports_derived_column_lists?
         false
@@ -854,6 +770,11 @@ module Sequel
         expression_list_append(sql, opts[:values])
       end
 
+      # SQLite does not support CTEs directly inside UNION/INTERSECT/EXCEPT.
+      def supports_cte_in_compounds?
+        false
+      end
+
       # SQLite supports quoted function names.
       def supports_quoted_function_names?
         true

data/lib/sequel/adapters/sqlanywhere.rb

@@ -1,11 +1,9 @@
 # frozen-string-literal: true
 
 require 'sqlanywhere'
-
-Sequel.require %w'shared/sqlanywhere', 'adapters'
+require_relative 'shared/sqlanywhere'
 
 module Sequel
-  # Module for holding all SqlAnywhere-related classes and modules for Sequel.
   module SqlAnywhere
 
     class SQLAnywhereException < StandardError
@@ -27,9 +25,6 @@ module Sequel
       def time(s) ::Sequel.string_to_time(s) end
     end.new
 
-    TYPE_TRANSLATOR = tt
-    Sequel::Deprecation.deprecate_constant(self, :TYPE_TRANSLATOR)
-
     SQLANYWHERE_TYPES = {}
     {
         [0, 484] => tt.method(:decimal),
@@ -40,15 +35,11 @@ module Sequel
     }.each do |k,v|
       k.each{|n| SQLANYWHERE_TYPES[n] = v}
     end
-    # SQLANYWHERE_TYPES.freeze # SEQUEL5
+    SQLANYWHERE_TYPES.freeze
 
-    # Database class for SQLAnywhere databases used with Sequel.
     class Database < Sequel::Database
       include Sequel::SqlAnywhere::DatabaseMethods
 
-      DEFAULT_CONFIG = { :user => 'dba', :password => 'sql' }
-      Sequel::Deprecation.deprecate_constant(self, :DEFAULT_CONFIG)
-
       attr_accessor :api
 
       set_adapter_scheme :sqlanywhere
@@ -79,12 +70,10 @@ module Sequel
         conn
       end
 
-      # Closes given database connection.
       def disconnect_connection(c)
         @api.sqlany_disconnect(c)
       end
 
-      # Returns number of rows affected
       def execute_dui(sql, opts=OPTS)
         synchronize(opts[:server]) do |conn|
           _execute(conn, :rows, sql, opts)
@@ -110,8 +99,6 @@ module Sequel
 
       private
 
-      LAST_INSERT_ID = 'SELECT @@IDENTITY'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :LAST_INSERT_ID)
       def _execute(conn, type, sql, opts)
         unless rs = log_connection_yield(sql, conn){@api.sqlany_execute_direct(conn, sql)}
           result, errstr = @api.sqlany_error(conn)
@@ -132,6 +119,7 @@ module Sequel
       end
 
       def adapter_initialize
+        @convert_smallint_to_bool = true
         @conversion_procs = SQLANYWHERE_TYPES.dup
         @conversion_procs[392] = method(:to_application_timestamp_sa)
         @api = SQLAnywhere::SQLAnywhereInterface.new
@@ -148,22 +136,15 @@ module Sequel
       end
     end
 
-    # Dataset class for SqlAnywhere datasets accessed via the native driver.
     class Dataset < Sequel::Dataset
       include Sequel::SqlAnywhere::DatasetMethods
 
-      Database::DatasetClass = self
-      Sequel::Deprecation.deprecate_constant(Database, :DatasetClass)
-
-      # Yield all rows matching this dataset.  If the dataset is set to
-      # split multiple statements, yield arrays of hashes one per statement
-      # instead of yielding results for all statements as hashes.
       def fetch_rows(sql)
         db = @db
         cps = db.conversion_procs
         api = db.api
         execute(sql) do |rs|
-          convert = (convert_smallint_to_bool and db.convert_smallint_to_bool)
+          convert = convert_smallint_to_bool
           col_infos = []
           api.sqlany_num_cols(rs).times do |i|
             _, _, name, _, type = api.sqlany_get_column_info(rs, i)

data/lib/sequel/adapters/sqlite.rb

@@ -1,11 +1,9 @@
 # frozen-string-literal: true
 
 require 'sqlite3'
-Sequel.require 'adapters/shared/sqlite'
+require_relative 'shared/sqlite'
 
 module Sequel
-  # Top level module for holding all SQLite-related modules and classes
-  # for Sequel.
   module SQLite
     FALSE_VALUES = (%w'0 false f no n' + [0]).freeze
 
@@ -60,9 +58,6 @@ module Sequel
       end
     end.new
 
-    TYPE_TRANSLATOR = tt
-    Sequel::Deprecation.deprecate_constant(self, :TYPE_TRANSLATOR)
-
     # Hash with string keys and callable values for converting SQLite types.
     SQLITE_TYPES = {}
     {
@@ -76,10 +71,8 @@ module Sequel
     }.each do |k,v|
       k.each{|n| SQLITE_TYPES[n] = v}
     end
-    # SQLITE_TYPES.freeze # SEQUEL5
+    SQLITE_TYPES.freeze
     
-    # Database class for SQLite databases used with Sequel and the
-    # ruby-sqlite3 driver.
     class Database < Sequel::Database
       include ::Sequel::SQLite::DatabaseMethods
       
@@ -149,7 +142,6 @@ module Sequel
         end
       end
       
-      # Run the given SQL with the given arguments and return the last inserted row id.
       def execute_insert(sql, opts=OPTS)
         _execute(:insert, sql, opts)
       end
@@ -291,17 +283,9 @@ module Sequel
       #end
     end
     
-    # Dataset class for SQLite datasets that use the ruby-sqlite3 driver.
     class Dataset < Sequel::Dataset
       include ::Sequel::SQLite::DatasetMethods
 
-      Database::DatasetClass = self
-      Sequel::Deprecation.deprecate_constant(Database, :DatasetClass)
-      
-      PREPARED_ARG_PLACEHOLDER = ':'.freeze
-      Sequel::Deprecation.deprecate_constant(self, :PREPARED_ARG_PLACEHOLDER)
-      
-      # SQLite already supports named bind arguments, so use directly.
       module ArgumentMapper
         include Sequel::Dataset::ArgumentMapper
         
@@ -332,7 +316,6 @@ module Sequel
       BindArgumentMethods = prepared_statements_module(:bind, ArgumentMapper)
       PreparedStatementMethods = prepared_statements_module(:prepare, BindArgumentMethods)
 
-      # Yield a hash for each row in the dataset.
       def fetch_rows(sql)
         execute(sql) do |result|
           i = -1

data/lib/sequel/adapters/tinytds.rb

@@ -1,7 +1,7 @@
 # frozen-string-literal: true
 
 require 'tiny_tds'
-Sequel.require 'adapters/shared/mssql'
+require_relative 'shared/mssql'
 
 module Sequel
   module TinyTDS
@@ -59,7 +59,7 @@ module Sequel
             else
               log_connection_yield(sql, c) do
                 r = c.execute(sql)
-                return r.send(m) if m
+                return r.public_send(m) if m
               end
             end
             yield(r) if block_given?
@@ -71,22 +71,18 @@ module Sequel
         end
       end
 
-      # Return the number of rows modified by the given +sql+.
       def execute_dui(sql, opts=OPTS)
         opts = Hash[opts]
         opts[:return] = :do
         execute(sql, opts)
       end
 
-      # Return the value of the autogenerated primary key (if any)
-      # for the row inserted by the given +sql+.
       def execute_insert(sql, opts=OPTS)
         opts = Hash[opts]
         opts[:return] = :insert
         execute(sql, opts)
       end
 
-      # Execute the DDL +sql+ on the database and return nil.
       def execute_ddl(sql, opts=OPTS)
         opts = Hash[opts]
         opts[:return] = :each
@@ -135,9 +131,6 @@ module Sequel
         Dataset
       end
 
-      TINYTDS_DISCONNECT_ERRORS = /\A(Attempt to initiate a new Adaptive Server operation with results pending|The request failed to run because the batch is aborted, this can be caused by abort signal sent from client|Adaptive Server connection timed out)/
-      Sequel::Deprecation.deprecate_constant(self, :TINYTDS_DISCONNECT_ERRORS)
-
       # Return true if the :conn argument is present and not active.
       def disconnect_error?(e, opts)
         super || (opts[:conn] && !opts[:conn].active?) || ((e.is_a?(::TinyTds::Error) && /\A(Attempt to initiate a new Adaptive Server operation with results pending|The request failed to run because the batch is aborted, this can be caused by abort signal sent from client|Adaptive Server connection timed out)/.match(e.message)))
@@ -185,9 +178,6 @@ module Sequel
     class Dataset < Sequel::Dataset
       include Sequel::MSSQL::DatasetMethods
 
-      Database::DatasetClass = self
-      Sequel::Deprecation.deprecate_constant(Database, :DatasetClass)
-      
       module ArgumentMapper
         include Sequel::Dataset::ArgumentMapper
         
@@ -213,10 +203,10 @@ module Sequel
       
       PreparedStatementMethods = prepared_statements_module("sql = prepared_sql; opts = Hash[opts]; opts[:arguments] = bind_arguments", ArgumentMapper)
     
-      # Yield hashes with symbol keys, attempting to optimize for
-      # various cases.
       def fetch_rows(sql)
         execute(sql) do |result|
+          # Mutating an array in the result is questionable, but supported
+          # by tiny_tds developers (tiny_tds issue #57)
           columns = result.fields.map!{|c| output_identifier(c)}
           if columns.empty?
             args = []
@@ -247,7 +237,7 @@ module Sequel
       
       private
       
-      # Properly escape the given string +v+.
+      # Properly escape the given string
       def literal_string_append(sql, v)
         sql << (mssql_unicode_strings ? "N'" : "'")
         sql << db.synchronize(@opts[:server]){|c| c.escape(v)}.gsub(/\\((?:\r\n)|\n)/, '\\\\\\\\\\1\\1') << "'"

data/lib/sequel/adapters/utils/emulate_offset_with_row_number.rb

@@ -7,7 +7,7 @@ module Sequel
     # when ordering.
     def empty?
       return super unless emulate_offset_with_row_number?
-      get(Sequel::SQL::AliasedExpression.new(1, :one)).nil?
+      select(Dataset::EMPTY_SELECT).limit(1).single_value!.nil?
     end
 
     # Emulate OFFSET support with the ROW_NUMBER window function

data/lib/sequel/adapters/utils/mysql_mysql2.rb

@@ -1,6 +1,7 @@
 # frozen-string-literal: true
 
-Sequel.require %w'shared/mysql utils/stored_procedures', 'adapters'
+require_relative '../shared/mysql'
+require_relative 'stored_procedures'
 
 module Sequel
   module MySQL
@@ -47,9 +48,6 @@ module Sequel
           conn.prepared_statements = {}
         end
 
-        # Stupid MySQL doesn't use SQLState error codes correctly, mapping
-        # all constraint violations to 23000 even though it recognizes
-        # different types.
         def database_specific_error_class(exception, opts)
           case exception.errno
           when 1048
@@ -58,6 +56,8 @@ module Sequel
             UniqueConstraintViolation
           when 1451, 1452
             ForeignKeyConstraintViolation
+          when 4025
+            CheckConstraintViolation
           else
             super
           end

data/lib/sequel/adapters/utils/mysql_prepared_statements.rb

@@ -8,10 +8,9 @@ module Sequel
 
         # Executes a prepared statement on an available connection.  If the
         # prepared statement already exists for the connection and has the same
-        # SQL, reuse it, otherwise, prepare the new statement.  Because of the
-        # usual MySQL stupidity, we are forced to name arguments via separate
-        # SET queries.  Use @sequel_arg_N (for N starting at 1) for these
-        # arguments.
+        # SQL, reuse it, otherwise, prepare the new statement.  Issue a SET
+        # query with literalized values for each argument, then an EXECUTE to
+        # execute the query with the arguments.
         def execute_prepared_statement(ps_name, opts, &block)
           args = opts[:arguments]
           ps = prepared_statement(ps_name)
@@ -30,8 +29,6 @@ module Sequel
       end
 
       module DatasetMethods
-        # Methods to add to MySQL prepared statement calls without using a
-        # real database prepared statement and bound variables.
         module CallableStatementMethods
           # Extend given dataset with this module so subselects inside subselects in
           # prepared statements work.