sequel 4.49.0 → 5.0.0

data/spec/extensions/update_refresh_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe "Sequel::Plugins::UpdateRefresh" do
   before do

data/spec/extensions/uuid_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe "Sequel::Plugins::Uuid" do
   before do
@@ -37,18 +37,16 @@ describe "Sequel::Plugins::Uuid" do
     o.uuid.must_equal @uuid
   end
 
-  if RUBY_VERSION >= '1.9'
-    it "should allow specifying the uuid field via the :field option" do
-      c = Class.new(Sequel::Model(:t))
-      c.class_eval do
-        columns :id, :u
-        plugin :uuid, :field=>:u
-        def _save_refresh(*) end
-      end
-      o = c.create
-      c.db.sqls.first.must_match(/INSERT INTO t \(u\) VALUES \('[-0-9a-f]+'\)/)
-      o.u.must_match(/[-0-9a-f]+/)
+  it "should allow specifying the uuid field via the :field option" do
+    c = Class.new(Sequel::Model(:t))
+    c.class_eval do
+      columns :id, :u
+      plugin :uuid, :field=>:u
+      def _save_refresh(*) end
     end
+    o = c.create
+    c.db.sqls.first.must_match(/INSERT INTO t \(u\) VALUES \('[-0-9a-f]+'\)/)
+    o.u.must_match(/[-0-9a-f]+/)
   end
 
   it "should not raise an error if the model doesn't have the uuid column" do

data/spec/extensions/validate_associated_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe "ValidatesAssociated plugin" do
   before do

data/spec/extensions/validation_class_methods_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 model_class = proc do |klass, &block|
   c = Class.new(klass)
@@ -158,7 +158,7 @@ describe Sequel::Model do
     c.must_equal false
     @c.validates{c = respond_to?(:length_of)}
     c.must_equal true
-  end if RUBY_VERSION >= '1.9'
+  end
 end
 
 describe Sequel::Model do
@@ -197,7 +197,7 @@ describe "Sequel::Plugins::ValidationClassMethods::ClassMethods::Generator" do
     @testit = testit = []
     
     @c = model_class.call Sequel::Model do
-      (class << self; self end).send(:define_method, :validates_blah) do
+      singleton_class.send(:define_method, :validates_blah) do
         testit << 1324
       end
     end

data/spec/extensions/validation_contexts_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe "Sequel::Plugins::ValidationHelpers" do
   before do

data/spec/extensions/validation_helpers_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe "Sequel::Plugins::ValidationHelpers" do
   before do
@@ -19,9 +19,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
     @m.value = '1_1'
     @m.must_be :valid?
     o = String.new
-    class << o
-      undef_method :blank?
-    end
+    o.singleton_class.send(:undef_method, :blank?)
     @m.value = o
     @m.must_be :valid?
     o = Object.new
@@ -86,38 +84,6 @@ describe "Sequel::Plugins::ValidationHelpers" do
     @m.must_be :valid?
   end
   
-  deprecated "should support modifying default options for all models" do
-    @c.set_validations{validates_presence(:value)}
-    @m.wont_be :valid?
-    @m.errors.must_equal(:value=>['is not present'])
-    o = Sequel::Plugins::ValidationHelpers::DEFAULT_OPTIONS[:presence].dup
-    Sequel::Plugins::ValidationHelpers::DEFAULT_OPTIONS[:presence][:message] = lambda{"was not entered"}
-    @m.wont_be :valid?
-    @m.errors.must_equal(:value=>["was not entered"])
-    @m.value = 1
-    @m.must_be :valid?
-    
-    @m.values.clear
-    Sequel::Plugins::ValidationHelpers::DEFAULT_OPTIONS[:presence][:allow_missing] = true
-    @m.must_be :valid?
-    @m.value = nil
-    @m.wont_be :valid?
-    @m.errors.must_equal(:value=>["was not entered"])
-
-    c = Class.new(Sequel::Model)
-    c.class_eval do
-      plugin :validation_helpers
-      set_columns([:value])
-      def validate
-        validates_presence(:value)
-      end
-    end
-    m = c.new(:value=>nil)
-    m.wont_be :valid?
-    m.errors.must_equal(:value=>["was not entered"])
-    Sequel::Plugins::ValidationHelpers::DEFAULT_OPTIONS[:presence] = o
-  end
-  
   it "should support modifying default validation options for a particular model" do
     @c.set_validations{validates_presence(:value)}
     @m.wont_be :valid?
@@ -369,7 +335,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
   it "should support validates_unique with a single attribute" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
-    @c.set_validations{validates_unique(:username)}
+    @c.set_validations{validates_unique(:username, :only_if_modified=>false)}
     @c.dataset = @c.dataset.with_fetch(proc do |sql|
       case sql
       when /count.*username = '0records'/
@@ -407,7 +373,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
   it "should support validates_unique with multiple attributes" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
-    @c.set_validations{validates_unique([:username, :password])}
+    @c.set_validations{validates_unique([:username, :password], :only_if_modified=>false)}
     @c.dataset = @c.dataset.with_fetch(proc do |sql|
       case sql
       when /count.*username = '0records'/
@@ -452,7 +418,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
   it "should support validates_unique with a block" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
-    @c.set_validations{validates_unique(:username){|ds| ds.filter(:active)}}
+    @c.set_validations{validates_unique(:username, :only_if_modified=>false){|ds| ds.filter(:active)}}
     @c.dataset = @c.dataset.with_fetch(:v=>0)
     
     DB.reset
@@ -465,7 +431,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
   it "should support validates_unique with :where option" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
-    @c.set_validations{validates_unique(:username, :where=>proc{|ds, obj, cols| ds.where(cols.map{|c| [Sequel.function(:lower, c), obj.send(c).downcase]})})}
+    @c.set_validations{validates_unique(:username, :only_if_modified=>false, :where=>proc{|ds, obj, cols| ds.where(cols.map{|c| [Sequel.function(:lower, c), obj.send(c).downcase]})})}
     @c.dataset = @c.dataset.with_fetch(:v=>0)
     
     DB.reset
@@ -479,7 +445,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
     c = @c
-    @c.set_validations{validates_unique(:username, :dataset=>c.where(:a=>[1,2,3]))}
+    @c.set_validations{validates_unique(:username, :only_if_modified=>false, :dataset=>c.where(:a=>[1,2,3]))}
     @c.dataset = @c.dataset.with_fetch(:v=>0)
     
     DB.reset
@@ -493,7 +459,7 @@ describe "Sequel::Plugins::ValidationHelpers" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
     c = @c
-    @c.set_validations{validates_unique(:username, :dataset=>c.cross_join(:a))}
+    @c.set_validations{validates_unique(:username, :only_if_modified=>false, :dataset=>c.cross_join(:a))}
     @c.dataset = @c.dataset.with_fetch(:v=>0)
     
     DB.reset
@@ -503,10 +469,10 @@ describe "Sequel::Plugins::ValidationHelpers" do
                     "SELECT count(*) AS count FROM items CROSS JOIN a WHERE ((username = '0records') AND (items.id != 3)) LIMIT 1"]
   end
 
-  it "should support :only_if_modified option for validates_unique, and not check uniqueness for existing records if values haven't changed" do
+  it "should not have validates_unique check uniqueness for existing records if values haven't changed" do
     @c.columns(:id, :username, :password)
     @c.set_dataset DB[:items]
-    @c.set_validations{validates_unique([:username, :password], :only_if_modified=>true)}
+    @c.set_validations{validates_unique([:username, :password])}
     @c.dataset = @c.dataset.with_fetch(:v=>0)
     
     DB.reset

data/spec/extensions/whitelist_security_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 describe Sequel::Model, "#(set|update)_(all|only)" do
   before do
@@ -16,7 +16,7 @@ describe Sequel::Model, "#(set|update)_(all|only)" do
   it "should raise errors if not all hash fields can be set and strict_param_setting is true" do
     @c.strict_param_setting = true
 
-    proc{@c.new.set_all(:x => 1, :y => 2, :z=>3, :use_after_commit_rollback => false)}.must_raise(Sequel::MassAssignmentRestriction)
+    proc{@c.new.set_all(:x => 1, :y => 2, :z=>3, :use_transactions => false)}.must_raise(Sequel::MassAssignmentRestriction)
     (o = @c.new).set_all(:x => 1, :y => 2, :z=>3)
     o.values.must_equal(:x => 1, :y => 2, :z=>3)
 
@@ -32,9 +32,9 @@ describe Sequel::Model, "#(set|update)_(all|only)" do
   end
 
   it "#set_all should set not set restricted fields" do
-    @o1.use_after_commit_rollback.must_be_nil
-    @o1.set_all(:x => 1, :use_after_commit_rollback => true)
-    @o1.use_after_commit_rollback.must_be_nil
+    @o1.use_transactions.must_equal false 
+    @o1.set_all(:x => 1, :use_transactions => true)
+    @o1.use_transactions.must_equal false
     @o1.values.must_equal(:x => 1)
   end
 

data/spec/extensions/xml_serializer_spec.rb

@@ -1,9 +1,9 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), "spec_helper")
+require_relative "spec_helper"
 
 begin
   require 'nokogiri'
-rescue LoadError => e
-  skip_warn "xml_serializer plugin: can't load nokogiri (#{e.class}: #{e})"
+rescue LoadError
+  warn "Skipping test of xml_serializer plugin: can't load nokogiri"
 else
 describe "Sequel::Plugins::XmlSerializer" do
   before do

data/spec/guards_helper.rb

@@ -3,7 +3,7 @@ require 'minitest/autorun'
 require 'minitest/hooks/default'
 require 'minitest/shared_description'
 
-require "#{File.dirname(__FILE__)}/deprecation_helper.rb"
+require_relative "deprecation_helper"
 
 def Sequel.guarded?(*checked)
   unless ENV['SEQUEL_NO_PENDING']
@@ -36,6 +36,7 @@ module Minitest::Spec::DSL
   def cspecify(message, *checked, &block)
     if pending = Sequel.guarded?(*checked)
       it(message) do
+        proc{instance_exec(&block)}.must_raise(Exception) if ENV['SEQUEL_CHECK_PENDING']
         skip "Not yet working on #{Array(pending).map{|x| x.is_a?(Proc) ? :proc : x}.join(', ')}"
       end
     else

data/spec/integration/associations_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), 'spec_helper.rb')
+require_relative "spec_helper"
 
 OneToOneEagerLimitStrategies = shared_description do
   it "eager loading one_to_one associations should work correctly" do
@@ -1587,28 +1587,6 @@ BasicRegularAndCompositeKeyAssociations = shared_description do
     @album.reload.alias_tags.must_equal []
   end
   
-  it "should work correctly with prepared_statements_association plugin" do
-    deprecated do
-      @album.update(:artist => @artist)
-      @album.add_tag(@tag)
-      
-      @album.reload
-      @artist.reload
-      @tag.reload
-      
-      [Tag, Album, Artist].each{|x| x.plugin :prepared_statements_associations}
-      @album.artist.must_equal @artist
-      @artist.first_album.must_equal @album
-      @artist.albums.must_equal [@album]
-      @album.tags.must_equal [@tag]
-      @album.alias_tags.must_equal [@tag]
-      @tag.albums.must_equal [@album]
-      unless @no_many_through_many
-        @album.first_tag.must_equal @tag
-      end
-    end
-  end
-
   it "should have working dataset associations" do
     album, artist, tag = @pr.call
 

data/spec/integration/database_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), 'spec_helper.rb')
+require_relative "spec_helper"
 
 describe Sequel::Database do
   before do
@@ -37,7 +37,7 @@ describe Sequel::Database do
       @db.drop_table?(:test2, :test)
     end
 
-    cspecify "should raise Sequel::UniqueConstraintViolation when a unique constraint is violated", [:jdbc, :sqlite], [:db2] do
+    cspecify "should raise Sequel::UniqueConstraintViolation when a unique constraint is violated", [:jdbc, :sqlite] do
       @db.create_table!(:test){String :a, :unique=>true, :null=>false}
       @db[:test].insert('1')
       proc{@db[:test].insert('1')}.must_raise(Sequel::UniqueConstraintViolation)
@@ -45,7 +45,7 @@ describe Sequel::Database do
       proc{@db[:test].update(:a=>'1')}.must_raise(Sequel::UniqueConstraintViolation)
     end
 
-    cspecify "should raise Sequel::UniqueConstraintViolation when a unique constraint is violated for composite primary keys", [:jdbc, :sqlite], [:db2] do
+    cspecify "should raise Sequel::UniqueConstraintViolation when a unique constraint is violated for composite primary keys", [:jdbc, :sqlite] do
       @db.create_table!(:test){String :a; String :b; primary_key [:a, :b]}
       @db[:test].insert(:a=>'1', :b=>'2')
       proc{@db[:test].insert(:a=>'1', :b=>'2')}.must_raise(Sequel::UniqueConstraintViolation)
@@ -53,14 +53,14 @@ describe Sequel::Database do
       proc{@db[:test].update(:a=>'1', :b=>'2')}.must_raise(Sequel::UniqueConstraintViolation)
     end
 
-    cspecify "should raise Sequel::CheckConstraintViolation when a check constraint is violated", :mysql, [:db2], [proc{|db| db.sqlite_version < 30802}, :sqlite] do
+    cspecify "should raise Sequel::CheckConstraintViolation when a check constraint is violated", :mysql, [proc{|db| db.sqlite_version < 30802}, :sqlite] do
       @db.create_table!(:test){String :a; check Sequel.~(:a=>'1')}
       proc{@db[:test].insert('1')}.must_raise(Sequel::CheckConstraintViolation)
       @db[:test].insert('2')
       proc{@db[:test].insert('1')}.must_raise(Sequel::CheckConstraintViolation)
     end
 
-    cspecify "should raise Sequel::ForeignKeyConstraintViolation when a foreign key constraint is violated", [:jdbc, :sqlite], [:db2]  do
+    cspecify "should raise Sequel::ForeignKeyConstraintViolation when a foreign key constraint is violated", [:jdbc, :sqlite]  do
       @db.create_table!(:test, :engine=>:InnoDB){primary_key :id}
       @db.create_table!(:test2, :engine=>:InnoDB){foreign_key :tid, :test}
       proc{@db[:test2].insert(:tid=>1)}.must_raise(Sequel::ForeignKeyConstraintViolation)
@@ -70,7 +70,7 @@ describe Sequel::Database do
       proc{@db[:test].where(:id=>1).delete}.must_raise(Sequel::ForeignKeyConstraintViolation)
     end
 
-    cspecify "should raise Sequel::NotNullConstraintViolation when a not null constraint is violated", [:jdbc, :sqlite], [:db2] do
+    cspecify "should raise Sequel::NotNullConstraintViolation when a not null constraint is violated", [:jdbc, :sqlite] do
       @db.create_table!(:test){Integer :a, :null=>false}
       proc{@db[:test].insert(:a=>nil)}.must_raise(Sequel::NotNullConstraintViolation)
       unless @db.database_type == :mysql
@@ -104,7 +104,7 @@ describe Sequel::Database do
     @db.disconnect_connection(conn)
   end
 
-  cspecify "should provide ability to check connections for validity", [:do, :postgres] do
+  it "should provide ability to check connections for validity" do
     conn = @db.synchronize{|c| c}
     @db.valid_connection?(conn).must_equal true
     @db.disconnect

data/spec/integration/dataset_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.expand_path(__FILE__)), 'spec_helper.rb')
+require_relative "spec_helper"
 
 describe "Simple Dataset operations" do
   before do
@@ -49,12 +49,6 @@ describe "Simple Dataset operations" do
     @ds.filter(:id=>2).first[:number].must_equal 20
   end
 
-  deprecated "should have insert_multiple return primary key values" do
-    @ds.extension(:sequel_3_dataset_methods).insert_multiple([{:number=>20}, {:number=>30}]).must_equal [2, 3]
-    @ds.filter(:id=>2).get(:number).must_equal 20
-    @ds.filter(:id=>3).get(:number).must_equal 30
-  end
-
   it "should join correctly" do
     @ds.join(Sequel[:items].as(:b), :id=>:id).select_all(:items).all.must_equal [{:id=>1, :number=>10}]
   end
@@ -108,7 +102,7 @@ describe "Simple Dataset operations" do
     @ds.all.must_equal [{:id=>1, :number=>11}]
   end
   
-  cspecify "should have update return the number of matched rows", [:do, :mysql] do
+  it "should have update return the number of matched rows" do
     @ds.update(:number=>:number).must_equal 1
     @ds.filter(:id=>1).update(:number=>:number).must_equal 1
     @ds.filter(:id=>2).update(:number=>:number).must_equal 0
@@ -171,7 +165,7 @@ describe "Simple Dataset operations" do
     @ds.all.must_equal [{:id=>1, :number=>10}]
   end
 
-  cspecify "should skip locked rows correctly", [:do] do
+  it "should skip locked rows correctly" do
     @ds.insert(:number=>10)
     q1 = Queue.new
     q2 = Queue.new
@@ -927,13 +921,13 @@ describe Sequel::SQL::Constants do
     (Time.now - @c[@ds.get(:t)]).must_be_close_to 0, 60
   end
 
-  cspecify "should have working CURRENT_TIMESTAMP", [:jdbc, :sqlite], [:swift] do
+  cspecify "should have working CURRENT_TIMESTAMP", [:jdbc, :sqlite] do
     @db.create_table!(:constants){DateTime :ts}
     @ds.insert(:ts=>Sequel::CURRENT_TIMESTAMP)
     (Time.now - @c[@ds.get(:ts)]).must_be_close_to 0, 60
   end
 
-  cspecify "should have working CURRENT_TIMESTAMP when used as a column default", [:jdbc, :sqlite], [:swift] do
+  cspecify "should have working CURRENT_TIMESTAMP when used as a column default", [:jdbc, :sqlite] do
     @db.create_table!(:constants){DateTime :ts, :default=>Sequel::CURRENT_TIMESTAMP}
     @ds.insert
     (Time.now - @c[@ds.get(:ts)]).must_be_close_to 0, 60
@@ -1055,12 +1049,6 @@ describe "Sequel::Dataset convenience methods" do
     @db.drop_table?(:a)
   end
   
-  deprecated "#[]= should update matching rows" do
-    @ds.insert(20, 10)
-    @ds.extension(:sequel_3_dataset_methods)[:a=>20] = {:b=>30}
-    @ds.all.must_equal [{:a=>20, :b=>30}]
-  end
-  
   it "#empty? should return whether the dataset returns no rows" do
     @ds.empty?.must_equal true
     @ds.insert(20, 10)
@@ -1751,36 +1739,6 @@ describe "Dataset identifier methods" do
   end
 end if IDENTIFIER_MANGLING
 
-describe "Dataset defaults and overrides" do
-  before(:all) do
-    @db = DB
-    @db.create_table!(:a){Integer :a}
-    deprecated do
-      @ds = @db[:a].order(:a).extension(:set_overrides)
-    end
-  end
-  before do
-    @ds.delete
-  end
-  after(:all) do
-    @db.drop_table?(:a)
-  end
-  
-  it "#set_defaults should set defaults that can be overridden" do
-    @ds = @ds.set_defaults(:a=>10)
-    @ds.insert
-    @ds.insert(:a=>20)
-    @ds.all.must_equal [{:a=>10}, {:a=>20}]
-  end
-  
-  it "#set_overrides should set defaults that cannot be overridden" do
-    @ds = @ds.set_overrides(:a=>10)
-    @ds.insert
-    @ds.insert(:a=>20)
-    @ds.all.must_equal [{:a=>10}, {:a=>10}]
-  end
-end
-
 if DB.dataset.supports_modifying_joins?
   describe "Modifying joined datasets" do
     before do