sequel 4.36.0 → 5.61.0

data/lib/sequel/extensions/pg_array.rb

@@ -32,7 +32,7 @@
 #
 # So if you want to insert an array into an integer[] database column:
 #
-#   DB[:table].insert(:column=>Sequel.pg_array([1, 2, 3]))
+#   DB[:table].insert(column: Sequel.pg_array([1, 2, 3]))
 #
 # To use this extension, first load it into your Sequel::Database instance:
 #
@@ -45,12 +45,10 @@
 # all scalar types that the native postgres adapter handles. It
 # also makes it easy to add support for other array types.  In
 # general, you just need to make sure that the scalar type is
-# handled and has the appropriate converter installed in
-# Sequel::Postgres::PG_TYPES or the Database instance's
-# conversion_procs usingthe appropriate type OID.  For user defined
+# handled and has the appropriate converter installed. For user defined
 # types, you can do this via:
 #
-#   DB.conversion_procs[scalar_type_oid] = lambda{|string| }
+#   DB.add_conversion_proc(scalar_type_oid){|string| }
 #
 # Then you can call
 # Sequel::Postgres::PGArray::DatabaseMethods#register_array_type
@@ -60,18 +58,6 @@
 #
 #   DB.register_array_type('foo')
 #
-# You can also register array types on a global basis using
-# Sequel::Postgres::PGArray.register.  In this case, you'll have
-# to specify the type oids:
-#
-#   Sequel::Postgres::PG_TYPES[1234] = lambda{|string| }
-#   Sequel::Postgres::PGArray.register('foo', :oid=>4321, :scalar_oid=>1234)
-#
-# Both Sequel::Postgres::PGArray::DatabaseMethods#register_array_type
-# and Sequel::Postgres::PGArray.register support many options to
-# customize the array type handling.  See the Sequel::Postgres::PGArray.register
-# method documentation.
-#
 # While this extension can parse PostgreSQL arrays with explicit bounds, it
 # currently ignores explicit bounds, so such values do not round
 # trip.
@@ -79,13 +65,12 @@
 # If you want an easy way to call PostgreSQL array functions and
 # operators, look into the pg_array_ops extension.
 #
-# This extension requires the strscan and delegate libraries.
+# This extension requires the delegate library, and the strscan library
+# sequel_pg has not been loaded.
 #
 # Related module: Sequel::Postgres::PGArray
 
 require 'delegate'
-require 'strscan'
-Sequel.require 'adapters/utils/pg_types'
 
 module Sequel
   module Postgres
@@ -93,122 +78,64 @@ module Sequel
     class PGArray < DelegateClass(Array)
       include Sequel::SQL::AliasMethods
 
-      ARRAY = "ARRAY".freeze
-      DOUBLE_COLON = '::'.freeze
-      EMPTY_ARRAY = "'{}'".freeze
-      EMPTY_BRACKET = '[]'.freeze
-      OPEN_BRACKET = '['.freeze
-      CLOSE_BRACKET = ']'.freeze
-      COMMA = ','.freeze
-      BACKSLASH = '\\'.freeze
-      EMPTY_STRING = ''.freeze
-      OPEN_BRACE = '{'.freeze
-      CLOSE_BRACE = '}'.freeze
-      NULL = 'NULL'.freeze
-      QUOTE = '"'.freeze
-
-      # Global hash of database array type name strings to symbols (e.g. 'double precision' => :float),
-      # used by the schema parsing for array types registered globally.
-      ARRAY_TYPES = {}
-
-      # Registers an array type that the extension should handle.  Makes a Database instance that
-      # has been extended with DatabaseMethods recognize the array type given and set up the
-      # appropriate typecasting.  Also sets up automatic typecasting for the native postgres
-      # adapter, so that on retrieval, the values are automatically converted to PGArray instances.
-      # The db_type argument should be the exact database type used (as returned by the PostgreSQL
-      # format_type database function).  Accepts the following options:
-      #
-      # :array_type :: The type to automatically cast the array to when literalizing the array.
-      #                Usually the same as db_type.
-      # :converter :: A callable object (e.g. Proc), that is called with each element of the array
-      #               (usually a string), and should return the appropriate typecasted object.
-      # :oid :: The PostgreSQL OID for the array type.  This is used by the Sequel postgres adapter
-      #         to set up automatic type conversion on retrieval from the database.
-      # :scalar_oid :: Should be the PostgreSQL OID for the scalar version of this array type. If given,
-      #                automatically sets the :converter option by looking for scalar conversion
-      #                proc.
-      # :scalar_typecast :: Should be a symbol indicating the typecast method that should be called on
-      #                     each element of the array, when a plain array is passed into a database
-      #                     typecast method.  For example, for an array of integers, this could be set to
-      #                     :integer, so that the typecast_value_integer method is called on all of the
-      #                     array elements.  Defaults to :type_symbol option.
-      # :type_procs :: A hash mapping oids to conversion procs, used for looking up the :scalar_oid and
-      #                value and setting the :oid value.  Defaults to the global Sequel::Postgres::PG_TYPES.
-      # :type_symbol :: The base of the schema type symbol for this type.  For example, if you provide
-      #                 :integer, Sequel will recognize this type as :integer_array during schema parsing.
-      #                 Defaults to the db_type argument.
-      # :typecast_method_map :: The map in which to place the database type string to type symbol mapping.
-      #                         Defaults to ARRAY_TYPES.
-      # :typecast_methods_module :: If given, a module object to add the typecasting method to.  Defaults
-      #                             to DatabaseMethods.
-      #
-      # If a block is given, it is treated as the :converter option.
-      def self.register(db_type, opts=OPTS, &block)
-        db_type = db_type.to_s
-        type = (opts[:type_symbol] || db_type).to_sym
-        type_procs = opts[:type_procs] || PG_TYPES
-        mod = opts[:typecast_methods_module] || DatabaseMethods
-        typecast_method_map = opts[:typecast_method_map] || ARRAY_TYPES
-
-        if converter = opts[:converter]
-          raise Error, "can't provide both a block and :converter option to register" if block
-        else
-          converter = block
-        end
-
-        if soid = opts[:scalar_oid]
-          raise Error, "can't provide both a converter and :scalar_oid option to register" if converter 
-          converter = type_procs[soid]
-        end
-
-        array_type = (opts[:array_type] || db_type).to_s.dup.freeze
-        creator = Creator.new(array_type, converter)
-
-        typecast_method_map[db_type] = :"#{type}_array"
-
-        define_array_typecast_method(mod, type, creator, opts.fetch(:scalar_typecast, type))
-
-        if oid = opts[:oid]
-          type_procs[oid] = creator
-        end
-
-        nil
-      end
-
-      # Define a private array typecasting method in the given module for the given type that uses
-      # the creator argument to do the type conversion.
-      def self.define_array_typecast_method(mod, type, creator, scalar_typecast)
-        mod.class_eval do
-          meth = :"typecast_value_#{type}_array"
-          scalar_typecast_method = :"typecast_value_#{scalar_typecast}"
-          define_method(meth){|v| typecast_value_pg_array(v, creator, scalar_typecast_method)}
-          private meth
-        end
-      end
-      private_class_method :define_array_typecast_method
-
       module DatabaseMethods
-        APOS = "'".freeze
-        DOUBLE_APOS = "''".freeze
-        ESCAPE_RE = /("|\\)/.freeze
-        ESCAPE_REPLACEMENT = '\\\\\1'.freeze
         BLOB_RANGE = 1...-1
 
         # Create the local hash of database type strings to schema type symbols,
         # used for array types local to this database.
         def self.extended(db)
-          db.instance_eval do
+          db.instance_exec do
             @pg_array_schema_types ||= {}
-            procs = conversion_procs
-            procs[1115] = Creator.new("timestamp without time zone", procs[1114])
-            procs[1185] = Creator.new("timestamp with time zone", procs[1184])
-            copy_conversion_procs([143, 791, 1000, 1001, 1003, 1005, 1006, 1007, 1009, 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1021, 1022, 1028, 1182, 1183, 1231, 1270, 1561, 1563, 2951])
+            register_array_type('timestamp without time zone', :oid=>1115, :scalar_oid=>1114, :type_symbol=>:datetime)
+            register_array_type('timestamp with time zone', :oid=>1185, :scalar_oid=>1184, :type_symbol=>:datetime_timezone, :scalar_typecast=>:datetime)
+
+            register_array_type('text', :oid=>1009, :scalar_oid=>25, :type_symbol=>:string)
+            register_array_type('integer', :oid=>1007, :scalar_oid=>23)
+            register_array_type('bigint', :oid=>1016, :scalar_oid=>20, :scalar_typecast=>:integer)
+            register_array_type('numeric', :oid=>1231, :scalar_oid=>1700, :type_symbol=>:decimal)
+            register_array_type('double precision', :oid=>1022, :scalar_oid=>701, :type_symbol=>:float)
+
+            register_array_type('boolean', :oid=>1000, :scalar_oid=>16)
+            register_array_type('bytea', :oid=>1001, :scalar_oid=>17, :type_symbol=>:blob)
+            register_array_type('date', :oid=>1182, :scalar_oid=>1082)
+            register_array_type('time without time zone', :oid=>1183, :scalar_oid=>1083, :type_symbol=>:time)
+            register_array_type('time with time zone', :oid=>1270, :scalar_oid=>1266, :type_symbol=>:time_timezone, :scalar_typecast=>:time)
+
+            register_array_type('smallint', :oid=>1005, :scalar_oid=>21, :scalar_typecast=>:integer)
+            register_array_type('oid', :oid=>1028, :scalar_oid=>26, :scalar_typecast=>:integer)
+            register_array_type('real', :oid=>1021, :scalar_oid=>700, :scalar_typecast=>:float)
+            register_array_type('character', :oid=>1014, :converter=>nil, :array_type=>:text, :scalar_typecast=>:string)
+            register_array_type('character varying', :oid=>1015, :converter=>nil, :scalar_typecast=>:string, :type_symbol=>:varchar)
+
+            register_array_type('xml', :oid=>143, :scalar_oid=>142)
+            register_array_type('money', :oid=>791, :scalar_oid=>790)
+            register_array_type('bit', :oid=>1561, :scalar_oid=>1560)
+            register_array_type('bit varying', :oid=>1563, :scalar_oid=>1562, :type_symbol=>:varbit)
+            register_array_type('uuid', :oid=>2951, :scalar_oid=>2950)
+
+            register_array_type('xid', :oid=>1011, :scalar_oid=>28)
+            register_array_type('cid', :oid=>1012, :scalar_oid=>29)
+
+            register_array_type('name', :oid=>1003, :scalar_oid=>19)
+            register_array_type('tid', :oid=>1010, :scalar_oid=>27)
+            register_array_type('int2vector', :oid=>1006, :scalar_oid=>22)
+            register_array_type('oidvector', :oid=>1013, :scalar_oid=>30)
+
             [:string_array, :integer_array, :decimal_array, :float_array, :boolean_array, :blob_array, :date_array, :time_array, :datetime_array].each do |v|
               @schema_type_classes[v] = PGArray
             end
           end
         end
 
+        def add_named_conversion_proc(name, &block)
+          ret = super
+          name = name.to_s if name.is_a?(Symbol)
+          from(:pg_type).where(:typname=>name).select_map([:oid, :typarray]).each do |scalar_oid, array_oid|
+            register_array_type(name, :oid=>array_oid.to_i, :scalar_oid=>scalar_oid.to_i)
+          end
+          ret
+        end
+
         # Handle arrays in bound variables
         def bound_variable_arg(arg, conn)
           case arg
@@ -221,25 +148,76 @@ module Sequel
           end
         end
 
-        # Register a database specific array type.  This can be used to support
-        # different array types per Database.  Use of this method does not
-        # affect global state, unlike PGArray.register.  See PGArray.register for
-        # possible options.
+        # Freeze the pg array schema types to prevent adding new ones.
+        def freeze
+          @pg_array_schema_types.freeze
+          super
+        end
+
+        # Register a database specific array type.  Options:
+        #
+        # :array_type :: The type to automatically cast the array to when literalizing the array.
+        #                Usually the same as db_type.
+        # :converter :: A callable object (e.g. Proc), that is called with each element of the array
+        #               (usually a string), and should return the appropriate typecasted object.
+        # :oid :: The PostgreSQL OID for the array type.  This is used by the Sequel postgres adapter
+        #         to set up automatic type conversion on retrieval from the database.
+        # :scalar_oid :: Should be the PostgreSQL OID for the scalar version of this array type. If given,
+        #                automatically sets the :converter option by looking for scalar conversion
+        #                proc.
+        # :scalar_typecast :: Should be a symbol indicating the typecast method that should be called on
+        #                     each element of the array, when a plain array is passed into a database
+        #                     typecast method.  For example, for an array of integers, this could be set to
+        #                     :integer, so that the typecast_value_integer method is called on all of the
+        #                     array elements.  Defaults to :type_symbol option.
+        # :type_symbol :: The base of the schema type symbol for this type.  For example, if you provide
+        #                 :integer, Sequel will recognize this type as :integer_array during schema parsing.
+        #                 Defaults to the db_type argument.
+        #
+        # If a block is given, it is treated as the :converter option.
         def register_array_type(db_type, opts=OPTS, &block)
-          opts = {:type_procs=>conversion_procs, :typecast_method_map=>@pg_array_schema_types, :typecast_methods_module=>(class << self; self; end)}.merge!(opts)
-          unless (opts.has_key?(:scalar_oid) || block) && opts.has_key?(:oid)
+          oid = opts[:oid]
+          soid = opts[:scalar_oid]
+
+          if has_converter = opts.has_key?(:converter)
+            raise Error, "can't provide both a block and :converter option to register_array_type" if block
+            converter = opts[:converter]
+          else
+            has_converter = true if block
+            converter = block
+          end
+
+          unless (soid || has_converter) && oid
             array_oid, scalar_oid = from(:pg_type).where(:typname=>db_type.to_s).get([:typarray, :oid])
-            opts[:scalar_oid] = scalar_oid unless opts.has_key?(:scalar_oid) || block
-            opts[:oid] = array_oid unless opts.has_key?(:oid)
+            soid ||= scalar_oid unless has_converter
+            oid ||= array_oid
           end
-          PGArray.register(db_type, opts, &block)
-          @schema_type_classes[:"#{opts[:type_symbol] || db_type}_array"] = PGArray
-          conversion_procs_updated
-        end
 
-        # Return PGArray if this type matches any supported array type.
-        def schema_type_class(type)
-          super || (ARRAY_TYPES.each_value{|v| return PGArray if type == v}; nil)
+          db_type = db_type.to_s
+          type = (opts[:type_symbol] || db_type).to_sym
+          typecast_method_map = @pg_array_schema_types
+
+          if soid
+            raise Error, "can't provide both a converter and :scalar_oid option to register" if has_converter 
+            converter = conversion_procs[soid]
+          end
+
+          array_type = (opts[:array_type] || db_type).to_s.dup.freeze
+          creator = Creator.new(array_type, converter)
+          add_conversion_proc(oid, creator)
+
+          typecast_method_map[db_type] = :"#{type}_array"
+
+          singleton_class.class_eval do
+            meth = :"typecast_value_#{type}_array"
+            scalar_typecast_method = :"typecast_value_#{opts.fetch(:scalar_typecast, type)}"
+            define_method(meth){|v| typecast_value_pg_array(v, creator, scalar_typecast_method)}
+            private meth
+            alias_method(meth, meth)
+          end
+
+          @schema_type_classes[:"#{type}_array"] = PGArray
+          nil
         end
 
         private
@@ -248,46 +226,23 @@ module Sequel
         def bound_variable_array(a)
           case a
           when Array
-            "{#{a.map{|i| bound_variable_array(i)}.join(COMMA)}}"
+            "{#{a.map{|i| bound_variable_array(i)}.join(',')}}"
           when Sequel::SQL::Blob
-            "\"#{literal(a)[BLOB_RANGE].gsub(DOUBLE_APOS, APOS).gsub(ESCAPE_RE, ESCAPE_REPLACEMENT)}\""
+            "\"#{literal(a)[BLOB_RANGE].gsub("''", "'").gsub(/("|\\)/, '\\\\\1')}\""
           when Sequel::LiteralString
             a
           when String
-            "\"#{a.gsub(ESCAPE_RE, ESCAPE_REPLACEMENT)}\""
+            "\"#{a.gsub(/("|\\)/, '\\\\\1')}\""
           else
             literal(a)
           end
         end
 
-        # Automatically handle array types for the given named types. 
-        def convert_named_procs_to_procs(named_procs)
-          h = super
-          unless h.empty?
-            from(:pg_type).where(:oid=>h.keys).select_map([:typname, :oid, :typarray]).each do |name, scalar_oid, array_oid|
-              register_array_type(name, :type_procs=>h, :oid=>array_oid.to_i, :scalar_oid=>scalar_oid.to_i)
-            end
-          end
-          h
-        end
-
-        # Manually override the typecasting for timestamp array types so that
-        # they use the database's timezone instead of the global Sequel
-        # timezone.
-        def get_conversion_procs
-          procs = super
-
-          procs[1115] = Creator.new("timestamp without time zone", procs[1114])
-          procs[1185] = Creator.new("timestamp with time zone", procs[1184])
-
-          procs
-        end
-
         # Look into both the current database's array schema types and the global
         # array schema types to get the type symbol for the given database type
         # string.
         def pg_array_schema_type(type)
-          @pg_array_schema_types[type] || ARRAY_TYPES[type]
+          @pg_array_schema_types[type]
         end
 
         # Make the column type detection handle registered array types.
@@ -299,6 +254,17 @@ module Sequel
           end
         end
 
+        # Set the :callable_default value if the default value is recognized as an empty array.
+        def schema_post_process(_)
+          super.each do |a|
+            h = a[1]
+            if h[:default] =~ /\A(?:'\{\}'|ARRAY\[\])::([\w ]+)\[\]\z/
+              type = $1.freeze
+              h[:callable_default] = lambda{Sequel.pg_array([], type)}
+            end
+          end
+        end
+
         # Convert ruby arrays to PostgreSQL arrays when used as default values.
         def column_definition_default_sql(sql, column)
           if (d = column[:default]) && d.is_a?(Array) && !Sequel.condition_specifier?(d)
@@ -335,97 +301,101 @@ module Sequel
         end
       end
 
-      # PostgreSQL array parser that handles PostgreSQL array output format.
-      # Note that does not handle all forms out input that PostgreSQL will
-      # accept, and it will not raise an error for all forms of invalid input.
-      class Parser < StringScanner
-        UNQUOTED_RE = /[{}",]|[^{}",]+/
-        QUOTED_RE = /["\\]|[^"\\]+/
-        NULL_RE = /NULL",/
-        OPEN_RE = /((\[\d+:\d+\])+=)?\{/
-
-        # Set the source for the input, and any converter callable
-        # to call with objects to be created.  For nested parsers
-        # the source may contain text after the end current parse,
-        # which will be ignored.
-        def initialize(source, converter=nil)
-          super(source)
-          @converter = converter 
-          @stack = [[]]
-          @recorded = String.new
-        end
+      unless Sequel::Postgres.respond_to?(:parse_pg_array)
+        require 'strscan'
+
+        # PostgreSQL array parser that handles PostgreSQL array output format.
+        # Note that does not handle all forms out input that PostgreSQL will
+        # accept, and it will not raise an error for all forms of invalid input.
+        class Parser < StringScanner
+          # Set the source for the input, and any converter callable
+          # to call with objects to be created.  For nested parsers
+          # the source may contain text after the end current parse,
+          # which will be ignored.
+          def initialize(source, converter=nil)
+            super(source)
+            @converter = converter 
+            @stack = [[]]
+            @encoding = string.encoding
+            @recorded = String.new.force_encoding(@encoding)
+          end
 
-        # Take the buffer of recorded characters and add it to the array
-        # of entries, and use a new buffer for recorded characters.
-        def new_entry(include_empty=false)
-          if !@recorded.empty? || include_empty
-            entry = @recorded
-            if entry == NULL && !include_empty
-              entry = nil
-            elsif @converter
-              entry = @converter.call(entry)
+          # Take the buffer of recorded characters and add it to the array
+          # of entries, and use a new buffer for recorded characters.
+          def new_entry(include_empty=false)
+            if !@recorded.empty? || include_empty
+              entry = @recorded
+              if entry == 'NULL' && !include_empty
+                entry = nil
+              elsif @converter
+                entry = @converter.call(entry)
+              end
+              @stack.last.push(entry)
+              @recorded = String.new.force_encoding(@encoding)
             end
-            @stack.last.push(entry)
-            @recorded = String.new
           end
-        end
 
-        # Parse the input character by character, returning an array
-        # of parsed (and potentially converted) objects.
-        def parse
-          raise Sequel::Error, "invalid array, empty string" if eos?
-          raise Sequel::Error, "invalid array, doesn't start with {" unless scan(OPEN_RE)
-
-          while !eos?
-            char = scan(UNQUOTED_RE)
-            if char == COMMA
-              # Comma outside quoted string indicates end of current entry
-              new_entry
-            elsif char == QUOTE
-              raise Sequel::Error, "invalid array, opening quote with existing recorded data" unless @recorded.empty?
-              while true
-                char = scan(QUOTED_RE)
-                if char == BACKSLASH
-                  @recorded << getch
-                elsif char == QUOTE
-                  n = peek(1)
-                  raise Sequel::Error, "invalid array, closing quote not followed by comma or closing brace" unless n == COMMA || n == CLOSE_BRACE
-                  break
+          # Parse the input character by character, returning an array
+          # of parsed (and potentially converted) objects.
+          def parse
+            raise Sequel::Error, "invalid array, empty string" if eos?
+            raise Sequel::Error, "invalid array, doesn't start with {" unless scan(/((\[\d+:\d+\])+=)?\{/)
+
+            # :nocov:
+            while !eos?
+            # :nocov:
+              char = scan(/[{}",]|[^{}",]+/)
+              if char == ','
+                # Comma outside quoted string indicates end of current entry
+                new_entry
+              elsif char == '"'
+                raise Sequel::Error, "invalid array, opening quote with existing recorded data" unless @recorded.empty?
+                # :nocov:
+                while true
+                # :nocov:
+                  char = scan(/["\\]|[^"\\]+/)
+                  if char == '\\'
+                    @recorded << getch
+                  elsif char == '"'
+                    n = peek(1)
+                    raise Sequel::Error, "invalid array, closing quote not followed by comma or closing brace" unless n == ',' || n == '}'
+                    break
+                  else
+                    @recorded << char
+                  end
+                end
+                new_entry(true)
+              elsif char == '{'
+                raise Sequel::Error, "invalid array, opening brace with existing recorded data" unless @recorded.empty?
+
+                # Start of new array, add it to the stack
+                new = []
+                @stack.last << new
+                @stack << new
+              elsif char == '}'
+                # End of current array, add current entry to the current array
+                new_entry
+
+                if @stack.length == 1
+                  raise Sequel::Error, "array parsing finished without parsing entire string" unless eos?
+
+                  # Top level of array, parsing should be over.
+                  # Pop current array off stack and return it as result
+                  return @stack.pop
                 else
-                  @recorded << char
+                  # Nested array, pop current array off stack
+                  @stack.pop
                 end
-              end
-              new_entry(true)
-            elsif char == OPEN_BRACE
-              raise Sequel::Error, "invalid array, opening brace with existing recorded data" unless @recorded.empty?
-
-              # Start of new array, add it to the stack
-              new = []
-              @stack.last << new
-              @stack << new
-            elsif char == CLOSE_BRACE
-              # End of current array, add current entry to the current array
-              new_entry
-
-              if @stack.length == 1
-                raise Sequel::Error, "array parsing finished without parsing entire string" unless eos?
-
-                # Top level of array, parsing should be over.
-                # Pop current array off stack and return it as result
-                return @stack.pop
               else
-                # Nested array, pop current array off stack
-                @stack.pop
+                # Add the character to the recorded character buffer.
+                @recorded << char
               end
-            else
-              # Add the character to the recorded character buffer.
-              @recorded << char
             end
-          end
 
-          raise Sequel::Error, "array parsing finished with array unclosed"
+            raise Sequel::Error, "array parsing finished with array unclosed"
+          end
         end
-      end unless Sequel::Postgres.respond_to?(:parse_pg_array)
+      end
 
       # Callable object that takes the input string and parses it using Parser.
       class Creator
@@ -477,13 +447,13 @@ module Sequel
       def sql_literal_append(ds, sql)
         at = array_type
         if empty? && at
-          sql << EMPTY_ARRAY
+          sql << "'{}'"
         else
-          sql << ARRAY
+          sql << "ARRAY"
           _literal_append(sql, ds, to_a)
         end
         if at
-          sql << DOUBLE_COLON << at.to_s << EMPTY_BRACKET
+          sql << '::' << at.to_s << '[]'
         end
       end
 
@@ -493,9 +463,9 @@ module Sequel
       # arrays, surrounding each with [] and interspersing
       # entries with ,.
       def _literal_append(sql, ds, array)
-        sql << OPEN_BRACKET
+        sql << '['
         comma = false
-        commas = COMMA
+        commas = ','
         array.each do |i|
           sql << commas if comma
           if i.is_a?(Array)
@@ -505,44 +475,8 @@ module Sequel
           end
           comma = true
         end
-        sql << CLOSE_BRACKET
+        sql << ']'
       end
-
-      # Register all array types that this extension handles by default.
-
-      register('text', :oid=>1009, :scalar_oid=>25, :type_symbol=>:string)
-      register('integer', :oid=>1007, :scalar_oid=>23)
-      register('bigint', :oid=>1016, :scalar_oid=>20, :scalar_typecast=>:integer)
-      register('numeric', :oid=>1231, :scalar_oid=>1700, :type_symbol=>:decimal)
-      register('double precision', :oid=>1022, :scalar_oid=>701, :type_symbol=>:float)
-
-      register('boolean', :oid=>1000, :scalar_oid=>16)
-      register('bytea', :oid=>1001, :scalar_oid=>17, :type_symbol=>:blob)
-      register('date', :oid=>1182, :scalar_oid=>1082)
-      register('time without time zone', :oid=>1183, :scalar_oid=>1083, :type_symbol=>:time)
-      register('timestamp without time zone', :oid=>1115, :scalar_oid=>1114, :type_symbol=>:datetime)
-      register('time with time zone', :oid=>1270, :scalar_oid=>1083, :type_symbol=>:time_timezone, :scalar_typecast=>:time)
-      register('timestamp with time zone', :oid=>1185, :scalar_oid=>1184, :type_symbol=>:datetime_timezone, :scalar_typecast=>:datetime)
-
-      register('smallint', :oid=>1005, :scalar_oid=>21, :scalar_typecast=>:integer)
-      register('oid', :oid=>1028, :scalar_oid=>26, :scalar_typecast=>:integer)
-      register('real', :oid=>1021, :scalar_oid=>700, :scalar_typecast=>:float)
-      register('character', :oid=>1014, :array_type=>:text, :scalar_typecast=>:string)
-      register('character varying', :oid=>1015, :scalar_typecast=>:string, :type_symbol=>:varchar)
-
-      register('xml', :oid=>143, :scalar_oid=>142)
-      register('money', :oid=>791, :scalar_oid=>790)
-      register('bit', :oid=>1561, :scalar_oid=>1560)
-      register('bit varying', :oid=>1563, :scalar_oid=>1562, :type_symbol=>:varbit)
-      register('uuid', :oid=>2951, :scalar_oid=>2950)
-
-      register('xid', :oid=>1011, :scalar_oid=>28)
-      register('cid', :oid=>1012, :scalar_oid=>29)
-
-      register('name', :oid=>1003, :scalar_oid=>19)
-      register('tid', :oid=>1010, :scalar_oid=>27)
-      register('int2vector', :oid=>1006, :scalar_oid=>22)
-      register('oidvector', :oid=>1013, :scalar_oid=>30)
     end
   end