sequel 3.8.0 → 3.9.0

data/spec/core/dataset_spec.rb

@@ -267,6 +267,33 @@ context "A dataset with multiple tables in its FROM clause" do
   end
 end
 
+context "Dataset#unused_table_alias" do
+  before do
+    @ds = Sequel::Dataset.new(nil).from(:test)
+  end
+  
+  specify "should return given symbol if it hasn't already been used" do
+    @ds.unused_table_alias(:blah).should == :blah
+  end
+
+  specify "should return a symbol specifying an alias that hasn't already been used if it has already been used" do
+    @ds.unused_table_alias(:test).should == :test_0
+    @ds.from(:test, :test_0).unused_table_alias(:test).should == :test_1
+    @ds.from(:test, :test_0).cross_join(:test_1).unused_table_alias(:test).should == :test_2
+  end
+
+  specify "should return an appropriate symbol if given other forms of identifiers" do
+    @ds.unused_table_alias('test').should == :test_0
+    @ds.unused_table_alias(:b__t___test).should == :test_0
+    @ds.unused_table_alias(:b__test).should == :test_0
+    @ds.unused_table_alias(:test.qualify(:b)).should == :test_0
+    @ds.unused_table_alias(:b.as(:test)).should == :test_0
+    @ds.unused_table_alias(:b.as(:test.identifier)).should == :test_0
+    @ds.unused_table_alias(:b.as('test')).should == :test_0
+    @ds.unused_table_alias(:test.identifier).should == :test_0
+  end
+end
+
 context "Dataset#exists" do
   before do
     @ds1 = Sequel::Dataset.new(nil).from(:test)
@@ -419,9 +446,62 @@ context "Dataset#where" do
   specify "should accept a subquery" do
     @dataset.filter('gdp > ?', @d1.select(:avg.sql_function(:gdp))).sql.should ==
       "SELECT * FROM test WHERE (gdp > (SELECT avg(gdp) FROM test WHERE (region = 'Asia')))"
-
-    @dataset.filter(:id => @d1.select(:id)).sql.should ==
-      "SELECT * FROM test WHERE (id IN (SELECT id FROM test WHERE (region = 'Asia')))"
+  end
+  
+  specify "should handle all types of IN/NOT IN queries" do
+    @dataset.filter(:id => @d1.select(:id)).sql.should == "SELECT * FROM test WHERE (id IN (SELECT id FROM test WHERE (region = 'Asia')))"
+    @dataset.filter(:id => []).sql.should == "SELECT * FROM test WHERE (id != id)"
+    @dataset.filter(:id => [1, 2]).sql.should == "SELECT * FROM test WHERE (id IN (1, 2))"
+    @dataset.filter([:id1, :id2] => @d1.select(:id1, :id2)).sql.should == "SELECT * FROM test WHERE ((id1, id2) IN (SELECT id1, id2 FROM test WHERE (region = 'Asia')))"
+    @dataset.filter([:id1, :id2] => []).sql.should == "SELECT * FROM test WHERE ((id1 != id1) AND (id2 != id2))"
+    @dataset.filter([:id1, :id2] => [[1, 2], [3,4]].sql_array).sql.should == "SELECT * FROM test WHERE ((id1, id2) IN ((1, 2), (3, 4)))"
+
+    @dataset.exclude(:id => @d1.select(:id)).sql.should == "SELECT * FROM test WHERE (id NOT IN (SELECT id FROM test WHERE (region = 'Asia')))"
+    @dataset.exclude(:id => []).sql.should == "SELECT * FROM test WHERE (1 = 1)"
+    @dataset.exclude(:id => [1, 2]).sql.should == "SELECT * FROM test WHERE (id NOT IN (1, 2))"
+    @dataset.exclude([:id1, :id2] => @d1.select(:id1, :id2)).sql.should == "SELECT * FROM test WHERE ((id1, id2) NOT IN (SELECT id1, id2 FROM test WHERE (region = 'Asia')))"
+    @dataset.exclude([:id1, :id2] => []).sql.should == "SELECT * FROM test WHERE (1 = 1)"
+    @dataset.exclude([:id1, :id2] => [[1, 2], [3,4]].sql_array).sql.should == "SELECT * FROM test WHERE ((id1, id2) NOT IN ((1, 2), (3, 4)))"
+  end
+
+  specify "should handle IN/NOT IN queries with multiple columns and an array where the database doesn't support it" do
+    @dataset.meta_def(:supports_multiple_column_in?){false}
+    @dataset.filter([:id1, :id2] => []).sql.should == "SELECT * FROM test WHERE ((id1 != id1) AND (id2 != id2))"
+    @dataset.filter([:id1, :id2] => [[1, 2], [3,4]].sql_array).sql.should == "SELECT * FROM test WHERE (((id1 = 1) AND (id2 = 2)) OR ((id1 = 3) AND (id2 = 4)))"
+    @dataset.exclude([:id1, :id2] => []).sql.should == "SELECT * FROM test WHERE (1 = 1)"
+    @dataset.exclude([:id1, :id2] => [[1, 2], [3,4]].sql_array).sql.should == "SELECT * FROM test WHERE (((id1 != 1) OR (id2 != 2)) AND ((id1 != 3) OR (id2 != 4)))"
+  end
+
+  specify "should handle IN/NOT IN queries with multiple columns and a dataset where the database doesn't support it" do
+    @dataset.meta_def(:supports_multiple_column_in?){false}
+    d1 = @d1.select(:id1, :id2)
+    def d1.fetch_rows(sql)
+      @sql_used = sql
+      @columns = [:id1, :id2]
+      yield(:id1=>1, :id2=>2)
+      yield(:id1=>3, :id2=>4)
+    end
+    d1.instance_variable_get(:@sql_used).should == nil
+    @dataset.filter([:id1, :id2] => d1).sql.should == "SELECT * FROM test WHERE (((id1 = 1) AND (id2 = 2)) OR ((id1 = 3) AND (id2 = 4)))"
+    d1.instance_variable_get(:@sql_used).should == "SELECT id1, id2 FROM test WHERE (region = 'Asia')"
+    d1.instance_variable_set(:@sql_used, nil)
+    @dataset.exclude([:id1, :id2] => d1).sql.should == "SELECT * FROM test WHERE (((id1 != 1) OR (id2 != 2)) AND ((id1 != 3) OR (id2 != 4)))"
+    d1.instance_variable_get(:@sql_used).should == "SELECT id1, id2 FROM test WHERE (region = 'Asia')"
+  end
+  
+  specify "should handle IN/NOT IN queries with multiple columns and an empty dataset where the database doesn't support it" do
+    @dataset.meta_def(:supports_multiple_column_in?){false}
+    d1 = @d1.select(:id1, :id2)
+    def d1.fetch_rows(sql)
+      @sql_used = sql
+      @columns = [:id1, :id2]
+    end
+    d1.instance_variable_get(:@sql_used).should == nil
+    @dataset.filter([:id1, :id2] => d1).sql.should == "SELECT * FROM test WHERE ((id1 != id1) AND (id2 != id2))"
+    d1.instance_variable_get(:@sql_used).should == "SELECT id1, id2 FROM test WHERE (region = 'Asia')"
+    d1.instance_variable_set(:@sql_used, nil)
+    @dataset.exclude([:id1, :id2] => d1).sql.should == "SELECT * FROM test WHERE (1 = 1)"
+    d1.instance_variable_get(:@sql_used).should == "SELECT id1, id2 FROM test WHERE (region = 'Asia')"
   end
   
   specify "should accept a subquery for an EXISTS clause" do
@@ -832,6 +912,13 @@ context "Dataset#literal" do
     @dataset.literal(d).should == s
   end
 
+  specify "should literalize Date properly, even if to_s is overridden" do
+    d = Date.today
+    def d.to_s; "adsf" end
+    s = d.strftime("'%Y-%m-%d'")
+    @dataset.literal(d).should == s
+  end
+
   specify "should literalize Time, DateTime, Date properly if SQL standard format is required" do
     @dataset.meta_def(:requires_sql_standard_datetimes?){true}
 
@@ -1276,6 +1363,21 @@ context "Dataset#limit" do
   specify "should include an offset if a second argument is given" do
     @dataset.limit(6, 10).sql.should ==
       'SELECT * FROM test LIMIT 6 OFFSET 10'
+    end
+    
+  specify "should convert regular strings to integers" do
+    @dataset.limit('6', 'a() - 1').sql.should ==
+      'SELECT * FROM test LIMIT 6 OFFSET 0'
+  end
+  
+  specify "should not convert literal strings to integers" do
+    @dataset.limit('6'.lit, 'a() - 1'.lit).sql.should ==
+      'SELECT * FROM test LIMIT 6 OFFSET a() - 1'
+  end
+    
+  specify "should not convert other objects" do
+    @dataset.limit(6, :a.sql_function - 1).sql.should ==
+      'SELECT * FROM test LIMIT 6 OFFSET (a() - 1)'
   end
   
   specify "should work with fixed sql datasets" do
@@ -1852,6 +1954,11 @@ context "Dataset#join_table" do
     proc{@d.join(:categories, :a=>:d).delete_sql}.should raise_error(Sequel::InvalidOperation)
     proc{@d.join(:categories, :a=>:d).truncate_sql}.should raise_error(Sequel::InvalidOperation)
   end
+
+  specify "should raise an error if an invalid option is passed" do
+    proc{@d.join(:c, [:id], nil)}.should raise_error(Sequel::Error)
+    proc{@d.join(:c, [:id], :c.qualify(:d))}.should raise_error(Sequel::Error)
+  end
 end
 
 context "Dataset#[]=" do
@@ -2683,6 +2790,10 @@ context "Dataset#update_sql" do
     @ds.update_sql("a = b").should == "UPDATE items SET a = b"
   end
   
+  specify "should handle implicitly qualified symbols" do
+    @ds.update_sql(:items__a=>:b).should == "UPDATE items SET items.a = b"
+  end
+  
   specify "should accept hash with string keys" do
     @ds.update_sql('c' => 'd').should == "UPDATE items SET c = 'd'"
   end
@@ -3036,7 +3147,7 @@ context Sequel::Dataset::UnnumberedArgumentMapper do
   end
   
   specify "should submitted the SQL to the database with placeholders and bind variables" do
-    @ps.each{|p| p.call(:n=>1)}
+    @ps.each{|p| p.prepared_sql; p.call(:n=>1)}
     @db.sqls.should == [["SELECT * FROM items WHERE (num = ?)", 1],
       ["SELECT * FROM items WHERE (num = ?)", 1],
       ["SELECT * FROM items WHERE (num = ?) LIMIT 1", 1],

data/spec/extensions/active_model_spec.rb

@@ -1,47 +1,53 @@
 require File.join(File.dirname(__FILE__), "spec_helper")
-if (begin
-  require 'active_model'
-  true
-  rescue LoadError
-  end)
+if RUBY_PLATFORM !~ /(win|w)32|java$/
 describe "ActiveModel plugin" do
-  before do
-    @c = Class.new(Sequel::Model) do
-      def delete; end
-    end
-    @c.plugin :active_model
-    @m = @c.new
-    @o = @c.load({})
-  end
-
   specify "should be compliant to the ActiveModel spec" do
     s = ''
     IO.popen('-') do |f|
       if f
         s = f.read
       else
-        ActiveModel::Lint.test(@m)
+        begin
+          require 'active_model'
+        rescue LoadError
+          puts "0 failures, 0 errors"
+        else
+          require 'test/unit'
+          require "test/unit/ui/console/testrunner"
+          class AMLintTest < Test::Unit::TestCase
+            def setup
+              @c = Class.new(Sequel::Model) do
+                def delete; end
+              end
+              @c.plugin :active_model
+              @m = @model = @c.new
+              @o = @c.load({})
+            end
+            include ActiveModel::Lint::Tests
+
+            def test_to_model
+              assert_equal @m.to_model.object_id.should, @m.object_id
+            end
+
+            def test_new_record
+              assert_equal true, @m.new_record?
+              assert_equal false, @o.new_record?
+            end
+
+            def test_destroyed
+              assert_equal false, @m.destroyed?
+              assert_equal false, @o.destroyed?
+              @m.destroy
+              @o.destroy
+              assert_equal true, @m.destroyed?
+              assert_equal true, @o.destroyed?
+            end
+          end
+          Test::Unit::UI::Console::TestRunner.run(AMLintTest)
+        end
       end
     end
     s.should =~ /0 failures, 0 errors/
   end
-  
-  specify "to_model should return self" do
-    @m.to_model.object_id.should == @m.object_id
-  end
-  
-  specify "new_record? should be aliased to new" do
-    @m.new_record?.should == true
-    @o.new_record?.should == false
-  end
-  
-  specify "new_record? should be aliased to new" do
-    @m.destroyed?.should == false
-    @o.destroyed?.should == false
-    @m.destroy
-    @o.destroy
-    @m.destroyed?.should == true
-    @o.destroyed?.should == true
-  end
 end 
-end
+end

data/spec/extensions/boolean_readers_spec.rb

@@ -8,7 +8,7 @@ describe Sequel::Model, "BooleanReaders plugin" do
     end
 
     @c = Class.new(Sequel::Model(@db[:items]))
-    @p =lambda do
+    @p = proc do
       @columns = [:id, :b, :y]
       def columns; @columns; end
     end

data/spec/extensions/migration_spec.rb

@@ -158,13 +158,17 @@ context "Sequel::Migrator" do
     end
     @db = dbc.new
     
-    File.open('001_create_sessions.rb', 'w') {|f| f << MIGRATION_001}
-    File.open('002_create_nodes.rb', 'w') {|f| f << MIGRATION_002}
-    File.open('003_create_users.rb', 'w') {|f| f << MIGRATION_003}
-    File.open('005_5_create_attributes.rb', 'w') {|f| f << MIGRATION_005}
-    Dir.mkdir("alt_app")
-    File.open('alt_app/001_create_alt_basic.rb', 'w') {|f| f << ALT_MIGRATION_001}
-    File.open('alt_app/003_create_alt_advanced.rb', 'w') {|f| f << ALT_MIGRATION_003}
+    @dirname = "migrate_#{$$}"
+    Dir.mkdir(@dirname)
+    File.open("#{@dirname}/001_create_sessions.rb", 'w') {|f| f << MIGRATION_001}
+    File.open("#{@dirname}/002_create_nodes.rb", 'w') {|f| f << MIGRATION_002}
+    File.open("#{@dirname}/003_create_users.rb", 'w') {|f| f << MIGRATION_003}
+    File.open("#{@dirname}/005_5_create_attributes.rb", 'w') {|f| f << MIGRATION_005}
+    
+    @alt_dirname = "migrate_alt_#{$$}"
+    Dir.mkdir(@alt_dirname)
+    File.open("#{@alt_dirname}/001_create_alt_basic.rb", 'w') {|f| f << ALT_MIGRATION_001}
+    File.open("#{@alt_dirname}/003_create_alt_advanced.rb", 'w') {|f| f << ALT_MIGRATION_003}
   end
   
   after do
@@ -175,47 +179,48 @@ context "Sequel::Migrator" do
     Object.send(:remove_const, "CreateAltBasic") if Object.const_defined?("CreateAltBasic")
     Object.send(:remove_const, "CreateAltAdvanced") if Object.const_defined?("CreateAltAdvanced")
 
-    File.delete('001_create_sessions.rb')
-    File.delete('002_create_nodes.rb')
-    File.delete('003_create_users.rb')
-    File.delete('005_5_create_attributes.rb')
-    File.delete("alt_app/001_create_alt_basic.rb")
-    File.delete("alt_app/003_create_alt_advanced.rb")
-    Dir.rmdir("alt_app")
+    File.delete("#{@dirname}/001_create_sessions.rb")
+    File.delete("#{@dirname}/002_create_nodes.rb")
+    File.delete("#{@dirname}/003_create_users.rb")
+    File.delete("#{@dirname}/005_5_create_attributes.rb")
+    Dir.rmdir(@dirname)
+    File.delete("#{@alt_dirname}/001_create_alt_basic.rb")
+    File.delete("#{@alt_dirname}/003_create_alt_advanced.rb")
+    Dir.rmdir(@alt_dirname)
   end
   
   specify "#migration_files should return the list of files for a specified version range" do
-    Sequel::Migrator.migration_files('.', 1..1).should == ['./001_create_sessions.rb']
-    Sequel::Migrator.migration_files('.', 1..3).should == ['./001_create_sessions.rb', './002_create_nodes.rb', './003_create_users.rb']
-    Sequel::Migrator.migration_files('.', 3..6).should == ['./003_create_users.rb', './005_5_create_attributes.rb']
-    Sequel::Migrator.migration_files('.', 7..8).should == []
-    Sequel::Migrator.migration_files('alt_app', 1..1).should == ['alt_app/001_create_alt_basic.rb']
-    Sequel::Migrator.migration_files('alt_app', 1..3).should == ['alt_app/001_create_alt_basic.rb','alt_app/003_create_alt_advanced.rb']
+    Sequel::Migrator.migration_files(@dirname, 1..1).map{|f| File.basename(f)}.should == ['001_create_sessions.rb']
+    Sequel::Migrator.migration_files(@dirname, 1..3).map{|f| File.basename(f)}.should == ['001_create_sessions.rb', '002_create_nodes.rb', '003_create_users.rb']
+    Sequel::Migrator.migration_files(@dirname, 3..6).map{|f| File.basename(f)}.should == ['003_create_users.rb', '005_5_create_attributes.rb']
+    Sequel::Migrator.migration_files(@dirname, 7..8).map{|f| File.basename(f)}.should == []
+    Sequel::Migrator.migration_files(@alt_dirname, 1..1).map{|f| File.basename(f)}.should == ['001_create_alt_basic.rb']
+    Sequel::Migrator.migration_files(@alt_dirname, 1..3).map{|f| File.basename(f)}.should == ['001_create_alt_basic.rb','003_create_alt_advanced.rb']
   end
   
   specify "#latest_migration_version should return the latest version available" do
-    Sequel::Migrator.latest_migration_version('.').should == 5
-    Sequel::Migrator.latest_migration_version('alt_app').should == 3
+    Sequel::Migrator.latest_migration_version(@dirname).should == 5
+    Sequel::Migrator.latest_migration_version(@alt_dirname).should == 3
   end
   
   specify "#migration_classes should load the migration classes for the specified range for the up direction" do
-    Sequel::Migrator.migration_classes('.', 3, 0, :up).should == [CreateSessions, CreateNodes, CreateUsers]
-    Sequel::Migrator.migration_classes('alt_app', 3, 0, :up).should == [CreateAltBasic, CreateAltAdvanced]
+    Sequel::Migrator.migration_classes(@dirname, 3, 0, :up).should == [CreateSessions, CreateNodes, CreateUsers]
+    Sequel::Migrator.migration_classes(@alt_dirname, 3, 0, :up).should == [CreateAltBasic, CreateAltAdvanced]
   end
   
   specify "#migration_classes should load the migration classes for the specified range for the down direction" do
-    Sequel::Migrator.migration_classes('.', 0, 5, :down).should == [CreateAttributes, CreateUsers, CreateNodes, CreateSessions]
-    Sequel::Migrator.migration_classes('alt_app', 0, 3, :down).should == [CreateAltAdvanced, CreateAltBasic]
+    Sequel::Migrator.migration_classes(@dirname, 0, 5, :down).should == [CreateAttributes, CreateUsers, CreateNodes, CreateSessions]
+    Sequel::Migrator.migration_classes(@alt_dirname, 0, 3, :down).should == [CreateAltAdvanced, CreateAltBasic]
   end
   
   specify "#migration_classes should start from current + 1 for the up direction" do
-    Sequel::Migrator.migration_classes('.', 3, 1, :up).should == [CreateNodes, CreateUsers]
-    Sequel::Migrator.migration_classes('alt_app', 3, 2, :up).should == [CreateAltAdvanced]
+    Sequel::Migrator.migration_classes(@dirname, 3, 1, :up).should == [CreateNodes, CreateUsers]
+    Sequel::Migrator.migration_classes(@alt_dirname, 3, 2, :up).should == [CreateAltAdvanced]
   end
   
   specify "#migration_classes should end on current + 1 for the down direction" do
-    Sequel::Migrator.migration_classes('.', 2, 5, :down).should == [CreateAttributes, CreateUsers]
-    Sequel::Migrator.migration_classes('alt_app', 2, 4, :down).should == [CreateAltAdvanced]
+    Sequel::Migrator.migration_classes(@dirname, 2, 5, :down).should == [CreateAttributes, CreateUsers]
+    Sequel::Migrator.migration_classes(@alt_dirname, 2, 4, :down).should == [CreateAltAdvanced]
   end
   
   specify "#schema_info_dataset should automatically create the schema_info table" do
@@ -266,12 +271,12 @@ context "Sequel::Migrator" do
   end
   
   specify "should apply migrations correctly in the up direction" do
-    Sequel::Migrator.apply(@db, '.', 3, 2)
+    Sequel::Migrator.apply(@db, @dirname, 3, 2)
     @db.creates.should == [3333]
     
     Sequel::Migrator.get_current_migration_version(@db).should == 3
 
-    Sequel::Migrator.apply(@db, '.', 5)
+    Sequel::Migrator.apply(@db, @dirname, 5)
     @db.creates.should == [3333, 5555]
 
     Sequel::Migrator.get_current_migration_version(@db).should == 5
@@ -286,7 +291,7 @@ context "Sequel::Migrator" do
   end
   
   specify "should apply migrations correctly in the down direction" do
-    Sequel::Migrator.apply(@db, '.', 1, 5)
+    Sequel::Migrator.apply(@db, @dirname, 1, 5)
     @db.drops.should == [5555, 3333, 2222]
 
     Sequel::Migrator.get_current_migration_version(@db).should == 1
@@ -297,7 +302,7 @@ context "Sequel::Migrator" do
   end
 
   specify "should apply migrations up to the latest version if no target is given" do
-    Sequel::Migrator.apply(@db, '.')
+    Sequel::Migrator.apply(@db, @dirname)
     @db.creates.should == [1111, 2222, 3333, 5555]
 
     Sequel::Migrator.get_current_migration_version(@db).should == 5
@@ -309,7 +314,7 @@ context "Sequel::Migrator" do
   end
 
   specify "should apply migrations down to 0 version correctly" do
-    Sequel::Migrator.apply(@db, '.', 0, 5)
+    Sequel::Migrator.apply(@db, @dirname, 0, 5)
     @db.drops.should == [5555, 3333, 2222, 1111]
 
     Sequel::Migrator.get_current_migration_version(@db).should == 0
@@ -320,8 +325,8 @@ context "Sequel::Migrator" do
   end
   
   specify "should return the target version" do
-    Sequel::Migrator.apply(@db, '.', 3, 2).should == 3
-    Sequel::Migrator.apply(@db, '.', 0).should == 0
-    Sequel::Migrator.apply(@db, '.').should == 5
+    Sequel::Migrator.apply(@db, @dirname, 3, 2).should == 3
+    Sequel::Migrator.apply(@db, @dirname, 0).should == 0
+    Sequel::Migrator.apply(@db, @dirname).should == 5
   end
 end

data/spec/extensions/optimistic_locking_spec.rb

@@ -0,0 +1,100 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+describe "optimistic_locking plugin" do
+  before do
+    @c = Class.new(Sequel::Model(:people)) do
+    end
+    h = {1=>{:id=>1, :name=>'John', :lock_version=>2}}
+    lv = @lv = "lock_version"
+    @c.dataset.quote_identifiers = false
+    @c.dataset.meta_def(:h){h}
+    @c.dataset.meta_def(:lv){lv}
+    @c.dataset.meta_def(:update) do |opts|
+      case update_sql(opts)
+      when /UPDATE people SET (name|#{lv}) = ('Jim'|'Bob'|\d+), (?:name|#{lv}) = ('Jim'|'Bob'|\d+) WHERE \(\(id = (\d+)\) AND \(#{lv} = (\d+)\)\)/
+        name, nlv = $1 == 'name' ? [$2, $3] : [$3, $2]
+        m = h[$4.to_i]
+        if m && m[:lock_version] == $5.to_i
+          m.merge!(:name=>name.gsub("'", ''), :lock_version=>nlv.to_i)
+          1
+        else
+          0
+        end
+      else
+        puts update_sql(opts)
+      end
+    end
+    @c.dataset.instance_eval do
+      def fetch_rows(sql)
+        m = h[1].dup
+        v = m.delete(:lock_version)
+        m[lv.to_sym] = v
+        yield(m)
+      end
+    end
+    @c.dataset.meta_def(:delete) do
+      case delete_sql
+      when /DELETE FROM people WHERE \(\(id = (\d+)\) AND \(#{lv} = (\d+)\)\)/
+        m = h[$1.to_i]
+        if m && m[lv.to_sym] == $2.to_i
+          h.delete[$1.to_i]
+          1
+        else
+          0
+        end
+      else
+        puts delete_sql
+      end
+    end
+    @c.columns :id, :name, :lock_version
+    @c.plugin :optimistic_locking
+  end
+
+  specify "should raise an error when updating a stale record" do
+    p1 = @c[1]
+    p2 = @c[1]
+    p1.update(:name=>'Jim')
+    proc{p2.update(:name=>'Bob')}.should raise_error(Sequel::Plugins::OptimisticLocking::Error)
+  end 
+
+  specify "should raise an error when destroying a stale record" do
+    p1 = @c[1]
+    p2 = @c[1]
+    p1.update(:name=>'Jim')
+    proc{p2.destroy}.should raise_error(Sequel::Plugins::OptimisticLocking::Error)
+  end 
+
+  specify "should not raise an error when updating the same record twice" do
+    p1 = @c[1]
+    p1.update(:name=>'Jim')
+    proc{p1.update(:name=>'Bob')}.should_not raise_error
+  end
+
+  specify "should allow changing the lock column via model.lock_column=" do
+    @lv.replace('lv')
+    @c.columns :id, :name, :lv
+    @c.lock_column = :lv
+    p1 = @c[1]
+    p2 = @c[1]
+    p1.update(:name=>'Jim')
+    proc{p2.update(:name=>'Bob')}.should raise_error(Sequel::Plugins::OptimisticLocking::Error)
+  end
+
+  specify "should allow changing the lock column via plugin option" do
+    @lv.replace('lv')
+    @c.columns :id, :name, :lv
+    @c.plugin :optimistic_locking, :lock_column=>:lv
+    p1 = @c[1]
+    p2 = @c[1]
+    p1.update(:name=>'Jim')
+    proc{p2.destroy}.should raise_error(Sequel::Plugins::OptimisticLocking::Error)
+  end
+
+  specify "should work when subclassing" do
+    c = Class.new(@c)
+    p1 = c[1]
+    p2 = c[1]
+    p1.update(:name=>'Jim')
+    proc{p2.update(:name=>'Bob')}.should raise_error(Sequel::Plugins::OptimisticLocking::Error)
+  end 
+end