sequel 3.43.0 → 3.44.0

data/lib/sequel/adapters/jdbc/sqlite.rb

@@ -30,6 +30,11 @@ module Sequel
 
         private
         
+        DATABASE_ERROR_REGEXPS = {/Abort due to constraint violation/ => ConstraintViolation}.freeze
+        def database_error_regexps
+          DATABASE_ERROR_REGEXPS
+        end
+
         # Use last_insert_rowid() to get the last inserted id.
         def last_insert_id(conn, opts={})
           statement(conn) do |stmt|

data/lib/sequel/adapters/jdbc/sqlserver.rb

@@ -18,7 +18,7 @@ module Sequel
         # than getObject() for this column avoids the problem.
         # Reference: http://social.msdn.microsoft.com/Forums/en/sqldataaccess/thread/20df12f3-d1bf-4526-9daa-239a83a8e435
         module MetadataDatasetMethods
-          def process_result_set_convert(cols, result, rn)
+          def process_result_set_convert(cols, result)
             while result.next
               row = {}
               cols.each do |n, i, p|
@@ -40,18 +40,16 @@ module Sequel
                   v
                 end
               end
-              row.delete(rn) if rn
               yield row
             end
           end
 
-          def process_result_set_no_convert(cols, result, rn)
+          def process_result_set_no_convert(cols, result)
             while result.next
               row = {}
               cols.each do |n, i|
                 row[n] = (n == :is_autoincrement ? result.getString(i) : result.getObject(i))
               end
-              row.delete(rn) if rn
               yield row
             end
           end

data/lib/sequel/adapters/mock.rb

@@ -66,6 +66,11 @@ module Sequel
           db.instance_eval do
             @primary_key_sequences = {}
           end
+        end,
+        'mssql' => lambda do |db|
+          db.instance_eval do
+            @server_version = 10000000
+          end
         end
       }
 

data/lib/sequel/adapters/mysql2.rb

@@ -138,21 +138,12 @@ module Sequel
       # Yield all rows matching this dataset.
       def fetch_rows(sql)
         execute(sql) do |r|
-          if identifier_output_method
-            cols = r.fields
-            @columns = cols2 = cols.map{|c| output_identifier(c.to_s)}
-            cs = cols.zip(cols2)
-            r.each(:cast_booleans=>convert_tinyint_to_bool?) do |row|
-              h = {}
-              cs.each do |a, b|
-                h[b] = row[a]
-              end
-              yield h
-            end
+          @columns = if identifier_output_method
+            r.fields.map!{|c| output_identifier(c.to_s)}
           else
-            @columns = r.fields
-            r.each(:cast_booleans=>convert_tinyint_to_bool?){|h| yield h}
+            r.fields
           end
+          r.each(:cast_booleans=>convert_tinyint_to_bool?){|h| yield h}
         end
         self
       end

data/lib/sequel/adapters/odbc.rb

@@ -105,16 +105,11 @@ module Sequel
           i = -1
           cols = s.columns(true).map{|c| [output_identifier(c.name), i+=1]}
           columns = cols.map{|c| c.at(0)}
-          if opts[:offset] && offset_returns_row_number_column?
-            rn = row_number_column
-            columns.delete(rn)
-          end
           @columns = columns
           if rows = s.fetch_all
             rows.each do |row|
               hash = {}
               cols.each{|n,i| hash[n] = convert_odbc_value(row[i])}
-              hash.delete(rn) if rn
               yield hash
             end
           end

data/lib/sequel/adapters/oracle.rb

@@ -37,7 +37,9 @@ module Sequel
           dbname = opts[:host]
         end
         conn = OCI8.new(opts[:user], opts[:password], dbname, opts[:privilege])
-        conn.prefetch_rows = typecast_value_integer(opts.fetch(:prefetch_rows, 100))
+        if prefetch_rows = opts.fetch(:prefetch_rows, 100)
+          conn.prefetch_rows = typecast_value_integer(prefetch_rows)
+        end
         conn.autocommit = true
         conn.non_blocking = true
         
@@ -383,18 +385,14 @@ module Sequel
       
       def fetch_rows(sql)
         execute(sql) do |cursor|
-          offset = @opts[:offset]
-          rn = row_number_column
           cps = db.conversion_procs
           cols = columns = cursor.get_col_names.map{|c| output_identifier(c)}
           metadata = cursor.column_metadata
           cm = cols.zip(metadata).map{|c, m| [c, cps[m.data_type]]}
-          columns = cols.reject{|x| x == rn} if offset
           @columns = columns
           while r = cursor.fetch
             row = {}
             r.zip(cm).each{|v, (c, cp)| row[c] = ((v && cp) ? cp.call(v) : v)}
-            row.delete(rn) if offset
             yield row
           end
         end

data/lib/sequel/adapters/postgres.rb

@@ -289,7 +289,8 @@ module Sequel
 
         # +copy_into+ uses PostgreSQL's +COPY FROM STDIN+ SQL statement to do very fast inserts 
         # into a table using input preformatting in either CSV or PostgreSQL text format.
-        # This method is only supported if pg is the underlying ruby driver.  This method should only be called if you want
+        # This method is only supported if pg 0.14.0+ is the underlying ruby driver.
+        # This method should only be called if you want
         # results returned to the client.  If you are using +COPY FROM+
         # with a filename, you should just use +run+ instead of this method.
         #

data/lib/sequel/adapters/shared/access.rb

@@ -43,6 +43,16 @@ module Sequel
         run(ds.into(name).sql)
       end
     
+      DATABASE_ERROR_REGEXPS = {
+        /The changes you requested to the table were not successful because they would create duplicate values in the index, primary key, or relationship/ => UniqueConstraintViolation,
+        /You cannot add or change a record because a related record is required|The record cannot be deleted or changed because table/ => ForeignKeyConstraintViolation,
+        /One or more values are prohibited by the validation rule/ => CheckConstraintViolation,
+        /You must enter a value in the .+ field|cannot contain a Null value because the Required property for this field is set to True/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # The SQL to drop an index for the table.
       def drop_index_sql(table, op)
         "DROP INDEX #{quote_identifier(op[:name] || default_index_name(table, op[:columns]))} ON #{quote_schema_table(table)}"

data/lib/sequel/adapters/shared/cubrid.rb

@@ -126,6 +126,15 @@ module Sequel
         :query
       end
 
+      DATABASE_ERROR_REGEXPS = {
+        /Operation would have caused one or more unique constraint violations/ => UniqueConstraintViolation,
+        /The constraint of the foreign key .+ is invalid|Update\/Delete operations are restricted by the foreign key/ => ForeignKeyConstraintViolation,
+        /cannot be made NULL/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # CUBRID is case insensitive, so don't modify identifiers
       def identifier_input_method_default
         nil

data/lib/sequel/adapters/shared/db2.rb

@@ -154,6 +154,16 @@ module Sequel
         end
       end
 
+      DATABASE_ERROR_REGEXPS = {
+        /DB2 SQL Error: SQLCODE=-803, SQLSTATE=23505|One or more values in the INSERT statement, UPDATE statement, or foreign key update caused by a DELETE statement are not valid because the primary key, unique constraint or unique index/ => UniqueConstraintViolation,
+        /DB2 SQL Error: (SQLCODE=-530, SQLSTATE=23503|SQLCODE=-532, SQLSTATE=23504)|The insert or update value of the FOREIGN KEY .+ is not equal to any value of the parent key of the parent table|A parent row cannot be deleted because the relationship .+ restricts the deletion/ => ForeignKeyConstraintViolation,
+        /DB2 SQL Error: SQLCODE=-545, SQLSTATE=23513|The requested operation is not allowed because a row does not satisfy the check constraint/ => CheckConstraintViolation,
+        /DB2 SQL Error: SQLCODE=-407, SQLSTATE=23502|Assignment of a NULL value to a NOT NULL column/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # DB2 has issues with quoted identifiers, so
       # turn off database quoting by default.
       def quote_identifiers_default

data/lib/sequel/adapters/shared/mssql.rb

@@ -238,6 +238,16 @@ module Sequel
         run(ds.into(name).sql)
       end
     
+      DATABASE_ERROR_REGEXPS = {
+        /Violation of UNIQUE KEY constraint/ => UniqueConstraintViolation,
+        /conflicted with the (FOREIGN KEY.*|REFERENCE) constraint/ => ForeignKeyConstraintViolation,
+        /conflicted with the CHECK constraint/ => CheckConstraintViolation,
+        /column does not allow nulls/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # The name of the constraint for setting the default value on the table and column.
       # The SQL used to select default constraints utilizes MSSQL catalog views which were introduced in 2005.
       # This method intentionally does not support MSSQL 2000.

data/lib/sequel/adapters/shared/mysql.rb

@@ -350,6 +350,15 @@ module Sequel
         "#{super}#{" ENGINE=#{engine}" if engine}#{" DEFAULT CHARSET=#{charset}" if charset}#{" DEFAULT COLLATE=#{collate}" if collate}"
       end
 
+      DATABASE_ERROR_REGEXPS = {
+        /Duplicate entry .+ for key/ => UniqueConstraintViolation,
+        /foreign key constraint fails/ => ForeignKeyConstraintViolation,
+        /cannot be null/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # Backbone of the tables and views support using SHOW FULL TABLES.
       def full_tables(type, opts)
         m = output_identifier_meth
@@ -430,6 +439,11 @@ module Sequel
         true
       end
 
+      # MySQL supports CREATE OR REPLACE VIEW.
+      def supports_create_or_replace_view?
+        true
+      end
+
       # Respect the :size option if given to produce
       # tinyblob, mediumblob, and longblob if :tiny,
       # :medium, or :long is given.

data/lib/sequel/adapters/shared/oracle.rb

@@ -136,6 +136,16 @@ module Sequel
         sql
       end
 
+      DATABASE_ERROR_REGEXPS = {
+        /unique constraint .+ violated/ => UniqueConstraintViolation,
+        /integrity constraint .+ violated/ => ForeignKeyConstraintViolation,
+        /check constraint .+ violated/ => CheckConstraintViolation,
+        /cannot insert NULL into|cannot update .+ to NULL/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       def default_sequence_name(table, column)
         "seq_#{table}_#{column}"
       end
@@ -160,6 +170,11 @@ module Sequel
         end
       end
 
+      # Oracle supports CREATE OR REPLACE VIEW.
+      def supports_create_or_replace_view?
+        true
+      end
+
       # Oracle's integer/:number type handles larger values than
       # most other databases's bigint types, so it should be
       # safe to use for Bignum.

data/lib/sequel/adapters/shared/postgres.rb

@@ -53,14 +53,14 @@ module Sequel
     end
 
     class CreateTableGenerator < Sequel::Schema::Generator
-      # Add an exclusion constraint when creating the table. elements should be
+      # Add an exclusion constraint when creating the table. Elements should be
       # an array of 2 element arrays, with the first element being the column or
       # expression the exclusion constraint is applied to, and the second element
       # being the operator to use for the column/expression to check for exclusion.
       #
       # Example:
       #
-      #   exclusion_constraint([[:col1, '&&'], [:col2, '=']])
+      #   exclude([[:col1, '&&'], [:col2, '=']])
       #   # EXCLUDE USING gist (col1 WITH &&, col2 WITH =)
       #
       # Options supported:
@@ -89,6 +89,9 @@ module Sequel
       end
     end
 
+    # Error raised when Sequel determines a PostgreSQL exclusion constraint has been violated.
+    class ExclusionConstraintViolation < Sequel::ConstraintViolation; end
+
     # Methods shared by Database instances that connect to PostgreSQL.
     module DatabaseMethods
       EXCLUDE_SCHEMAS = /pg_*|information_schema/i
@@ -627,6 +630,17 @@ module Sequel
         end
       end
 
+      DATABASE_ERROR_REGEXPS = {
+        /duplicate key value violates unique constraint/ => UniqueConstraintViolation,
+        /violates foreign key constraint/ => ForeignKeyConstraintViolation,
+        /violates check constraint/ => CheckConstraintViolation,
+        /violates not-null constraint/ => NotNullConstraintViolation,
+        /conflicting key value violates exclusion constraint/ => ExclusionConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # SQL for doing fast table insert from stdin.
       def copy_into_sql(table, opts)
         sql = "COPY #{literal(table)}"
@@ -717,6 +731,11 @@ module Sequel
         "CREATE TRIGGER #{name} #{whence} #{events.map{|e| e.to_s.upcase}.join(' OR ')} ON #{quote_schema_table(table)}#{' FOR EACH ROW' if opts[:each_row]} EXECUTE PROCEDURE #{function}(#{Array(opts[:args]).map{|a| literal(a)}.join(', ')})"
       end
 
+      # DDL fragment for initial part of CREATE VIEW statement
+      def create_view_prefix_sql(name, options)
+        "CREATE #{'OR REPLACE 'if options[:replace]}#{'TEMPORARY 'if options[:temp]}VIEW #{quote_schema_table(name)}"
+      end
+
       # The errors that the main adapters can raise, depends on the adapter being used
       def database_error_classes
         CONVERTED_EXCEPTIONS
@@ -919,6 +938,11 @@ module Sequel
         true
       end
 
+      # PostgreSQL supports CREATE OR REPLACE VIEW.
+      def supports_create_or_replace_view?
+        true
+      end
+
       # Handle bigserial type if :serial option is present
       def type_literal_generic_bignum(column)
         column[:serial] ? :bigserial : super

data/lib/sequel/adapters/shared/sqlite.rb

@@ -312,6 +312,21 @@ module Sequel
         ps
       end
 
+      # SQLite support creating temporary views.
+      def create_view_prefix_sql(name, options)
+        "CREATE #{'TEMPORARY 'if options[:temp]}VIEW #{quote_schema_table(name)}"
+      end
+
+      DATABASE_ERROR_REGEXPS = {
+        /is not unique\z/ => UniqueConstraintViolation,
+        /foreign key constraint failed\z/ => ForeignKeyConstraintViolation,
+        /\A(SQLITE ERROR 19 \(CONSTRAINT\) : )?constraint failed\z/ => ConstraintViolation,
+        /may not be NULL\z/ => NotNullConstraintViolation,
+      }.freeze
+      def database_error_regexps
+        DATABASE_ERROR_REGEXPS
+      end
+
       # The array of column schema hashes for the current columns in the table
       def defined_columns_for(table)
         cols = parse_pragma(table, {})

data/lib/sequel/adapters/tinytds.rb

@@ -18,6 +18,7 @@ module Sequel
         opts = server_opts(server)
         opts[:username] = opts[:user]
         c = TinyTds::Client.new(opts)
+        c.query_options.merge!(:cache_rows=>false)
 
         if (ts = opts[:textsize])
           sql = "SET TEXTSIZE #{typecast_value_integer(ts)}"
@@ -215,40 +216,12 @@ module Sequel
       # various cases.
       def fetch_rows(sql)
         execute(sql) do |result|
-          each_opts = {:cache_rows=>false}
-          each_opts[:timezone] = :utc if db.timezone == :utc
-          rn = row_number_column if offset = @opts[:offset]
-          columns = cols = result.fields.map{|c| output_identifier(c)}
-          if offset
-            rn = row_number_column
-            columns = columns.dup
-            columns.delete(rn)
-          end
-          @columns = columns
-          #if identifier_output_method
-            each_opts[:as] = :array
-            result.each(each_opts) do |r|
-              h = {}
-              cols.zip(r).each{|k, v| h[k] = v}
-              h.delete(rn) if rn
-              yield h
-            end
-=begin
-        # Temporarily disable this optimization, as tiny_tds uses string keys
-        # if result.fields is called before result.each(:symbolize_keys=>true).
-        # See https://github.com/rails-sqlserver/tiny_tds/issues/57
+          @columns = result.fields.map!{|c| output_identifier(c)}
+          if db.timezone == :utc
+            result.each(:timezone=>:utc){|r| yield r}
           else
-            each_opts[:symbolize_keys] = true
-            if offset
-              result.each(each_opts) do |r|
-                r.delete(rn) if rn
-                yield r
-              end
-            else
-              result.each(each_opts, &Proc.new)
-            end
+            result.each{|r| yield r}
           end
-=end
         end
         self
       end

data/lib/sequel/adapters/utils/emulate_offset_with_row_number.rb

@@ -1,36 +1,5 @@
 module Sequel
   module EmulateOffsetWithRowNumber
-    # When a subselect that uses :offset is used in IN or NOT IN,
-    # use a nested subselect that only includes the first column
-    # instead of the ROW_NUMBER column added by the emulated offset support.
-    def complex_expression_sql_append(sql, op, args)
-      case op
-      when :IN, :"NOT IN"
-        ds = args.at(1)
-        if ds.is_a?(Sequel::Dataset) && ds.opts[:offset]
-          c = ds.opts[:select].first
-          case c
-          when Symbol
-            t, cl, a = split_symbol(c)
-            if a
-              c = SQL::Identifier.new(a)
-            elsif t
-              c = SQL::Identifier.new(cl)
-            end
-          when SQL::AliasedExpression
-            c = SQL::Identifier.new(c.aliaz)
-          when SQL::QualifiedIdentifier
-            c = SQL::Identifier.new(c.column)
-          end
-          super(sql, op, [args.at(0), ds.from_self.select(c)])
-        else
-          super
-        end
-      else
-        super
-      end
-    end
-
     # Emulate OFFSET support with the ROW_NUMBER window function
     # 
     # The implementation is ugly, cloning the current dataset and modifying
@@ -47,6 +16,7 @@ module Sequel
         raise(Error, "#{db.database_type} requires an order be provided if using an offset")
       end
 
+      columns = clone(:append_sql=>'').columns
       dsa1 = dataset_alias(1)
       rn = row_number_column
       sql = @opts[:append_sql] || ''
@@ -54,6 +24,7 @@ module Sequel
         unordered.
         select_append{ROW_NUMBER(:over, :order=>order){}.as(rn)}.
         from_self(:alias=>dsa1).
+        select(*columns).
         limit(@opts[:limit]).
         where(SQL::Identifier.new(rn) > o).
         order(rn))
@@ -67,11 +38,5 @@ module Sequel
     def default_offset_order
       clone(:append_sql=>'').columns
     end
-
-    # This emulation adds an extra row number column that should be
-    # eliminated.
-    def offset_returns_row_number_column?
-      true
-    end
   end
 end