sequel-privacy 0.5.5 → 0.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7dd8660d0cc93e21c96080ba66f777e9b39f00ec7a5ca4f8fa211739a97dbe62
-  data.tar.gz: 85952e038e33a535adf8adaed566c08310e003f2540a406457029d678e889009
+  metadata.gz: f44402a685dc5c1569213ac155c7fba6ecbd291eb8a2091491f510105ddcc4d7
+  data.tar.gz: bc3a007c36fb539cd5f911b65c8bccf087218bd871b53991cfb9987cf44acc1c
 SHA512:
-  metadata.gz: 9276223bd19d31daaabbaa34076e15c6dce4ce2439daadc30bee5e021fc7a88571323ce213ab2840afbe533b53d73129625817177a44b7a178f1fc93b6f21c37
-  data.tar.gz: d6c2e72d8eea11c83b42be27a64dd5076e0e320a7d15efe7a6092ca543714203cf643ad14eee190b986eda570a331fca2b8d519126494ff35d5caef421f2fb9a
+  metadata.gz: c8ed3ffe946e6525075651c1965ded61114b44d0bfc10e67bcac71d5d2bfce7f8dcd682818fc6c1611eaca1ab8cfd5d709c24067d03c394edcb31b4de5b08593
+  data.tar.gz: 694cc27fb53f8ef0c68c7ab645c3f55251d1b3c838fdb9f52c9cf66bbbd33a8caff9d8969f0157f8fef8101562a99e570fbe3916d2d04389eccb7fc207a2aa5c

data/README.md

@@ -180,6 +180,33 @@ policy :MyPolicy, ->() { ... },
 
 **`allow_anonymous: true`**: Skip the auto-deny for nil actor. Use for state-gate policies that examine only the subject (e.g. "post is published").
 
+### Policy Factories
+
+Use `policy_factory` when a policy needs definition-time arguments, while still receiving the normal runtime policy arguments (`actor`, `subject`, `direct_object`) during enforcement.
+
+```ruby
+module P
+  extend Sequel::Privacy::PolicyDSL
+
+  policy_factory :AllowIfActorMeetsFieldVisibility, ->(visibility_field) {
+    ->(actor, subject) {
+      allow if actor.meets_visibility?(subject.public_send(visibility_field))
+    }
+  }
+end
+
+class Member < Sequel::Model
+  plugin :privacy
+
+  privacy do
+    can :view, P::AllowMembers
+    field :phone, P::AllowIfActorMeetsFieldVisibility(:phone_visibility)
+  end
+end
+```
+
+Policy factories accept the same options as `policy`. The factory must return a Proc, and each call returns a concrete `Policy` instance with its own cache identity.
+
 ### Policy Combinators
 
 Use `all()` to require multiple conditions:

data/lib/sequel/plugins/privacy.rb

@@ -126,6 +126,8 @@ module Sequel
             case p
             when Sequel::Privacy::Policy, Proc
               p
+            when Sequel::Privacy::PolicyFactory
+              Kernel.raise ArgumentError, "Policy factory #{p.factory_name} must be called with arguments"
             else
               Kernel.raise ArgumentError, "Invalid policy: #{p.inspect}"
             end

data/lib/sequel/privacy/enforcer.rb

@@ -61,7 +61,7 @@ module Sequel
 
           # Fail-secure: every chain ends with AlwaysDeny.
           unless policies.last == BuiltInPolicies::AlwaysDeny
-            logger&.warn { 'Policy chain should end with AlwaysDeny. Appending it.' }
+            logger&.debug { 'Policy chain should end with AlwaysDeny. Appending it.' }
             policies = policies.dup << BuiltInPolicies::AlwaysDeny
           end
 

data/lib/sequel/privacy/policy_dsl.rb

@@ -50,6 +50,35 @@ module Sequel
         )
         const_set(name, p)
       end
+
+      sig do
+        params(
+          name: Symbol,
+          factory: Proc,
+          comment: T.nilable(String),
+          cacheable: T::Boolean,
+          single_match: T::Boolean,
+          cache_by: T.nilable(T.any(Symbol, T::Array[Symbol])),
+          allow_anonymous: T::Boolean
+        ).void
+      end
+      def policy_factory(name, factory, comment = nil, cacheable: true, single_match: false, cache_by: nil,
+                         allow_anonymous: false)
+        policy_factory = PolicyFactory.new(
+          name,
+          factory,
+          comment: comment,
+          cacheable: cacheable,
+          single_match: single_match,
+          cache_by: cache_by,
+          allow_anonymous: allow_anonymous
+        )
+
+        const_set(name, policy_factory)
+        define_singleton_method(name) do |*args|
+          policy_factory.call(*args)
+        end
+      end
     end
   end
 end

data/lib/sequel/privacy/policy_factory.rb

@@ -0,0 +1,68 @@
+# typed: true
+# frozen_string_literal: true
+
+module Sequel
+  module Privacy
+    # A PolicyFactory captures definition-time arguments and returns concrete
+    # Policy instances that can be registered in a privacy policy chain.
+    class PolicyFactory
+      extend T::Sig
+
+      sig { returns(String) }
+      attr_reader :factory_name
+
+      sig do
+        params(
+          factory_name: Symbol,
+          factory: Proc,
+          comment: T.nilable(String),
+          cacheable: T::Boolean,
+          single_match: T::Boolean,
+          cache_by: T.nilable(T.any(Symbol, T::Array[Symbol])),
+          allow_anonymous: T::Boolean
+        ).void
+      end
+      def initialize(factory_name, factory, comment: nil, cacheable: true, single_match: false, cache_by: nil,
+                     allow_anonymous: false)
+        @factory_name = T.let(factory_name.to_s, String)
+        @factory = T.let(factory, Proc)
+        @comment = T.let(comment, T.nilable(String))
+        @cacheable = T.let(cacheable, T::Boolean)
+        @single_match = T.let(single_match, T::Boolean)
+        @cache_by = T.let(cache_by, T.nilable(T.any(Symbol, T::Array[Symbol])))
+        @allow_anonymous = T.let(allow_anonymous, T::Boolean)
+      end
+
+      sig { params(args: T.untyped).returns(Policy) }
+      def call(*args)
+        lam = T.unsafe(@factory).call(*args)
+        unless lam.is_a?(Proc)
+          Kernel.raise ArgumentError,
+                       "Policy factory #{@factory_name} must return a Proc, got #{lam.inspect}"
+        end
+
+        T.cast(
+          Policy.create(
+            policy_name_for(args),
+            lam,
+            @comment,
+            cacheable: @cacheable,
+            single_match: @single_match,
+            cache_by: @cache_by,
+            allow_anonymous: @allow_anonymous
+          ),
+          Policy
+        )
+      end
+
+      private
+
+      sig { params(args: T::Array[T.untyped]).returns(Symbol) }
+      def policy_name_for(args)
+        return @factory_name.to_sym if args.empty?
+
+        :"#{@factory_name}(#{args.map(&:inspect).join(', ')})"
+      end
+    end
+  end
+end

data/lib/sequel/privacy/version.rb

@@ -3,6 +3,6 @@
 
 module Sequel
   module Privacy
-    VERSION = '0.5.5'
+    VERSION = '0.5.7'
   end
 end

data/lib/sequel-privacy.rb

@@ -20,6 +20,7 @@ require_relative 'sequel/privacy/version'
 require_relative 'sequel/privacy/errors'
 require_relative 'sequel/privacy/i_actor'
 require_relative 'sequel/privacy/policy'
+require_relative 'sequel/privacy/policy_factory'
 require_relative 'sequel/privacy/cache'
 require_relative 'sequel/privacy/actions'
 require_relative 'sequel/privacy/viewer_context'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sequel-privacy
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.7
 platform: ruby
 authors:
 - Austin Bales
@@ -114,6 +114,7 @@ files:
 - lib/sequel/privacy/i_actor.rb
 - lib/sequel/privacy/policy.rb
 - lib/sequel/privacy/policy_dsl.rb
+- lib/sequel/privacy/policy_factory.rb
 - lib/sequel/privacy/version.rb
 - lib/sequel/privacy/viewer_context.rb
 homepage: https://github.com/arbales/sequel-privacy