sequel-activerecord_connection 0.2.4 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a46fc2de408ac66a48628919f4030c847118c12fb7db1fc4060436fb05ce8976
-  data.tar.gz: 4aa867bb6b6a18de97fdf69f213987d0d94aed960539a70ae12fa50e348609fa
+  metadata.gz: bb35cdbc0ade81ae15042834733f9ec4683b6889eab2c35412710d631a02de53
+  data.tar.gz: 75f97d5bee8522c12a7a3c65e05e1511f40ca4eccab8bc4b8cb2e1c3ece1a44a
 SHA512:
-  metadata.gz: 3403df36d5e6741f4a7c2236ee479645aa580b0841f799fe1f0ad8b6ce0421344330857ff8afa52aafd4232f9cc1ba3e497c16b9e85615c7119be4bb19ef219c
-  data.tar.gz: e5c12006fce490bf8500e575d45c5046f368c6904386dcd5503ce7f9bd2c7b75a172d331aadc81d99259776fbae6e07d3074f6d554dcbe3171add28ebd27b952
+  metadata.gz: 4fbf8edd6c9a61a8761431d33ba89c63a2aa444417d5ebec7b42ec9d3ef8aa5c509b28d35d708af223289c8e085b62204c3af690dc18c13e0df69f61a837b41d
+  data.tar.gz: 5f4408be86e1d09a856215ca6e1fd4ef594955549e52987107ff33fc8efb24c68f4fdaf03c0132bb22fe4e2023b31d5526dc77f225d476718528d101c2f6bb8c

data/CHANGELOG.md

@@ -1,7 +1,41 @@
+## 0.4.1 (2020-09-28)
+
+* Require Sequel version 5.16.0 or above (@janko)
+
+## 0.4.0 (2020-09-28)
+
+* Return correct result of `Database#in_transaction?` after ActiveRecord transaction exited (@janko)
+
+* Make ActiveRecord create a savepoint inside a Sequel transaction with `auto_savepoint: true` (@janko)
+
+* Make Sequel create a savepoint inside ActiveRecord transaction with `joinable: false` (@janko)
+
+* Improve reliability of nested transactions when combining Sequel and ActiveRecord (@janko)
+
+* Raise error when attempting to add an `after_commit`/`after_rollback` hook on ActiveRecord transaction (@janko)
+
+* Fix infinite loop that could happen with transactional Rails tests (@janko)
+
+## 0.3.0 (2020-07-24)
+
+* Fully support Sequel transaction API (all transaction options, transaction/savepoint hooks etc.) (@janko)
+
+## 0.2.6 (2020-07-19)
+
+* Return block result in `Sequel::Database#transaction` (@zabolotnov87, @janko)
+
+* Fix `Sequel::Model#save_changes` or `#save` with additional options not executing (@zabolotnov87, @janko)
+
+## 0.2.5 (2020-06-04)
+
+* Use `#current_timestamp_utc` for the JDBC SQLite adapter as well (@HoneyryderChuck)
+
 ## 0.2.4 (2020-06-03)
 
 * Add JRuby support for ActiveRecord 6.0 and 5.2 (@HoneyryderChuck)
 
+* Use `#current_timestamp_utc` setting for SQLite adapter on Sequel >= 5.33 (@HoneyryderChuck)
+
 ## 0.2.3 (2020-05-25)
 
 * Fix Ruby 2.7 kwargs warnings in `#transaction` (@HoneyryderChuck)

data/README.md

@@ -3,7 +3,7 @@
 This is an extension for [Sequel] that allows it to reuse an existing
 ActiveRecord connection for database interaction. It works on ActiveRecord 4.2
 or higher, and supports the built-in `postgresql`, `mysql2` and `sqlite3`
-adapters.
+adapters, as well as JDBC adapter for JRuby.
 
 This can be useful if you're using a library that uses Sequel for database
 interaction (e.g. [Rodauth]), but you want to avoid creating a separate
@@ -11,15 +11,15 @@ database connection. Or if you're transitioning from ActiveRecord to Sequel,
 and want the database connection to be shared.
 
 Note that this is a best-effort implementation, so some discrepancies are still
-possible. That being said, this implementation passes [Rodauth]'s test suite
-(for all adapters), which has fairly advanced Sequel usage.
+possible. That being said, this implementation passes Rodauth's test suite
+(for all adapters), which has some fairly advanced Sequel usage.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem "sequel-activerecord_connection"
+gem "sequel-activerecord_connection", "~> 0.3"
 ```
 
 And then execute:
@@ -42,8 +42,7 @@ appropriate Sequel adapter and load the `activerecord_connection` extension:
 ```rb
 require "sequel"
 
-DB = Sequel.postgres(test: false) # avoid creating a connection
-DB.extension :activerecord_connection
+DB = Sequel.postgres(extensions: :activerecord_connection)
 ```
 
 Now any Sequel operations that you make will internaly be done using the
@@ -75,70 +74,64 @@ ActiveRecord adapters, just make sure to initialize the corresponding Sequel
 adapter before loading the extension.
 
 ```rb
-DB = Sequel.postgres(test: false) # for "postgresql" adapter
+DB = Sequel.postgres(extensions: :activerecord_connection) # for "postgresql" adapter
 # or
-DB = Sequel.mysql2(test: false) # for "mysql2" adapter
+DB = Sequel.mysql2(extensions: :activerecord_connection) # for "mysql2" adapter
 # or
-DB = Sequel.sqlite(test: false) # for "sqlite3" adapter
+DB = Sequel.sqlite(extensions: :activerecord_connection) # for "sqlite3" adapter
+# or
+DB = Sequel.jdbc(extensions: :activerecord_connection) # for JDBC adapter
 ```
 
 ### Transactions
 
-The database extension overrides Sequel transactions to use ActiveRecord
-transcations, which allows using ActiveRecord inside Sequel transactions (and
-vice-versa), and have things like ActiveRecord's transactional callbacks still
-work correctly.
+This database extension keeps the transaction state of Sequel and ActiveRecord
+in sync, allowing you to use Sequel and ActiveRecord transactions
+interchangeably (including nesting them), and have things like ActiveRecord's
+and Sequel's transactional callbacks still work correctly.
 
 ```rb
-DB.transaction do
-  ActiveRecord::Base.transaction do
-    # this all works
-  end
+ActiveRecord::Base.transaction do
+  DB.in_transaction? #=> true
 end
 ```
 
-The following Sequel transaction options are currently supported:
-
-* `:savepoint`
-* `:auto_savepoint`
-* `:rollback`
+Sequel's transaction API is fully supported:
 
 ```rb
-ActiveRecord::Base.transaction do
-  DB.transaction(savepoint: true) do # will create a savepoint
-    DB.transaction do # will not create a savepoint
-      # ...
-    end
+DB.transaction(isolation: :serializable) do
+  DB.after_commit { ... } # executed after transaction commits
+  DB.transaction(savepoint: true) do # creates a savepoint
+    DB.after_commit(savepoint: true) { ... } # executed if all enclosing savepoints have been released
   end
 end
 ```
 
-The `#in_transaction?` method is supported as well:
+One caveat to keep in mind is that using Sequel's transaction/savepoint hooks
+currently don't work if ActiveRecord holds the corresponding
+transaction/savepoint. This is because it's difficult to be notified when
+ActiveRecord commits or rolls back the transaction/savepoint.
 
 ```rb
-ActiveRecord::Base.transaction do
-  DB.in_transaction? #=> true
+DB.transaction do
+  DB.after_commit { ... } # will get executed
 end
-```
-
-Other transaction-related Sequel methods (`#after_commit`, `#after_rollback`
-etc) are not supported, because ActiveRecord currently doesn't provide
-transactional callbacks on the connection level (only on the model level).
 
-### Exceptions
-
-To ensure Sequel compatibility, any `ActiveRecord::StatementInvalid` exceptions
-will be translated into Sequel exceptions:
-
-```rb
-DB[:posts].multi_insert [{ id: 1 }, { id: 1 }]
-#~> Sequel::UniqueConstraintViolation
+DB.transaction do
+  DB.transaction(savepoint: true) do
+    DB.after_commit(savepoint: true) { ... } # will get executed
+  end
+end
 
-DB[:posts].insert(title: nil)
-#~> Sequel::NotNullConstraintViolation
+ActiveRecord::Base.transaction do
+  DB.after_commit { ... } # not allowed (will raise Sequel::ActiveRecordConnection::Error)
+end
 
-DB[:posts].insert(author_id: 123)
-#~> Sequel::ForeignKeyConstraintViolation
+DB.transaction do
+  ActiveRecord::Base.transaction(requires_new: true) do
+    DB.after_commit(savepoint: true) { ... } # not allowed (will raise Sequel::ActiveRecordConnection::Error)
+  end
+end
 ```
 
 ### Model

data/lib/sequel/extensions/activerecord_connection.rb

@@ -1,7 +1,16 @@
+# frozen_string_literal: true
+
 module Sequel
   module ActiveRecordConnection
     Error = Class.new(Sequel::Error)
 
+    TRANSACTION_ISOLATION_MAP = {
+      uncommitted:  :read_uncommitted,
+      committed:    :read_committed,
+      repeatable:   :repeatable_read,
+      serializable: :serializable,
+    }
+
     def self.extended(db)
       db.activerecord_model = ActiveRecord::Base
       db.timezone = ActiveRecord::Base.default_timezone
@@ -21,57 +30,82 @@ module Sequel
       raise Error, "creating a Sequel connection is not allowed"
     end
 
-    def transaction(options = {})
-      savepoint      = options.delete(:savepoint)
-      rollback       = options.delete(:rollback)
-      auto_savepoint = options.delete(:auto_savepoint)
-      server         = options.delete(:server)
+    # Avoid calling Sequel's connection pool, instead use ActiveRecord.
+    def synchronize(*)
+      if ActiveRecord.version >= Gem::Version.new("5.1.0")
+        activerecord_connection.lock.synchronize do
+          yield activerecord_raw_connection
+        end
+      else
+        yield activerecord_raw_connection
+      end
+    end
 
-      fail Error, "#{options} transaction options are currently not supported" unless options.empty?
+    private
 
-      if in_transaction?
-        requires_new = savepoint || Thread.current[:sequel_activerecord_auto_savepoint]
-      else
-        requires_new = true
+    # Synchronizes transaction state with ActiveRecord. Sequel uses this
+    # information to know whether we're in a transaction, whether to create a
+    # savepoint, when to run transaction/savepoint hooks etc.
+    def _trans(conn)
+      hash = super || { savepoints: [], activerecord: true }
+
+      # add any ActiveRecord transactions/savepoints that have been opened
+      # directly via ActiveRecord::Base.transaction
+      while hash[:savepoints].length < activerecord_connection.open_transactions
+        hash[:savepoints] << { activerecord: true }
       end
 
-      activerecord_model.transaction(requires_new: requires_new) do
-        begin
-          Thread.current[:sequel_activerecord_auto_savepoint] = true if auto_savepoint
-          yield
-        rescue Sequel::Rollback => exception
-          raise if rollback == :reraise
-          raise ActiveRecord::Rollback, exception.message, exception.backtrace
-        ensure
-          Thread.current[:sequel_activerecord_auto_savepoint] = nil if auto_savepoint
-        end
+      # remove any ActiveRecord transactions/savepoints that have been closed
+      # directly via ActiveRecord::Base.transaction
+      while hash[:savepoints].length > activerecord_connection.open_transactions && hash[:savepoints].last[:activerecord]
+        hash[:savepoints].pop
+      end
+
+      # sync knowledge about joinability of current ActiveRecord transaction/savepoint
+      if activerecord_connection.transaction_open? && !activerecord_connection.current_transaction.joinable?
+        hash[:savepoints].last[:auto_savepoint] = true
+      end
 
-        raise ActiveRecord::Rollback if rollback == :always
+      if hash[:savepoints].empty? && hash[:activerecord]
+        Sequel.synchronize { @transactions.delete(conn) }
+      else
+        Sequel.synchronize { @transactions[conn] = hash }
       end
+
+      super
     end
 
-    def in_transaction?(*)
-      activerecord_connection.transaction_open?
+    def begin_transaction(conn, opts = {})
+      isolation = TRANSACTION_ISOLATION_MAP.fetch(opts[:isolation]) if opts[:isolation]
+      joinable  = !opts[:auto_savepoint]
+
+      activerecord_connection.begin_transaction(isolation: isolation, joinable: joinable)
     end
 
-    %i[after_commit after_rollback rollback_on_exit rollback_checker].each do |meth|
-      define_method(meth) do |*|
-        fail Error, "Database##{meth} is currently not supported"
-      end
+    def commit_transaction(conn, opts = {})
+      activerecord_connection.commit_transaction
     end
 
-    # Avoid calling Sequel's connection pool, instead use ActiveRecord.
-    def synchronize(*)
-      if ActiveRecord.version >= Gem::Version.new("5.1.0")
-        activerecord_connection.lock.synchronize do
-          yield activerecord_raw_connection
-        end
-      else
-        yield activerecord_raw_connection
+    def rollback_transaction(conn, opts = {})
+      activerecord_connection.rollback_transaction
+      activerecord_connection.transaction_manager.send(:after_failure_actions, activerecord_connection.current_transaction, $!) if activerecord_connection.transaction_manager.respond_to?(:after_failure_actions)
+    end
+
+    def add_transaction_hook(conn, type, block)
+      if _trans(conn)[:activerecord]
+        fail Error, "cannot add transaction hook when ActiveRecord holds the outer transaction"
       end
+
+      super
     end
 
-    private
+    def add_savepoint_hook(conn, type, block)
+      if _trans(conn)[:savepoints].last[:activerecord]
+        fail Error, "cannot add savepoint hook when ActiveRecord holds the current savepoint"
+      end
+
+      super
+    end
 
     def activerecord_raw_connection
       activerecord_connection.raw_connection

data/lib/sequel/extensions/activerecord_connection/jdbc.rb

@@ -1,6 +1,12 @@
 module Sequel
   module ActiveRecordConnection
     module Jdbc
+      def self.extended(db)
+        if db.timezone == :utc && db.respond_to?(:current_timestamp_utc)
+          db.current_timestamp_utc = true
+        end
+      end
+
       def statement(conn)
         stmt = activerecord_raw_connection.connection.createStatement
         yield stmt

data/lib/sequel/extensions/activerecord_connection/postgres.rb

@@ -9,11 +9,21 @@ module Sequel
         else
           result.cmd_tuples
         end
+      rescue ActiveRecord::PreparedStatementCacheExpired
+        raise # ActiveRecord's transaction manager needs to handle this exception
       rescue ActiveRecord::StatementInvalid => exception
         raise_error(exception.cause, classes: database_error_classes)
       ensure
         result.clear if result
       end
+
+      def transaction(options = {})
+        %i[deferrable read_only synchronous].each do |key|
+          fail Error, "#{key.inspect} transaction option is currently not supported" if options.key?(key)
+        end
+
+        super
+      end
     end
   end
 end

data/sequel-activerecord_connection.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "sequel-activerecord_connection"
-  spec.version       = "0.2.4"
+  spec.version       = "0.4.1"
   spec.authors       = ["Janko Marohnić"]
   spec.email         = ["janko.marohnic@gmail.com"]
 
@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = Gem::Requirement.new(">= 2.2.0")
 
-  spec.add_dependency "sequel", ">= 4.0", "< 6"
+  spec.add_dependency "sequel", "~> 5.16"
   spec.add_dependency "activerecord", ">= 4.2", "< 7"
 
   spec.add_development_dependency "minitest"

metadata

@@ -1,35 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: sequel-activerecord_connection
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.4.1
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-03 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '5.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '5.16'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement