sepafm 1.1.6 → 1.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c038dcb77ca225b13580f7f01c23ecf58fc00e23
-  data.tar.gz: aa11761b080c92183b185d997bb5c7e509e88171
+  metadata.gz: af34aff52da80e8a3c24f44f5728ab8c356189fb
+  data.tar.gz: 5b3a43610e7c900412e65fc83874d66bf6d132f2
 SHA512:
-  metadata.gz: ea3ae75974fbbb309e959796d709dbf50209f03e8fe5d2b5d47b4028c08cd9dbecbeb2e0f835b84792ee5d71f43e16aae94b7ac69dbb09122c990cff6016435d
-  data.tar.gz: ad964633e3b736ade71ee6a64222311167a47f5f0b7d5406ac06b1f0bfd3012a232e782e798d86d6fe9e14c30afa9f1df549ccc2a1310054735daed5e71ebe3b
+  metadata.gz: 912764345d7c6bb8758ff1fc31f378e01fe0737e99d221e97a6007dd7798291a2aaa538a688c245da875ca5f335bc73539232018cec6276344056161088d97cd
+  data.tar.gz: 3d9681d0485431280410fa30c6bdb3900c7390249e8c8378510da383dabecaab3bbe7cf3b15aefce9305ee9424a0ca35fe1e66b0a3f1f6d0fde3b00df985da5e

data/lib/sepa/application_request.rb

@@ -208,7 +208,7 @@ module Sepa
       # @return [String] the base64 encoded digest of the {#application_request}
       def calculate_digest
         sha1 = OpenSSL::Digest::SHA1.new
-        encode(sha1.digest(@application_request.canonicalize))
+        encode(sha1.digest(@application_request.canonicalize(canonicalization_mode)))
       end
 
       # Adds value to signature node
@@ -231,7 +231,7 @@ module Sepa
         sha1 = OpenSSL::Digest::SHA1.new
         dsig = 'http://www.w3.org/2000/09/xmldsig#'
         node = @application_request.at_css("dsig|SignedInfo", 'dsig' => dsig)
-        signature = @signing_private_key.sign(sha1, node.canonicalize)
+        signature = @signing_private_key.sign(sha1, node.canonicalize(canonicalization_mode))
         encode signature
       end
 
@@ -266,5 +266,11 @@ module Sepa
         target_id.content = @target_id
         @application_request.at(node).add_next_sibling target_id
       end
+
+      def canonicalization_mode
+        return Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0 if @bank == :danske && @command == :renew_certificate
+
+        Nokogiri::XML::XML_C14N_1_0
+      end
   end
 end

data/lib/sepa/version.rb

@@ -1,4 +1,9 @@
 module Sepa
   # The current version of the gem
-  VERSION = "1.1.6".freeze
+  MAJOR = 1
+  MINOR = 1
+  TINY  = 7
+  PRE   = nil
+
+  VERSION = [MAJOR, MINOR, TINY, PRE].compact.join('.')
 end

data/test/sepa/banks/danske/danske_renew_cert_application_request_test.rb

@@ -18,12 +18,13 @@ class DanskeRenewCertApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test 'signature is calculated correctly' do
-    sha1        = OpenSSL::Digest::SHA1.new
-    keys_path   = File.expand_path('../keys', __FILE__)
-    private_key = rsa_key(File.read("#{keys_path}/signing_key.pem"))
+    sha1                  = OpenSSL::Digest::SHA1.new
+    keys_path             = File.expand_path('../keys', __FILE__)
+    private_key           = rsa_key(File.read("#{keys_path}/signing_key.pem"))
+    canonicalization_mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0
 
     signed_info_node = @doc.at("dsig|SignedInfo", dsig: 'http://www.w3.org/2000/09/xmldsig#')
-    actual_signature = encode(private_key.sign(sha1, signed_info_node.canonicalize))
+    actual_signature = encode(private_key.sign(sha1, signed_info_node.canonicalize(canonicalization_mode)))
 
     calculated_signature = @doc.at("dsig|SignatureValue", dsig: 'http://www.w3.org/2000/09/xmldsig#').content
 

data/test/sepa/sepa_test.rb

@@ -3,6 +3,6 @@ require 'test_helper'
 class TestSepa < ActiveSupport::TestCase
   test 'version is defined correctly' do
     refute_nil Sepa::VERSION
-    assert_equal "1.1.6", Sepa::VERSION
+    assert_equal '1.1.7', Sepa::VERSION
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepafm
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.1.7
 platform: ruby
 authors:
 - Joni Kanerva
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-12 00:00:00.000000000 Z
+date: 2016-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel