sepafm 1.1.5 → 1.1.6

data/lib/sepa/xml_templates/soap/danske/renew_certificate.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/"
+              xmlns:pkif="http://danskebank.dk/PKI/PKIFactoryService">
+  <env:Header/>
+  <env:Body>
+    <pkif:RenewCertificateIn>
+      <pkif:RequestHeader>
+        <pkif:SenderId/>
+        <pkif:CustomerId/>
+        <pkif:RequestId/>
+        <pkif:Timestamp/>
+        <pkif:InterfaceVersion>1</pkif:InterfaceVersion>
+        <pkif:Environment/>
+      </pkif:RequestHeader>
+    </pkif:RenewCertificateIn>
+  </env:Body>
+</env:Envelope>

data/readme.md

@@ -1,8 +1,8 @@
 # Devlab / SEPA
 
-[![Code Climate](https://codeclimate.com/github/devlab-oy/sepa/badges/gpa.svg)](https://codeclimate.com/github/devlab-oy/sepa)
-[![Test Coverage](https://codeclimate.com/github/devlab-oy/sepa/badges/coverage.svg)](https://codeclimate.com/github/devlab-oy/sepa)
-[![Build Status](https://travis-ci.org/devlab-oy/sepa.svg?branch=master)](https://travis-ci.org/devlab-oy/sepa)
+[![Code Climate](https://codeclimate.com/repos/577f932c113b7263ba004849/badges/3728d42150003eafa174/gpa.svg)](https://codeclimate.com/repos/577f932c113b7263ba004849/feed)
+[![Test Coverage](https://codeclimate.com/repos/577f932c113b7263ba004849/badges/3728d42150003eafa174/coverage.svg)](https://codeclimate.com/repos/577f932c113b7263ba004849/coverage)
+[![Build Status](https://semaphoreci.com/api/v1/devlab/sepa/branches/master/badge.svg)](https://semaphoreci.com/devlab/sepa)
 [![Gem Version](https://badge.fury.io/rb/sepafm.svg)](http://badge.fury.io/rb/sepafm)
 
 This project aims to create an open source implementation of SEPA Financial Messages using Web Services. Project implementation is done in Ruby.

data/sepafm.gemspec

@@ -16,16 +16,16 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.1.7'
+  spec.required_ruby_version = '>= 2.2.5'
 
   spec.add_dependency 'activemodel', '~> 4.2'
   spec.add_dependency 'nokogiri',    '~> 1.6'
   spec.add_dependency 'savon',       '~> 2.11'
 
   spec.add_development_dependency 'bundler',                   '~> 1.12'
-  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.5'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.6'
   spec.add_development_dependency 'dotenv',                    '~> 2.1'
-  spec.add_development_dependency 'minitest',                  '~> 5.8'
-  spec.add_development_dependency 'rake',                      '~> 11.1'
+  spec.add_development_dependency 'minitest',                  '~> 5.9'
+  spec.add_development_dependency 'rake',                      '~> 11.2'
   spec.add_development_dependency 'rubyntlm',                  '~> 0.6'
 end

data/test/custom_assertions.rb

@@ -11,6 +11,27 @@ module Minitest::Assertions
            "Expected #{ expected.inspect } and #{ actual.inspect } would not have the same items"
   end
 
+  def assert_valid_against_schema(schema, document)
+    errors = []
+
+    Dir.chdir(SCHEMA_PATH) do
+      xsd = Nokogiri::XML::Schema(IO.read(schema))
+      xsd.validate(document).each do |error|
+        errors << error
+      end
+    end
+
+    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+  end
+
+  def refute_valid_against_schema(schema, document)
+    Dir.chdir(SCHEMA_PATH) do
+      xsd = Nokogiri::XML::Schema(IO.read(schema))
+
+      refute xsd.valid?(document)
+    end
+  end
+
   private
 
     def same_items(expected, actual)

data/test/sepa/banks/danske/danske_cert_soap_builder_test.rb

@@ -90,10 +90,6 @@ class DanskeCertSoapBuilderTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      assert xsd.valid?(@doc)
-    end
+    assert_valid_against_schema 'soap.xsd', @doc
   end
-
 end

data/test/sepa/banks/danske/danske_certificate_application_request_test.rb

@@ -2,15 +2,13 @@ require 'test_helper'
 
 class DanskeCertificateApplicationRequestTest < ActiveSupport::TestCase
   setup do
-    @danske_create_certificate_params = danske_create_certificate_params
-@danske_create_certificate_params[:environment] = :test
-@danske_create_certificate_application_request    =
-        Sepa::ApplicationRequest.new @danske_create_certificate_params
+    @params = danske_create_certificate_params
+    @ar     = Sepa::ApplicationRequest.new(@params)
   end
 
-  test 'should set environment to customertest when test in parameters' do
-    environment_node =
-        @danske_create_certificate_application_request.to_nokogiri.at('tns|Environment')
-    assert_equal environment_node.content, 'customertest'
+  test 'environment is set to customertest when test in parameters' do
+    environment_node = @ar.to_nokogiri.at('tns|Environment')
+
+    assert_equal 'customertest', environment_node.content
   end
 end

data/test/sepa/banks/danske/danske_generic_soap_builder_test.rb

@@ -223,41 +223,25 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      assert xsd.valid?(@doc)
-    end
+    assert_valid_against_schema 'soap.xsd', @doc
   end
 
   def test_schema_validation_should_fail_with_wrong_must_understand_value
-    wsse = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
-    security_node = @doc.at(
-      '//wsse:Security', 'wsse' => wsse
-    )
+    wsse          = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+    security_node = @doc.at('//wsse:Security', 'wsse' => wsse)
 
     security_node['env:mustUnderstand'] = '3'
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      refute xsd.valid?(@doc)
-    end
+    refute_valid_against_schema 'soap.xsd', @doc
   end
 
   def test_should_validate_against_ws_security_schema
-    wsse = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
-
-    ws_node = @doc.xpath(
-      '//wsse:Security', 'wsse' => wsse
-    )
-
+    wsse    = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+    ws_node = @doc.xpath('//wsse:Security', 'wsse' => wsse)
     ws_node = ws_node.to_xml
-
     ws_node = Nokogiri::XML(ws_node)
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema IO.read 'oasis-200401-wss-wssecurity-secext-1.0.xsd'
-      assert xsd.valid?(ws_node)
-    end
+    assert_valid_against_schema 'oasis-200401-wss-wssecurity-secext-1.0.xsd', ws_node
   end
 
   test 'application request is encrypted' do

data/test/sepa/banks/danske/danske_get_bank_cert_test.rb

@@ -80,20 +80,14 @@ class DanskeGetBankCertTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_soap_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      assert xsd.valid?(@doc)
-    end
+    assert_valid_against_schema 'soap.xsd', @doc
   end
 
   def test_request_should_validate_against_pki_service_schema
     request = @doc.css('GetBankCertificateRequest', 'xmlns' => @elem).to_xml
     request = Nokogiri::XML(request)
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('PKIFactory.xsd'))
-      assert xsd.valid?(request)
-    end
+    assert_valid_against_schema 'PKIFactory.xsd', request
   end
 
   def test_invalid_bank_root_cert_serial_should_fail_schema_validation
@@ -102,10 +96,6 @@ class DanskeGetBankCertTest < ActiveSupport::TestCase
     request = @doc.css('GetBankCertificateRequest', 'xmlns' => @elem).to_xml
     request = Nokogiri::XML(request)
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('PKIFactory.xsd'))
-      refute xsd.valid?(request)
-    end
+    refute_valid_against_schema 'PKIFactory.xsd', request
   end
-
 end

data/test/sepa/banks/danske/danske_renew_cert_application_request_test.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class DanskeRenewCertApplicationRequestTest < ActiveSupport::TestCase
+  setup do
+    @params = danske_renew_cert_params
+
+    # Convert the keys here since the conversion is usually done by the client and these tests
+    # bypass the client
+    @params[:own_signing_certificate] = x509_certificate(@params[:own_signing_certificate])
+    @params[:signing_private_key]     = rsa_key(@params[:signing_private_key])
+
+    @ar  = Sepa::ApplicationRequest.new(@params)
+    @doc = @ar.to_nokogiri
+  end
+
+  test 'validates against schema' do
+    assert_valid_against_schema 'danske_pki.xsd', @doc
+  end
+
+  test 'signature is calculated correctly' do
+    sha1        = OpenSSL::Digest::SHA1.new
+    keys_path   = File.expand_path('../keys', __FILE__)
+    private_key = rsa_key(File.read("#{keys_path}/signing_key.pem"))
+
+    signed_info_node = @doc.at("dsig|SignedInfo", dsig: 'http://www.w3.org/2000/09/xmldsig#')
+    actual_signature = encode(private_key.sign(sha1, signed_info_node.canonicalize))
+
+    calculated_signature = @doc.at("dsig|SignatureValue", dsig: 'http://www.w3.org/2000/09/xmldsig#').content
+
+    assert_equal actual_signature, calculated_signature
+  end
+end

data/test/sepa/banks/danske/danske_renew_cert_request_soap_builder_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'
+
+class DanskeRenewCertRequestSoapBuilderTest < ActiveSupport::TestCase
+  setup do
+    @params = danske_renew_cert_params
+
+    # Convert the keys here since the conversion is usually done by the client and these tests
+    # bypass the client
+    @params[:own_signing_certificate] = x509_certificate(@params[:own_signing_certificate])
+    @params[:signing_private_key]     = rsa_key(@params[:signing_private_key])
+
+    soap_builder = Sepa::SoapBuilder.new(@params)
+    @doc         = Nokogiri::XML(soap_builder.to_xml)
+  end
+
+  test "validates against schema" do
+    assert_valid_against_schema 'soap.xsd', @doc
+  end
+
+  test 'validates against ws security schema' do
+    wsse    = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+    ws_node = @doc.at('wsse|Security', 'wsse': wsse)
+    ws_node = ws_node.to_xml
+    ws_node = Nokogiri::XML(ws_node)
+
+    assert_valid_against_schema 'oasis-200401-wss-wssecurity-secext-1.0.xsd', ws_node
+  end
+
+  test 'signature is calculated correctly' do
+    sha1        = OpenSSL::Digest::SHA1.new
+    private_key = rsa_key(@params.fetch(:signing_private_key))
+
+    added_signature = @doc.at("dsig|SignatureValue", dsig: 'http://www.w3.org/2000/09/xmldsig#').content
+
+    signed_info_node = @doc.at("dsig|SignedInfo", dsig: 'http://www.w3.org/2000/09/xmldsig#')
+    signed_info_node = signed_info_node.canonicalize(Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0)
+    actual_signature = encode(private_key.sign(sha1, signed_info_node)).gsub(/\s+/, "")
+
+    assert_equal actual_signature, added_signature
+  end
+end

data/test/sepa/banks/nordea/nordea_application_request_test.rb

@@ -241,30 +241,18 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test 'download file should validate against schema' do
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('application_request.xsd'))
-      assert xsd.valid?(@doc_file)
-    end
+    assert_valid_against_schema 'application_request.xsd', @doc_file
   end
 
   test 'upload file should validate against schema' do
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('application_request.xsd'))
-      assert xsd.valid?(@doc_up)
-    end
+    assert_valid_against_schema 'application_request.xsd', @doc_up
   end
 
   test 'download file list should validate against schema' do
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('application_request.xsd'))
-      assert xsd.valid?(@doc_list)
-    end
+    assert_valid_against_schema 'application_request.xsd', @doc_list
   end
 
   test 'get user info should validate against schema' do
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('application_request.xsd'))
-      assert xsd.valid?(@doc_get)
-    end
+    assert_valid_against_schema 'application_request.xsd', @doc_get
   end
 end

data/test/sepa/banks/nordea/nordea_cert_application_request_test.rb

@@ -64,10 +64,6 @@ class NordeaCertApplicationRequestTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('cert_application_request.xsd'))
-      assert xsd.valid?(@xml)
-    end
+    assert_valid_against_schema 'cert_application_request.xsd', @xml
   end
-
 end

data/test/sepa/banks/nordea/nordea_cert_request_soap_builder_test.rb

@@ -56,10 +56,7 @@ class NordeaCertRequestSoapBuilderTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      assert xsd.valid?(@xml)
-    end
+    assert_valid_against_schema 'soap.xsd', @xml
   end
 
 end

data/test/sepa/banks/nordea/nordea_generic_soap_builder_test.rb

@@ -237,40 +237,24 @@ class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
   end
 
   def test_should_validate_against_schema
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      assert xsd.valid?(@doc)
-    end
+    assert_valid_against_schema 'soap.xsd', @doc
   end
 
   def test_schema_validation_should_fail_with_wrong_must_understand_value
-    wsse = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
-    security_node = @doc.xpath(
-      '//wsse:Security', 'wsse' => wsse
-    ).first
+    wsse          = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+    security_node = @doc.xpath('//wsse:Security', 'wsse' => wsse).first
 
     security_node['env:mustUnderstand'] = '3'
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      refute xsd.valid?(@doc)
-    end
+    refute_valid_against_schema 'soap.xsd', @doc
   end
 
   def test_should_validate_against_ws_security_schema
-    wsse = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
-
-    ws_node = @doc.xpath(
-      '//wsse:Security', 'wsse' => wsse
-    )
-
+    wsse    = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+    ws_node = @doc.xpath('//wsse:Security', 'wsse' => wsse)
     ws_node = ws_node.to_xml
     ws_node = Nokogiri::XML(ws_node)
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema IO.read 'oasis-200401-wss-wssecurity-secext-1.0.xsd'
-      assert xsd.valid?(ws_node)
-    end
+    assert_valid_against_schema 'oasis-200401-wss-wssecurity-secext-1.0.xsd', ws_node
   end
-
 end

data/test/sepa/banks/nordea/nordea_renew_cert_application_request_test.rb

@@ -14,16 +14,7 @@ class NordeaRenewCertApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test "validates against schema" do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('cert_application_request.xsd'))
-      xsd.validate(@doc).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'cert_application_request.xsd', @doc
   end
 
   test "customer id is set correctly" do

data/test/sepa/banks/nordea/nordea_renew_cert_request_soap_builder_test.rb

@@ -14,16 +14,7 @@ class NordeaRenewCertRequestSoapBuilderTest < ActiveSupport::TestCase
   end
 
   test "validates against schema" do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      xsd.validate(@doc).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'soap.xsd', @doc
   end
 
   test 'sender id is properly set' do

data/test/sepa/banks/op/op_application_request_test.rb

@@ -23,41 +23,14 @@ class OpApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test 'download file validates against schema' do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('op/ApplicationRequest_20080918.xsd'))
-      xsd.validate(@doc_file).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'op/ApplicationRequest_20080918.xsd', @doc_file
   end
 
   test 'upload file validates against schema' do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('op/ApplicationRequest_20080918.xsd'))
-      xsd.validate(@doc_up).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'op/ApplicationRequest_20080918.xsd', @doc_up
   end
 
   test 'download file list validates against schema' do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('op/ApplicationRequest_20080918.xsd'))
-      xsd.validate(@doc_list).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'op/ApplicationRequest_20080918.xsd', @doc_list
   end
 end

data/test/sepa/banks/op/op_cert_application_request_test.rb

@@ -63,15 +63,6 @@ class OpCertApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test "validates against schema" do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('op/CertApplicationRequest_200812.xsd'))
-      xsd.validate(@xml).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'op/CertApplicationRequest_200812.xsd', @xml
   end
 end

data/test/sepa/banks/op/op_cert_request_soap_builder_test.rb

@@ -48,15 +48,6 @@ class OpCertRequestSoapBuilderTest < ActiveSupport::TestCase
   end
 
   test "validates against schema" do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      xsd.validate(@xml).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'soap.xsd', @xml
   end
 end

data/test/sepa/banks/op/op_generic_soap_builder_test.rb

@@ -19,16 +19,7 @@ class OpGenericSoapBuilderTest < ActiveSupport::TestCase
   end
 
   test 'validates against schema' do
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('soap.xsd'))
-      xsd.validate(@doc).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'soap.xsd', @doc
   end
 
   test 'validates against ws security schema' do
@@ -38,15 +29,6 @@ class OpGenericSoapBuilderTest < ActiveSupport::TestCase
     ws_node = ws_node.to_xml
     ws_node = Nokogiri::XML(ws_node)
 
-    errors = []
-
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read('oasis-200401-wss-wssecurity-secext-1.0.xsd'))
-      xsd.validate(ws_node).each do |error|
-        errors << error
-      end
-    end
-
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    assert_valid_against_schema 'oasis-200401-wss-wssecurity-secext-1.0.xsd', ws_node
   end
 end