sepafm 0.1.0 → 0.1.1

data/lib/sepa/version.rb

@@ -1,3 +1,3 @@
 module Sepa
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/sepafm.rb

@@ -25,3 +25,17 @@ SCHEMA_PATH = "#{ROOT_PATH}/lib/sepa/xml_schemas"
 SCHEMA_FILE = "#{ROOT_PATH}/lib/sepa/xml_schemas/wsdl.xml"
 AR_TEMPLATE_PATH = "#{ROOT_PATH}/lib/sepa/xml_templates/application_request"
 SOAP_TEMPLATE_PATH = "#{ROOT_PATH}/lib/sepa/xml_templates/soap"
+
+# Common XML namespaces
+DSIG = 'http://www.w3.org/2000/09/xmldsig#'
+OASIS_UTILITY = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd'
+OASIS_SECEXT = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd'
+XML_DATA = 'http://bxd.fi/xmldata/'
+BXD = 'http://model.bxd.fi'
+
+# Nordea XML namespaces
+NORDEA_PKI = 'http://bxd.fi/CertificateService'
+NORDEA_XML_DATA = 'http://filetransfer.nordea.com/xmldata/'
+
+# Danske XML namespaces
+DANSKE_PKI = 'http://danskebank.dk/PKI/PKIFactoryService/elements'

data/{README.md → readme.md}

@@ -71,7 +71,7 @@ Make sure response is valid
 response.valid?
 ```
 
-Get reponse content
+Get response content
 
 ```ruby
 response.content

data/test/sepa/banks/danske/danske_cert_response_test.rb

@@ -2,51 +2,65 @@ require 'test_helper'
 
 class DanskeCertResponseTest < ActiveSupport::TestCase
 
-  get_bank_cert_soap = Nokogiri::XML(File.open "#{DANSKE_TEST_RESPONSE_PATH}get_bank_cert.xml")
-  get_bank_cert_response = Sepa::DanskeResponse.new(get_bank_cert_soap, command: :get_bank_certificate)
+  setup do
+    options = {
+        response: (File.open "#{DANSKE_TEST_RESPONSE_PATH}get_bank_cert.xml"),
+        command: :get_bank_certificate
+    }
+    @get_bank_cert_response = Sepa::DanskeResponse.new options
 
-  create_certificate_soap = Nokogiri::XML(File.open "#{DANSKE_TEST_RESPONSE_PATH}create_cert.xml")
-  create_certificate_response = Sepa::DanskeResponse.new(create_certificate_soap, command: :create_certificate)
+    options = {
+        response: (File.open "#{DANSKE_TEST_RESPONSE_PATH}create_cert.xml"),
+        command: :create_certificate
+    }
+    @create_certificate_response = Sepa::DanskeResponse.new options
+  end
 
-  ##
   # Tests for get bank certificate
-
   test 'should have correct bank signing cert with get_bank_certificate command' do
-    bank_signing_cert = get_bank_cert_response.bank_signing_cert
+    bank_signing_cert = @get_bank_cert_response.bank_signing_cert
     refute_nil bank_signing_cert
     assert_equal bank_signing_cert.to_s, DANSKE_BANK_SIGNING_CERT
   end
 
   test 'should have corrent bank encryption cert with get bank certificate command' do
-    bank_encryption_cert = get_bank_cert_response.bank_encryption_cert
+    bank_encryption_cert = @get_bank_cert_response.bank_encryption_cert
     refute_nil bank_encryption_cert
     assert_equal bank_encryption_cert.to_s, DANSKE_BANK_ENCRYPTION_CERT
   end
 
   test 'should have correct bank root cert with get bank certificate command' do
-    bank_root_cert = get_bank_cert_response.bank_root_cert
+    bank_root_cert = @get_bank_cert_response.bank_root_cert
     refute_nil bank_root_cert
     assert_equal bank_root_cert.to_s, DANSKE_BANK_ROOT_CERT
   end
 
-  ##
   # Tests for create certificate
-
   test 'should have own encryption certificate with create certificate command' do
-    own_encryption_cert = create_certificate_response.own_encryption_cert
+    own_encryption_cert = @create_certificate_response.own_encryption_cert
     refute_nil own_encryption_cert
     assert own_encryption_cert.respond_to? :sign
   end
 
   test 'should have on signing certificate with create certificate command' do
-    own_signing_cert = create_certificate_response.own_signing_cert
+    own_signing_cert = @create_certificate_response.own_signing_cert
     refute_nil own_signing_cert
     assert own_signing_cert.respond_to? :sign
   end
 
   test 'should have correct CA certificate with create certificate command' do
-    ca_certificate = create_certificate_response.ca_certificate
+    ca_certificate = @create_certificate_response.ca_certificate
     refute_nil ca_certificate
     assert ca_certificate.respond_to? :sign
   end
+
+  test 'hashes should match' do
+    assert @create_certificate_response.hashes_match?
+  end
+
+  test 'hashes shouldnt match when data is corrupted' do
+    @create_certificate_response.doc.at('xmlns|ReturnText', xmlns: DANSKE_PKI).content = 'kana'
+    refute @create_certificate_response.hashes_match?
+  end
+
 end

data/test/sepa/banks/danske/danske_cert_soap_builder_test.rb

@@ -66,17 +66,17 @@ class DanskeCertSoapBuilderTest < ActiveSupport::TestCase
 
   def test_encrypted_key_is_added_properly_and_can_be_decrypted
     enc_key = @doc.css("CipherValue", 'xmlns' => @xenc)[0].content
-    enc_key = Base64.decode64(enc_key)
+    enc_key = decode enc_key
     assert @enc_private_key.private_decrypt(enc_key)
   end
 
   def test_encypted_data_is_added_properly_and_can_be_decrypted
     enc_key = @doc.css("CipherValue", 'xmlns' => @xenc)[0].content
-    enc_key = Base64.decode64(enc_key)
+    enc_key = decode enc_key
     key = @enc_private_key.private_decrypt(enc_key)
 
     encypted_data = @doc.css("CipherValue", 'xmlns' => @xenc)[1].content
-    encypted_data = Base64.decode64(encypted_data)
+    encypted_data = decode encypted_data
     iv = encypted_data[0, 8]
     encypted_data = encypted_data[8, encypted_data.length]
 

data/test/sepa/banks/danske/danske_generic_soap_builder_test.rb

@@ -26,7 +26,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       status: 'ALL',
       target_id: 'Danske FI',
       file_type: 'pain.001.001.02',
-      content: Base64.encode64('kissa'),
+      content: encode('kissa'),
       file_reference: "11111111A12006030329501800000014",
     }
 
@@ -159,7 +159,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       inclusive_namespaces = nil, with_comments = false
     )
 
-    actual_digest = Base64.encode64(sha1.digest(body_node)).strip
+    actual_digest = encode(sha1.digest(body_node)).strip
 
     assert_equal actual_digest, added_digest
   end
@@ -208,7 +208,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       with_comments = false
     )
 
-    actual_digest = Base64.encode64(sha1.digest(timestamp_node)).strip
+    actual_digest = encode(sha1.digest(timestamp_node)).strip
 
     assert_equal actual_digest, added_digest
   end
@@ -230,7 +230,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       with_comments = false
     )
 
-    actual_signature = Base64.encode64(
+    actual_signature = encode(
       private_key.sign(sha1, signed_info_node)
     ).gsub(/\s+/, "")
 

data/test/sepa/banks/danske/responses/create_cert.xml

@@ -1,38 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:pkif="http://danskebank.dk/PKI/PKIFactoryService" xmlns:elem="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns:xd="http://www.w3.org/2000/09/xmldsig#">
-  <soapenv:Header/>
-  <soapenv:Body>
-    <CreateCertificateOut xmlns="http://danskebank.dk/PKI/PKIFactoryService">
-      <pkif:ResponseHeader xmlns="">
-        <pkif:SenderId>360817</pkif:SenderId>
-        <pkif:CustomerId>360817</pkif:CustomerId>
-        <pkif:RequestId>494d9bf886</pkif:RequestId>
-        <pkif:Timestamp>2014-06-11T10:46:37Z</pkif:Timestamp>
-        <pkif:InterfaceVersion>1</pkif:InterfaceVersion>
-        <pkif:Environment>customertest</pkif:Environment>
-      </pkif:ResponseHeader>
-      <tns:CreateCertificateResponse xmlns:tns="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns="" xml:id="response">
-        <tns:ReturnCode>00</tns:ReturnCode>
-        <tns:ReturnText>OK</tns:ReturnText>
-        <tns:EncryptionCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NjANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCvWdhjVCuWXWu4H8WqUJGuvme+6l0g37fAXur3Xm28RChzvhue7pvwhtsZEyHN3Oa9DhLMV9UQC4wy5Md7Js+rm2HtgOtM2LMorE4GeoTYpi5f1fbYDUqHj2ygkkWDqQ9v0xSCJkGIyW+1vsrcId+DDlZqBacuXwtv5xy8plmX7wIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIEMDANBgkqhkiG9w0BAQsFAAOCAQEAkITeNDN6Mxkb8AXF9SjZ1xfWD+yZcyb5wqQmpvwlM1gfovvV5mW/r2Wgn8uyhwwZd8dDJClNRslQeQrV8FbmCF8uh0dr1z2pt/t3u6lZ5YH1MWmLKGpJ8gGnWkRwEtkeZCuaD+Nji6YCGqCPytmKae+CFvz46XrvQ+VxfoqD8IlSoT2Himw6kfbE7H5oyJtuBSjozz+zz9GE09HQzCn3j1AX1jF0U0qFOXOR185NnDHtQPBytUOOBHBNog1+bVfby7E1nmXum38pMVnv5ReSvnhKhmusmxkHaKCGwgYCoKMvsXntHStAvmH/t4tGdNyLvmC/88GYfoBXtNrsuZV3Ew==</tns:EncryptionCert>
-        <tns:SigningCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NTANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCfh+ajEvsFS1kByPsjReO+EmyFglGDiCBh7voya2aSbvGMQm/aAYugTliAhoklq4adwUwqjf86gon3ZdUMDBmDpJiPlxeexBHesOjr32hxzO8u67tS5o1xfDex3ga192g+94pAJsqmn3Fc8LJ0Wn2zJPtYCTYvbrx6551QLiD3fwIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIGwDANBgkqhkiG9w0BAQsFAAOCAQEASgxJaAoWP08MKVnuvNxG7EkmogFUfKCX7fWrHYxDzEs5uhnRQ6IR4GitTHEM/BE5KNGu6MuHuKMhp4HuMBg5YzaFtk5yFk+K6BjLEEFwz/NBFLyrtPmrezxjmxMYx4PRTqeyEthOIkZ1KFQvzxB1Vg2Kt5fqdvxKVODAFstJB2nE3uICnrOQmHlo/R/1rp0J/VQnOsWdgKmIFhFlFdFpWhI7m1ry7cuilHPdCHq+M83jGfTYVXulwbxDYv0LPHZGzCxoAnxZQM4r2HqwXTCZiRT/eP+fEv7A571aHb9GhJhQQQ0lStd1vhOJu1LlO3fe68SSKSye5CozKwvvlEwbag==</tns:SigningCert>
-        <tns:CACert>MIIEFzCCAv+gAwIBAgIFAc+WvjUwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTEzMDAwMzAeFw0xMDEwMTEwMDAwMDBaFw0yMDEwMTEwMDAwMDBaMIGaMRAwDgYDVQQDEwdEQkdTV0RLMQswCQYDVQQGEwJESzETMBEGA1UEBxMKQ29wZW5oYWdlbjEQMA4GA1UECBMHRGVubWFyazEaMBgGA1UEChMRRGFuc2tlIEJhbmsgR3JvdXAxHDAaBgNVBAsTE0RhbnNrZSBCYW5rIERlbm1hcmsxGDAWBgNVBAUTDzYxMTI2MjI4NzczMDEwMTCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAOC0DrY9Q4HzHQ/BWr/RWB1GOq+90BiGN85uhWAeGGMI2od/ahn/R7zl8+MNcMLAuVHB8LvzRrC3lxZqjNvRKv8fYsMgwdmdYtBwiqHINpXTLjQxtLEWqEu5fiMZAi1oFE08YAkCDLUGopbkY+d2KULqxFK2blwHi3m0jOwuZGiw4ELeChGcELsOpCT/oJU5mR3dFHbRs3HBgWmuFwJKvwHNZeNAmrCwEUWqw1x4MjQRHRGl10TfTNqPrd7zyTfyR0+GPy1INxHwWZroBUc9j54ONX9pV6x835WedHdo80UxImjCiIruClzsMAXYtvsC3d9xgk9oLNFIVPRe2fTs07ECAQOjZjBkMB8GA1UdIwQYMBaAFLU6ie9kUC8x5CDLauuTRJBL35qYMB0GA1UdDgQWBBQO5nD7QkqlQCrxigdJncTYo20tIzAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB/wIBADANBgkqhkiG9w0BAQsFAAOCAQEAQPCp0H3g88CZZurq0kS76ozBVRiLZ3V8S0+IYi0dmMCfTpW/qnEzMGn+NlHOvgkm5C2VaHCdbEzZPsvv4cx2YrqpsFf8x+Ts6W2r3VVjOdve5u0Oj1CK/ONwaqUl5p4SxRCfnv6sSh6TwxhJF/zESiHXLdyWdJf+NkXsATE6QB4ZjgaGw1NcvhnDUvbbfUZ1zOTIf7+wUpfCNCJi0T1sFvJ88nYkVoQmVWQFS7Kwj+kwQ1ILfnp/1xbycrt1XNxZ8SkRDAWOJARY0fS/C0o7/1t/SB2ePrY/g0U8ZWi0B6odT5isGNpLOKzhD5YGjbKGesC9GEnhmhLoawXU7b4Wcw==</tns:CACert>
-        <tns:RequestId/>
-        <Signature xmlns="http://www.w3.org/2000/09/xmldsig#">
-          <SignedInfo>
-            <CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
-            <SignatureMethod Algorithm="http://www.w3.org/2000/09/xmldsig#rsa-sha1"/>
-            <Reference URI="#response">
-              <Transforms>
-                <Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/>
-                <Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
-              </Transforms>
-              <DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1"/>
-              <DigestValue>2vCYl3h7ksRgk7IyV2axgpXxTWM=</DigestValue>
-            </Reference>
-          </SignedInfo>
-          <SignatureValue>CqPQW88gjJayDovXbk++IXJ5yjAJNf5+BL6wodkwIErqLdK3DYeAn9T6MQRNciB7POZkKqtnFj4CG1mbpGRCP5yduaBYP96uUoRSZiGuFHqb5HvMIgMvDCsnRJX11tUaMhrZkktYb0Xx2ulPrbLm/n9kW9L0oZftEijm7ixYSIsNEdJMHxWqCDGQCzLwD5zz512nNHEm3Ddimvh3mOqZ6deGtfODl4KuK247NNuak6Pjz9sE5hJnwDi4E1jtme735HEcxkrtYlqTIOjPXS/xRKkHEW6R59R3DR3FpYAo3H+SR/2WptoQhaBvVtlzle9Z8BG2JFRnbudAo3CkA245Vg==</SignatureValue><KeyInfo><X509Data><X509Certificate>MIIEADCCAuigAwIBAgIFAMa3bfMwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTExMDAwMjAeFw0xMjA4MDEwMDAwMDBaFw0xNDEwMzEwMDAwMDBaMIGXMQ8wDQYDVQQDEwZEUFNJR04xCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MzkxMDAwMzCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAL1zYMqPk/6klEpL5wo+vWAo3MmxPz4wq9wuLAHpPUhJ4ZpHmncNsdmqSSXT6U4mxTY8tzKvz4ZdTDljp+5J6OxOl1B7av3V7hlHtfGb7wozsBAya2JOoPrLxc+ajapslbduiEvdhW9ZLKvn/n7rQ9sZzHA6GyGKQk8lfvKK+OjMylA86XyxApasFD/0eIDnzUJHth3UpPoQTJAlB7h7d4CKc/QG9tFv900AAi4R/Tmy9TRai7fVCkXz7y4qRXN+M7NIhDGAsCmtM6oSuDqjv3lh10nD7XELTxTvcbpq5xHLt9yknwjiM2ivc4XudDMgC7ESoH6vaJSUcbC17+wa6IUCAQOjUjBQMB8GA1UdIwQYMBaAFIT65b/ekUlm38WKUsOzt7MgHMdtMB0GA1UdDgQWBBQHbPgey2TInIKC7xbag8AZG25qnTAOBgNVHQ8BAf8EBAMCBsAwDQYJKoZIhvcNAQELBQADggEBAFl3WfGkVElIeUXjQsr8uQFXhkSbrI14F6mRIkUpCTa9Px/UUfw1HQNVn4Tyep30JmfsFN91Yj387jiZDzoeMYeiVI32wyZkao7rC3Z4YhAfUdPdVFZqO1k2gOgoZ49nyLKVS+GlyuzeLQVBnFE7f3sbpgDTRzd8o58W5VncHuzmSj/IVe8ZwRQ4bm3cHlKTQpRnyz5x7UJjp08fH6KOUal8DVsOaQKoo+jWIsPPir58b/QZsxIRL4uq3qqQt5udrbZqyltRsyxUpgomIN5irCn7Wgr+iYwNLhzXYwxKvwKsNRS7isEAZuyfH9fNarBRP4p72g+225NB0itQ73Xo7pg=</X509Certificate><X509IssuerSerial><X509IssuerName>serialNumber=611262281110002, OU=Danske Bank Group, O=Danske Bank Group, ST=Denmark, L=Copenhagen, C=DK, CN=DBGROOT</X509IssuerName><X509SerialNumber>3333910003</X509SerialNumber></X509IssuerSerial></X509Data></KeyInfo></Signature>
-      </tns:CreateCertificateResponse>
-    </CreateCertificateOut>
-  </soapenv:Body>
-</soapenv:Envelope>
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:pkif="http://danskebank.dk/PKI/PKIFactoryService" xmlns:elem="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns:xd="http://www.w3.org/2000/09/xmldsig#"><soapenv:Header/><soapenv:Body><CreateCertificateOut xmlns="http://danskebank.dk/PKI/PKIFactoryService"><pkif:ResponseHeader xmlns=""><pkif:SenderId>360817</pkif:SenderId><pkif:CustomerId>360817</pkif:CustomerId><pkif:RequestId>b0410899f4</pkif:RequestId><pkif:Timestamp>2014-06-25T11:45:47Z</pkif:Timestamp><pkif:InterfaceVersion>1</pkif:InterfaceVersion><pkif:Environment>customertest</pkif:Environment></pkif:ResponseHeader><tns:CreateCertificateResponse xml:id="response" xmlns:tns="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns=""><tns:ReturnCode>00</tns:ReturnCode><tns:ReturnText>OK</tns:ReturnText><tns:EncryptionCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NjANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCvWdhjVCuWXWu4H8WqUJGuvme+6l0g37fAXur3Xm28RChzvhue7pvwhtsZEyHN3Oa9DhLMV9UQC4wy5Md7Js+rm2HtgOtM2LMorE4GeoTYpi5f1fbYDUqHj2ygkkWDqQ9v0xSCJkGIyW+1vsrcId+DDlZqBacuXwtv5xy8plmX7wIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIEMDANBgkqhkiG9w0BAQsFAAOCAQEAkITeNDN6Mxkb8AXF9SjZ1xfWD+yZcyb5wqQmpvwlM1gfovvV5mW/r2Wgn8uyhwwZd8dDJClNRslQeQrV8FbmCF8uh0dr1z2pt/t3u6lZ5YH1MWmLKGpJ8gGnWkRwEtkeZCuaD+Nji6YCGqCPytmKae+CFvz46XrvQ+VxfoqD8IlSoT2Himw6kfbE7H5oyJtuBSjozz+zz9GE09HQzCn3j1AX1jF0U0qFOXOR185NnDHtQPBytUOOBHBNog1+bVfby7E1nmXum38pMVnv5ReSvnhKhmusmxkHaKCGwgYCoKMvsXntHStAvmH/t4tGdNyLvmC/88GYfoBXtNrsuZV3Ew==</tns:EncryptionCert><tns:SigningCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NTANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCfh+ajEvsFS1kByPsjReO+EmyFglGDiCBh7voya2aSbvGMQm/aAYugTliAhoklq4adwUwqjf86gon3ZdUMDBmDpJiPlxeexBHesOjr32hxzO8u67tS5o1xfDex3ga192g+94pAJsqmn3Fc8LJ0Wn2zJPtYCTYvbrx6551QLiD3fwIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIGwDANBgkqhkiG9w0BAQsFAAOCAQEASgxJaAoWP08MKVnuvNxG7EkmogFUfKCX7fWrHYxDzEs5uhnRQ6IR4GitTHEM/BE5KNGu6MuHuKMhp4HuMBg5YzaFtk5yFk+K6BjLEEFwz/NBFLyrtPmrezxjmxMYx4PRTqeyEthOIkZ1KFQvzxB1Vg2Kt5fqdvxKVODAFstJB2nE3uICnrOQmHlo/R/1rp0J/VQnOsWdgKmIFhFlFdFpWhI7m1ry7cuilHPdCHq+M83jGfTYVXulwbxDYv0LPHZGzCxoAnxZQM4r2HqwXTCZiRT/eP+fEv7A571aHb9GhJhQQQ0lStd1vhOJu1LlO3fe68SSKSye5CozKwvvlEwbag==</tns:SigningCert><tns:CACert>MIIEFzCCAv+gAwIBAgIFAc+WvjUwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTEzMDAwMzAeFw0xMDEwMTEwMDAwMDBaFw0yMDEwMTEwMDAwMDBaMIGaMRAwDgYDVQQDEwdEQkdTV0RLMQswCQYDVQQGEwJESzETMBEGA1UEBxMKQ29wZW5oYWdlbjEQMA4GA1UECBMHRGVubWFyazEaMBgGA1UEChMRRGFuc2tlIEJhbmsgR3JvdXAxHDAaBgNVBAsTE0RhbnNrZSBCYW5rIERlbm1hcmsxGDAWBgNVBAUTDzYxMTI2MjI4NzczMDEwMTCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAOC0DrY9Q4HzHQ/BWr/RWB1GOq+90BiGN85uhWAeGGMI2od/ahn/R7zl8+MNcMLAuVHB8LvzRrC3lxZqjNvRKv8fYsMgwdmdYtBwiqHINpXTLjQxtLEWqEu5fiMZAi1oFE08YAkCDLUGopbkY+d2KULqxFK2blwHi3m0jOwuZGiw4ELeChGcELsOpCT/oJU5mR3dFHbRs3HBgWmuFwJKvwHNZeNAmrCwEUWqw1x4MjQRHRGl10TfTNqPrd7zyTfyR0+GPy1INxHwWZroBUc9j54ONX9pV6x835WedHdo80UxImjCiIruClzsMAXYtvsC3d9xgk9oLNFIVPRe2fTs07ECAQOjZjBkMB8GA1UdIwQYMBaAFLU6ie9kUC8x5CDLauuTRJBL35qYMB0GA1UdDgQWBBQO5nD7QkqlQCrxigdJncTYo20tIzAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB/wIBADANBgkqhkiG9w0BAQsFAAOCAQEAQPCp0H3g88CZZurq0kS76ozBVRiLZ3V8S0+IYi0dmMCfTpW/qnEzMGn+NlHOvgkm5C2VaHCdbEzZPsvv4cx2YrqpsFf8x+Ts6W2r3VVjOdve5u0Oj1CK/ONwaqUl5p4SxRCfnv6sSh6TwxhJF/zESiHXLdyWdJf+NkXsATE6QB4ZjgaGw1NcvhnDUvbbfUZ1zOTIf7+wUpfCNCJi0T1sFvJ88nYkVoQmVWQFS7Kwj+kwQ1ILfnp/1xbycrt1XNxZ8SkRDAWOJARY0fS/C0o7/1t/SB2ePrY/g0U8ZWi0B6odT5isGNpLOKzhD5YGjbKGesC9GEnhmhLoawXU7b4Wcw==</tns:CACert><tns:RequestId/><Signature xmlns="http://www.w3.org/2000/09/xmldsig#">
+  <SignedInfo>
+    <CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
+    <SignatureMethod Algorithm="http://www.w3.org/2000/09/xmldsig#rsa-sha1"/>
+    <Reference URI="#response">
+      <Transforms>
+        <Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/>
+        <Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
+      </Transforms>
+      <DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1"/>
+      <DigestValue>2vCYl3h7ksRgk7IyV2axgpXxTWM=</DigestValue>
+    </Reference>
+  </SignedInfo>
+  <SignatureValue>CqPQW88gjJayDovXbk++IXJ5yjAJNf5+BL6wodkwIErqLdK3DYeAn9T6MQRNciB7POZkKqtnFj4CG1mbpGRCP5yduaBYP96uUoRSZiGuFHqb5HvMIgMvDCsnRJX11tUaMhrZkktYb0Xx2ulPrbLm/n9kW9L0oZftEijm7ixYSIsNEdJMHxWqCDGQCzLwD5zz512nNHEm3Ddimvh3mOqZ6deGtfODl4KuK247NNuak6Pjz9sE5hJnwDi4E1jtme735HEcxkrtYlqTIOjPXS/xRKkHEW6R59R3DR3FpYAo3H+SR/2WptoQhaBvVtlzle9Z8BG2JFRnbudAo3CkA245Vg==</SignatureValue><KeyInfo><X509Data><X509Certificate>MIIEADCCAuigAwIBAgIFAMa3bfMwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTExMDAwMjAeFw0xMjA4MDEwMDAwMDBaFw0xNDEwMzEwMDAwMDBaMIGXMQ8wDQYDVQQDEwZEUFNJR04xCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MzkxMDAwMzCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAL1zYMqPk/6klEpL5wo+vWAo3MmxPz4wq9wuLAHpPUhJ4ZpHmncNsdmqSSXT6U4mxTY8tzKvz4ZdTDljp+5J6OxOl1B7av3V7hlHtfGb7wozsBAya2JOoPrLxc+ajapslbduiEvdhW9ZLKvn/n7rQ9sZzHA6GyGKQk8lfvKK+OjMylA86XyxApasFD/0eIDnzUJHth3UpPoQTJAlB7h7d4CKc/QG9tFv900AAi4R/Tmy9TRai7fVCkXz7y4qRXN+M7NIhDGAsCmtM6oSuDqjv3lh10nD7XELTxTvcbpq5xHLt9yknwjiM2ivc4XudDMgC7ESoH6vaJSUcbC17+wa6IUCAQOjUjBQMB8GA1UdIwQYMBaAFIT65b/ekUlm38WKUsOzt7MgHMdtMB0GA1UdDgQWBBQHbPgey2TInIKC7xbag8AZG25qnTAOBgNVHQ8BAf8EBAMCBsAwDQYJKoZIhvcNAQELBQADggEBAFl3WfGkVElIeUXjQsr8uQFXhkSbrI14F6mRIkUpCTa9Px/UUfw1HQNVn4Tyep30JmfsFN91Yj387jiZDzoeMYeiVI32wyZkao7rC3Z4YhAfUdPdVFZqO1k2gOgoZ49nyLKVS+GlyuzeLQVBnFE7f3sbpgDTRzd8o58W5VncHuzmSj/IVe8ZwRQ4bm3cHlKTQpRnyz5x7UJjp08fH6KOUal8DVsOaQKoo+jWIsPPir58b/QZsxIRL4uq3qqQt5udrbZqyltRsyxUpgomIN5irCn7Wgr+iYwNLhzXYwxKvwKsNRS7isEAZuyfH9fNarBRP4p72g+225NB0itQ73Xo7pg=</X509Certificate><X509IssuerSerial><X509IssuerName>serialNumber=611262281110002, OU=Danske Bank Group, O=Danske Bank Group, ST=Denmark, L=Copenhagen, C=DK, CN=DBGROOT</X509IssuerName><X509SerialNumber>3333910003</X509SerialNumber></X509IssuerSerial></X509Data></KeyInfo></Signature></tns:CreateCertificateResponse></CreateCertificateOut></soapenv:Body></soapenv:Envelope>

data/test/sepa/banks/nordea/nordea_application_request_test.rb

@@ -9,16 +9,16 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
     @nordea_generic_params[:private_key] = OpenSSL::PKey::RSA.new @nordea_generic_params[:private_key]
     @nordea_generic_params[:cert] = OpenSSL::X509::Certificate.new @nordea_generic_params[:cert]
 
-    ar_file = Sepa::SoapBuilder.new(@nordea_generic_params).ar
+    ar_file = Sepa::SoapBuilder.new(@nordea_generic_params).application_request
 
     @nordea_generic_params[:command] = :get_user_info
-    ar_get = Sepa::SoapBuilder.new(@nordea_generic_params).ar
+    ar_get = Sepa::SoapBuilder.new(@nordea_generic_params).application_request
 
     @nordea_generic_params[:command] = :download_file_list
-    ar_list = Sepa::SoapBuilder.new(@nordea_generic_params).ar
+    ar_list = Sepa::SoapBuilder.new(@nordea_generic_params).application_request
 
     @nordea_generic_params[:command] = :upload_file
-    ar_up = Sepa::SoapBuilder.new(@nordea_generic_params).ar
+    ar_up = Sepa::SoapBuilder.new(@nordea_generic_params).application_request
 
     @doc_file = Nokogiri::XML(ar_file.to_xml)
     @doc_get = Nokogiri::XML(ar_get.to_xml)
@@ -36,8 +36,8 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
     sha1.reset
 
     xmldsig_schema_digest = sha1.digest(xmldsig_schema)
-    assert_equal Base64.encode64(ar_schema_digest).strip, "1O24A7+/6S7CFYVlhH1jEZh1ARs="
-    assert_equal Base64.encode64(xmldsig_schema_digest).strip, "bmG0+2KykgkLeWsXsl6CFbyo4Yc="
+    assert_equal encode(ar_schema_digest).strip, "1O24A7+/6S7CFYVlhH1jEZh1ARs="
+    assert_equal encode(xmldsig_schema_digest).strip, "bmG0+2KykgkLeWsXsl6CFbyo4Yc="
   end
 
   def test_ar_should_initialize_with_proper_params
@@ -165,7 +165,7 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
   end
 
   def test_should_have_content_when_upload_file
-    assert_equal @doc_up.at_css("Content").content, Base64.encode64(@nordea_generic_params[:content])
+    assert_equal @doc_up.at_css("Content").content, encode(@nordea_generic_params[:content])
   end
 
   def test_should_not_have_content_when_download_file_list
@@ -200,7 +200,7 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
 
     # Calculate digest
     sha1 = OpenSSL::Digest::SHA1.new
-    actual_digest = Base64.encode64(sha1.digest(@doc_file.canonicalize))
+    actual_digest = encode(sha1.digest(@doc_file.canonicalize))
 
     # And then make sure the two are equal
     assert_equal calculated_digest.strip, actual_digest.strip
@@ -222,7 +222,7 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
     private_key = OpenSSL::PKey::RSA.new(File.read("#{keys_path}/nordea.key"))
 
     sha1 = OpenSSL::Digest::SHA1.new
-    actual_signature = Base64.encode64(private_key.sign(
+    actual_signature = encode(private_key.sign(
     sha1, signed_info_node.canonicalize))
 
     # And then of course assert the two are equal

data/test/sepa/banks/nordea/nordea_application_response_test.rb

@@ -1,23 +1,38 @@
 require 'test_helper'
 
 class NordeaApplicationResponseTest < ActiveSupport::TestCase
+  include Sepa::Utilities
 
-  def setup
-    keys_path = File.expand_path('../keys', __FILE__)
-    @root_cert = OpenSSL::X509::Certificate.new File.read("#{keys_path}/root_cert.cer")
-    @not_root_cert = OpenSSL::X509::Certificate.new File.read("#{keys_path}/nordea.crt")
-
-    @dfl = Nokogiri::XML(File.read("#{NORDEA_TEST_RESPONSE_PATH}/dfl.xml"))
-    @dfl = Sepa::Response.new(@dfl, command: :download_file_list).application_response
-
-    @uf = Nokogiri::XML(File.read("#{NORDEA_TEST_RESPONSE_PATH}/uf.xml"))
-    @uf = Sepa::Response.new(@uf, command: :upload_file).application_response
+  KEYS_PATH = File.expand_path('../keys', __FILE__)
 
-    @df_tito = Nokogiri::XML(File.read("#{NORDEA_TEST_RESPONSE_PATH}/df_tito.xml"))
-    @df_tito = Sepa::Response.new(@df_tito, command: :download_file).application_response
-
-    @gui = Nokogiri::XML(File.read("#{NORDEA_TEST_RESPONSE_PATH}/gui.xml"))
-    @gui = Sepa::Response.new(@gui, command: :get_user_info).application_response
+  def setup
+    options = {
+      response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/dfl.xml"),
+      command: :download_file_list
+    }
+    @dfl = Sepa::NordeaResponse.new(options).application_response
+    @dfl_doc = xml_doc @dfl
+
+    options = {
+      response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/uf.xml"),
+      command: :upload_file
+    }
+    @uf = Sepa::NordeaResponse.new(options).application_response
+    @uf_doc = xml_doc @dfl
+
+    options = {
+      response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/df_tito.xml"),
+      command: :download_file
+    }
+    @df_tito = Sepa::NordeaResponse.new(options).application_response
+    @df_tito_doc = xml_doc @df_tito
+
+    options = {
+      response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/gui.xml"),
+      command: :get_user_info
+    }
+    @gui = Sepa::NordeaResponse.new(options).application_response
+    @gui_doc = xml_doc @gui
 
     @dfl_ar = Sepa::ApplicationResponse.new(@dfl)
     @uf_ar = Sepa::ApplicationResponse.new(@uf)
@@ -32,7 +47,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
     assert @gui_ar.valid?
   end
 
-  def test_should_fail_if_initialized_with_not_nokogiri_xml
+  def test_should_fail_if_initialized_with_invalid_xml
     as = Sepa::ApplicationResponse.new("Jees")
     refute as.valid?
   end
@@ -59,39 +74,39 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   end
 
   def test_invalid_dfl_hash_check_should_not_verify
-    customer_id_node = @dfl.at_css('c2b|CustomerId')
+    customer_id_node = @dfl_doc.at_css('c2b|CustomerId')
     customer_id_node.content = customer_id_node.content[0..-2]
 
-    refute Sepa::ApplicationResponse.new(@dfl).hashes_match?
+    refute Sepa::ApplicationResponse.new(@dfl_doc.to_s).hashes_match?
   end
 
   def test_invalid_uf_hash_check_should_not_verify
-    timestamp_node = @uf.at_css('c2b|Timestamp')
+    timestamp_node = @uf_doc.at_css('c2b|Timestamp')
     timestamp_node.content = Time.now.iso8601
 
-    refute Sepa::ApplicationResponse.new(@uf).hashes_match?
+    refute Sepa::ApplicationResponse.new(@uf_doc.to_s).hashes_match?
   end
 
   def test_invalid_df_hash_check_should_not_verify
-    digest_value_node = @df_tito.at_css(
+    digest_value_node = @df_tito_doc.at_css(
       'xmlns|DigestValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     digest_value_node.content = digest_value_node.content[4..-1]
 
-    refute Sepa::ApplicationResponse.new(@df_tito).hashes_match?
+    refute Sepa::ApplicationResponse.new(@df_tito_doc.to_s).hashes_match?
   end
 
   def test_invalid_gui_hash_check_should_not_verify
-    digest_value_node = @gui.at_css(
+    digest_value_node = @gui_doc.at_css(
       'xmlns|DigestValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     digest_value_node.content = '1234' + digest_value_node.content
 
-    refute Sepa::ApplicationResponse.new(@gui).hashes_match?
+    refute Sepa::ApplicationResponse.new(@gui_doc.to_s).hashes_match?
   end
 
   def test_proper_dfl_signature_should_verify
@@ -111,51 +126,51 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   end
 
   def test_corrupted_signature_in_dfl_should_fail_signature_verification
-    signature_node = @dfl.at_css(
+    signature_node = @dfl_doc.at_css(
       'xmlns|SignatureValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     signature_node.content = signature_node.content[4..-1]
 
-    refute Sepa::ApplicationResponse.new(@dfl).signature_is_valid?
+    refute Sepa::ApplicationResponse.new(@dfl_doc.to_s).signature_is_valid?
   end
 
   def test_corrupted_signature_in_uf_should_fail_signature_verification
-    signature_node = @uf.at_css(
+    signature_node = @uf_doc.at_css(
       'xmlns|SignatureValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     signature_node.content = signature_node.content[0..-5]
 
-    refute Sepa::ApplicationResponse.new(@uf).signature_is_valid?
+    refute Sepa::ApplicationResponse.new(@uf_doc.to_s).signature_is_valid?
   end
 
   def test_corrupted_signature_in_df_should_fail_signature_verification
-    signature_node = @df_tito.at_css(
+    signature_node = @df_tito_doc.at_css(
       'xmlns|SignatureValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     signature_node.content = 'a' + signature_node.content[1..-1]
 
-    refute Sepa::ApplicationResponse.new(@df_tito).signature_is_valid?
+    refute Sepa::ApplicationResponse.new(@df_tito_doc.to_s).signature_is_valid?
   end
 
   def test_corrupted_signature_in_gui_should_fail_signature_verification
-    signature_node = @gui.at_css(
+    signature_node = @gui_doc.at_css(
       'xmlns|SignatureValue',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
     signature_node.content = 'zombi' + signature_node.content[1..-1]
 
-    refute Sepa::ApplicationResponse.new(@gui).signature_is_valid?
+    refute Sepa::ApplicationResponse.new(@gui_doc.to_s).signature_is_valid?
   end
 
   def test_should_raise_error_if_certificate_corrupted_in_dfl
-    cert_node = @dfl.at_css(
+    cert_node = @dfl_doc.at_css(
       'xmlns|X509Certificate',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
@@ -163,12 +178,12 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
     cert_node.content = cert_node.content[0..-5]
 
     assert_raises(OpenSSL::X509::CertificateError) do
-      Sepa::ApplicationResponse.new(@dfl).certificate
+      Sepa::ApplicationResponse.new(@dfl_doc.to_s).certificate
     end
   end
 
   def test_should_raise_error_if_certificate_corrupted_in_uf
-    cert_node = @uf.at_css(
+    cert_node = @uf_doc.at_css(
       'xmlns|X509Certificate',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
@@ -176,12 +191,12 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
     cert_node.content = cert_node.content[4..-1]
 
     assert_raises(OpenSSL::X509::CertificateError) do
-      Sepa::ApplicationResponse.new(@uf).certificate
+      Sepa::ApplicationResponse.new(@uf_doc.to_s).certificate
     end
   end
 
   def test_should_raise_error_if_certificate_corrupted_in_df
-    cert_node = @df_tito.at_css(
+    cert_node = @df_tito_doc.at_css(
       'xmlns|X509Certificate',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
@@ -189,44 +204,41 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
     cert_node.content = "n5iw#{cert_node.content}"
 
     assert_raises(OpenSSL::X509::CertificateError) do
-      Sepa::ApplicationResponse.new(@df_tito).certificate
+      Sepa::ApplicationResponse.new(@df_tito_doc.to_s).certificate
     end
   end
 
   def test_should_raise_error_if_certificate_corrupted_in_gui
-    cert_node = @gui.at_css(
+    cert_node = @gui_doc.at_css(
       'xmlns|X509Certificate',
       'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
     )
 
-    cert_node.content = Base64.encode64('voivoi')
+    cert_node.content = encode 'voivoi'
 
     assert_raises(OpenSSL::X509::CertificateError) do
-      Sepa::ApplicationResponse.new(@gui).certificate
+      Sepa::ApplicationResponse.new(@gui_doc.to_s).certificate
     end
   end
 
   def test_cert_should_be_trusted_with_correct_root_cert
-    assert @dfl_ar.cert_is_trusted(@root_cert)
-    assert @uf_ar.cert_is_trusted(@root_cert)
-    assert @df_ar.cert_is_trusted(@root_cert)
-    assert @gui_ar.cert_is_trusted(@root_cert)
-  end
-
-  def test_dfl_should_fail_if_wrong_root_cert
-    assert_raises(SecurityError) { @dfl_ar.cert_is_trusted(@not_root_cert) }
-  end
-
-  def test_uf_should_fail_if_wrong_root_cert
-    assert_raises(SecurityError) { @uf_ar.cert_is_trusted(@not_root_cert) }
+    root_cert = OpenSSL::X509::Certificate.new File.read("#{KEYS_PATH}/root_cert.cer")
+    assert @dfl_ar.cert_is_trusted(root_cert)
+    assert @uf_ar.cert_is_trusted(root_cert)
+    assert @df_ar.cert_is_trusted(root_cert)
+    assert @gui_ar.cert_is_trusted(root_cert)
   end
 
-  def test_df_should_fail_if_wrong_root_cert
-    assert_raises(SecurityError) { @df_ar.cert_is_trusted(@not_root_cert) }
+  def test_should_fail_if_wrong_root_cert
+    not_root_cert = OpenSSL::X509::Certificate.new File.read("#{KEYS_PATH}/nordea.crt")
+    assert_raises(SecurityError) { @dfl_ar.cert_is_trusted(not_root_cert) }
+    assert_raises(SecurityError) { @uf_ar.cert_is_trusted(not_root_cert) }
+    assert_raises(SecurityError) { @df_ar.cert_is_trusted(not_root_cert) }
+    assert_raises(SecurityError) { @gui_ar.cert_is_trusted(not_root_cert) }
   end
 
-  def test_gui_should_fail_if_wrong_root_cert
-    assert_raises(SecurityError) { @gui_ar.cert_is_trusted(@not_root_cert) }
+  test 'to_s works' do
+    assert_equal @uf, @uf_ar.to_s
   end
 
 end