sepa_king_extended 0.10.1

data/spec/account_spec.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::Account do
+  describe :new do
+    it 'should not accept unknown keys' do
+      expect {
+        SEPA::Account.new foo: 'bar'
+      }.to raise_error(NoMethodError)
+    end
+  end
+
+  describe :name do
+    it 'should accept valid value' do
+      expect(SEPA::Account).to accept('Gläubiger GmbH', 'Zahlemann & Söhne GbR', 'X' * 70, for: :name)
+    end
+
+    it 'should not accept invalid value' do
+      expect(SEPA::Account).not_to accept(nil, '', 'X' * 71, for: :name)
+    end
+  end
+
+  describe :iban do
+    it 'should accept valid value' do
+      expect(SEPA::Account).to accept('DE21500500009876543210', 'PL61109010140000071219812874', for: :iban)
+    end
+
+    it 'should not accept invalid value' do
+      expect(SEPA::Account).not_to accept(nil, '', 'invalid', for: :iban)
+    end
+  end
+
+  describe :bic do
+    it 'should accept valid value' do
+      expect(SEPA::Account).to accept('DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX', for: :bic)
+    end
+
+    it 'should not accept invalid value' do
+      expect(SEPA::Account).not_to accept('', 'invalid', for: :bic)
+    end
+  end
+end

data/spec/converter_spec.rb

@@ -0,0 +1,74 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::Converter do
+  include SEPA::Converter::InstanceMethods
+
+  describe :convert_text do
+    it 'should convert special chars' do
+      expect(convert_text('10€')).to eq('10E')
+      expect(convert_text('info@bundesbank.de')).to eq('info(at)bundesbank.de')
+      expect(convert_text('abc_def')).to eq('abc-def')
+    end
+
+    it 'should not change allowed special character' do
+      expect(convert_text('üöäÜÖÄß')).to eq('üöäÜÖÄß')
+      expect(convert_text('&*$%')).to eq('&*$%')
+    end
+
+    it 'should convert line breaks' do
+      expect(convert_text("one\ntwo"))    .to eq('one two')
+      expect(convert_text("one\ntwo\n"))  .to eq('one two')
+      expect(convert_text("\none\ntwo\n")).to eq('one two')
+      expect(convert_text("one\n\ntwo"))  .to eq('one two')
+    end
+
+    it 'should convert number' do
+      expect(convert_text(1234)).to eq('1234')
+    end
+
+    it 'should remove invalid chars' do
+      expect(convert_text('"=<>!')).to eq('')
+    end
+
+    it 'should not touch valid chars' do
+      expect(convert_text("abc-ABC-0123- ':?,-(+.)/")).to eq("abc-ABC-0123- ':?,-(+.)/")
+    end
+
+    it 'should not touch nil' do
+      expect(convert_text(nil)).to eq(nil)
+    end
+  end
+
+  describe :convert_decimal do
+    it "should convert Integer to BigDecimal" do
+      expect(convert_decimal(42)).to eq(BigDecimal('42.00'))
+    end
+
+    it "should convert Float to BigDecimal" do
+      expect(convert_decimal(42.12)).to eq(BigDecimal('42.12'))
+    end
+
+    it 'should round' do
+      expect(convert_decimal(1.345)).to eq(BigDecimal('1.35'))
+    end
+
+    it 'should not touch nil' do
+      expect(convert_decimal(nil)).to eq(nil)
+    end
+
+    it 'should not convert zero value' do
+      expect(convert_decimal(0)).to eq(nil)
+    end
+
+    it 'should not convert negative value' do
+      expect(convert_decimal(-3)).to eq(nil)
+    end
+
+    it 'should not convert invalid value' do
+      expect(convert_decimal('xyz')).to eq(nil)
+      expect(convert_decimal('NaN')).to eq(nil)
+      expect(convert_decimal('Infinity')).to eq(nil)
+    end
+  end
+end

data/spec/credit_transfer_spec.rb

@@ -0,0 +1,364 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::CreditTransfer do
+  let(:message_id_regex) { /SEPA-KING\/[0-9a-z_]{22}/ }
+  let(:credit_transfer) {
+    SEPA::CreditTransfer.new name:       'Schuldner GmbH',
+                             bic:        'BANKDEFFXXX',
+                             iban:       'DE87200500001234567890'
+  }
+
+  describe :new do
+    it 'should accept missing options' do
+      expect {
+        SEPA::CreditTransfer.new
+      }.to_not raise_error
+    end
+  end
+
+  describe :add_transaction do
+    it 'should add valid transactions' do
+      3.times do
+        credit_transfer.add_transaction(credit_transfer_transaction)
+      end
+
+      expect(credit_transfer.transactions.size).to eq(3)
+    end
+
+    it 'should fail for invalid transaction' do
+      expect {
+        credit_transfer.add_transaction name: ''
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe :to_xml do
+    context 'for invalid debtor' do
+      it 'should fail' do
+        expect {
+          SEPA::CreditTransfer.new.to_xml
+        }.to raise_error(RuntimeError)
+      end
+    end
+
+    context 'for valid debtor' do
+      context 'without BIC (IBAN-only)' do
+        subject do
+          sct = SEPA::CreditTransfer.new name:       'Schuldner GmbH',
+                                         iban:       'DE87200500001234567890'
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              bic:                    'PBNKDEFF370',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50,
+                              reference:              'XYZ-1234/123',
+                              remittance_information: 'Rechnung vom 22.08.2013'
+
+          sct
+        end
+
+        it 'should create valid XML file' do
+          expect(subject.to_xml).to validate_against('pain.001.003.03.xsd')
+        end
+
+        it 'should fail for pain.001.001.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_001_03)
+          }.to raise_error(RuntimeError)
+        end
+
+        it 'should fail for pain.001.002.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_002_03)
+          }.to raise_error(RuntimeError)
+        end
+      end
+
+      context 'with BIC' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              bic:                    'PBNKDEFF370',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50,
+                              reference:              'XYZ-1234/123',
+                              remittance_information: 'Rechnung vom 22.08.2013'
+
+          sct
+        end
+
+        it 'should validate against pain.001.001.03' do
+          expect(subject.to_xml('pain.001.001.03')).to validate_against('pain.001.001.03.xsd')
+        end
+
+        it 'should validate against pain.001.002.03' do
+          expect(subject.to_xml('pain.001.002.03')).to validate_against('pain.001.002.03.xsd')
+        end
+
+        it 'should validate against pain.001.003.03' do
+          expect(subject.to_xml('pain.001.003.03')).to validate_against('pain.001.003.03.xsd')
+        end
+      end
+
+      context 'without requested_date given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              bic:                    'PBNKDEFF370',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50,
+                              reference:              'XYZ-1234/123',
+                              remittance_information: 'Rechnung vom 22.08.2013'
+
+          sct.add_transaction name:                   'Amazonas GmbH',
+                              iban:                   'DE27793589132923472195',
+                              amount:                 59.00,
+                              reference:              'XYZ-5678/456',
+                              remittance_information: 'Rechnung vom 21.08.2013'
+
+          sct.to_xml
+        end
+
+        it 'should create valid XML file' do
+          expect(subject).to validate_against('pain.001.003.03.xsd')
+        end
+
+        it 'should have message_identification' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/GrpHdr/MsgId', message_id_regex)
+        end
+
+        it 'should contain <PmtInfId>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/PmtInfId', /#{message_id_regex}\/1/)
+        end
+
+        it 'should contain <ReqdExctnDt>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/ReqdExctnDt', Date.new(1999, 1, 1).iso8601)
+        end
+
+        it 'should contain <PmtMtd>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/PmtMtd', 'TRF')
+        end
+
+        it 'should contain <BtchBookg>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/BtchBookg', 'true')
+        end
+
+        it 'should contain <NbOfTxs>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/NbOfTxs', '2')
+        end
+
+        it 'should contain <CtrlSum>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CtrlSum', '161.50')
+        end
+
+        it 'should contain <Dbtr>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/Dbtr/Nm', 'Schuldner GmbH')
+        end
+
+        it 'should contain <DbtrAcct>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/DbtrAcct/Id/IBAN', 'DE87200500001234567890')
+        end
+
+        it 'should contain <DbtrAgt>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/DbtrAgt/FinInstnId/BIC', 'BANKDEFFXXX')
+        end
+
+        it 'should contain <EndToEndId>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/PmtId/EndToEndId', 'XYZ-1234/123')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/PmtId/EndToEndId', 'XYZ-5678/456')
+        end
+
+        it 'should contain <Amt>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/Amt/InstdAmt', '102.50')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/Amt/InstdAmt', '59.00')
+        end
+
+        it 'should contain <CdtrAgt> for every BIC given' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/CdtrAgt/FinInstnId/BIC', 'PBNKDEFF370')
+          expect(subject).not_to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/CdtrAgt')
+        end
+
+        it 'should contain <Cdtr>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/Cdtr/Nm', 'Telekomiker AG')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/Cdtr/Nm', 'Amazonas GmbH')
+        end
+
+        it 'should contain <CdtrAcct>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/CdtrAcct/Id/IBAN', 'DE37112589611964645802')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/CdtrAcct/Id/IBAN', 'DE27793589132923472195')
+        end
+
+        it 'should contain <RmtInf>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/RmtInf/Ustrd', 'Rechnung vom 22.08.2013')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/RmtInf/Ustrd', 'Rechnung vom 21.08.2013')
+        end
+      end
+
+      context 'with different requested_date given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2)
+
+          sct.to_xml
+        end
+
+        it 'should contain two payment_informations with <ReqdExctnDt>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/ReqdExctnDt', (Date.today + 1).iso8601)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/ReqdExctnDt', (Date.today + 2).iso8601)
+
+          expect(subject).not_to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]')
+        end
+
+        it 'should contain two payment_informations with different <PmtInfId>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/PmtInfId', /#{message_id_regex}\/1/)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/PmtInfId', /#{message_id_regex}\/2/)
+        end
+      end
+
+      context 'with different batch_booking given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: false)
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: true)
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: true)
+
+          sct.to_xml
+        end
+
+        it 'should contain two payment_informations with <BtchBookg>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/BtchBookg', 'false')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/BtchBookg', 'true')
+
+          expect(subject).not_to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]')
+        end
+      end
+
+      context 'with transactions containing different group criteria' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1, batch_booking: false, amount: 1)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1, batch_booking: true,  amount: 2)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2, batch_booking: false, amount: 4)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2, batch_booking: true,  amount: 8)
+
+          sct.to_xml
+        end
+
+        it 'should contain multiple payment_informations' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/ReqdExctnDt', (Date.today + 1).iso8601)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/BtchBookg', 'false')
+
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/ReqdExctnDt', (Date.today + 1).iso8601)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/BtchBookg', 'true')
+
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/ReqdExctnDt', (Date.today + 2).iso8601)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/BtchBookg', 'false')
+
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/ReqdExctnDt', (Date.today + 2).iso8601)
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/BtchBookg', 'true')
+        end
+
+        it 'should have multiple control sums' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/CtrlSum', '1.00')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/CtrlSum', '2.00')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/CtrlSum', '4.00')
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/CtrlSum', '8.00')
+        end
+      end
+
+      context 'with instruction given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50,
+                              instruction:            '1234/ABC'
+
+          sct.to_xml
+        end
+
+        it 'should create valid XML file' do
+          expect(subject).to validate_against('pain.001.003.03.xsd')
+        end
+
+        it 'should contain <InstrId>' do
+          expect(subject).to have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/PmtId/InstrId', '1234/ABC')
+        end
+      end
+
+      context 'with a different currency given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              iban:                   'DE37112589611964645802',
+                              bic:                    'PBNKDEFF370',
+                              amount:                 102.50,
+                              currency:               'CHF'
+
+          sct
+        end
+
+        it 'should validate against pain.001.001.03' do
+          expect(subject.to_xml('pain.001.001.03')).to validate_against('pain.001.001.03.xsd')
+        end
+
+        it 'should have a CHF Ccy' do
+          doc = Nokogiri::XML(subject.to_xml('pain.001.001.03'))
+          doc.remove_namespaces!
+
+          nodes = doc.xpath('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/Amt/InstdAmt')
+          expect(nodes.length).to eql(1)
+          expect(nodes.first.attribute('Ccy').value).to eql('CHF')
+        end
+
+        it 'should fail for pain.001.002.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_002_03)
+          }.to raise_error(RuntimeError)
+        end
+
+        it 'should fail for pain.001.003.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_003_03)
+          }.to raise_error(RuntimeError)
+        end
+      end
+
+      context 'with a transaction without a bic' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50
+
+          sct
+        end
+
+        it 'should validate against pain.001.001.03' do
+          expect(subject.to_xml('pain.001.001.03')).to validate_against('pain.001.001.03.xsd')
+        end
+
+        it 'should fail for pain.001.002.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_002_03)
+          }.to raise_error(RuntimeError)
+        end
+
+        it 'should validate against pain.001.003.03' do
+          expect(subject.to_xml(SEPA::PAIN_001_003_03)).to validate_against('pain.001.003.03.xsd')
+        end
+      end
+    end
+  end
+end

data/spec/credit_transfer_transaction_spec.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::CreditTransferTransaction do
+  describe :initialize do
+    it 'should initialize a valid transaction' do
+      expect(
+        SEPA::CreditTransferTransaction.new name:                   'Telekomiker AG',
+                                            iban:                   'DE37112589611964645802',
+                                            bic:                    'PBNKDEFF370',
+                                            amount:                 102.50,
+                                            reference:              'XYZ-1234/123',
+                                            remittance_information: 'Rechnung 123 vom 22.08.2013'
+      ).to be_valid
+    end
+  end
+
+  describe :schema_compatible? do
+    context 'for pain.001.003.03' do
+      it 'should succeed' do
+        expect(SEPA::CreditTransferTransaction.new({})).to be_schema_compatible('pain.001.003.03')
+      end
+
+      it 'should fail for invalid attributes' do
+        expect(SEPA::CreditTransferTransaction.new(:currency => 'CHF')).not_to be_schema_compatible('pain.001.003.03')
+      end
+    end
+
+    context 'pain.001.002.03' do
+      it 'should succeed for valid attributes' do
+        expect(SEPA::CreditTransferTransaction.new(:bic => 'SPUEDE2UXXX', :service_level => 'SEPA')).to be_schema_compatible('pain.001.002.03')
+      end
+
+      it 'should fail for invalid attributes' do
+        expect(SEPA::CreditTransferTransaction.new(:bic => nil)).not_to be_schema_compatible('pain.001.002.03')
+        expect(SEPA::CreditTransferTransaction.new(:bic => 'SPUEDE2UXXX', :service_level => 'URGP')).not_to be_schema_compatible('pain.001.002.03')
+        expect(SEPA::CreditTransferTransaction.new(:bic => 'SPUEDE2UXXX', :currency => 'CHF')).not_to be_schema_compatible('pain.001.002.03')
+      end
+    end
+
+    context 'for pain.001.001.03' do
+      it 'should succeed for valid attributes' do
+        expect(SEPA::CreditTransferTransaction.new(:bic => 'SPUEDE2UXXX', :currency => 'CHF')).to be_schema_compatible('pain.001.001.03')
+        expect(SEPA::CreditTransferTransaction.new(:bic => nil)).to be_schema_compatible('pain.001.003.03')
+      end
+    end
+  end
+
+  context 'Requested date' do
+    it 'should allow valid value' do
+      expect(SEPA::CreditTransferTransaction).to accept(nil, Date.new(1999, 1, 1), Date.today, Date.today.next, Date.today + 2, for: :requested_date)
+    end
+
+    it 'should not allow invalid value' do
+      expect(SEPA::CreditTransferTransaction).not_to accept(Date.new(1995,12,21), Date.today - 1, for: :requested_date)
+    end
+  end
+end

data/spec/creditor_account_spec.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::CreditorAccount do
+  it 'should initialize a new account' do
+    expect(
+      SEPA::CreditorAccount.new name:                'Gläubiger GmbH',
+                                bic:                 'BANKDEFFXXX',
+                                iban:                'DE87200500001234567890',
+                                creditor_identifier: 'DE98ZZZ09999999999'
+    ).to be_valid
+  end
+
+  describe :creditor_identifier do
+    it 'should accept valid value' do
+      expect(SEPA::CreditorAccount).to accept('DE98ZZZ09999999999', 'AT12ZZZ00000000001', 'IT97ZZZA1B2C3D4E5F6G7H8', 'NL97ZZZ123456780001', 'FR12ZZZ123456', for: :creditor_identifier)
+    end
+
+    it 'should not accept invalid value' do
+      expect(SEPA::CreditorAccount).not_to accept('', 'invalid', 'DE98ZZZ099999999990', 'DEAAAAAAAAAAAAAAAA', for: :creditor_identifier)
+    end
+  end
+end

data/spec/debtor_account_spec.rb

@@ -0,0 +1,12 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::DebtorAccount do
+  it 'should initialize a new account' do
+    expect(
+      SEPA::DebtorAccount.new name:       'Gläubiger GmbH',
+                              bic:        'BANKDEFFXXX',
+                              iban:       'DE87200500001234567890'
+    ).to be_valid
+  end
+end