sepa_king 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c07809500fdf4e08660e27eef792b69530285d64
-  data.tar.gz: c54f6fa344d87892a6642e3ef2dd3e140b643eb5
+  metadata.gz: a55e01a727d2ad4cb40cc2f284f1e77149781359
+  data.tar.gz: f8a2b539e05d97d6630a260b91362c7ecc7fb2b9
 SHA512:
-  metadata.gz: 4fbe19893a4147654d7f65a04f57caf74c85876cc547173157e427c36d92e919c7b10bd48e12fb3fcce03ff78e4fbf16f234b2d78983753edad209885f71f784
-  data.tar.gz: 90ad61a32ef0c8f1e0b6e3a190a448b54c4fb5f90ea30d81e6c0775d0df18ad03123d5964faf319b787f6a70c2f7e77736e813f990186d42d0c89f4f50f48010
+  metadata.gz: 50a4b696964158725ee468d65a00839bb37d0e7d2939bccb17d0ccb25e24ad14b2160ec7acb22c1ba045e0047f6a5866bf96602e3b26406436b2120bb6c11639
+  data.tar.gz: c78387d1c6fd870f045b1ae37eb8b3d7a1aae21ec68604e00b00c75b0ad8cc584a55872534890e525d2d1e37183fc0d7bf27818def85ea7d8fc6f7fe0688eba4

data/README.md

@@ -16,7 +16,7 @@ This gem implements the following two messages out of the ISO 20022 standard:
 * Credit Transfer Initiation (`pain.001.003.03`, `pain.001.002.03` and `pain.001.001.03`)
 * Direct Debit Initiation (`pain.008.003.02`, `pain.008.002.02` and `pain.008.001.02`)
 
-This means it handles the "Specification of Data Formats" in version 2.6 (2012-11-17) and version 2.7 (2013-11-04)
+It handles the _Specification of Data Formats_ v2.7 (2013-11-04).
 
 BTW: **pain** is a shortcut for **Pa**yment **In**itiation.
 

data/gemfiles/Gemfile-activemodel-5.0.x

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gemspec path: '..'
 
-gem 'activemodel', '5.0.0.rc1'
+gem 'activemodel', '~> 5.0.0'

data/lib/sepa_king/converter.rb

@@ -20,20 +20,16 @@ module SEPA
 
         value.to_s.
           # Replace some special characters described as "Best practices" in Chapter 6.2 of this document:
-          # http://www.europeanpaymentscouncil.eu/index.cfm/knowledge-bank/epc-documents/sepa-requirements-for-an-extended-character-set-unicode-subset-best-practices/epc217-08-best-practices-sepa-requirements-for-character-set-ssgpdf/
+          # http://www.europeanpaymentscouncil.eu/index.cfm/knowledge-bank/epc-documents/sepa-requirements-for-an-extended-character-set-unicode-subset-best-practices/
           gsub('€','E').
           gsub('@','(at)').
-          gsub('&', '+').
           gsub('_','-').
 
-          # Replace non-ASCII characters with an ASCII approximation
-          i18n_transliterate.
-
           # Replace linebreaks by spaces
           gsub(/\n+/,' ').
 
           # Remove all invalid characters
-          gsub(/[^a-zA-Z0-9\ \'\:\?\,\-\(\+\.\)\/]/, '').
+          gsub(/[^a-zA-Z0-9ÄÖÜäöüß&*$%\ \'\:\?\,\-\(\+\.\)\/]/, '').
 
           # Remove leading and trailing spaces
           strip

data/lib/sepa_king/version.rb

@@ -1,3 +1,3 @@
 module SEPA
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/lib/sepa_king.rb

@@ -1,11 +1,8 @@
-require 'i18n'
 require 'active_model'
 require 'bigdecimal'
 require 'builder'
 require 'iban-tools'
 
-require 'sepa_king/core_ext/string'
-
 require 'sepa_king/converter'
 require 'sepa_king/validator'
 require 'sepa_king/account'

data/sepa_king.gemspec

@@ -21,14 +21,13 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 1.9.3'
 
   s.add_runtime_dependency 'activemodel', '>= 3.0.0'
-  s.add_runtime_dependency 'i18n'
   s.add_runtime_dependency 'builder'
   s.add_runtime_dependency 'iban-tools'
 
   s.add_development_dependency 'bundler'
-  s.add_development_dependency 'rspec', '~> 3.0'
+  s.add_development_dependency 'rspec'
   s.add_development_dependency 'coveralls'
-  s.add_development_dependency 'simplecov', '~> 0.11.0'
+  s.add_development_dependency 'simplecov', '~> 0.11.2'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'nokogiri'
 end

data/spec/converter_spec.rb

@@ -6,14 +6,14 @@ describe SEPA::Converter do
 
   describe :convert_text do
     it 'should convert special chars' do
-      expect(convert_text('GmbH & Co. KG')).to eq('GmbH + Co. KG')
       expect(convert_text('10€')).to eq('10E')
       expect(convert_text('info@bundesbank.de')).to eq('info(at)bundesbank.de')
       expect(convert_text('abc_def')).to eq('abc-def')
     end
 
-    it 'should convert umlaute' do
-      expect(convert_text('üöäÜÖÄß')).to eq('uoaUOAss')
+    it 'should not change allowed special character' do
+      expect(convert_text('üöäÜÖÄß')).to eq('üöäÜÖÄß')
+      expect(convert_text('&*$%')).to eq('&*$%')
     end
 
     it 'should convert line breaks' do

data/spec/direct_debit_spec.rb

@@ -198,7 +198,7 @@ describe SEPA::DirectDebit do
         end
 
         it 'should contain <Cdtr>' do
-          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/Cdtr/Nm', 'Glaubiger GmbH')
+          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/Cdtr/Nm', 'Gläubiger GmbH')
         end
 
         it 'should contain <CdtrAcct>' do
@@ -239,8 +239,8 @@ describe SEPA::DirectDebit do
         end
 
         it 'should contain <Dbtr>' do
-          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[1]/Dbtr/Nm', 'Zahlemann + Sohne GbR')
-          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[2]/Dbtr/Nm', 'Meier + Schulze oHG')
+          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[1]/Dbtr/Nm', 'Zahlemann & Söhne GbR')
+          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[2]/Dbtr/Nm', 'Meier & Schulze oHG')
         end
 
         it 'should contain <DbtrAcct>' do
@@ -250,7 +250,7 @@ describe SEPA::DirectDebit do
 
         it 'should contain <RmtInf>' do
           expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[1]/RmtInf/Ustrd', 'Unsere Rechnung vom 10.08.2013')
-          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[2]/RmtInf/Ustrd', 'Vielen Dank fur Ihren Einkauf')
+          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf/DrctDbtTxInf[2]/RmtInf/Ustrd', 'Vielen Dank für Ihren Einkauf')
         end
       end
 
@@ -387,7 +387,7 @@ describe SEPA::DirectDebit do
         end
 
         it 'should contain two payment_informations with <Cdtr>' do
-          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf[1]/Cdtr/Nm', 'Glaubiger GmbH')
+          expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf[1]/Cdtr/Nm', 'Gläubiger GmbH')
           expect(subject).to have_xml('//Document/CstmrDrctDbtInitn/PmtInf[2]/Cdtr/Nm', 'Creditor Inc.')
         end
       end

data/spec/spec_helper.rb

@@ -16,10 +16,6 @@ end
 
 require 'sepa_king'
 
-if I18n.respond_to?(:enforce_available_locales=)
-  I18n.enforce_available_locales = false
-end
-
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
 Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepa_king
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Georg Leciejewski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-28 00:00:00.000000000 Z
+date: 2016-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -25,20 +25,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: i18n
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -85,16 +71,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -115,14 +101,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -185,7 +171,6 @@ files:
 - lib/sepa_king/account/creditor_account.rb
 - lib/sepa_king/account/debtor_account.rb
 - lib/sepa_king/converter.rb
-- lib/sepa_king/core_ext/string.rb
 - lib/sepa_king/message.rb
 - lib/sepa_king/message/credit_transfer.rb
 - lib/sepa_king/message/direct_debit.rb
@@ -197,7 +182,6 @@ files:
 - sepa_king.gemspec
 - spec/account_spec.rb
 - spec/converter_spec.rb
-- spec/core_ext/string_spec.rb
 - spec/credit_transfer_spec.rb
 - spec/credit_transfer_transaction_spec.rb
 - spec/creditor_account_spec.rb
@@ -238,14 +222,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Ruby gem for creating SEPA XML files
 test_files:
 - spec/account_spec.rb
 - spec/converter_spec.rb
-- spec/core_ext/string_spec.rb
 - spec/credit_transfer_spec.rb
 - spec/credit_transfer_transaction_spec.rb
 - spec/creditor_account_spec.rb

data/lib/sepa_king/core_ext/string.rb

@@ -1,27 +0,0 @@
-# encoding: utf-8
-
-# Extend String class to use I18n.transliterate as an instance method
-#
-# To have a better ASCII approximation for some languages, it's strongly
-# recommended to add custom rules in your I18n dictionary like this
-# example for Germany:
-#
-# de:
-#   i18n:
-#     transliterate:
-#       rule:
-#         Ä: 'Ae'
-#         Ö: 'Oe'
-#         Ü: 'Ue'
-#         ä: 'ae'
-#         ö: 'oe'
-#         ü: 'ue'
-#         ß: 'ss'
-#
-# Because this stuff is out of scope of this gem, we don't include the rules here
-
-String.class_eval do
-  def i18n_transliterate(replacement='?')
-    I18n.transliterate(self, replacement)
-  end
-end

data/spec/core_ext/string_spec.rb

@@ -1,11 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe String do
-  describe :i18n_transliterate do
-    it 'should use I18n.transliterate' do
-      expect('Ærøskøbing'.i18n_transliterate).to eq('AEroskobing')
-      expect('Jürgen'.i18n_transliterate).to eq('Jurgen')
-    end
-  end
-end