sepa_king 0.12.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50a8c2ef19885186d039b8f47eec9b27074dfe71917ad3dbee6ed164f4410169
-  data.tar.gz: f0220baed094637316211e1e2b5dc5fc57dfc6ec11211881f73c59561d4df565
+  metadata.gz: bbdd7991d9da595e8a78eef4ede917a4bf96f425305da1ea0f908e9c04c23750
+  data.tar.gz: 5ac2d38ed83dec60f68ea9f70b8be7bd16e01385457c41f58f15dc00990e07a9
 SHA512:
-  metadata.gz: c0a3ab450bca76dd5889866129d3e5172ce7d7b51cfb1f329709d01a510c14ef30a4ad3114b968ec406510f5360149518f1905adfd4e2784cbfd0d06c27a11a1
-  data.tar.gz: 4ff86a20f750668a273248ae3ab60928f22ccbc25f195678ad6c6afaa39df5006a2dcf7cd0fef6a2fe18c2f91dea364e19f66f1ab57f84ae9f378ee4bdf0a78e
+  metadata.gz: 10dd0ce9bae0413cc3ed0d65b470fc8f0911bd4035cc19a3a4505a88d6076ee552b1c0d4cd8e8d0d0ab9542a9d42eb717418d43a7e5c6ad5212fab2d4d042123
+  data.tar.gz: a27678581e7f3d371d47fe58ad77b9245bade4d05adaa69dd1ec0425efb253fb4db8f624f77e5ce2cbf18b9000e429614b4068b61fa466e46a9d347a03ccd75b

data/.github/workflows/main.yml

@@ -0,0 +1,50 @@
+name: Test
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '2.7', '3.0', '3.1' ]
+        rails: [ '4.2', '5.0', '5.1', '5.2', '6.0', '6.1', '7.0' ]
+        exclude:
+          - ruby: '2.7'
+            rails: '4.2'
+          - ruby: '3.0'
+            rails: '4.2'
+          - ruby: '3.0'
+            rails: '5.0'
+          - ruby: '3.0'
+            rails: '5.1'
+          - ruby: '3.0'
+            rails: '5.2'
+          - ruby: '3.1'
+            rails: '4.2'
+          - ruby: '3.1'
+            rails: '5.0'
+          - ruby: '3.1'
+            rails: '5.1'
+          - ruby: '3.1'
+            rails: '5.2'
+
+    name: Ruby ${{ matrix.ruby }} / Rails ${{ matrix.rails }}
+    env:
+      BUNDLE_GEMFILE: gemfiles/Gemfile-activemodel-${{ matrix.rails }}.x
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Setup Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # 'bundle install' and cache gems
+
+    - name: RSpec
+      run: bundle exec rake

data/.gitignore

@@ -4,6 +4,6 @@ coverage/*
 rdoc/*
 pkg/*
 .DS_Store
-Gemfile.lock
+Gemfile*.lock
 # tmp disable
 docs/

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013-2019 Georg Leciejewski (Sales King GmbH) & Georg Ledermann
+Copyright (c) 2013-2022 Georg Leciejewski (Sales King GmbH) & Georg Ledermann
 
 MIT License
 

data/README.md

@@ -1,10 +1,9 @@
 # Ruby gem for creating SEPA XML files
 
-[![Build Status](https://travis-ci.org/salesking/sepa_king.svg)](http://travis-ci.org/salesking/sepa_king)
+[![Build Status](https://github.com/salesking/sepa_king/workflows/Test/badge.svg?branch=master)](https://github.com/salesking/sepa_king/actions)
 [![Code Climate](https://codeclimate.com/github/salesking/sepa_king/badges/gpa.svg)](https://codeclimate.com/github/salesking/sepa_king)
 [![Coverage Status](https://coveralls.io/repos/salesking/sepa_king/badge.svg?branch=master)](https://coveralls.io/r/salesking/sepa_king?branch=master)
 [![Gem Version](https://badge.fury.io/rb/sepa_king.svg)](http://badge.fury.io/rb/sepa_king)
-[![Dependency Status](https://gemnasium.com/salesking/sepa_king.svg)](https://gemnasium.com/salesking/sepa_king)
 
 We love building payment applications! So after developing the [DTAUS library for Ruby](https://github.com/salesking/king_dtaus) we move on with SEPA.
 
@@ -16,15 +15,15 @@ This gem implements the following two messages out of the ISO 20022 standard:
 * Credit Transfer Initiation (`pain.001.003.03`, `pain.001.002.03` and `pain.001.001.03`)
 * Direct Debit Initiation (`pain.008.003.02`, `pain.008.002.02` and `pain.008.001.02`)
 
-It handles the _Specification of Data Formats_ v2.7 (2013-11-04).
+It handles the _Specification of Data Formats_ v3.3 (2019-11-17).
 
 BTW: **pain** is a shortcut for **Pa**yment **In**itiation.
 
 
 ## Requirements
 
-* Ruby 2.2 or newer
-* ActiveModel 3.1 or newer (including 6.0)
+* Ruby 2.7 or newer
+* ActiveModel 4.2 or newer (including 7.0)
 
 
 ## Installation
@@ -146,8 +145,8 @@ sdd.add_transaction(
 sdd.add_transaction ...
 
 # Last: create XML string
-xml_string = sdd.to_xml # Use latest schema pain.008.003.02
-xml_string = sdd.to_xml('pain.008.002.02') # Use former schema pain.008.002.02
+xml_string = sdd.to_xml                    # Use schema pain.008.001.02
+xml_string = sdd.to_xml('pain.008.002.02') # Use schema pain.008.002.02
 ```
 
 
@@ -237,8 +236,8 @@ sct.add_transaction(
 sct.add_transaction ...
 
 # Last: create XML string
-xml_string = sct.to_xml # Use latest schema pain.001.003.03
-xml_string = sct.to_xml('pain.001.002.03') # Use former schema pain.001.002.03
+xml_string = sct.to_xml                    # Use schema pain.001.001.03
+xml_string = sct.to_xml('pain.001.002.03') # Use schema pain.001.002.03
 ```
 
 ## Validations
@@ -286,7 +285,7 @@ https://github.com/salesking/sepa_king/graphs/contributors
 
 ## Resources
 
-* http://www.ebics.de/index.php?id=77
+* https://www.ebics.de/de/datenformate
 * SalesKing: http://salesking.eu
 
 
@@ -294,4 +293,4 @@ https://github.com/salesking/sepa_king/graphs/contributors
 
 Released under the MIT license
 
-Copyright (c) 2013-2019 Georg Leciejewski (SalesKing), Georg Ledermann (https://github.com/ledermann)
+Copyright (c) 2013-2022 Georg Leciejewski (SalesKing), Georg Ledermann (https://github.com/ledermann)

data/gemfiles/{Gemfile-activemodel-4.1.x → Gemfile-activemodel-6.1.x}

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gemspec path: '..'
 
-gem 'activemodel', '~>4.1.15'
+gem 'activemodel', '~> 6.1.4'

data/gemfiles/{Gemfile-activemodel-3.1.x → Gemfile-activemodel-7.0.x}

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gemspec path: '..'
 
-gem 'activemodel', '~>3.1.12'
+gem 'activemodel', '~> 7.0.1'

data/lib/sepa_king/message/credit_transfer.rb

@@ -5,7 +5,7 @@ module SEPA
     self.account_class = DebtorAccount
     self.transaction_class = CreditTransferTransaction
     self.xml_main_tag = 'CstmrCdtTrfInitn'
-    self.known_schemas = [ PAIN_001_003_03, PAIN_001_002_03, PAIN_001_001_03, PAIN_001_001_03_CH_02 ]
+    self.known_schemas = [ PAIN_001_001_03, PAIN_001_001_03_CH_02, PAIN_001_003_03, PAIN_001_002_03 ]
 
   private
     # Find groups of transactions which share the same values of some attributes
@@ -17,7 +17,7 @@ module SEPA
       }
     end
 
-    def build_payment_informations(builder)
+    def build_payment_informations(builder, schema_name)
       # Build a PmtInf block for every group of transactions
       grouped_transactions.each do |group, transactions|
         # All transactions with the same requested_date are placed into the same PmtInf block
@@ -52,7 +52,7 @@ module SEPA
             builder.FinInstnId do
               if account.bic
                 builder.BIC(account.bic)
-              else
+              elsif schema_name != PAIN_001_001_03_CH_02
                 builder.Othr do
                   builder.Id('NOTPROVIDED')
                 end

data/lib/sepa_king/message/direct_debit.rb

@@ -5,7 +5,7 @@ module SEPA
     self.account_class = CreditorAccount
     self.transaction_class = DirectDebitTransaction
     self.xml_main_tag = 'CstmrDrctDbtInitn'
-    self.known_schemas = [ PAIN_008_003_02, PAIN_008_002_02, PAIN_008_001_02 ]
+    self.known_schemas = [ PAIN_008_001_02, PAIN_008_003_02, PAIN_008_002_02 ]
 
     validate do |record|
       if record.transactions.map(&:local_instrument).uniq.size > 1
@@ -24,7 +24,7 @@ module SEPA
       }
     end
 
-    def build_payment_informations(builder)
+    def build_payment_informations(builder, schema_name)
       # Build a PmtInf block for every group of transactions
       grouped_transactions.each do |group, transactions|
         builder.PmtInf do

data/lib/sepa_king/message.rb

@@ -46,7 +46,7 @@ module SEPA
         builder.Document(xml_schema(schema_name)) do
           builder.__send__(xml_main_tag) do
             build_group_header(builder)
-            build_payment_informations(builder)
+            build_payment_informations(builder, schema_name)
           end
         end
       end
@@ -63,9 +63,9 @@ module SEPA
       raise ArgumentError.new("Schema #{schema_name} is unknown!") unless self.known_schemas.include?(schema_name)
 
       case schema_name
-        when PAIN_001_002_03, PAIN_008_002_02, PAIN_001_001_03, PAIN_001_001_03_CH_02
+        when PAIN_001_002_03, PAIN_008_002_02
           account.bic.present? && transactions.all? { |t| t.schema_compatible?(schema_name) }
-        when PAIN_001_003_03, PAIN_008_003_02, PAIN_008_001_02
+        when PAIN_001_001_03, PAIN_001_001_03_CH_02, PAIN_001_003_03, PAIN_008_003_02, PAIN_008_001_02
           transactions.all? { |t| t.schema_compatible?(schema_name) }
       end
     end
@@ -75,7 +75,7 @@ module SEPA
       raise ArgumentError.new('message_identification must be a string!') unless value.is_a?(String)
 
       regex = /\A([A-Za-z0-9]|[\+|\?|\/|\-|\:|\(|\)|\.|\,|\'|\ ]){1,35}\z/
-      raise ArgumentError.new("message_identification does not match #{regex}!") unless value.match(regex)
+      raise ArgumentError.new("message_identification does not match #{regex}!") unless value.match?(regex)
 
       @message_identification = value
     end
@@ -91,7 +91,7 @@ module SEPA
       raise ArgumentError.new('creation_date_time must be a string!') unless value.is_a?(String)
 
       regex = /[0-9]{4}[-][0-9]{2,2}[-][0-9]{2,2}(?:\s|T)[0-9]{2,2}[:][0-9]{2,2}[:][0-9]{2,2}/
-      raise ArgumentError.new("creation_date_time does not match #{regex}!") unless value.match(regex)
+      raise ArgumentError.new("creation_date_time does not match #{regex}!") unless value.match?(regex)
 
       @creation_date_time = value
     end
@@ -161,7 +161,7 @@ module SEPA
     end
 
     def validate_final_document!(document, schema_name)
-      xsd = Nokogiri::XML::Schema(File.read(File.expand_path("../../../lib/schema/#{schema_name}.xsd", __FILE__)))
+      xsd = Nokogiri::XML::Schema(File.read(File.expand_path("../../lib/schema/#{schema_name}.xsd", __dir__)))
       errors = xsd.validate(document).map { |error| error.message }
       raise SEPA::Error.new("Incompatible with schema #{schema_name}: #{errors.join(', ')}") if errors.any?
     end

data/lib/sepa_king/validator.rb

@@ -8,7 +8,7 @@ module SEPA
       field_name = options[:field_name] || :iban
       value = record.send(field_name).to_s
 
-      unless IBANTools::IBAN.valid?(value) && value.match(REGEX)
+      unless IBANTools::IBAN.valid?(value) && value.match?(REGEX)
         record.errors.add(field_name, :invalid, message: options[:message])
       end
     end
@@ -23,7 +23,7 @@ module SEPA
       value = record.send(field_name)
 
       if value
-        unless value.to_s.match(REGEX)
+        unless value.to_s.match?(REGEX)
           record.errors.add(field_name, :invalid, message: options[:message])
         end
       end
@@ -31,7 +31,12 @@ module SEPA
   end
 
   class CreditorIdentifierValidator < ActiveModel::Validator
-    REGEX = /\A[a-zA-Z]{2,2}[0-9]{2,2}([A-Za-z0-9]|[\+|\?|\/|\-|\:|\(|\)|\.|,|']){3,3}([A-Za-z0-9]|[\+|\?|\/|\-|:|\(|\)|\.|,|']){1,28}\z/
+    REGEX = %r{\A
+      [a-zA-Z]{2}                 # ISO country code
+      [0-9]{2}                    # Check digits
+      [A-Za-z0-9]{3}              # Creditor business code
+      [A-Za-z0-9+?/:().,'-]{1,28} # National identifier
+    \z}x
 
     def validate(record)
       field_name = options[:field_name] || :creditor_identifier
@@ -43,9 +48,9 @@ module SEPA
     end
 
     def valid?(creditor_identifier)
-      if ok = creditor_identifier.to_s.match(REGEX)
+      if ok = creditor_identifier.to_s.match?(REGEX)
         # In Germany, the identifier has to be exactly 18 chars long
-        if creditor_identifier[0..1].match(/DE/i)
+        if creditor_identifier[0..1].match?(/DE/i)
           ok = creditor_identifier.length == 18
         end
       end
@@ -54,13 +59,13 @@ module SEPA
   end
 
   class MandateIdentifierValidator < ActiveModel::Validator
-    REGEX = /\A([A-Za-z0-9]|[\+|\?|\/|\-|\:|\(|\)|\.|\,|\']){1,35}\z/
+    REGEX = %r{\A[A-Za-z0-9 +?/:().,'-]{1,35}\z}
 
     def validate(record)
       field_name = options[:field_name] || :mandate_id
       value = record.send(field_name)
 
-      unless value.to_s.match(REGEX)
+      unless value.to_s.match?(REGEX)
         record.errors.add(field_name, :invalid, message: options[:message])
       end
     end

data/lib/sepa_king/version.rb

@@ -1,3 +1,3 @@
 module SEPA
-  VERSION = '0.12.0'
+  VERSION = '0.14.0'
 end

data/sepa_king.gemspec

@@ -1,5 +1,5 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'sepa_king/version'
 
@@ -7,25 +7,24 @@ Gem::Specification.new do |s|
   s.name          = 'sepa_king'
   s.version       = SEPA::VERSION
   s.authors       = ['Georg Leciejewski', 'Georg Ledermann']
-  s.email         = ['gl@salesking.eu', 'mail@georg-ledermann.de']
-  s.description   = 'Implemention of pain.001.002.03 and pain.008.002.02 (ISO 20022)'
+  s.email         = ['gl@salesking.eu', 'georg@ledermann.dev']
+  s.description   = 'Implemention of Payments Initiation (ISO 20022)'
   s.summary       = 'Ruby gem for creating SEPA XML files'
-  s.homepage      = 'http://github.com/salesking/sepa_king'
+  s.homepage      = 'https://github.com/salesking/sepa_king'
   s.license       = 'MIT'
 
   s.files         = `git ls-files`.split($/)
-  s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ['lib']
 
-  s.required_ruby_version = '>= 2.2'
+  s.required_ruby_version = '>= 2.7'
 
-  s.add_runtime_dependency 'activemodel', '>= 3.1'
+  s.add_runtime_dependency 'activemodel', '>= 4.2'
   s.add_runtime_dependency 'nokogiri'
   s.add_runtime_dependency 'iban-tools'
 
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'coveralls_reborn'
   s.add_development_dependency 'simplecov'
   s.add_development_dependency 'rake'
 end

data/spec/account_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::Account do
+RSpec.describe SEPA::Account do
   describe :new do
     it 'should not accept unknown keys' do
       expect {

data/spec/converter_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::Converter do
+RSpec.describe SEPA::Converter do
   include SEPA::Converter::InstanceMethods
 
   describe :convert_text do

data/spec/credit_transfer_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::CreditTransfer do
+RSpec.describe SEPA::CreditTransfer do
   let(:message_id_regex) { /SEPA-KING\/[0-9a-z_]{22}/ }
   let(:credit_transfer) {
     SEPA::CreditTransfer.new name:       'Schuldner GmbH',
@@ -38,7 +38,7 @@ describe SEPA::CreditTransfer do
       it 'should fail' do
         expect {
           SEPA::CreditTransfer.new.to_xml
-        }.to raise_error(SEPA::Error)
+        }.to raise_error(SEPA::Error, /Name is too short/)
       end
     end
 
@@ -62,7 +62,7 @@ describe SEPA::CreditTransfer do
         sct
       end
 
-      it 'should validate against pain.001.003.01' do
+      it 'should validate against pain.001.003.03' do
         expect(subject.to_xml(SEPA::PAIN_001_003_03)).to validate_against('pain.001.003.03.xsd')
       end
     end
@@ -90,7 +90,7 @@ describe SEPA::CreditTransfer do
         sct
       end
 
-      it 'should validate against pain.001.001.01' do
+      it 'should validate against pain.001.001.03' do
         expect(subject.to_xml(SEPA::PAIN_001_001_03)).to validate_against('pain.001.001.03.xsd')
       end
     end
@@ -105,26 +105,35 @@ describe SEPA::CreditTransfer do
                               bic:                    'PBNKDEFF370',
                               iban:                   'DE37112589611964645802',
                               amount:                 102.50,
+                              currency:               currency,
                               reference:              'XYZ-1234/123',
                               remittance_information: 'Rechnung vom 22.08.2013'
 
           sct
         end
 
-        it 'should create valid XML file' do
-          expect(subject.to_xml).to validate_against('pain.001.003.03.xsd')
+        let(:currency) { nil }
+
+        it 'should validate against pain.001.003.03' do
+          expect(subject.to_xml(SEPA::PAIN_001_003_03)).to validate_against('pain.001.003.03.xsd')
         end
 
-        it 'should fail for pain.001.001.03' do
-          expect {
-            subject.to_xml(SEPA::PAIN_001_001_03)
-          }.to raise_error(SEPA::Error)
+        it 'should validate against pain.001.001.03' do
+          expect(subject.to_xml(SEPA::PAIN_001_001_03)).to validate_against('pain.001.001.03.xsd')
+        end
+
+        context 'with CHF as currency' do
+          let(:currency) { 'CHF' }
+
+          it 'should validate against pain.001.001.03.ch.02' do
+            expect(subject.to_xml(SEPA::PAIN_001_001_03_CH_02)).to validate_against('pain.001.001.03.ch.02.xsd')
+          end
         end
 
         it 'should fail for pain.001.002.03' do
           expect {
             subject.to_xml(SEPA::PAIN_001_002_03)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
       end
 
@@ -143,7 +152,7 @@ describe SEPA::CreditTransfer do
         end
 
         it 'should validate against pain.001.001.03' do
-          expect(subject.to_xml('pain.001.001.03')).to validate_against('pain.001.001.03.xsd')
+          expect(subject.to_xml).to validate_against('pain.001.001.03.xsd')
         end
 
         it 'should validate against pain.001.002.03' do
@@ -176,7 +185,7 @@ describe SEPA::CreditTransfer do
         end
 
         it 'should create valid XML file' do
-          expect(subject).to validate_against('pain.001.003.03.xsd')
+          expect(subject).to validate_against('pain.001.001.03.xsd')
         end
 
         it 'should have message_identification' do
@@ -344,7 +353,7 @@ describe SEPA::CreditTransfer do
         end
 
         it 'should create valid XML file' do
-          expect(subject).to validate_against('pain.001.003.03.xsd')
+          expect(subject).to validate_against('pain.001.001.03.xsd')
         end
 
         it 'should contain <InstrId>' do
@@ -381,13 +390,13 @@ describe SEPA::CreditTransfer do
         it 'should fail for pain.001.002.03' do
           expect {
             subject.to_xml(SEPA::PAIN_001_002_03)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
 
         it 'should fail for pain.001.003.03' do
           expect {
             subject.to_xml(SEPA::PAIN_001_003_03)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
       end
 
@@ -409,7 +418,7 @@ describe SEPA::CreditTransfer do
         it 'should fail for pain.001.002.03' do
           expect {
             subject.to_xml(SEPA::PAIN_001_002_03)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
 
         it 'should validate against pain.001.003.03' do

data/spec/credit_transfer_transaction_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::CreditTransferTransaction do
+RSpec.describe SEPA::CreditTransferTransaction do
   describe :initialize do
     it 'should initialize a valid transaction' do
       expect(

data/spec/creditor_account_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::CreditorAccount do
+RSpec.describe SEPA::CreditorAccount do
   it 'should initialize a new account' do
     expect(
       SEPA::CreditorAccount.new name:                'Gläubiger GmbH',

data/spec/debtor_account_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::DebtorAccount do
+RSpec.describe SEPA::DebtorAccount do
   it 'should initialize a new account' do
     expect(
       SEPA::DebtorAccount.new name:       'Gläubiger GmbH',

data/spec/debtor_address_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::DebtorAddress do
+RSpec.describe SEPA::DebtorAddress do
   it 'should initialize a new address' do
     expect(
       SEPA::DebtorAddress.new country_code:       'CH',

data/spec/direct_debit_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::DirectDebit do
+RSpec.describe SEPA::DirectDebit do
   let(:message_id_regex) { /SEPA-KING\/[0-9a-z_]{22}/ }
 
   let(:direct_debit) {
@@ -70,7 +70,7 @@ describe SEPA::DirectDebit do
       it 'should fail' do
         expect {
           SEPA::DirectDebit.new.to_xml
-        }.to raise_error(SEPA::Error)
+        }.to raise_error(SEPA::Error, /Name is too short/)
       end
     end
 
@@ -158,7 +158,7 @@ describe SEPA::DirectDebit do
         it 'should fail for pain.008.002.02' do
           expect {
             subject.to_xml(SEPA::PAIN_008_002_02)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
 
         it 'should validate against pain.008.001.02' do
@@ -256,7 +256,7 @@ describe SEPA::DirectDebit do
         end
 
         it 'should create valid XML file' do
-          expect(subject).to validate_against('pain.008.003.02.xsd')
+          expect(subject).to validate_against('pain.008.001.02.xsd')
         end
 
         it 'should have creditor identifier' do
@@ -385,7 +385,7 @@ describe SEPA::DirectDebit do
         it 'should raise error on XML generation' do
           expect {
             subject.to_xml
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /CORE, COR1 AND B2B must not be mixed in one message/)
         end
       end
 
@@ -516,7 +516,7 @@ describe SEPA::DirectDebit do
         end
 
         it 'should create valid XML file' do
-          expect(subject).to validate_against('pain.008.003.02.xsd')
+          expect(subject).to validate_against('pain.008.001.02.xsd')
         end
 
         it 'should contain <InstrId>' do
@@ -533,7 +533,7 @@ describe SEPA::DirectDebit do
         end
 
         it 'should fail as the payment identification becomes too large' do
-          expect { subject.to_xml }.to raise_error(SEPA::Error)
+          expect { subject.to_xml }.to raise_error(SEPA::Error, /The value has a length of '37'; this exceeds the allowed maximum length of '35'/)
         end
       end
 
@@ -546,7 +546,7 @@ describe SEPA::DirectDebit do
           sct
         end
 
-        it 'should validate against pain.001.001.03' do
+        it 'should validate against pain.008.001.02' do
           expect(subject.to_xml(SEPA::PAIN_008_001_02)).to validate_against('pain.008.001.02.xsd')
         end
 
@@ -562,13 +562,13 @@ describe SEPA::DirectDebit do
         it 'should fail for pain.008.002.02' do
           expect {
             subject.to_xml(SEPA::PAIN_008_002_02)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
 
         it 'should fail for pain.008.003.02' do
           expect {
             subject.to_xml(SEPA::PAIN_008_003_02)
-          }.to raise_error(SEPA::Error)
+          }.to raise_error(SEPA::Error, /Incompatible with schema/)
         end
       end
     end

data/spec/direct_debit_transaction_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::DirectDebitTransaction do
+RSpec.describe SEPA::DirectDebitTransaction do
   describe :initialize do
     it 'should create a valid transaction' do
       expect(

data/spec/message_spec.rb

@@ -10,7 +10,7 @@ class DummyMessage < SEPA::Message
   self.transaction_class = DummyTransaction
 end
 
-describe SEPA::Message do
+RSpec.describe SEPA::Message do
   describe :amount_total do
     subject do
       message = DummyMessage.new
@@ -86,7 +86,7 @@ describe SEPA::Message do
     end
   end
 
-describe :creation_date_time do
+  describe :creation_date_time do
     subject { DummyMessage.new }
 
     describe 'getter' do

data/spec/spec_helper.rb

@@ -18,12 +18,13 @@ require 'sepa_king'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
+Dir[File.expand_path(File.join(__dir__, 'support', '**', '*.rb'))].each {|f| require f}
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
+  config.disable_monkey_patching!
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing

data/spec/transaction_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::Transaction do
+RSpec.describe SEPA::Transaction do
   describe :new do
     it 'should have default for reference' do
       expect(SEPA::Transaction.new.reference).to eq('NOTPROVIDED')
@@ -26,7 +26,7 @@ describe SEPA::Transaction do
     end
   end
 
-  context 'Adress' do
+  context 'Address' do
     context 'with address_line' do
       it 'should accept valid value' do
         expect(SEPA::Transaction).to accept(SEPA::DebtorAddress.new(

data/spec/validation_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Credit Transfer Initiation' do
+RSpec.describe 'Credit Transfer Initiation' do
   it "should validate example file" do
     expect(File.read('spec/examples/pain.001.002.03.xml')).to validate_against('pain.001.002.03.xsd')
     expect(File.read('spec/examples/pain.001.003.03.xml')).to validate_against('pain.001.003.03.xsd')
@@ -12,7 +12,7 @@ describe 'Credit Transfer Initiation' do
   end
 end
 
-describe 'Direct Debit Initiation' do
+RSpec.describe 'Direct Debit Initiation' do
   it 'should validate example file' do
     expect(File.read('spec/examples/pain.008.002.02.xml')).to validate_against('pain.008.002.02.xsd')
     expect(File.read('spec/examples/pain.008.003.02.xml')).to validate_against('pain.008.003.02.xsd')

data/spec/validator_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe SEPA::IBANValidator do
+RSpec.describe SEPA::IBANValidator do
   class Validatable
     include ActiveModel::Model
     attr_accessor :iban, :iban_the_terrible
@@ -29,7 +29,7 @@ describe SEPA::IBANValidator do
   end
 end
 
-describe SEPA::BICValidator do
+RSpec.describe SEPA::BICValidator do
   class Validatable
     include ActiveModel::Model
     attr_accessor :bic, :custom_bic
@@ -52,7 +52,7 @@ describe SEPA::BICValidator do
   end
 end
 
-describe SEPA::CreditorIdentifierValidator do
+RSpec.describe SEPA::CreditorIdentifierValidator do
   class Validatable
     include ActiveModel::Model
     attr_accessor :creditor_identifier, :crid
@@ -61,11 +61,29 @@ describe SEPA::CreditorIdentifierValidator do
   end
 
   it 'should accept valid creditor_identifier' do
-    expect(Validatable).to accept('DE98ZZZ09999999999', 'AT12ZZZ00000000001', 'FR12ZZZ123456', 'NL97ZZZ123456780001', for: [:creditor_identifier, :crid])
+    expect(Validatable).to accept(
+      'DE98ZZZ09999999999',
+      'CH0712300000012345',
+      'SE97ZZZ1234567890',
+      'PL97ZZZ0123456789',
+      'NO97ZZZ123456785',
+      'HU74111A12345676',
+      'BG32ZZZ100064095',
+      'AT12ZZZ00000000001',
+      'FR12ZZZ123456',
+      'NL97ZZZ123456780001',
+      for: [:creditor_identifier, :crid]
+    )
   end
 
   it 'should not accept an invalid creditor_identifier' do
-    expect(Validatable).not_to accept('', 'xxx', 'DE98ZZZ099999999990', for: [:creditor_identifier, :crid])
+    expect(Validatable).not_to accept(
+      '',
+      'xxx',
+      'DE98ZZZ099999999990',
+      'DE98---09999999999',
+      for: [:creditor_identifier, :crid]
+    )
   end
 
   it "should customize error message" do
@@ -75,7 +93,7 @@ describe SEPA::CreditorIdentifierValidator do
   end
 end
 
-describe SEPA::MandateIdentifierValidator do
+RSpec.describe SEPA::MandateIdentifierValidator do
   class Validatable
     include ActiveModel::Model
     attr_accessor :mandate_id, :mid
@@ -88,12 +106,12 @@ describe SEPA::MandateIdentifierValidator do
   end
 
   it 'should not accept an invalid mandate_identifier' do
-    expect(Validatable).not_to accept(nil, '', 'X' * 36, 'ABC 123', '#/*', 'Ümläüt', for: [:mandate_id, :mid])
+    expect(Validatable).not_to accept(nil, '', 'X' * 36, '#/*', 'Ümläüt', for: [:mandate_id, :mid])
   end
 
   it "should customize error message" do
-    v = Validatable.new(:mandate_id => 'ABC 123')
+    v = Validatable.new(:mandate_id => '*** 123')
     v.valid?
-    expect(v.errors[:mandate_id]).to eq(['ABC 123 seems wrong'])
+    expect(v.errors[:mandate_id]).to eq(['*** 123 seems wrong'])
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: sepa_king
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Georg Leciejewski
 - Georg Ledermann
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-08-25 00:00:00.000000000 Z
+date: 2022-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -82,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: coveralls_reborn
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,31 +123,29 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Implemention of pain.001.002.03 and pain.008.002.02 (ISO 20022)
+description: Implemention of Payments Initiation (ISO 20022)
 email:
 - gl@salesking.eu
-- mail@georg-ledermann.de
+- georg@ledermann.dev
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/Gemfile-activemodel-3.1.x
-- gemfiles/Gemfile-activemodel-3.2.x
-- gemfiles/Gemfile-activemodel-4.0.x
-- gemfiles/Gemfile-activemodel-4.1.x
 - gemfiles/Gemfile-activemodel-4.2.x
 - gemfiles/Gemfile-activemodel-5.0.x
 - gemfiles/Gemfile-activemodel-5.1.x
 - gemfiles/Gemfile-activemodel-5.2.x
 - gemfiles/Gemfile-activemodel-6.0.x
+- gemfiles/Gemfile-activemodel-6.1.x
+- gemfiles/Gemfile-activemodel-7.0.x
 - lib/schema/pain.001.001.03.ch.02.xsd
 - lib/schema/pain.001.001.03.xsd
 - lib/schema/pain.001.002.03.xsd
@@ -189,18 +187,17 @@ files:
 - spec/examples/pain.008.003.02.xml
 - spec/message_spec.rb
 - spec/spec_helper.rb
-- spec/support/active_model.rb
 - spec/support/custom_matcher.rb
 - spec/support/factories.rb
 - spec/support/validations.rb
 - spec/transaction_spec.rb
 - spec/validation_spec.rb
 - spec/validator_spec.rb
-homepage: http://github.com/salesking/sepa_king
+homepage: https://github.com/salesking/sepa_king
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -208,39 +205,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.3.23
+signing_key:
 specification_version: 4
 summary: Ruby gem for creating SEPA XML files
-test_files:
-- spec/account_spec.rb
-- spec/converter_spec.rb
-- spec/credit_transfer_spec.rb
-- spec/credit_transfer_transaction_spec.rb
-- spec/creditor_account_spec.rb
-- spec/debtor_account_spec.rb
-- spec/debtor_address_spec.rb
-- spec/direct_debit_spec.rb
-- spec/direct_debit_transaction_spec.rb
-- spec/examples/pain.001.001.03.ch.02.xml
-- spec/examples/pain.001.001.03.xml
-- spec/examples/pain.001.002.03.xml
-- spec/examples/pain.001.003.03.xml
-- spec/examples/pain.008.002.02.xml
-- spec/examples/pain.008.003.02.xml
-- spec/message_spec.rb
-- spec/spec_helper.rb
-- spec/support/active_model.rb
-- spec/support/custom_matcher.rb
-- spec/support/factories.rb
-- spec/support/validations.rb
-- spec/transaction_spec.rb
-- spec/validation_spec.rb
-- spec/validator_spec.rb
+test_files: []

data/.travis.yml

@@ -1,37 +0,0 @@
-rvm:
-  - 2.2.10
-  - 2.3.8
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
-gemfile:
-  - gemfiles/Gemfile-activemodel-3.1.x
-  - gemfiles/Gemfile-activemodel-3.2.x
-  - gemfiles/Gemfile-activemodel-4.0.x
-  - gemfiles/Gemfile-activemodel-4.1.x
-  - gemfiles/Gemfile-activemodel-4.2.x
-  - gemfiles/Gemfile-activemodel-5.0.x
-  - gemfiles/Gemfile-activemodel-5.1.x
-  - gemfiles/Gemfile-activemodel-5.2.x
-  - gemfiles/Gemfile-activemodel-6.0.x
-matrix:
-  exclude:
-    - rvm: 2.2.10
-      gemfile: gemfiles/Gemfile-activemodel-6.0.x
-    - rvm: 2.3.8
-      gemfile: gemfiles/Gemfile-activemodel-6.0.x
-    - rvm: 2.4.6
-      gemfile: gemfiles/Gemfile-activemodel-4.1.x
-    - rvm: 2.4.6
-      gemfile: gemfiles/Gemfile-activemodel-4.2.x
-    - rvm: 2.4.6
-      gemfile: gemfiles/Gemfile-activemodel-6.0.x
-    - rvm: 2.5.5
-      gemfile: gemfiles/Gemfile-activemodel-4.1.x
-    - rvm: 2.5.5
-      gemfile: gemfiles/Gemfile-activemodel-4.2.x
-    - rvm: 2.6.3
-      gemfile: gemfiles/Gemfile-activemodel-4.1.x
-    - rvm: 2.6.3
-      gemfile: gemfiles/Gemfile-activemodel-4.2.x
-sudo: false

data/gemfiles/Gemfile-activemodel-3.2.x

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '..'
-
-gem 'activemodel', '~>3.2.22.2'

data/gemfiles/Gemfile-activemodel-4.0.x

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '..'
-
-gem 'activemodel', '~>4.0.13'

data/spec/support/active_model.rb

@@ -1,30 +0,0 @@
-unless defined?(ActiveModel::Model)
-  # ActiveModel::Model is available since ActiveModel 4.0 only.
-  #
-  # If it's missing, add the code from
-  # https://github.com/rails/rails/blob/master/activemodel/lib/active_model/model.rb
-  module ActiveModel
-    module Model
-      def self.included(base)
-        base.class_eval do
-          extend  ActiveModel::Naming
-          extend  ActiveModel::Translation
-          include ActiveModel::Validations
-          include ActiveModel::Conversion
-        end
-      end
-
-      def initialize(params={})
-        params.each do |attr, value|
-          self.public_send("#{attr}=", value)
-        end if params
-
-        super()
-      end
-
-      def persisted?
-        false
-      end
-    end
-  end
-end