sepa_king 0.0.3 → 0.0.4

data/spec/credit_transfer_transaction_spec.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::CreditTransferTransaction do
+  it 'should initialize a new transaction' do
+    expect(
+      SEPA::CreditTransferTransaction.new :name                   => 'Telekomiker AG',
+                                          :iban                   => 'DE37112589611964645802',
+                                          :bic                    => 'PBNKDEFF370',
+                                          :amount                 => 102.50,
+                                          :reference              => 'XYZ-1234/123',
+                                          :remittance_information => 'Rechnung 123 vom 22.08.2013'
+    ).to be_valid
+  end
+end

data/spec/creditor_account_spec.rb

@@ -0,0 +1,31 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::CreditorAccount do
+  it 'should initialize a new account' do
+    expect(
+      SEPA::CreditorAccount.new :name       => 'Gläubiger GmbH',
+                                :bic        => 'BANKDEFFXXX',
+                                :iban       => 'DE87200500001234567890',
+                                :identifier => 'DE98ZZZ09999999999'
+    ).to be_valid
+  end
+
+  describe :identifier do
+    it 'should accept valid value' do
+      [ 'DE98ZZZ09999999999' ].each do |value_value|
+        expect(
+          SEPA::CreditorAccount.new :identifier => value_value
+        ).to have(:no).errors_on(:identifier)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ '', 'invalid' ].each do |invalue_value|
+        expect(
+          SEPA::CreditorAccount.new :identifier => invalue_value
+        ).to have_at_least(1).errors_on(:identifier)
+      end
+    end
+  end
+end

data/spec/debtor_account_spec.rb

@@ -0,0 +1,12 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::DebtorAccount do
+  it 'should initialize a new account' do
+    expect(
+      SEPA::DebtorAccount.new :name       => 'Gläubiger GmbH',
+                              :bic        => 'BANKDEFFXXX',
+                              :iban       => 'DE87200500001234567890'
+    ).to be_valid
+  end
+end

data/spec/direct_debit_spec.rb

@@ -0,0 +1,76 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::DirectDebit do
+  let(:direct_debit) {
+    SEPA::DirectDebit.new :name       => 'Gläubiger GmbH',
+                          :bic        => 'BANKDEFFXXX',
+                          :iban       => 'DE87200500001234567890',
+                          :identifier => 'DE98ZZZ09999999999'
+  }
+
+  describe :new do
+    it 'should accept missing options' do
+      expect {
+        SEPA::DirectDebit.new
+      }.to_not raise_error
+    end
+  end
+
+  describe :add_transaction do
+    it 'should add valid transactions' do
+      3.times {
+        direct_debit.add_transaction :name                      => 'Zahlemann & Söhne GbR',
+                                     :bic                       => 'SPUEDE2UXXX',
+                                     :iban                      => 'DE21500500009876543210',
+                                     :amount                    => 39.99,
+                                     :reference                 => 'XYZ/2013-08-ABO/12345',
+                                     :remittance_information    => 'Unsere Rechnung vom 10.08.2013',
+                                     :mandate_id                => 'K-02-2011-12345',
+                                     :mandate_date_of_signature => Date.new(2011,1,25)
+      }
+
+      expect(direct_debit).to have(3).transactions
+    end
+
+    it 'should fail for invalid transaction' do
+      expect {
+        direct_debit.add_transaction :name => ''
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe :to_xml do
+    it 'should fail for invalid debtor' do
+      expect {
+        SEPA::DirectDebit.new.to_xml
+      }.to raise_error(RuntimeError)
+    end
+
+    it 'should create valid XML file' do
+      dd = direct_debit
+
+      dd.add_transaction :name                      => 'Zahlemann & Söhne GbR',
+                         :bic                       => 'SPUEDE2UXXX',
+                         :iban                      => 'DE21500500009876543210',
+                         :amount                    => 39.99,
+                         :reference                 => 'XYZ/2013-08-ABO/12345',
+                         :remittance_information    => 'Unsere Rechnung vom 10.08.2013',
+                         :mandate_id                => 'K-02-2011-12345',
+                         :mandate_date_of_signature => Date.new(2011,1,25)
+
+      dd.add_transaction :name                      => 'Meier & Schulze oHG',
+                         :bic                       => 'GENODEF1JEV',
+                         :iban                      => 'DE68210501700012345678',
+                         :amount                    => 750.00,
+                         :reference                 => 'XYZ/2013-08-ABO/6789',
+                         :remittance_information    => 'Vielen Dank für Ihren Einkauf!',
+                         :mandate_id                => 'K-08-2010-42123',
+                         :mandate_date_of_signature => Date.new(2010,7,25)
+
+      expect(
+        XML::Document.string(dd.to_xml)
+      ).to validate_against('pain.008.002.02.xsd')
+    end
+  end
+end

data/spec/direct_debit_transaction_spec.rb

@@ -0,0 +1,53 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::DirectDebitTransaction do
+  it 'should initialize a new transaction' do
+    expect(
+      SEPA::DirectDebitTransaction.new :name                      => 'Zahlemann & Söhne Gbr',
+                                       :bic                       => 'SPUEDE2UXXX',
+                                       :iban                      => 'DE21500500009876543210',
+                                       :amount                    => 39.99,
+                                       :reference                 => 'XYZ-1234/123',
+                                       :remittance_information    => 'Vielen Dank für Ihren Einkauf!',
+                                       :mandate_id                => 'K-02-2011-12345',
+                                       :mandate_date_of_signature => Date.new(2011,1,25)
+    ).to be_valid
+  end
+
+  context 'Mandate Date of Signature' do
+    it 'should allow valid value' do
+      [ Date.today, Date.today - 1 ].each do |valid_value|
+        expect(
+          SEPA::DirectDebitTransaction.new :mandate_date_of_signature => valid_value
+        ).to have(:no).errors_on(:mandate_date_of_signature)
+      end
+    end
+
+    it 'should not allow invalid value' do
+      [ nil, '2010-12-01', Date.today + 1 ].each do |invalid_value|
+        expect(
+          SEPA::DirectDebitTransaction.new :mandate_date_of_signature => invalid_value
+        ).to have_at_least(1).errors_on(:mandate_date_of_signature)
+      end
+    end
+  end
+
+  context 'Mandate ID' do
+    it 'should allow valid value' do
+      [ 'XYZ-123', 'X' * 35 ].each do |valid_value|
+        expect(
+          SEPA::DirectDebitTransaction.new :mandate_id => valid_value
+        ).to have(:no).errors_on(:mandate_id)
+      end
+    end
+
+    it 'should not allow invalid value' do
+      [ nil, '', 'X' * 36 ].each do |invalid_value|
+        expect(
+          SEPA::DirectDebitTransaction.new :mandate_id => invalid_value
+        ).to have_at_least(1).errors_on(:mandate_id)
+      end
+    end
+  end
+end

data/spec/message_spec.rb

@@ -0,0 +1,22 @@
+# encoding: utf-8
+require 'spec_helper'
+
+class DummyTransaction < SEPA::Transaction
+  def valid?; true end
+end
+
+class DummyMessage < SEPA::Message
+  self.account_class = Hash
+  self.transaction_class = DummyTransaction
+end
+
+describe SEPA::Message do
+  describe :amount_total do
+    it 'should sum up transactions' do
+      message = DummyMessage.new
+      message.add_transaction :amount => 1.1
+      message.add_transaction :amount => 2.2
+      message.amount_total.should == 3.3
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -8,7 +8,6 @@ require 'coveralls'
 SimpleCov.formatter = Coveralls::SimpleCov::Formatter
 SimpleCov.start
 
-require 'ostruct'
 require 'xml'
 require 'sepa_king'
 

data/spec/support/validations.rb

@@ -0,0 +1,27 @@
+# Borrowed from rspec-rails
+# https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/extensions/active_record/base.rb
+
+module ::ActiveModel::Validations
+  # Extension to enhance `to have` on AR Model instances.  Calls
+  # model.valid? in order to prepare the object's errors object. Accepts
+  # a :context option to specify the validation context.
+  #
+  # You can also use this to specify the content of the error messages.
+  #
+  # @example
+  #
+  #     expect(model).to have(:no).errors_on(:attribute)
+  #     expect(model).to have(1).error_on(:attribute)
+  #     expect(model).to have(n).errors_on(:attribute)
+  #     expect(model).to have(n).errors_on(:attribute, :context => :create)
+  #
+  #     expect(model.errors_on(:attribute)).to include("can't be blank")
+  def errors_on(attribute, options = {})
+    valid_args = [options[:context]].compact
+    self.valid?(*valid_args)
+
+    [self.errors[attribute]].flatten.compact
+  end
+
+  alias :error_on :errors_on
+end

data/spec/transaction_spec.rb

@@ -0,0 +1,112 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe SEPA::Transaction do
+  context 'Name' do
+    it 'should accept valid value' do
+      [ 'Manfred Mustermann III.', 'Zahlemann & Söhne GbR', 'X' * 70 ].each do |value_value|
+        expect(
+          SEPA::Transaction.new :name => value_value
+        ).to have(:no).errors_on(:name)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ nil, '', 'X' * 71 ].each do |invalue_value|
+        expect(
+          SEPA::Transaction.new :name => invalue_value
+        ).to have_at_least(1).errors_on(:name)
+      end
+    end
+  end
+
+  context 'IBAN' do
+    it 'should accept valid value' do
+      [ 'DE21500500009876543210', 'PL61109010140000071219812874' ].each do |value_value|
+        expect(
+          SEPA::Transaction.new :iban => value_value
+        ).to have(:no).errors_on(:iban)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ nil, '', 'invalid' ].each do |invalue_value|
+        expect(
+          SEPA::Transaction.new :iban => invalue_value
+        ).to have_at_least(1).errors_on(:iban)
+      end
+    end
+  end
+
+  context 'BIC' do
+    it 'should accept valid value' do
+      [ 'DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX' ].each do |value_value|
+        expect(
+          SEPA::Transaction.new :bic => value_value
+        ).to have(:no).errors_on(:bic)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ nil, '', 'invalid' ].each do |invalue_value|
+        expect(
+          SEPA::Transaction.new :bic => invalue_value
+        ).to have_at_least(1).errors_on(:bic)
+      end
+    end
+  end
+
+  context 'Amount' do
+    it 'should accept valid value' do
+      [ 0.01, 1, 100, 100.00, 99.99, 1234567890.12, BigDecimal('10'), '42', '42.51', '42.512', 1.23456 ].each do |value_value|
+        expect(
+          SEPA::Transaction.new :amount => value_value
+        ).to have(:no).errors_on(:amount)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ nil, 0, -3, 'xz' ].each do |invalue_value|
+        expect(
+          SEPA::Transaction.new :amount => invalue_value
+        ).to have_at_least(1).errors_on(:amount)
+      end
+    end
+  end
+
+  context 'Reference' do
+    it 'should accept valid value' do
+      [ nil, 'ABC-1234/78.0', 'X' * 35 ].each do |value_value|
+        expect(
+          SEPA::Transaction.new :reference => value_value
+        ).to have(:no).errors_on(:reference)
+      end
+    end
+
+    it 'should not accept invalid value' do
+      [ '', 'X' * 36 ].each do |invalid_value|
+        expect(
+          SEPA::Transaction.new :reference => invalid_value
+        ).to have_at_least(1).errors_on(:reference)
+      end
+    end
+  end
+
+  context 'Remittance information' do
+    it 'should allow valid value' do
+      [ nil, 'Bonus', 'X' * 140 ].each do |valid_value|
+        expect(
+          SEPA::Transaction.new :remittance_information => valid_value
+        ).to have(:no).errors_on(:remittance_information)
+      end
+    end
+
+    it 'should not allow invalid value' do
+      [ '', 'X' * 141 ].each do |invalid_value|
+        expect(
+          SEPA::Transaction.new :remittance_information => invalid_value
+        ).to have_at_least(1).errors_on(:remittance_information)
+      end
+    end
+  end
+end

data/spec/{sepa_king/validation_spec.rb → validation_spec.rb}

@@ -2,12 +2,12 @@ require 'spec_helper'
 
 describe 'Credit Transfer Initiation' do
   it "should validate example file" do
-    XML::Document.file('spec/fixtures/pain.001.002.03.xml').should validate_against('pain.001.002.03.xsd')
+    XML::Document.file('spec/examples/pain.001.002.03.xml').should validate_against('pain.001.002.03.xsd')
   end
 end
 
 describe 'Direct Debit Initiation' do
   it 'should validate example file' do
-    XML::Document.file('spec/fixtures/pain.008.002.02.xml').should validate_against('pain.008.002.02.xsd')
+    XML::Document.file('spec/examples/pain.008.002.02.xml').should validate_against('pain.008.002.02.xsd')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepa_king
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Georg Leciejewski
@@ -9,8 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-23 00:00:00.000000000 Z
+date: 2013-08-26 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -156,27 +170,33 @@ files:
 - lib/schema/pain.008.002.02.xsd
 - lib/sepa_king.rb
 - lib/sepa_king/account.rb
-- lib/sepa_king/credit_transaction.rb
-- lib/sepa_king/credit_transfer.rb
-- lib/sepa_king/debt_transaction.rb
-- lib/sepa_king/direct_debit.rb
-- lib/sepa_king/exception.rb
-- lib/sepa_king/text_converter.rb
+- lib/sepa_king/account/creditor_account.rb
+- lib/sepa_king/account/debtor_account.rb
+- lib/sepa_king/converter.rb
+- lib/sepa_king/message.rb
+- lib/sepa_king/message/credit_transfer.rb
+- lib/sepa_king/message/direct_debit.rb
 - lib/sepa_king/transaction.rb
+- lib/sepa_king/transaction/credit_transfer_transaction.rb
+- lib/sepa_king/transaction/direct_debit_transaction.rb
 - lib/sepa_king/version.rb
 - sepa_king.gemspec
-- spec/fixtures/pain.001.002.03.xml
-- spec/fixtures/pain.008.002.02.xml
-- spec/sepa_king/account_spec.rb
-- spec/sepa_king/credit_transaction_spec.rb
-- spec/sepa_king/credit_transfer_spec.rb
-- spec/sepa_king/debt_transaction_spec.rb
-- spec/sepa_king/direct_debit_spec.rb
-- spec/sepa_king/text_converter_spec.rb
-- spec/sepa_king/transaction_spec.rb
-- spec/sepa_king/validation_spec.rb
+- spec/account_spec.rb
+- spec/converter_spec.rb
+- spec/credit_transfer_spec.rb
+- spec/credit_transfer_transaction_spec.rb
+- spec/creditor_account_spec.rb
+- spec/debtor_account_spec.rb
+- spec/direct_debit_spec.rb
+- spec/direct_debit_transaction_spec.rb
+- spec/examples/pain.001.002.03.xml
+- spec/examples/pain.008.002.02.xml
+- spec/message_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matcher.rb
+- spec/support/validations.rb
+- spec/transaction_spec.rb
+- spec/validation_spec.rb
 homepage: http://github.com/salesking/sepa_king
 licenses:
 - MIT
@@ -202,15 +222,19 @@ signing_key:
 specification_version: 4
 summary: Generate SEPA XML files with Ruby ... the easy way
 test_files:
-- spec/fixtures/pain.001.002.03.xml
-- spec/fixtures/pain.008.002.02.xml
-- spec/sepa_king/account_spec.rb
-- spec/sepa_king/credit_transaction_spec.rb
-- spec/sepa_king/credit_transfer_spec.rb
-- spec/sepa_king/debt_transaction_spec.rb
-- spec/sepa_king/direct_debit_spec.rb
-- spec/sepa_king/text_converter_spec.rb
-- spec/sepa_king/transaction_spec.rb
-- spec/sepa_king/validation_spec.rb
+- spec/account_spec.rb
+- spec/converter_spec.rb
+- spec/credit_transfer_spec.rb
+- spec/credit_transfer_transaction_spec.rb
+- spec/creditor_account_spec.rb
+- spec/debtor_account_spec.rb
+- spec/direct_debit_spec.rb
+- spec/direct_debit_transaction_spec.rb
+- spec/examples/pain.001.002.03.xml
+- spec/examples/pain.008.002.02.xml
+- spec/message_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matcher.rb
+- spec/support/validations.rb
+- spec/transaction_spec.rb
+- spec/validation_spec.rb

data/lib/sepa_king/credit_transaction.rb

@@ -1,5 +0,0 @@
-# encoding: utf-8
-module SEPA
-  class CreditTransaction < Transaction
-  end
-end

data/lib/sepa_king/credit_transfer.rb

@@ -1,104 +0,0 @@
-# encoding: utf-8
-
-module SEPA
-  class CreditTransfer
-    attr_reader :debitor, :transactions
-
-    def initialize(debitor_options)
-      @debitor = Account.new(debitor_options)
-      @transactions = []
-    end
-
-    def add_transaction(options)
-      @transactions << CreditTransaction.new(options)
-    end
-
-    def to_xml
-      builder = Builder::XmlMarkup.new :indent => 2
-      builder.instruct!
-      builder.Document :xmlns                => 'urn:iso:std:iso:20022:tech:xsd:pain.001.002.03',
-                       :'xmlns:xsi'          => 'http://www.w3.org/2001/XMLSchema-instance',
-                       :'xsi:schemaLocation' => 'urn:iso:std:iso:20022:tech:xsd:pain.001.002.03 pain.001.002.03.xsd' do
-        builder.CstmrCdtTrfInitn do
-          builder.GrpHdr do
-            builder.MsgId(message_identification)
-            builder.CreDtTm(Time.now.iso8601)
-            builder.NbOfTxs(transactions.length)
-            builder.InitgPty do
-              builder.Nm(debitor.name)
-            end
-          end
-
-          builder.PmtInf do
-            builder.PmtInfId(payment_information_identification)
-            builder.PmtMtd('TRF')
-            builder.BtchBookg(true)
-            builder.NbOfTxs(transactions.length)
-            builder.CtrlSum(amount_total)
-            builder.PmtTpInf do
-              builder.SvcLvl do
-                builder.Cd('SEPA')
-              end
-            end
-            builder.ReqdExctnDt(Date.today.next.iso8601)
-            builder.Dbtr do
-              builder.Nm(debitor.name)
-            end
-            builder.DbtrAcct do
-              builder.Id do
-                builder.IBAN(debitor.iban)
-              end
-            end
-            builder.DbtrAgt do
-              builder.FinInstnId do
-                builder.BIC(debitor.bic)
-              end
-            end
-            builder.ChrgBr('SLEV')
-            transactions.each do |transaction|
-              builder.CdtTrfTxInf do
-                builder.PmtId do
-                  builder.EndToEndId(transaction.reference || 'NOTPROVIDED')
-                end
-                builder.Amt do
-                  builder.InstdAmt(transaction.amount, :Ccy => 'EUR')
-                end
-                builder.CdtrAgt do
-                  builder.FinInstnId do
-                    builder.BIC(transaction.bic)
-                  end
-                end
-                builder.Cdtr do
-                  builder.Nm(transaction.name)
-                end
-                builder.CdtrAcct do
-                  builder.Id do
-                    builder.IBAN(transaction.iban)
-                  end
-                end
-                if transaction.remittance_information
-                  builder.RmtInf do
-                    builder.Ustrd(transaction.remittance_information)
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-
-  private
-    def amount_total
-      transactions.inject(0) { |sum, t| sum + t.amount }
-    end
-
-    def message_identification
-      "SEPA-KING/#{Time.now.iso8601}"
-    end
-
-    def payment_information_identification
-      message_identification
-    end
-  end
-end

data/lib/sepa_king/debt_transaction.rb

@@ -1,18 +0,0 @@
-# encoding: utf-8
-module SEPA
-  class DebtTransaction < Transaction
-    attr_reader :mandate_id, :mandate_date_of_signature
-
-    def mandate_id=(value)
-      raise ArgumentError.new('Mandate ID is missing') if value.nil? || value.empty?
-      raise ArgumentError.new("Mandate ID is too long: #{value.length}, must be 35 maximum") if value.length > 35
-      @mandate_id = convert_text(value)
-    end
-
-    def mandate_date_of_signature=(value)
-      raise ArgumentError.new('Mandate Date of Signature is missing') unless value.is_a?(Date)
-      raise ArgumentError.new('Mandate Date of Signature is in the future') if value > Date.today
-      @mandate_date_of_signature = value
-    end
-  end
-end