sepa_clearer 0.0.2 → 0.5.1

data/lib/sepa_clearer/clearer.rb

@@ -1,20 +1,66 @@
+require 'sqlite3'
+
 module SepaClearer
   class Clearer
-    def initialize(clearer = 'DeutscheBundesbank')
-      @klass = SepaClearer.const_get(clearer).new
+    attr_accessor :db
+
+    # Make sure we always have the correct order of columns
+    ATTRIBUTES = [:name, :bic, :sct, :core, :cor1, :b2b]
+
+    def initialize(db_name = 'deutsche_bundesbank')
+      self.db = SQLite3::Database.new File.join(File.dirname(__FILE__), '../..', "data/#{db_name}.db")
+    end
+
+    def add(provider)
+      data = boolean_to_integers(provider.to_a)
+      db.execute "INSERT INTO payment_providers (#{ATTRIBUTES.join(',')}) VALUES (?, ?, ?, ?, ?, ?)", data
     end
 
     def all
-      @klass.data
+      db.execute("SELECT #{ATTRIBUTES.join(',')} FROM payment_providers ORDER BY name").map do |row|
+        PaymentProvider.new(hash_from_result(row))
+      end
     end
 
     def find_by_bic(bic)
-      normalized_bic = normalize_bic(bic)
-      @klass.data.find { |provider| provider.bic == normalized_bic }
+      db.execute("SELECT #{ATTRIBUTES.join(',')} FROM payment_providers WHERE bic = ?", normalize_bic(bic)).map do |row|
+        PaymentProvider.new(hash_from_result(row))
+      end.first
+    end
+
+    def delete
+      db.execute("DELETE FROM payment_providers").first
     end
 
     def normalize_bic(bic)
       bic.to_s.ljust(11, 'X').upcase
     end
+
+    protected
+
+    def hash_from_result(raw_array)
+      raw_array_with_boolean = integers_to_boolean(raw_array)
+      Hash[ATTRIBUTES.zip(raw_array_with_boolean)]
+    end
+
+    def boolean_to_integers(array)
+      array.map do |element|
+        if element.kind_of?(TrueClass) || element.kind_of?(FalseClass)
+          element ? 1 : 0
+        else
+          element
+        end
+      end
+    end
+
+    def integers_to_boolean(array)
+      array.map do |element|
+        if element.kind_of?(Integer)
+          element == 1
+        else
+          element
+        end
+      end
+    end
   end
 end

data/lib/sepa_clearer/deutsche_bundesbank.rb

@@ -2,29 +2,28 @@ require 'csv'
 
 module SepaClearer
   class DeutscheBundesbank
-    CAPABILITIES_MAPPING = {
-                        service_sct: :sct,
-                        service_sdd: :core,
-                        service_cor1: :cor1,
-                        service_b2b: :b2b
-                      }
+    MAPPING = {
+                              service_sct: :sct,
+                              service_sdd: :core,
+                              service_cor1: :cor1,
+                              service_b2b: :b2b
+                            }
 
     def data(file = nil)
       @data ||= begin
         [].tap do |data|
-          CSV.foreach(file || default_data_file, { headers: true, col_sep: ';', header_converters: :symbol }) do |row|
-            data.push PaymentProvider.new(*parse_raw_data(row))
+          CSV.foreach(file || default_data_file, { headers: true, col_sep: ';', header_converters: :symbol, encoding: "iso-8859-1:UTF-8" }) do |row|
+            data.push PaymentProvider.new(parse_raw_data(row))
           end
         end
       end
     end
 
     def parse_raw_data(data)
-      [
-        data[:name].strip.chomp,
-        data[:bic],
-        CAPABILITIES_MAPPING.map { |key, service| data[key] == '1' ? service : nil }.compact
-      ]
+      MAPPING.reduce({}) { |hsh,(key, service)| hsh[service] = (data[key] == '1'); hsh }.merge({
+        name: data[:name].strip.chomp,
+        bic: data[:bic].strip.chomp,
+      })
     end
 
     def default_data_file

data/lib/sepa_clearer/payment_provider.rb

@@ -2,12 +2,45 @@ module SepaClearer
   class PaymentProvider
     SERVICES = [:sct, :core, :cor1, :b2b]
 
-    attr_accessor :name, :bic, :capabilities
+    attr_accessor :name, :bic, :sct, :core, :cor1, :b2b
 
-    def initialize(name, bic, capabilities)
-      self.name = name
-      self.bic = bic
-      self.capabilities = capabilities
+    def initialize(options = {})
+      self.name = options[:name]
+      self.bic = options[:bic]
+      self.sct = options[:sct] || false
+      self.core = options[:core] || false
+      self.cor1 = options[:cor1] || false
+      self.b2b = options[:b2b] || false
+    end
+
+    def capabilities
+      SERVICES.map { |s| [s, send(s)] }.select { |_,v| v }.map { |k,v| k }
+    end
+
+    # Returns a list of provided direct debit methods sorted by there speed
+    # :cor1 => 2 business days
+    # :core => 3 business days (recurring) & 6 business days for first
+    def direct_debit_instruments
+      (capabilities & [:core, :cor1]).sort
+    end
+
+    def bic
+      @bic.to_s.ljust(11, 'X').upcase
+    end
+
+    def to_a
+      to_hash.values
+    end
+
+    def to_hash
+      {
+        name: name,
+        bic: bic,
+        sct: sct,
+        core: core,
+        cor1: cor1,
+        b2b: b2b,
+      }
     end
   end
 end

data/lib/sepa_clearer/version.rb

@@ -1,3 +1,3 @@
 module SepaClearer
-  VERSION = '0.0.2'
+  VERSION = '0.5.1'
 end

data/sepa-clearer.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "sqlite3"
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake", "~> 0"
   spec.add_development_dependency "rspec", "~> 3"

data/spec/clearer_spec.rb

@@ -9,18 +9,22 @@ describe SepaClearer::Clearer do
 
   describe '#find_by_bic' do
     it 'returns the provider with the given BIC' do
-      expect(subject.find_by_bic('AABAFI22TMS')).to be_kind_of(SepaClearer::PaymentProvider)
+      expect(subject.find_by_bic('AABAFI22')).to be_kind_of(SepaClearer::PaymentProvider)
     end
 
     it 'returns nil if no object matches the BIC' do
       expect(subject.find_by_bic('MYTHINGY')).to eq(nil)
     end
 
-    it 'normalizes thebic before searching' do
+    it 'normalizes the bic before searching' do
       allow(subject).to receive(:normalize_bic).and_return('AAA')
       expect(subject.find_by_bic('MYTHINGY')).to eq(nil)
       expect(subject).to have_received(:normalize_bic)
     end
+
+    it 'returns an initialize object' do
+      expect(subject.find_by_bic('AABAFI22').name).to eq('BANK OF ALAND PLC')
+    end
   end
 
   describe '#normalize_bic' do

data/spec/deutsche_bundesbank_spec.rb

@@ -3,20 +3,24 @@ require 'spec_helper'
 describe SepaClearer::DeutscheBundesbank do
   describe '#parse_raw_data' do
     let(:data) { { name: "My Org \n", bic: 'QWERTZ12345', service_sct: '1' } }
-    it 'returns an array' do
-      expect(subject.parse_raw_data(data)).to eq(['My Org', 'QWERTZ12345', [:sct]])
+
+    it 'returns a hash' do
+      expect(subject.parse_raw_data(data)).to be_kind_of(Hash)
     end
 
     it 'cleans up the name' do
-      expect(subject.parse_raw_data(data)[0]).to eq('My Org')
+      expect(subject.parse_raw_data(data)[:name]).to eq('My Org')
     end
 
     it 'returns the BIC' do
-      expect(subject.parse_raw_data(data)[1]).to eq('QWERTZ12345')
+      expect(subject.parse_raw_data(data)[:bic]).to eq('QWERTZ12345')
     end
 
     it 'maps the capabilities' do
-      expect(subject.parse_raw_data(data)[2]).to eq([:sct])
+      expect(subject.parse_raw_data(data)[:sct]).to eq(true)
+      expect(subject.parse_raw_data(data)[:core]).to eq(false)
+      expect(subject.parse_raw_data(data)[:cor1]).to eq(false)
+      expect(subject.parse_raw_data(data)[:b2b]).to eq(false)
     end
   end
 end

data/spec/payment_provider_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe SepaClearer::PaymentProvider do
   describe '.new' do
-    subject(:provider) { described_class.new('Testorg', 'SOMEVALIDID', [:core]) }
+    subject(:provider) { described_class.new(name: 'Testorg', bic: 'SOMEVALIDID') }
 
     it 'sets the proper name' do
       expect(provider.name).to eq('Testorg')
@@ -12,8 +12,52 @@ describe SepaClearer::PaymentProvider do
       expect(provider.bic).to eq('SOMEVALIDID')
     end
 
-    it 'sets the proper capabilities' do
-      expect(provider.capabilities).to eq([:core])
+    it 'does not set any capabilities' do
+      expect(provider.capabilities).to eq([])
+    end
+  end
+
+  describe '#capabilities' do
+    subject(:provider) { described_class.new(sct: true, core: false, cor1: true, b2b: true) }
+
+    it 'returns all capabilities' do
+      expect(provider.capabilities).to eq([:sct, :cor1, :b2b])
+    end
+  end
+
+  describe '#direct_debit_instruments' do
+    it 'returns only DD instruments' do
+      allow(subject).to receive(:capabilities).and_return([:b2b, :cor1, :core, :sct])
+      expect(subject.direct_debit_instruments).to eq([:cor1, :core])
+    end
+
+    it 'returns faster cor1 first if order last' do
+      allow(subject).to receive(:capabilities).and_return([:core, :cor1])
+      expect(subject.direct_debit_instruments.first).to eq(:cor1)
+    end
+
+    it 'returns faster cor1 first if order properly' do
+      allow(subject).to receive(:capabilities).and_return([:cor1, :core])
+      expect(subject.direct_debit_instruments.first).to eq(:cor1)
+    end
+  end
+
+  describe '#to_hash' do
+    subject(:provider) { described_class.new(name: 'test', bic: 'bic', sct: true, core: false, cor1: true, b2b: true) }
+
+    it 'returns a hash' do
+      expect(provider.to_hash).to be_kind_of(Hash)
+    end
+
+    it 'sets correct values' do
+      expect(provider.to_hash).to match({
+        name: 'test',
+        bic: 'BICXXXXXXXX',
+        sct: true,
+        core: false,
+        cor1: true,
+        b2b: true
+      })
     end
   end
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: sepa_clearer
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.5.1
 platform: ruby
 authors:
 - Maximilian Schulz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-07-17 00:00:00.000000000 Z
+date: 2021-10-28 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -69,6 +83,7 @@ files:
 - Rakefile
 - bin/update_data
 - data/deutsche_bundesbank.csv
+- data/deutsche_bundesbank.db
 - lib/sepa_clearer.rb
 - lib/sepa_clearer/clearer.rb
 - lib/sepa_clearer/deutsche_bundesbank.rb
@@ -83,7 +98,7 @@ homepage: http://opensource.railslove.com/sepa-clearer
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -98,9 +113,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: List of all available SEPA clearers and their supported features
 test_files:
@@ -108,4 +122,3 @@ test_files:
 - spec/deutsche_bundesbank_spec.rb
 - spec/payment_provider_spec.rb
 - spec/spec_helper.rb
-has_rdoc: