sepa 0.0.18.1 → 0.0.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 66a897ba3be8da790054ae7e8e3486d989092ffc
-  data.tar.gz: 1da0321274827f0069538136dc92aa219bb4c046
+  metadata.gz: ab9664447c049ccc5d9bee8208adedeaf835127a
+  data.tar.gz: 2458d3d8e38a35ac4e06fd6d84cbb3b6b8f3fdbd
 SHA512:
-  metadata.gz: 7801d300bb5447344727d6c6b6402015bffc6e49f03452f43da2cf81cfb592762e1b3e8e04eddf4dccf41e2f38b4b3fcad26cefce4838b02815ae4aa43465c3d
-  data.tar.gz: 26cd127d05963b39714e8bded55d3a782faeb0a570ff05c6ff06d19e8e5c8053b79933b93324506c35adba7873e5ed09e5cb5b4dccef2c7bb095010a632b40fa
+  metadata.gz: c767a5457b79d39ed6d7ca038cb4ae97cefd6593ca20e999c71fca5ae7059f04fd34786e0a4b486d2816c67100ddfa04dff8457859063da0935e66aa61099419
+  data.tar.gz: 4415b51f8c5bd33c997218e2bd8ffee8718546117f02d75e62095ced989d1b56a1865a3c69dcc3b3a53ebd9bb69c3eb01ab1d9069c4ea285beb8214fec20b55a

data/lib/sepa/base.rb

@@ -7,6 +7,10 @@ module Sepa
       self.string = constrain s
     end
 
+    def empty?
+      (self.string == nil) || (self.string == '')
+    end
+
     def to_s
       self.string
     end
@@ -58,12 +62,16 @@ module Sepa
       (type_def == :string) || (type_def.is_a?(Class) && type_def < StringWithConstraint)
     end
 
+    def empty_item? item
+      item == nil || (item.respond_to?(:empty?) && item.empty?)
+    end
+
     def to_xml builder
       self.class.attribute_defs.each do |name, meta|
         item = self.send(name)
         options = meta[:options] || { }
         attributes = build_xml_attributes options[:attributes]
-        next if item == nil || (item.is_a?(Sepa::Base) && item.empty?)
+        next if empty_item? item
         if string_type?(meta[:type])
           builder.__send__(meta[:tag], normalize(item), attributes)
         elsif meta[:type] == :[]

data/lib/sepa/version.rb

@@ -1,3 +1,3 @@
 module Sepa
-  VERSION = "0.0.18.1"
+  VERSION = "0.0.18.2"
 end

data/spec/sepa/payments_initiation/contact_details_spec.rb

@@ -0,0 +1,18 @@
+# -*- coding: utf-8 -*-
+
+require 'spec_helper'
+
+describe Sepa::PaymentsInitiation::ContactDetails do
+  it "should be empty by default" do
+    Sepa::PaymentsInitiation::ContactDetails.new({ }).should be_empty
+  end
+
+  it "should not generate an empty 'Nm' tag" do
+    contact_details = Sepa::PaymentsInitiation::ContactDetails.new({ :phone_number => "12345" })
+    builder = Builder::XmlMarkup.new(:indent => 2)
+    xml = builder.Document() {
+      contact_details.to_xml builder
+    }
+    expect(xml).to eq "<Document>\n  <PhneNb>12345</PhneNb>\n</Document>\n"
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepa
 version: !ruby/object:Gem::Version
-  version: 0.0.18.1
+  version: 0.0.18.2
 platform: ruby
 authors:
 - Conan Dalton
@@ -148,6 +148,7 @@ files:
 - spec/sepa/expected_customer_direct_debit_initiation_v02_with_remittance_information.xml
 - spec/sepa/expected_customer_direct_debit_initiation_v04.xml
 - spec/sepa/expected_customer_direct_debit_initiation_v04_with_org_id.xml
+- spec/sepa/payments_initiation/contact_details_spec.rb
 - spec/sepa/payments_initiation/financial_identification_scheme_name_1_choice_spec.rb
 - spec/sepa/payments_initiation/generic_financial_identification_1_spec.rb
 - spec/sepa/payments_initiation/pain00800104/customer_direct_debit_initiation_spec.rb
@@ -186,6 +187,7 @@ test_files:
 - spec/sepa/expected_customer_direct_debit_initiation_v02_with_remittance_information.xml
 - spec/sepa/expected_customer_direct_debit_initiation_v04.xml
 - spec/sepa/expected_customer_direct_debit_initiation_v04_with_org_id.xml
+- spec/sepa/payments_initiation/contact_details_spec.rb
 - spec/sepa/payments_initiation/financial_identification_scheme_name_1_choice_spec.rb
 - spec/sepa/payments_initiation/generic_financial_identification_1_spec.rb
 - spec/sepa/payments_initiation/pain00800104/customer_direct_debit_initiation_spec.rb