seory 0.0.4 → 0.1.0

data/lib/seory/rails_helper.rb

@@ -0,0 +1,7 @@
+module Seory
+  module RailsHelper
+    def seory(repository = Seory.default_repository)
+      repository.lookup(controller)
+    end
+  end
+end

data/lib/seory/railtie.rb

@@ -0,0 +1,11 @@
+module Seory
+  autoload :RailsHelper, 'seory/rails_helper'
+
+  class Railtie < ::Rails::Railtie
+    initializer 'seory' do |app|
+      config_dir = (Rails.root + Seory.config_dir)
+
+      app.config.to_prepare { config_dir.each_child {|src| src.extname == '.rb' && load(src) } }
+    end
+  end
+end

data/lib/seory/repository.rb

@@ -1,23 +1,57 @@
 require 'seory/runtime'
 
 module Seory
+  class DuplicateDefault < Seory::Error; end
+
   class Repository
+    class << self
+      def extract_label_from_trace(trace)
+        trace.first.split(':').first
+      end
+    end
+
+    attr_accessor :helper
+
     def initialize
-      @store = []
+      @page_groups = []
     end
 
-    def <<(page_contents)
-      @store << page_contents
+    def <<(page_group)
+      remove_old_group!(page_group.name)
+
+      @page_groups << page_group
+
+      clear_page_order_pre_calculation!
     end
 
     def lookup(controller)
-      page_contents = @store.detect {|page| page.match?(controller) }
+      page = pre_orderd_pages.detect {|pg| pg.match?(controller) } || default
 
-      Seory::Runtime.new(page_contents, controller, default)
+      Seory::Runtime.new(page, controller, default).tap do |runtime|
+        runtime.extend helper if helper
+      end
     end
 
     def default
-      @store.detect(&:default?)
+      @default ||=
+        @page_groups.map(&:default).compact.tap {|defaults|
+          raise DuplicateDefault if defaults.size > 1
+        }.first
+    end
+
+    private
+
+    def pre_orderd_pages
+      @pre_orderd_pages ||= @page_groups.sort_by(&:name).flat_map(&:pages)
+    end
+
+    def remove_old_group!(page_group_name)
+      @page_groups.reject! {|pg| pg.name == page_group_name }
+    end
+
+    def clear_page_order_pre_calculation!
+      @pre_orderd_pages = nil
+      @default = nil
     end
   end
 end

data/lib/seory/runtime.rb

@@ -1,17 +1,17 @@
-# TODO move somewhere
-require 'active_support/all'
 require 'seory'
 
 module Seory
   class Runtime
     delegate :action_name, to: :controller
 
-    attr_reader :controller
+    attr_reader :page_contents, :controller
 
     def initialize(page_contents, controller, fallback = nil)
       @page_contents = page_contents
       @controller    = controller
       @fallback      = fallback
+
+      extend build_assign_accessor_module(@page_contents.assign_name_accessors)
     end
 
     def assigns(name)
@@ -30,14 +30,12 @@ module Seory
 
     def calculate_content_for(name)
       case page_content = lookup_content_for(name)
-      when String
-        page_content
       when Symbol
         calculate_content_for(page_content)
       when ->(o) { o.respond_to?(:call) }
         instance_exec(&page_content)
       else
-        raise 'BUG'
+        page_content.to_s
       end
     end
 
@@ -45,5 +43,14 @@ module Seory
       @page_contents.content_for(name) || \
       @fallback.try {|fb| fb.content_for(name) }
     end
+
+    def build_assign_accessor_module(names)
+      Module.new do
+        Array(names).each do |name|
+          define_method(name) { assigns(name) }
+        end
+      end
+    end
+
   end
 end

data/lib/seory/version.rb

@@ -1,3 +1,3 @@
 module Seory
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/seory.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activesupport", "> 3.2"
+  spec.add_dependency "railties",      "> 3.2"
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"

data/spec/seory/{page_condition/path_condition_spec.rb → condition/path_spec.rb}

@@ -1,10 +1,10 @@
 require 'spec_helper'
-require 'seory/page_condition/path_condition'
+require 'seory/condition/path'
 
-describe Seory::PageCondition::PathCondition do
+describe Seory::Condition::Path do
   let(:controller) { double('controller') }
   let(:path_condition) do
-    Seory::PageCondition::PathCondition.new('/users/alice')
+    Seory::Condition::Path.new('/users/alice')
   end
 
   context 'Accessed to /users/alice (controller: users, action: show, id: alice)' do

data/spec/seory/condition/slug_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+require 'seory/condition/slug'
+
+describe Seory::Condition::Slug do
+  context 'with nested controller slug' do
+    let(:controller) do
+      double('controller', {
+        controller_name: 'products',
+        controller_path: 'contents/products',
+        action_name:     'index'
+      })
+    end
+    let(:slug_condition) { Seory::Condition::Slug.new('contents/products#index') }
+
+    specify { expect(slug_condition.match?(controller)).to be_truthy }
+  end
+end
+

data/spec/seory/dsl_spec.rb

@@ -7,7 +7,7 @@ describe Seory::Dsl do
   context 'with traditional syntax' do
     let(:seory_class) { Object.new.extend(Seory::Dsl) }
     before do
-      seory_class.describe do
+      seory_class.describe('Group A') do
         match ->(c) { c.controller_name == 'reports' } do
           title 'Useful reports'
         end
@@ -30,13 +30,13 @@ describe Seory::Dsl do
     end
 
     context 'at reports#index / match with proc' do
-      let(:controller) { double('controller', controller_name: 'reports', action_name: 'index') }
+      let(:controller) { double('controller', controller_name: 'reports', controller_path: 'reports', action_name: 'index') }
 
       specify { expect(seory.title).to eq 'Useful reports' }
     end
 
     context 'at products#index' do
-      let(:controller) { double('controller', controller_name: 'products', action_name: 'index') }
+      let(:controller) { double('controller', controller_name: 'products', controller_path: 'products', action_name: 'index') }
 
       specify { expect(seory.title).to eq 'My Great Product' }
       specify { expect(seory.h1).to eq 'Great Product Name' }
@@ -46,13 +46,31 @@ describe Seory::Dsl do
     end
 
     context 'at misc#show' do
-      let(:controller) { double('controller', controller_name: 'misc', action_name: 'show') }
+      let(:controller) { double('controller', controller_name: 'misc', controller_path: 'misc', action_name: 'show') }
 
       specify { expect(seory.h1).to eq 'MISC' }
       specify { expect(seory.misc(:option)).to eq 'dynamic option name at misc' }
     end
   end
 
+  context 'accessor to assign' do
+    let(:seory_class) { Object.new.extend(Seory::Dsl) }
+    let(:controller) do
+      controller_double('products#show') { @product = OpenStruct.new(name: 'seory') }
+    end
+
+    before do
+      seory_class.describe do
+        match slug('products#show') do
+          assign_reader :product
+          title { product.name }
+        end
+      end
+    end
+
+    specify { expect(seory.title).to eq 'seory' }
+  end
+
   context 'with matcher build dsl syntax' do
     let(:seory_class) { Object.new.extend(Seory::Dsl) }
     before do
@@ -69,7 +87,7 @@ describe Seory::Dsl do
 
     context 'at products#show' do
       let(:controller) do
-        double('controller', controller_name: 'products', action_name: 'show', params: {id: 42}).tap do |c|
+        double('controller', controller_name: 'products', controller_path: 'products', action_name: 'show', params: {id: 42}).tap do |c|
           allow(c).to receive_message_chain(:request, :fullpath) { '/products/42' }
         end
       end

data/spec/seory/{page_contents_spec.rb → page_spec.rb}

@@ -1,14 +1,14 @@
 require 'spec_helper'
-require 'seory/page_contents'
+require 'seory/page'
 
-describe Seory::PageContents do
+describe Seory::Page do
   specify 'cant define without condition' do
-    expect { Seory::PageContents.new }.to raise_error(Seory::EmptyCondition)
+    expect { Seory::Page.new }.to raise_error(Seory::EmptyCondition)
   end
 
-  context 'content PageContents' do
+  context 'content Page' do
     let(:seory_def) do
-      Seory::PageContents.new(:default)
+      Seory::Page.new(:default)
     end
 
     context 'define static content' do
@@ -40,16 +40,16 @@ describe Seory::PageContents do
 
   describe 'condition and #match?' do
     def init_with(*args, &block)
-      Seory::PageContents.new(*args, &block)
+      Seory::Page.new(*args, &block)
     end
 
-    let(:controller) { double('controller', controller_name: 'people', action_name: 'index') }
+    let(:controller) { double('controller', controller_path: 'people', action_name: 'index') }
 
     specify '`:default` matches everything (stacked in bottom)' do
       expect(init_with(:default)).to be_match(double('something'))
     end
 
-    describe 'controller_name#action_name' do
+    describe 'controller_path#action_name' do
       specify do
         expect(init_with('people#index').match?(controller)).to be_truthy
       end
@@ -63,7 +63,7 @@ describe Seory::PageContents do
       end
 
       specify do
-        page_contents = init_with {|c| c.controller_name == 'people' }
+        page_contents = init_with {|c| c.controller_path == 'people' }
 
         expect(page_contents.match?(controller)).to be_truthy
       end
@@ -102,17 +102,17 @@ describe Seory::PageContents do
 
     describe 'proc conditions' do
       let(:page_content) do
-        init_with {|c| c.controller_name == 'users' }
+        init_with {|c| c.controller_path == 'users' }
       end
 
       specify 'match UsersController' do
-        allow(controller).to receive(:controller_name) { 'users' }
+        allow(controller).to receive(:controller_path) { 'users' }
 
         expect(page_content.match?(controller)).to be_truthy
       end
 
       specify 'not match GoodsController' do
-        allow(controller).to receive(:controller_name) { 'goods' }
+        allow(controller).to receive(:controller_path) { 'goods' }
 
         expect(page_content.match?(controller)).to be_falsy
       end

data/spec/seory/rails_helper_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+require 'seory'
+
+describe Seory::RailsHelper do
+  before do
+    Seory.seo_content 'products' do
+      match slug('products#index') do
+        title 'Product index'
+      end
+
+      default do
+        title 'Default title'
+      end
+    end
+
+    Seory.seo_content 'Review for products' do
+      match slug('products/reviews#index') do
+        assign_reader :product
+
+        title { "Reviews for #{bang(product.name)}" }
+      end
+    end
+
+    Seory.helper do
+      def bang(string); string + ' !!!'; end
+    end
+  end
+
+  context 'GET /products' do
+    let(:context) do
+      Seory::ViewContextDouble.new(controller_double('products#index'))
+    end
+
+    specify do
+      expect(context.seory.title).to eq 'Product index'
+    end
+  end
+
+  context 'GET /products/a-computer/reviews' do
+    let(:context) do
+      controller = controller_double('products/reviews#index') do
+        @product = OpenStruct.new(name: 'a-computer')
+      end
+
+      Seory::ViewContextDouble.new(controller)
+    end
+
+    specify do
+      expect(context.seory.title).to eq "Reviews for a-computer !!!"
+    end
+  end
+
+  context 'GET /users' do
+    let(:context) do
+      Seory::ViewContextDouble.new(controller_double('users#index'))
+    end
+
+    specify do
+      expect(context.seory.title).to eq 'Default title'
+    end
+  end
+end

data/spec/seory/repository_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+require 'seory/repository'
+require 'seory/dsl/descriptor'
+
+describe Seory::Repository do
+  let(:repository) { Seory::Repository.new }
+
+  describe '.extract_label_from_trace' do
+    let(:label) do
+      begin
+        raise
+      rescue => ex
+        Seory::Repository.extract_label_from_trace(ex.backtrace)
+      end
+    end
+
+    specify { expect(label).to eq __FILE__ }
+  end
+
+  def title_for(*args)
+    repository.lookup(controller_double(*args)).title
+  end
+
+  def page_group(name, title = name)
+    describe_page_group(name) do
+      match(slug("#{name}#show")) { title title }
+    end
+  end
+
+  def describe_page_group(name, &block)
+    Seory::Dsl::Descriptor.new(name, repository).describe(&block)
+  end
+
+  context 'has 2 page groups: users & products' do
+    before do
+      repository << page_group('users')
+      repository << page_group('products')
+    end
+
+    specify 'lookup valid page over page_groups' do
+      expect(title_for('users#show', id: 42)).to eq 'users'
+      expect(title_for('products#show', id: 42)).to eq 'products'
+    end
+
+    context 'overrides same name group' do
+      before do
+        repository << page_group('users', 'other users')
+      end
+
+      specify 'after one should be used' do
+        expect(title_for('users#show', id: 42)).to eq 'other users'
+      end
+    end
+
+    context 'match controller by PageGroup#name sorted' do
+      before do
+        repository << (
+          Seory::Dsl::Descriptor.new('aaa', repository).describe do
+            match(params(controller: 'users')) { title 'defined after, match ahead' }
+          end
+        )
+      end
+
+      specify do
+        expect(title_for('users#show', id: 42)).to eq 'defined after, match ahead'
+      end
+    end
+  end
+
+  describe 'helper integration' do
+    before do
+      repository << describe_page_group('default') { default { title { upcase('title') }} }
+      repository.helper = Module.new do
+        def upcase(string); string.upcase; end
+      end
+    end
+
+    specify do
+      expect(title_for('hoge#foo')).to eq 'TITLE'
+    end
+  end
+
+  describe 'default fallback' do
+    context 'default is used from any page group' do
+      before do
+        repository << page_group('users')
+        repository << describe_page_group('default') { default { title 'default title' } }
+      end
+
+      specify do
+        expect(title_for('hoge#foo')).to eq 'default title'
+      end
+
+      specify 'default can be specified from only one page group or raise DuplicateDefault' do
+        expect {
+          repository << describe_page_group('duplicate default') { default { title 'duplicate default' } }
+
+          repository.lookup(controller_double('hi#index'))
+        }.to raise_error(Seory::DuplicateDefault)
+      end
+    end
+  end
+end