sentry-raven 0.15.3 → 0.15.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc70253c8534fa8631331cbabf07e6cb4c4d31d2
-  data.tar.gz: 3d956a4c483a317b359332de520c3b402f8317bf
+  metadata.gz: 1c32e6b50c0d7de4f7e17c570e5e8a9bf79903d1
+  data.tar.gz: 9be97f5863a940ff07b862be7398f33a488bf8cd
 SHA512:
-  metadata.gz: 2354d4020c5379674e12700beae4d39188a8f4b212832fa9bf1862977af062e84c9f9b559f0822a4b7430dd42c3ad2580778b55795a65b95586b9714860df462
-  data.tar.gz: 1842f5311c0d807b3595f26941b2162d400fb806b0c2d314cd5053d0e280dbcf832d05b3fb9c1a4633f42ea17a12fb7929b88237bdae0a0926d6b1a98167d079
+  metadata.gz: 38530147d817ec7c5f49859c3e498892a2fe1e85e3c034f38cf931996739b80a38af16598151507890a17072fdc0beea706146c3caaf6fca80bc6469fff76f74
+  data.tar.gz: 6be4d40e98ff009d447ce7667afe959a269b08a002a30945f955f7efc51213af58272195b61b3903d8c12f9792e0e0da2ff68429fa59bd842110bdd3b8d618ae

data/README.md

@@ -7,7 +7,7 @@ A client and integration layer for the [Sentry](https://github.com/getsentry/sen
 
 ## Requirements
 
-We test on Ruby MRI 1.8.7/REE, 1.9.3, 2.0, 2.1 and 2.2. JRuby support is experimental - check TravisCI to see if the build is passing or failing.
+We test on Ruby MRI 1.8.7/REE through Ruby 2.3 at the latest patchlevel/teeny version. JRuby support is experimental - check TravisCI to see if the build is passing or failing.
 
 ## Getting Started
 ### Install

data/lib/raven/backtrace.rb

@@ -7,10 +7,10 @@ module Raven
     # Handles backtrace parsing line by line
     class Line
       # regexp (optionnally allowing leading X: for windows support)
-      RUBY_INPUT_FORMAT = %r{^((?:[a-zA-Z]:)?[^:]+|<.*>):(\d+)(?::in `([^']+)')?$}.freeze
+      RUBY_INPUT_FORMAT = %r{^((?:[a-zA-Z]:)?[^:]+|<.*>):(\d+)(?::in `([^']+)')?$}
 
       # org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
-      JAVA_INPUT_FORMAT = %r{^(.+)\.([^\.]+)\(([^\:]+)\:(\d+)\)$}.freeze
+      JAVA_INPUT_FORMAT = %r{^(.+)\.([^\.]+)\(([^\:]+)\:(\d+)\)$}
 
       APP_DIRS_PATTERN = /(bin|exe|app|config|lib|test)/
 
@@ -84,8 +84,8 @@ module Raven
     # holder for an Array of Backtrace::Line instances
     attr_reader :lines
 
-    def self.parse(ruby_backtrace, opts = {})
-      ruby_lines = split_multiline_backtrace(ruby_backtrace)
+    def self.parse(backtrace, opts = {})
+      ruby_lines = backtrace.is_a?(Array) ? backtrace : backtrace.split(/\n\s*/)
 
       filters = opts[:filters] || []
       filtered_lines = ruby_lines.to_a.map do |line|
@@ -128,13 +128,5 @@ module Raven
     private
 
     attr_writer :lines
-
-    def self.split_multiline_backtrace(backtrace)
-      if backtrace.to_a.size == 1
-        backtrace.to_a.first.split(/\n\s*/)
-      else
-        backtrace
-      end
-    end
   end
 end

data/lib/raven/base.rb

@@ -21,7 +21,7 @@ if (major == 1 && minor < 9) || (major == 1 && minor == 9 && patch < 2)
 end
 
 module Raven
-  AVAILABLE_INTEGRATIONS = %w[delayed_job railties sidekiq rack rake]
+  AVAILABLE_INTEGRATIONS = %w[delayed_job railties sidekiq rack rake].freeze
 
   class << self
     # The client object is responsible for delivering formatted data to the Sentry server.

data/lib/raven/client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'zlib'
 require 'base64'
 
@@ -9,9 +10,9 @@ require 'raven/transports/udp'
 module Raven
   # Encodes events and sends them to the Sentry server.
   class Client
-    PROTOCOL_VERSION = '5'
-    USER_AGENT = "raven-ruby/#{Raven::VERSION}"
-    CONTENT_TYPE = 'application/json'
+    PROTOCOL_VERSION = '5'.freeze
+    USER_AGENT = "raven-ruby/#{Raven::VERSION}".freeze
+    CONTENT_TYPE = 'application/json'.freeze
 
     attr_accessor :configuration
 

data/lib/raven/configuration.rb

@@ -84,7 +84,9 @@ module Raven
     # Optional Proc to be used to send events asynchronously.
     attr_reader :async
 
-    # Exceptions from these directories to be ignored
+    # Directories to be recognized as part of your app. e.g. if you
+    # have an `engines` dir at the root of your project, you may want
+    # to set this to something like /(app|config|engines|lib)/
     attr_accessor :app_dirs_pattern
 
     # Catch exceptions before they're been processed by
@@ -109,14 +111,14 @@ module Raven
       'CGI::Session::CookieStore::TamperedWithCookie',
       'Mongoid::Errors::DocumentNotFound',
       'Sinatra::NotFound',
-    ]
+    ].freeze
 
     def initialize
       self.server = ENV['SENTRY_DSN'] if ENV['SENTRY_DSN']
       @context_lines = 3
       self.current_environment = ENV['RAILS_ENV'] || ENV['RACK_ENV'] || 'default'
       self.send_modules = true
-      self.excluded_exceptions = IGNORE_DEFAULT
+      self.excluded_exceptions = IGNORE_DEFAULT.dup
       self.processors = [Raven::Processor::RemoveCircularReferences, Raven::Processor::UTF8Conversion, Raven::Processor::SanitizeData]
       self.ssl_verification = true
       self.encoding = 'gzip'
@@ -130,15 +132,7 @@ module Raven
       self.sanitize_credit_cards = true
       self.environments = []
 
-      self.release = ENV['HEROKU_SLUG_COMMIT']
-
-      if self.release.nil? || self.release.empty?
-        self.release = File.read(File.join(Rails.root, 'REVISION')).strip rescue nil
-      end
-
-      if self.release.nil? || self.release.empty?
-        self.release = `git rev-parse --short HEAD`.strip rescue nil
-      end
+      self.release = detect_release
     end
 
     def server=(value)
@@ -168,14 +162,14 @@ module Raven
       @encoding = encoding
     end
 
-    alias_method :dsn=, :server=
+    alias dsn= server=
 
     def async=(value)
       raise ArgumentError.new("async must be callable (or false to disable)") unless value == false || value.respond_to?(:call)
       @async = value
     end
 
-    alias_method :async?, :async
+    alias async? async
 
     # Allows config options to be read like a hash
     #
@@ -202,5 +196,25 @@ module Raven
       raise Error.new('No secret key specified') unless secret_key
       raise Error.new('No project ID specified') unless project_id
     end
+
+    def detect_release
+      detect_release_from_heroku ||
+        detect_release_from_capistrano ||
+        detect_release_from_git
+    end
+
+    private
+
+    def detect_release_from_heroku
+      ENV['HEROKU_SLUG_COMMIT']
+    end
+
+    def detect_release_from_capistrano
+      File.read(File.join(project_root, 'REVISION')).strip rescue nil
+    end
+
+    def detect_release_from_git
+      `git rev-parse --short HEAD`.strip if File.directory?(".git") rescue nil
+    end
   end
 end

data/lib/raven/event.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rubygems'
 require 'socket'
 require 'securerandom'
@@ -16,11 +17,11 @@ module Raven
       "warning" => 30,
       "error" => 40,
       "fatal" => 50,
-    }
+    }.freeze
 
     BACKTRACE_RE = /^(.+?):(\d+)(?::in `(.+?)')?$/
 
-    PLATFORM = "ruby"
+    PLATFORM = "ruby".freeze
 
     attr_reader :id
     attr_accessor :project, :message, :timestamp, :time_spent, :level, :logger,
@@ -221,7 +222,7 @@ module Raven
 
     def get_file_context(filename, lineno, context)
       return nil, nil, nil unless Raven::LineCache.is_valid_file(filename)
-      lines = (2 * context + 1).times.map do |i|
+      lines = Array.new(2 * context + 1) do |i|
         Raven::LineCache.getline(filename, lineno - context + i)
       end
       [lines[0..(context - 1)], lines[context], lines[(context + 1)..-1]]

data/lib/raven/integrations/delayed_job.rb

@@ -2,7 +2,6 @@ require 'delayed_job'
 
 module Delayed
   module Plugins
-
     class Raven < ::Delayed::Plugin
       callbacks do |lifecycle|
         lifecycle.around(:invoke_job) do |job, *args, &block|
@@ -20,7 +19,7 @@ module Delayed
                 # handlers are YAML objects in strings, we definitely can't
                 # report all of that or the event will get truncated randomly
                 :handler     => job.handler[0...100],
-                :last_error  => job.last_error,
+                :last_error  => job.last_error[0...100],
                 :run_at      => job.run_at,
                 :locked_at   => job.locked_at,
                 :locked_by   => job.locked_by,
@@ -29,7 +28,7 @@ module Delayed
                 }
             }
             if job.respond_to?('payload_object') && job.payload_object.respond_to?('job_data')
-              extra.merge!(:active_job => job.payload_object.job_data)
+              extra[:active_job] = job.payload_object.job_data
             end
             ::Raven.capture_exception(exception,
               :logger  => 'delayed_job',

data/lib/raven/integrations/rack.rb

@@ -32,8 +32,8 @@ module Raven
       end
     end
     class << self
-      alias_method :capture_message, :capture_type
-      alias_method :capture_exception, :capture_type
+      alias capture_message capture_type
+      alias capture_exception capture_type
     end
 
     def initialize(app)

data/lib/raven/integrations/rails.rb

@@ -17,6 +17,7 @@ module Raven
       Raven.configure do |config|
         config.logger ||= ::Rails.logger
         config.project_root ||= ::Rails.root
+        config.release = config.detect_release # if project_root has changed, need to re-check
       end
 
       if Raven.configuration.catch_debugged_exceptions

data/lib/raven/integrations/rails/active_job.rb

@@ -17,7 +17,7 @@ module Raven
 
               # Add provider_job_id details if Rails 5
               if defined?(provider_job_id)
-                active_job_details.merge!(:provider_job_id => provider_job_id)
+                active_job_details[:provider_job_id] = provider_job_id
               end
 
               Raven.capture_exception(exception, :extra => active_job_details)

data/lib/raven/interfaces.rb

@@ -1,6 +1,7 @@
 module Raven
 
-  INTERFACES = {}
+  # TODO: a constant isn't appropriate here, refactor
+  INTERFACES = {} # rubocop:disable Style/MutableConstant
 
   class Interface
     def initialize(attributes = nil)

data/lib/raven/linecache.rb

@@ -3,7 +3,10 @@
 module Raven
   class LineCache
     class << self
-      CACHE = {}
+      # TODO: a constant isn't appropriate here, refactor
+      # also would there be threading bugs essentially using this as a class
+      # variable?
+      CACHE = {} # rubocop:disable Style/MutableConstant
 
       def is_valid_file(path)
         lines = getlines(path)

data/lib/raven/logger.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 module Raven
   class Logger
-    LOG_PREFIX = "** [Raven] "
+    LOG_PREFIX = "** [Raven] ".freeze
 
     [
       :fatal,

data/lib/raven/processor/sanitizedata.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 require 'json'
 module Raven
   class Processor::SanitizeData < Processor
-    STRING_MASK = '********'
+    STRING_MASK = '********'.freeze
     INT_MASK = 0
-    DEFAULT_FIELDS = %w(authorization password passwd secret ssn social(.*)?sec)
+    DEFAULT_FIELDS = %w(authorization password passwd secret ssn social(.*)?sec).freeze
     CREDIT_CARD_RE = /^(?:\d[ -]*?){13,16}$/
-    REGEX_SPECIAL_CHARACTERS = %w(. $ ^ { [ ( | ) * + ?)
+    REGEX_SPECIAL_CHARACTERS = %w(. $ ^ { [ ( | ) * + ?).freeze
 
     attr_accessor :sanitize_fields, :sanitize_credit_cards
 

data/lib/raven/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Raven
-  VERSION = "0.15.3"
+  VERSION = "0.15.4".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sentry-raven
 version: !ruby/object:Gem::Version
-  version: 0.15.3
+  version: 0.15.4
 platform: ruby
 authors:
 - Sentry Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-06 00:00:00.000000000 Z
+date: 2016-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -42,16 +42,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.36.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.36.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement