sensu-plugins-zfs 1.0.6 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b341e26b5d3f60dbc4642b1a8ced419af25ec84a
-  data.tar.gz: 99654f826a95b1540402594b0e4f390ee43a8ffb
+  metadata.gz: 7c3a3744fcbbe19ac49cf6e968082a6b6f1aa392
+  data.tar.gz: 11e6ac61a97cd02a890c980d4fb52fdf8ad2223e
 SHA512:
-  metadata.gz: 3d72b51b7b093db3956e8d37b541d7e871859267702090bac82b0c4a58ad99be373ae9cb6e21b3e248e6b743536fe5905ddefc6415252daac17233e6aae2fd63
-  data.tar.gz: 88497e12945e9818f1c43f56a63668eed32fa2a06d20a2819b9f89f146ed44efc9b11dc56bc4a1563037057dbfce2e9f2db4f3edaba7fb740858914c84c68b83
+  metadata.gz: ba3d899bfe554cdf8c1e0633b85618b98d7b18a21352f2d8f149e5a8d300450c4429769d0b278f1bc7862bdb2170231beb1aa175b53b9a3fb9b3a61e1fce830c
+  data.tar.gz: c8552e5482f078fd8071237bc953c640714edf9d0da8c481d7fb114f635454fc5c90362d9af38870c867819923367dac0fbde48fb1fc25479d5be6f75398e2b5

data/README.md

@@ -1,21 +1,27 @@
 # SensuPluginsZFS
 
-Sensu plugin for zfs checks.
-
-So far we just got a simple plugin that checks if the zpool is online.
+Sensu plugin for zfs health checks.
 
 ## Checks
 
 ### check-zpool.rb
 
-Checks if the zpool state is ONLINE
+Checks if the zpool state is ONLINE and wether there has been any errors on
+vdevs.
+
+- `-z, --zpool` What zpool to check. If omitted, we check all zpools.
 
 ## Installation
 [Installation and setup](http://sensu-plugins.io/docs/installation_instructions.html)
 
 ## Contributing
 
-That this time ideas for additional checks/metrics would be very much appreciated.
+At this time ideas for additional checks/metrics would be very much appreciated.
+
+I have a few ideas that would be nice:
+
+- [ ] Check that disks have been scrubbed recently
+- [ ] Check/metric for pool capacity
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/blacksails/sensu-plugins-zfs.
 

data/bin/check-zpool.rb

@@ -9,6 +9,18 @@ class CheckZPool < Sensu::Plugin::Check::CLI
          long: "--zpool ZPOOL",
          description: "Name of zpool to check. If omitted, we check all zpools"
 
+  option :cap_warn,
+         short: "-c PERCENTAGE",
+         long: "--capacity-warn PERCENTAGE",
+         description: "Warn if capacity is above this threshold",
+         default: 80
+
+  option :cap_crit,
+         short: "-C PERCENTAGE",
+         long: "--capacity-crit PERCENTAGE",
+         description: "Crit if capacity is above this threshold",
+         default: 90
+
   def run
     zpools = []
     if config[:zpool]
@@ -19,6 +31,7 @@ class CheckZPool < Sensu::Plugin::Check::CLI
     zpools.each do |zp|
       check_state zp
       check_vdevs zp
+      check_capacity zp
     end
     if config[:zpool]
       ok "zpool #{config[:zpool]} is ok"
@@ -41,4 +54,12 @@ class CheckZPool < Sensu::Plugin::Check::CLI
       end
     end
   end
+
+  def check_capacity(zp)
+    if zp.capacity > config[:cap_crit]
+      critical "capacity for zpool #{zp.name} is above #{config[:cap_crit}% (currently #{zp.capacity}%)"
+    elsif zp.capacity > config[:warn_crit]
+      warning "capacity for zpool #{zp.name} is above #{config[:cap_warn}% (currently #{zp.capacity}%)"
+    end
+  end
 end

data/lib/sensu-plugins-zfs/version.rb

@@ -1,3 +1,3 @@
 module SensuPluginsZFS
-  VERSION = "1.0.6"
+  VERSION = "1.1.0"
 end

data/lib/sensu-plugins-zfs/zpool.rb

@@ -8,11 +8,12 @@ module SensuPluginsZFS
   end
 
   class ZPool
-    attr_reader :state, :name, :vdevs
+    attr_reader :name, :state, :capacity, :vdevs
 
     def initialize(name)
       @name = name
       @state = %x[sudo zpool status #{name} | grep '^ state: ' | cut -d ' ' -f 3].strip
+      @capacity = %x[zpool get -H capacity #{@name} | awk '{print $3}' | cut -d '%' -f1].strip.to_i
       @vdevs = create_vdevs name
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-zfs
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.1.0
 platform: ruby
 authors:
 - Benjamin Nørgaard