sensu-plugins-rabbitmq 3.6.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 37b8d41fe46ac07ede1456194b6b1953924a12a8
-  data.tar.gz: 106179e22f2ec92593d20b62c0eb2c7b6a9abfdc
+SHA256:
+  metadata.gz: eb736097ac7037864024d62e1ba0cc0d112c5e216b6d1fa0ac4816da19875ed1
+  data.tar.gz: 1478860ce3dbdc717410a41b27f1e4064e102f45be649fd3a10a7a3813bd01bd
 SHA512:
-  metadata.gz: 521ec362117fcadb6c0bb993d3041180cde0c5ca40db1a44b8bb687e1d383cc2658467c98d8e70168578c24969522eb9b00f3d7313900a8f59f6040b40657e95
-  data.tar.gz: dc16d15e7271d4a973f003143f3a3b4d165aebcbe0504e4c257fad7baa53882a4c287ea2c9fdd879190b26cd1e88fbc078cd3b5d9a6621aa38a095a9ced33942
+  metadata.gz: af04fcf0e8a83ed3403029ccc8698c3a13ef56b9c543cc8400552841658b151b1143b35c676870c3f5b609580b7f53bbf5d3a5221d74dc5b09a6075a9ba736fd
+  data.tar.gz: 368de85951f046b580b69231cecbfeec6517f01e2003e9fb42d6c02f3b7c71782cf7e2a838456b8de2f2a2d368774e1312ad02752b8fafe61050d5d3eddc3b85

data/CHANGELOG.md

@@ -5,6 +5,17 @@ This CHANGELOG follows the format listed [here](https://github.com/sensu-plugins
 
 ## [Unreleased]
 
+
+## [4.0.0] - 2018-03-17
+### Security
+- updated rubocop dependency to `~> 0.51.0` per: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418. (@majormoses)
+
+### Breaking Changes
+- removed ruby `< 2.1` support (@majormoses)
+
+### Changed
+- appeased the cops (@majormoses)
+
 ## [3.6.0] - 2017-10-04
 ### Added
 - check-rabbitmq-queues-synchronised.rb: added new check if all mirrored queues are synchronised (@cyrilgdn)
@@ -170,7 +181,8 @@ NOTE: this release changes the option flags in check-rabbitmq-node-health.rb to
 - Remove copy paste errors in the Readme
 - Removed Rubygems require Ruby 1.8.7 backwards compatibility from all plugins
 
-[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/3.6.0...HEAD
+[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/4.0.0...HEAD
+[4.0.0]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/3.6.0..4.0.0
 [3.6.0]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/3.5.0...3.6.0
 [3.5.0]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/3.4.0...3.5.0
 [3.4.0]: https://github.com/sensu-plugins/sensu-plugins-rabbitmq/compare/3.3.0...3.4.0

data/README.md

@@ -31,4 +31,23 @@
 
 [Installation and Setup](http://sensu-plugins.io/docs/installation_instructions.html)
 
+## Permissions
+
+In order to run these checks you need the following permissions set:
+```
+:conf => '^aliveness-test$',
+:write => '^amq\.default$',
+:read => '.*'
+```
+You must also add the `monitoring` tag.
+
+This can be done like this:
+```
+rabbitmqctl add_user sensu_monitoring $MY_SUPER_LONG_SECURE_PASSWORD
+rabbitmqctl set_permissions  -p / sensu_monitoring "^aliveness-test$" "^amq\.default$" "^(amq\.default|aliveness-test)$"
+rabbitmqctl set_user_tags sensu_monitoring monitoring
+```
+
+**It is highly recommended that you do not give administrator access! and use minimum permissions!**
+
 ## Notes

data/bin/check-rabbitmq-alive.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check alive plugin
 # ===
@@ -115,7 +116,7 @@ class CheckRabbitMQAlive < Sensu::Plugin::Check::CLI
       { 'status' => 'ok', 'message' => 'RabbitMQ server is alive' }
     rescue Errno::ECONNREFUSED => e
       { 'status' => 'critical', 'message' => e.message }
-    rescue => e
+    rescue StandardError => e
       { 'status' => 'unknown', 'message' => e.message }
     end
   end

data/bin/check-rabbitmq-amqp-alive.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check amqp alive plugin
 # ===
@@ -142,7 +143,7 @@ class CheckRabbitAMQPAlive < Sensu::Plugin::Check::CLI
       { 'status' => 'critical', 'message' => 'Possible authentication failure' }
     rescue Bunny::TCPConnectionFailed
       { 'status' => 'critical', 'message' => 'TCP connection refused' }
-    rescue => e
+    rescue StandardError => e
       { 'status' => 'unknown', 'message' => e.message }
     end
   end

data/bin/check-rabbitmq-cluster-health.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check cluster nodes health plugin
 # ===
@@ -161,7 +162,7 @@ class CheckRabbitMQCluster < Sensu::Plugin::Check::CLI
       { 'status' => status, 'message' => message }
     rescue Errno::ECONNREFUSED => e
       { 'status' => 'critical', 'message' => e.message }
-    rescue => e
+    rescue StandardError => e
       { 'status' => 'unknown', 'message' => e.message }
     end
   end

data/bin/check-rabbitmq-consumers.rb

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
 
 # Check RabbitMQ consumers
 # ===
@@ -109,19 +109,19 @@ class CheckRabbitMQConsumers < Sensu::Plugin::Check::CLI
         password: password,
         ssl: config[:ssl]
       )
-    rescue
+    rescue StandardError
       warning 'could not connect to rabbitmq'
     end
     connection
   end
 
   def return_condition(missing, critical, warning)
-    if critical.count > 0 || missing.count > 0
+    if critical.count.positive? || missing.count.positive?
       message = ''
-      message << "Queues in critical state: #{critical.join(', ')}. " if critical.count > 0
-      message << "Queues missing: #{missing.join(', ')}" if missing.count > 0
+      message << "Queues in critical state: #{critical.join(', ')}. " if critical.count.positive?
+      message << "Queues missing: #{missing.join(', ')}" if missing.count.positive?
       critical(message)
-    elsif warning.count > 0
+    elsif warning.count.positive?
       warning("Queues in warning state: #{warning.join(', ')}")
     else
       ok
@@ -154,7 +154,7 @@ class CheckRabbitMQConsumers < Sensu::Plugin::Check::CLI
         critical.push(queue['name']) if consumers <= config[:critical]
         warn.push(queue['name']) if consumers <= config[:warn]
       end
-    rescue
+    rescue StandardError
       critical 'Could not find any queue, check rabbitmq server'
     end
     return_condition(missing, critical, warn)

data/bin/check-rabbitmq-messages.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # Check RabbitMQ Messages
 # ===
@@ -112,7 +113,7 @@ class CheckRabbitMQMessages < Sensu::Plugin::Check::CLI
         password: password,
         ssl: config[:ssl]
       )
-    rescue
+    rescue StandardError
       warning 'Could not connect to rabbitmq'
     end
     rabbitmq_info

data/bin/check-rabbitmq-network-partitions.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ Network Partitions Check
 # ===
@@ -68,7 +69,7 @@ class CheckRabbitMQPartitions < Sensu::Plugin::Check::CLI
     ok 'no network partition detected'
   rescue Errno::ECONNREFUSED => e
     critical e.message
-  rescue => e
+  rescue StandardError => e
     unknown e.message
   end
 

data/bin/check-rabbitmq-node-health.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check node health plugin
 # ===
@@ -215,7 +216,7 @@ class CheckRabbitMQNodeHealth < Sensu::Plugin::Check::CLI
       { 'status' => status, 'message' => message }
     rescue Errno::ECONNREFUSED => e
       { 'status' => 'critical', 'message' => e.message }
-    rescue => e
+    rescue StandardError => e
       { 'status' => 'unknown', 'message' => e.message }
     end
   end

data/bin/check-rabbitmq-node-usage.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby -W0
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check node health plugin
 # ===
@@ -72,7 +73,7 @@ class CheckRabbitMQNodeUsage < Sensu::Plugin::Check::CLI
          description: 'Resource type',
          required: true,
          long: '--type TYPE',
-         in: %w(mem socket fd proc disk)
+         in: %w[mem socket fd proc disk]
 
   option :memwarn,
          description: 'Warning % of mem usage vs high watermark',
@@ -179,7 +180,7 @@ class CheckRabbitMQNodeUsage < Sensu::Plugin::Check::CLI
     end
 
     { 'status' => output[:status], 'message' => output[:message] }
-  rescue => e
+  rescue StandardError => e
     { 'status' => 'unknown', 'message' => e.message }
   end
 

data/bin/check-rabbitmq-queue-drain-time.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ Queue Drain Time
 # ===
@@ -106,7 +107,7 @@ class CheckRabbitMQQueueDrainTime < Sensu::Plugin::Check::CLI
         password: password,
         ssl: config[:ssl]
       )
-    rescue
+    rescue StandardError
       warning 'could not get rabbitmq queue info'
     end
 
@@ -125,10 +126,10 @@ class CheckRabbitMQQueueDrainTime < Sensu::Plugin::Check::CLI
 
     acquire_rabbitmq_queues.each do |queue|
       # we don't care about empty queues and they'll have an infinite drain time so skip them
-      next if queue['messages'] == 0 || queue['messages'].nil?
+      next if queue['messages'].zero? || queue['messages'].nil?
 
       # handle rate of zero which is an infinite time until empty
-      if queue['backing_queue_status']['avg_egress_rate'].to_f == 0
+      if queue['backing_queue_status']['avg_egress_rate'].to_f.zero?
         crit_queues[queue['name']] = 'Infinite (drain rate = 0)'
         next
       end

data/bin/check-rabbitmq-queue.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: false
+
 #
 # Check RabbitMQ Queue Messages
 # ===
@@ -22,13 +23,16 @@
 # for details.
 
 require 'sensu-plugins-rabbitmq'
+require 'sensu-plugins-rabbitmq/check'
+require 'sensu-plugin/check/cli'
 
 # main plugin class
-class CheckRabbitMQMessages < Sensu::Plugin::RabbitMQ::Check
+class CheckRabbitMQQueue < Sensu::Plugin::RabbitMQ::Check
   option :queue,
          description: 'RabbitMQ queue to monitor',
          long: '--queue queue_names',
          required: true,
+         # not sure if there is a better way to handle frozen strings
          proc: proc { |a| a.split(',') }
 
   option :warn,

data/bin/check-rabbitmq-queues-synchronised.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # Check RabbitMQ Queues Synchronised
 # ===
@@ -55,7 +56,7 @@ class CheckRabbitMQQueuesSynchronised < Sensu::Plugin::RabbitMQ::Check
     end
   rescue Errno::ECONNREFUSED => e
     critical e.message
-  rescue => e
+  rescue StandardError => e
     unknown e.message
   end
 

data/bin/check-rabbitmq-stomp-alive.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ check alive plugin
 # ===
@@ -118,7 +119,7 @@ class CheckRabbitStomp < Sensu::Plugin::Check::CLI
       { 'status' => 'critical', 'message' => 'TCP connection refused' }
     rescue Stomp::Error::BrokerException => e
       { 'status' => 'critical', 'message' => "Error from broker. Check auth details? #{e.message}" }
-    rescue => e
+    rescue StandardError => e
       { 'status' => 'unknown', 'message' => "#{e.class}: #{e.message}" }
     end
   end

data/bin/metrics-rabbitmq-exchange.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ Exchange Metrics
 # ===

data/bin/metrics-rabbitmq-overview.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ Overview Metrics
 # ===
@@ -99,7 +100,7 @@ class RabbitMQMetrics < Sensu::Plugin::Metric::CLI::Graphite
         password: password,
         ssl: config[:ssl]
       )
-    rescue
+    rescue StandardError
       warning 'could not get rabbitmq info'
     end
     rabbitmq_info

data/bin/metrics-rabbitmq-queue.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 # RabbitMQ Queue Metrics
 # ===

data/lib/sensu-plugins-rabbitmq.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ruby_dig'
 
 require 'sensu-plugins-rabbitmq/version'

data/lib/sensu-plugins-rabbitmq/check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 require 'sensu-plugin/check/cli'
 require 'sensu-plugins-rabbitmq/rabbitmq'
 

data/lib/sensu-plugins-rabbitmq/metrics.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sensu-plugin/metric/cli'
 require 'socket'
 require 'sensu-plugins-rabbitmq/rabbitmq'

data/lib/sensu-plugins-rabbitmq/rabbitmq.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 require 'carrot-top'
 require 'inifile'
 
@@ -66,7 +68,7 @@ module Sensu
               password: password,
               ssl: config[:ssl]
             )
-          rescue
+          rescue StandardError
             warning 'could not get rabbitmq info'
           end
 

data/lib/sensu-plugins-rabbitmq/version.rb

@@ -2,8 +2,8 @@
 
 module SensuPluginsRabbitMQ
   module Version
-    MAJOR = 3
-    MINOR = 6
+    MAJOR = 4
+    MINOR = 0
     PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-rabbitmq
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Sensu-Plugins and contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-04 00:00:00.000000000 Z
+date: 2018-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sensu-plugin
@@ -25,103 +25,103 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: carrot-top
+  name: amq-protocol
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: 2.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: 2.0.1
 - !ruby/object:Gem::Dependency
-  name: stomp
+  name: bunny
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.4.3
+        version: 2.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.4.3
+        version: 2.5.0
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: carrot-top
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 0.0.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 0.0.7
 - !ruby/object:Gem::Dependency
-  name: bunny
+  name: inifile
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: amq-protocol
+  name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
-  name: inifile
+  name: ruby_dig
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 0.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 0.0.2
 - !ruby/object:Gem::Dependency
-  name: ruby_dig
+  name: stomp
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.2
+        version: 1.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.2
+        version: 1.4.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -207,33 +207,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: '3.4'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: 0.51.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: 0.51.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -314,7 +314,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -322,7 +322,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Sensu plugins for rabbitmq