sensu-plugins-network-checks 2.3.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad2b4d51ea5ccbd0596f33bce7406bc0eb667c29ebb6a897d677806c52b8c51d
-  data.tar.gz: 5674a9d85e5b10f7bd89257154e4df08027e41de5523ca7216c449f7b5bbf509
+  metadata.gz: 657f6d68bbee8aca2ec7dc4331d727a45ea9970253c4b1d3d5f31764bd97217d
+  data.tar.gz: c0da8c7a1d2098e9dd61f5e73426e2c68e5d22f50ffcc6083d085ba5a0646885
 SHA512:
-  metadata.gz: 62884a63cff4cb0d44f5efd209aebc2f89eb5fc204d351c75119642ba51df301beb512ba03b3cff0451d37a6943cf9d75a87510944ca33bfe24511bc51336ec6
-  data.tar.gz: 831ba7fe92ed1bbb040fc6b9b1e234cc75aa8e1481dcba0097f6bd9bf92529de3dd552e34dfb0adb9eb2eb06692a1fd4d4a3e2f7143f19a7c3ea45de16bc4a56
+  metadata.gz: 3a36487ab0ef6fee539ea55ce28d37149e58bc223c5e32f5346b5e4a6fadf6ae930eff6174b64d6de6ccdfb58ddbc4c909a4a978c736411bb504333e9a29e90f
+  data.tar.gz: ecd98e5e3b7773fbfc1f3a8869e8b121a71d0d8dbb018df47ce6685c0a5021848a8261cbb1cc83ab01d8d6c6c7babf6398f48152deea3ee8042fa389e3dd58f0

data/CHANGELOG.md

@@ -5,6 +5,16 @@ This CHANGELOG follows the format listed  [here](https://github.com/sensu-plugin
 
 ## [Unreleased]
 
+## [3.0.0] - 2018-03-17
+### Security
+- updated rubocop dependency to `~> 0.51.0` per: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418. (@majormoses)
+
+### Breaking Changes
+- removed ruby `< 2.1` support (@majormoses)
+
+### Changed
+- appeased the cops and updated cop config (@majormoses)
+
 ## [2.3.1] - 2018-02-28
 ### Changed
 - update whois-parser gem dependency to version 1.0.1 (@amdprophet)
@@ -203,6 +213,7 @@ This CHANGELOG follows the format listed  [here](https://github.com/sensu-plugin
 * initial release, same as community repo
 
 [Unreleased]: https://github.com/sensu-plugins/sensu-plugins-network-checks/compare/2.3.0...HEAD
+[3.0.0]: https://github.com/sensu-plugins/sensu-plugins-network-checks/compare/2.3.0...3.0.0
 [2.3.1]: https://github.com/sensu-plugins/sensu-plugins-network-checks/compare/2.3.0...2.3.1
 [2.3.0]: https://github.com/sensu-plugins/sensu-plugins-network-checks/compare/2.2.0...2.3.0
 [2.2.0]: https://github.com/sensu-plugins/sensu-plugins-network-checks/compare/2.1.1...2.2.0

data/bin/check-banner.rb

@@ -1,6 +1,7 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
-#  encoding: UTF-8
 #   check-banner
 #
 # DESCRIPTION:

data/bin/check-jsonwhois-domain-expiration.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-# encoding: utf-8
+# frozen_string_literal: false
+
 #
 #   check-jsonwhois-domain-expiration
 #
@@ -72,7 +73,7 @@ class JSONWhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
          short: '-r LEVEL',
          long: '--report-errors LEVEL',
          proc: proc(&:to_sym),
-         in: %i(unknown warning critical),
+         in: %i[unknown warning critical],
          default: :unknown,
          description: 'Level for reporting connection or parsing errors'
 
@@ -110,7 +111,7 @@ class JSONWhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
         else
           results[:ok][domain] = domain_result
         end
-      rescue
+      rescue StandardError
         results[:unknown][domain] = 'Connection or parsing error' unless config[:'ignore-errors']
       end
     end

data/bin/check-mtu.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   check-mtu.rb
 #

data/bin/check-multicast-groups.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: false
+
 #
 #   check-multicast-groups
 #
@@ -66,7 +68,7 @@ class CheckMulticastGroups < Sensu::Plugin::Check::CLI
       critical "#{diff.size} missing multicast group(s):\n#{diff_output}"
     end
     ok
-  rescue => ex
+  rescue StandardError => ex
     critical "Failed to check multicast groups: #{ex}"
   end
 end

data/bin/check-netfilter-conntrack.rb

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-bin_dir = File.expand_path(File.dirname(__FILE__))
+bin_dir = File.expand_path(__dir__)
 shell_script_path = File.join(bin_dir, File.basename($PROGRAM_NAME, '.rb') + '.sh')
 
 exec shell_script_path, *ARGV

data/bin/check-netstat-tcp.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   check-netstat-tcp
 #
@@ -102,7 +104,7 @@ class CheckNetstatTCP < Sensu::Plugin::Check::CLI
   end
 
   def run
-    state_counts = netstat(%w(tcp tcp6))
+    state_counts = netstat(%w[tcp tcp6])
     is_critical = false
     is_warning = false
     message = ''

data/bin/check-ping.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #  check-ping
 #
@@ -83,7 +85,7 @@ class CheckPING < Sensu::Plugin::Check::CLI
     pt = Net::Ping::External.new(config[:host], nil, config[:timeout])
 
     config[:count].times do |i|
-      sleep(config[:interval]) unless i == 0
+      sleep(config[:interval]) unless i.zero?
       result[i] = config[:ipv6] ? pt.ping6 : pt.ping
     end
 

data/bin/check-ports-bind.rb

@@ -1,6 +1,7 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
-#  encoding: UTF-8
 #   check-ports-bind
 #
 # DESCRIPTION:

data/bin/check-ports-nmap.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   check-ports-nmap
 #

data/bin/check-ports.rb

@@ -1,6 +1,7 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
-#  encoding: UTF-8
 #   check-ports
 #
 # DESCRIPTION:

data/bin/check-rbl.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   check-rbl
 #
@@ -89,7 +91,7 @@ class RblCheck < Sensu::Plugin::Check::CLI
 
     # YELLOW
     unless msg_string.empty? # rubocop:disable UnlessElse
-      if criticality > 0
+      if criticality.positive?
         critical "#{ip_add} Blacklisted in#{msg_string}"
       else
         warning "#{ip_add} Blacklisted in#{msg_string}"

data/bin/check-socat.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: false
+
 #
 #   check-socat
 #

data/bin/check-whois-domain-expiration-multi.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-# encoding: utf-8
+# frozen_string_literal: false
+
 #
 #   check-whois-domain-expiration-multi
 #
@@ -66,7 +67,7 @@ class WhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
          short: '-r LEVEL',
          long: '--report-errors LEVEL',
          proc: proc(&:to_sym),
-         in: %i(unknown warning critical),
+         in: %i[unknown warning critical],
          default: :unknown,
          description: 'Level for reporting connection or parsing errors'
 
@@ -126,7 +127,7 @@ class WhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
         else
           results[:ok][domain] = domain_result
         end
-      rescue
+      rescue StandardError
         results[:unknown][domain] = 'Parsing error' unless config[:'ignore-errors']
       end
     end

data/bin/check-whois-domain-expiration.rb

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-# encoding: utf-8
+# frozen_string_literal: false
+
 #
 #   check-whois-domain-expiration
 #
@@ -63,6 +64,7 @@ class WhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
   def run
     whois = Whois.whois(config[:domain])
 
+    # TODO: figure out which to use `Date` or `Time`
     expires_on = DateTime.parse(whois.parser.expires_on.to_s)
     num_days = (expires_on - DateTime.now).to_i
 
@@ -75,7 +77,7 @@ class WhoisDomainExpirationCheck < Sensu::Plugin::Check::CLI
     else
       ok
     end
-  rescue
+  rescue StandardError
     unknown "#{config[:domain]} can't be checked"
   end
 end

data/bin/metrics-interface.rb

@@ -1,5 +1,6 @@
 #! /usr/bin/env ruby
-#  encoding: UTF-8
+# frozen_string_literal: true
+
 #
 #   interface-metrics
 #
@@ -52,7 +53,7 @@ class InterfaceGraphite < Sensu::Plugin::Metric::CLI::Graphite
   def run
     # Metrics borrowed from hoardd: https://github.com/coredump/hoardd
 
-    metrics = %w(rxBytes
+    metrics = %w[rxBytes
                  rxPackets
                  rxErrors
                  rxDrops
@@ -67,7 +68,7 @@ class InterfaceGraphite < Sensu::Plugin::Metric::CLI::Graphite
                  txFifo
                  txColls
                  txCarrier
-                 txCompressed)
+                 txCompressed]
 
     File.open('/proc/net/dev', 'r').each_line do |line|
       interface, stats_string = line.scan(/^\s*([^:]+):\s*(.*)$/).first

data/bin/metrics-net.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   metrics-net
 #
@@ -91,7 +93,7 @@ class LinuxPacketMetrics < Sensu::Plugin::Metric::CLI::Graphite
 
       begin
         if_speed = File.open(iface_path + '/speed').read.strip
-      rescue
+      rescue StandardError
         if_speed = 0
       end
 

data/bin/metrics-netif.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   netif-metrics
 #

data/bin/metrics-netstat-tcp.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #   metrics-netstat-tcp
 #

data/bin/metrics-ping.rb

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 # metrics-ping
 #
@@ -69,8 +71,8 @@ class PingMetrics < Sensu::Plugin::Metric::CLI::Graphite
          long: '--timeout TIMEOUT',
          default: 5
 
-  OVERVIEW_METRICS = [:packets_transmitted, :packets_received, :packet_loss, :time].freeze
-  STATISTIC_METRICS = [:min, :avg, :max, :mdev].freeze
+  OVERVIEW_METRICS = %i[packets_transmitted packets_received packet_loss time].freeze
+  STATISTIC_METRICS = %i[min avg max mdev].freeze
   FLOAT = '(\d+\.\d+)'.freeze
 
   def overview

data/bin/metrics-sockstat.rb

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 # metrics-sockstat
 #
@@ -54,7 +56,7 @@ class MetricsSockstat < Sensu::Plugin::Metric::CLI::Graphite
 
   def read_sockstat
     return IO.read('/proc/net/sockstat')
-  rescue => e
+  rescue StandardError => e
     unknown "Failed to read /proc/net/sockstat: #{e}"
   end
 

data/lib/sensu-plugins-network-checks.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'sensu-plugins-network-checks/version'

data/lib/sensu-plugins-network-checks/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module SensuPluginsNetworkChecks
   module Version
-    MAJOR = 2
-    MINOR = 3
-    PATCH = 1
+    MAJOR = 3
+    MINOR = 0
+    PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,43 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-network-checks
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Sensu-Plugins and contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-28 00:00:00.000000000 Z
+date: 2018-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: dnsbl-client
+  name: sensu-plugin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: sensu-plugin
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: dnsbl-client
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: net-ping
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +94,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -212,14 +212,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 0.51.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 0.51.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -307,7 +307,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="