sensu-plugins-influxdb-metrics-checker 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59b2a0ef87bf23bb182781dcd48a5d578783e326
-  data.tar.gz: 915f1f28d7d280773e4fc5e925cdca9c7e0e5dcb
+  metadata.gz: f2faf768f52259477f77f590df56d99c8e99a9c4
+  data.tar.gz: 33c7bb5da5466dce940086afc2944242ff6b9815
 SHA512:
-  metadata.gz: 6a27e57baeb6db9e730aa62a9ce42d5ddc1e0eb76372ee1b1bf1de6e7ad17a2eaf86339288e4359f74eac8596a1191ca83f74250f41973455835ffea9a7acaac
-  data.tar.gz: e5f351a2bcae1822e41d928da7e3d1870dd8874ad59ebbbd052ea0884b44c11629d6cf0e4512e676a3f3d3380221397095dfa0ed187b3436b2688c383c16d8dc
+  metadata.gz: 535f53f71f815f6cfd18e413070b735fd0e80284f0228b0d8d659844f0fa3560a7d740011664b64d285b53c9117644ad6922abba7d8ac35870c6cce032a05d30
+  data.tar.gz: e0d5ef15e1f95cb094d2137a0b3da60cb888afa7722f84cdc358d78b4e2d525dbfb219c2695022d1c2c7c3d4ab280105406eca9e7a7adfcaced845810e7aa3b5

data/CHANGELOG.md

@@ -3,6 +3,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
+# [0.6.0] - 2017-02-01
+- eleventh release
+Using absolute time in `epoch seconds` instead of relative time `now`
+
 # [0.5.0] - 2017-01-24
 - tenth release
 Changing from Percentage of Difference to Percentage of Change.
@@ -61,4 +65,6 @@ Leaving 5 minutes to the data to consolidate.
 [0.3.4]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.3.4...0.4.0
 [0.4.0]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.0...0.4.4
 [0.4.4]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.4...0.4.8
-[0.4.8]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.8...HEAD
+[0.4.8]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.8...0.5.0
+[0.5.0]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.5.0...0.6.0
+[0.6.0]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.6.0...HEAD

data/README.md

@@ -11,10 +11,11 @@ We chose to do it as a Sensu plugin because it comes with Handlers that will all
 The result is that now we are able to experiment with our metrics and alerts, giving us a better understanding of whats going on in our systems.
 
 ## What it does
-The script will compare the values of yesterday at this time minus 25 minutes, with the values of today at this time minus 25 minus.
+The script will compare the values of yesterday at this time minus period, with the values of today at this time minus period.
+Being period a default value of 20 minutes. 
 It will calculate the percentage of difference and will act on that.
 You will be able to set a threshold of warning and critical values where your program will act.
-It will also leave it 10 minutes to aggregate the data in influxdb, so we are more precise.
+It will also leave it 5 minutes to aggregate the data in influxdb, so we are more precise.
 
 ## Components
 There is just one script that you can find at

data/bin/check-influxdb-metrics.rb

@@ -9,6 +9,7 @@ require 'uri'
 require 'json'
 require 'base64'
 require 'addressable/uri'
+require './time-management'
 
 class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   option :host,
@@ -83,7 +84,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
          long: '--period=VALUE',
          description: 'Filter by a given day period in minutes',
          proc: proc { |l| l.to_i },
-         default: 30
+         default: 20
 
   option :triangulate,
          long: '--triangulate=VALUE',
@@ -99,15 +100,28 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
          default: 2
 
   BASE_QUERY = 'SELECT sum("value") from '.freeze
-  TODAY_START_PERIOD = 20
-  YESTERDAY_START_PERIOD = 1465 # starts counting 1455 minutes before now() [ yesetrday - 20 minutes] to match with today_query_for_a_period start_period
+  TIME_MANAGER = TimeManagement.new
+
+  def today_start_period
+    TIME_MANAGER.period_epoch(Time.now, TIME_MANAGER.today_start_period)
+  end
+
+  def yesterday_start_period
+    TIME_MANAGER.period_epoch(Time.now, TIME_MANAGER.yesterday_start_period)
+  end
 
   def yesterday_end_period
-    config[:period] + YESTERDAY_START_PERIOD
+    decrease = config[:period] + TIME_MANAGER.yesterday_start_period
+    TIME_MANAGER.period_epoch(Time.now, decrease)
   end
 
   def today_end_period
-    config[:period] + TODAY_START_PERIOD
+    decrease = config[:period] + TIME_MANAGER.today_start_period
+    TIME_MANAGER.period_epoch(Time.now, decrease)
+  end
+
+  def epoch_time(time)
+    time.to_i.to_s
   end
 
   def base_query_with_metricname(metric)
@@ -135,8 +149,8 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
     config[:applyfilterbothqueries].nil? ? '' : " AND \"#{config[:tag]}\" =~ /#{config[:filter]}/"
   end
 
-  def query_for_a_period(metric, start_period, end_period, istriangulated)
-    query = base_query_with_metricname(metric) + ' WHERE time > now() - ' + end_period.to_s + 'm AND time < now() - ' + start_period.to_s + 'm'
+  def query_for_a_period_timespan(metric, start_period, end_period, istriangulated)
+    query = base_query_with_metricname(metric) + ' WHERE time > ' + end_period.to_s + 's AND time < ' + start_period.to_s + 's'
     query + add_filter_when_needed(istriangulated)
   end
 
@@ -149,7 +163,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def query_encoded_for_a_period(metric, start_period, end_period, istriangulated)
-    query = query_for_a_period(metric, start_period, end_period, istriangulated)
+    query = query_for_a_period_timespan(metric, start_period, end_period, istriangulated)
     encode_parameters(query)
   end
 
@@ -172,7 +186,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def today_metrics
-    today_info = metrics(config[:metric], TODAY_START_PERIOD, today_end_period, false)
+    today_info = metrics(config[:metric], today_start_period, today_end_period, false)
     @today_metric_count = validate_metrics_and_count(today_info)
     if @today_metric_count > 0
       series = read_series_from_metrics(today_info)
@@ -184,7 +198,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def yesterday_metrics
-    yesterday_info = metrics(config[:metric], YESTERDAY_START_PERIOD, yesterday_end_period, false)
+    yesterday_info = metrics(config[:metric], yesterday_start_period, yesterday_end_period, false)
     @yesterday_metric_count = validate_metrics_and_count(yesterday_info)
     if @yesterday_metric_count > 0
       series = read_series_from_metrics(yesterday_info)
@@ -196,7 +210,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def today_triangulated_metrics
-    today_triangulated_info = metrics(config[:triangulate], TODAY_START_PERIOD, today_end_period, true)
+    today_triangulated_info = metrics(config[:triangulate], today_start_period, today_end_period, true)
     @today_triangulated_metric_count = validate_metrics_and_count(today_triangulated_info)
     if @today_triangulated_metric_count > 0
       series = read_series_from_metrics(today_triangulated_info)
@@ -208,7 +222,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def yesterday_triangulated_metrics
-    yesterday_triangulated_info = metrics(config[:triangulate], YESTERDAY_START_PERIOD, yesterday_end_period, true)
+    yesterday_triangulated_info = metrics(config[:triangulate], yesterday_start_period, yesterday_end_period, true)
     @yesterday_triangulated_metric_count = validate_metrics_and_count(yesterday_triangulated_info)
     if @yesterday_triangulated_metric_count > 0
       series = read_series_from_metrics(yesterday_triangulated_info)

data/bin/time-management.rb

@@ -0,0 +1,25 @@
+class TimeManagement
+  TODAY_START_PERIOD = 5
+  YESTERDAY_START_PERIOD = 1445 # starts counting 1445 minutes before now() [ yesterday - 5 minutes] to match with today_query_for_a_period start_period
+
+  def today_start_period
+    TODAY_START_PERIOD
+  end
+
+  def yesterday_start_period
+    YESTERDAY_START_PERIOD
+  end
+
+  def period_seconds(a_given_day_period)
+    a_given_day_period * 60
+  end
+
+  def period_epoch(time, a_given_period)
+    period = time - period_seconds(a_given_period)
+    epoch_time(period)
+  end
+
+  def epoch_time(time)
+    time.to_i.to_s
+  end
+end

data/lib/sensu-plugins-influxdb-metrics-checker/version.rb

@@ -1,7 +1,7 @@
 module SensuPluginsInfluxDbMetricsChecker
   module Version
     MAJOR = 0
-    MINOR = 5
+    MINOR = 6
     PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-influxdb-metrics-checker
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Juanjo Guerrero Cerezuela
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-25 00:00:00.000000000 Z
+date: 2017-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sensu-plugin
@@ -202,6 +202,7 @@ description: This plugin retrieves metrics and evaluate them. Aiming to track ou
 email: "<pliyosan@gmail.com>"
 executables:
 - check-influxdb-metrics.rb
+- time-management.rb
 extensions: []
 extra_rdoc_files: []
 files:
@@ -209,6 +210,7 @@ files:
 - LICENSE
 - README.md
 - bin/check-influxdb-metrics.rb
+- bin/time-management.rb
 - lib/sensu-plugins-influxdb-metrics-checker.rb
 - lib/sensu-plugins-influxdb-metrics-checker/version.rb
 homepage: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker