sensu-plugins-influxdb-metrics-checker 0.4.8 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c949341d92c3b4ab53a73e4bb6730e7c96cf06f
-  data.tar.gz: 1f7b5faba9d2d4beaf0400999c6c5effc8d06a7b
+  metadata.gz: 59b2a0ef87bf23bb182781dcd48a5d578783e326
+  data.tar.gz: 915f1f28d7d280773e4fc5e925cdca9c7e0e5dcb
 SHA512:
-  metadata.gz: 4fa1d53baacf1dc0a5e047c6b43c51d121d8aca09c81eefa703cfc07840f9aaa14ab4f4de16fd27e95f28b6278aaa5c137f49987212a4d950eaab501f2fdd7df
-  data.tar.gz: 9d6702dfdc47bf67fee5cc9c401b994741569b98f6d46ae73328021206d7fa913194aab5329f09574101b53d655a87129be3b48d0227bab611215bfb0dd61033
+  metadata.gz: 6a27e57baeb6db9e730aa62a9ce42d5ddc1e0eb76372ee1b1bf1de6e7ad17a2eaf86339288e4359f74eac8596a1191ca83f74250f41973455835ffea9a7acaac
+  data.tar.gz: e5f351a2bcae1822e41d928da7e3d1870dd8874ad59ebbbd052ea0884b44c11629d6cf0e4512e676a3f3d3380221397095dfa0ed187b3436b2688c383c16d8dc

data/CHANGELOG.md

@@ -3,6 +3,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
+# [0.5.0] - 2017-01-24
+- tenth release
+Changing from Percentage of Difference to Percentage of Change.
+
 # [0.4.8] - 2017-01-24
 - ninth release
 Bug fix when values comes as null. Now they will become zero.

data/bin/check-influxdb-metrics.rb

@@ -83,7 +83,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
          long: '--period=VALUE',
          description: 'Filter by a given day period in minutes',
          proc: proc { |l| l.to_i },
-         default: 25
+         default: 30
 
   option :triangulate,
          long: '--triangulate=VALUE',
@@ -99,8 +99,8 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
          default: 2
 
   BASE_QUERY = 'SELECT sum("value") from '.freeze
-  TODAY_START_PERIOD = 10
-  YESTERDAY_START_PERIOD = 1455 # starts counting 1455 minutes before now() [ yesetrday - 10 minutes] to match with today_query_for_a_period start_period
+  TODAY_START_PERIOD = 20
+  YESTERDAY_START_PERIOD = 1465 # starts counting 1455 minutes before now() [ yesetrday - 20 minutes] to match with today_query_for_a_period start_period
 
   def yesterday_end_period
     config[:period] + YESTERDAY_START_PERIOD
@@ -283,12 +283,12 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
   end
 
   def difference_for_standard_queries(today, yesterday)
-    difference = difference_between_two_metrics(today, yesterday)
+    difference = difference_between_two_metrics(yesterday, today)
     evaluate_percentage_and_notify(difference)
   end
 
   def difference_for_regex_queries(today, yesterday)
-    difference = difference_between_two_metrics(today, yesterday)
+    difference = difference_between_two_metrics(yesterday, today)
     evaluate_percentage_for_regex(difference)
   end
 
@@ -307,14 +307,24 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
       if today_value > yesterday_value
         difference_for_regex_queries(today_value, yesterday_value)
       end
+    else
+      warn 'new metric found: ' + today_key
     end
   end
 
-  def difference_between_two_metrics(original, newnumber)
+  # percentage difference calculator (deprecated)
+  def previous_difference_between_two_metrics(original, newnumber)
     decrease = original - newnumber
     decrease.to_f / original.to_f * 100
   end
 
+  # percentage of change
+  def difference_between_two_metrics(yesterday, today)
+    decrease = today.to_f - yesterday.to_f
+    division = decrease.to_f / yesterday.to_f.abs
+    division.to_f * 100.to_f
+  end
+
   def request(path)
     protocol = config[:ssl] ? 'https' : 'http'
     auth = Base64.encode64("#{config[:user]}:#{config[:pass]}")
@@ -351,7 +361,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
 
   def evaluate_distance_and_notify(distance)
     if distance > config[:distance].to_f
-      puts 'distance of ' + distance.to_s
+      puts 'distance of ' + distance.round(3).to_s
       critical config[:metric] + ' vs ' + config[:triangulate] + ' distance is greater than allowed minimum of ' + config[:distance].to_s
     else
       ok 'distance ok'
@@ -362,15 +372,15 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
     if @is_using_regex
       difference_for_regex_and_notify
     else
-      difference_between_two_metrics(today, yesterday)
+      difference_between_two_metrics(yesterday, today)
     end
   end
 
   def difference_between_percentages_of_two_metrics
     validate_base_metrics
     validate_triangulated_metrics
-    base = difference_between_two_metrics(today_metrics, yesterday_metrics)
-    triangulated = difference_between_two_metrics(today_triangulated_metrics, yesterday_triangulated_metrics)
+    base = difference_between_two_metrics(yesterday_metrics, today_metrics)
+    triangulated = difference_between_two_metrics(yesterday_triangulated_metrics, today_triangulated_metrics)
     puts 'difference for ' + config[:metric] + ' ' + base.round(3).to_s + '% vs ' + config[:triangulate] + ' ' + triangulated.round(3).to_s + '%'
     distance = distance_between_two_numbers(base, triangulated)
     evaluate_distance_and_notify(distance)

data/lib/sensu-plugins-influxdb-metrics-checker/version.rb

@@ -1,8 +1,8 @@
 module SensuPluginsInfluxDbMetricsChecker
   module Version
     MAJOR = 0
-    MINOR = 4
-    PATCH = 8
+    MINOR = 5
+    PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-influxdb-metrics-checker
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.5.0
 platform: ruby
 authors:
 - Juanjo Guerrero Cerezuela
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-24 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sensu-plugin