sensu-plugins-eventstore 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38994ee87db4e297cdec9d70ef832775a29e1b33
-  data.tar.gz: 59436bc00a7b1e9bc17ad38bad1e398344a5bc75
+  metadata.gz: bdb16fcadb0f5c1ce1f91bc09a8f43f82d9650b0
+  data.tar.gz: 3924369e8a2e84752246717a2f74e4427b1a8494
 SHA512:
-  metadata.gz: c5112ccfa0d8a846abc8c7d3181b136794d74f463726075c12c6db4c1665891f4aff7b17c6eb22ed894b8451ac2512dd695aba85df3a8d2d33130ee73cc1ce02
-  data.tar.gz: bfa6f88dcdf913849037905f1a4b38a8294877d8e86a3186bbb22e829412cdeb88ff80e8e1bfa7a870487b258566f32a7e899c9b083b8cce9ccfba20b17dd400
+  metadata.gz: fa8d641213093e20eef660428ff88985f3dc40192af60033871cbd177eed1baed8da29323cfd12eaa5ffe465024c537420123f7897db479d30c79612648e3443
+  data.tar.gz: 1f0c76a904c019f0145f80696ad50e4e160fd143c38fe2bedc5fd5544578a73fe39e0eea7d5a0d4e7cc5bf24739f85122e88132c6ee23412863d0d874fed96ef

data/bin/check-gossip.rb

@@ -73,7 +73,7 @@ class CheckGossip < Sensu::Plugin::Check::CLI
 
       current_machine_ips = get_current_machine_ipv4s
       event_store_ips = get_event_store_ips_from_dns cluster_dns
-      critical_failure_from_no_event_store_ips cluster_dns unless event_store_ips.any?
+      critical_no_event_store_ips cluster_dns unless event_store_ips.any?
       gossip_address = get_matching_ips current_machine_ips, event_store_ips
       expected_nodes = event_store_ips.count
     end
@@ -85,13 +85,12 @@ class CheckGossip < Sensu::Plugin::Check::CLI
     matched_ips = machine_ips.select do |ip_to_look_for|
       event_store_ips.find { |ip_to_match| ip_to_look_for == ip_to_match }
     end
-    critical_failure_from_no_matching_ips machine_ips, event_store_ips unless matched_ips.one?
+    critical_no_matching_ips machine_ips, event_store_ips unless matched_ips.one?
     matched_ips[0]
   end
 
-  def get_masters(document)
-    states = document.xpath '//State'
-    states.count { |state| state.content == 'Master' }
+  def get_master_count(document)
+    get_states(document).count { |state| state.content == 'Master' }
   end
 
   def get_members(document)
@@ -102,8 +101,17 @@ class CheckGossip < Sensu::Plugin::Check::CLI
     document.xpath '//IsAlive'
   end
 
+  def get_states(document)
+    document.xpath '//State'
+  end
+
   def only_one_master?(document)
-    get_masters(document) == 1
+    get_master_count(document) == 1
+  end
+
+  def all_nodes_master_or_slave?(document)
+    states = get_states document
+    states.all? {|node| node.content == "Master" || node.content == "Slave"}
   end
 
   def node_count_is_correct?(document, expected_count)
@@ -115,56 +123,31 @@ class CheckGossip < Sensu::Plugin::Check::CLI
     nodes.all? { |node| node_is_alive? node }
   end
 
-  def check_node(gossip_address, gossip_port, expected_nodes)
-    puts "\nchecking gossip at #{gossip_address}:#{gossip_port}"
-
-    begin
-      connection_url = "http://#{gossip_address}:#{gossip_port}/gossip?format=xml";
-      gossip = open(connection_url)
-
-    rescue StandardError
-      critical "Could not connect to #{connection_url} to check gossip, has event store fallen over on this node? "
-    end
-
-    xml_doc = Nokogiri::XML(gossip.readline)
-
-    puts "Checking for #{expected_nodes} nodes"
-    critical_failure_from_missing_nodes xml_doc, expected_nodes unless node_count_is_correct? xml_doc, expected_nodes
-
-    puts "Checking nodes for IsAlive state"
-    critical_failure_from_dead_nodes xml_doc, expected_nodes unless nodes_all_alive? xml_doc
-
-    puts "Checking for exactly 1 master"
-    critical_failure_from_incorrect_master_count xml_doc unless only_one_master? xml_doc
-
-    ok "#{gossip_address} is gossiping with #{expected_nodes} nodes. All nodes are marked as alive and one master node was found."
-  end
-
-  def critical_failure_from_no_matching_ips(machine_ips, event_store_ips)
+  def critical_no_matching_ips(machine_ips, event_store_ips)
     critical "this machine has ips of #{machine_ips}, event store (according to dns lookup) has ips of #{event_store_ips}. There should be exactly one match, but wasn't. "
   end
-  def critical_failure_from_no_event_store_ips(dns_name)
+  def critical_no_event_store_ips(dns_name)
     critical "could not find any ips at dns name #{dns_name} so cannot check gossips"
   end
-  def critical_failure_from_missing_nodes(xml_doc, expected_nodes)
-    critical "Wrong number of nodes, was #{get_members(xml_doc).count} should be exactly #{expected_nodes}"
+  def critical_missing_nodes(xml_doc, expected_nodes)
+    critical "Wrong number of nodes, was #{get_members(xml_doc).count} should be #{expected_nodes}"
   end
-  def critical_failure_from_dead_nodes(xml_doc, expected_nodes)
+  def critical_dead_nodes(xml_doc, expected_nodes)
     critical "Only #{get_is_alive_nodes(xml_doc).count { |node| node_is_alive? node}} alive nodes, should be #{expected_nodes} alive"
   end
-  def critical_failure_from_incorrect_master_count(xml_doc)
-    critical "Wrong number of node masters, there should be exactly 1 but there were #{get_masters(xml_doc)} masters"
+  def critical_master_count(xml_doc)
+    critical "Wrong number of node masters, there should be 1 but there were #{get_master_count(xml_doc)} masters"
+  end
+  def warn_nodes_not_ready(xml_doc)
+    states = get_states xml_doc
+    states = states.find { |node| node.content != "Master" and node.content != "Slave"}
+    warn "nodes found with states: #{states} when expected Master or Slave."
   end
 
   def node_is_alive?(node)
     node.content == 'true'
   end
 
-  def print_all(collection, type)
-    puts "\nprinting #{type} collection"
-    collection.each { |item| p item }
-  end
-
   def get_event_store_ips_from_dns(dns_name)
     Resolv::DNS.open { |dns|
       resources = dns.getresources dns_name, Resolv::DNS::Resource::IN::A
@@ -181,4 +164,32 @@ class CheckGossip < Sensu::Plugin::Check::CLI
 
     potential_ips.select { |info| ipv4_regex.match(info)}
   end
+
+  def check_node(gossip_address, gossip_port, expected_nodes)
+    puts "\nchecking gossip at #{gossip_address}:#{gossip_port}"
+
+    begin
+      connection_url = "http://#{gossip_address}:#{gossip_port}/gossip?format=xml"
+      gossip = open(connection_url)
+
+    rescue StandardError
+      critical "Could not connect to #{connection_url} to check gossip, has event store fallen over on this node? "
+    end
+
+    xml_doc = Nokogiri::XML(gossip.readline)
+
+    puts "Checking for #{expected_nodes} nodes"
+    critical_missing_nodes xml_doc, expected_nodes unless node_count_is_correct? xml_doc, expected_nodes
+
+    puts "Checking nodes for IsAlive state"
+    critical_dead_nodes xml_doc, expected_nodes unless nodes_all_alive? xml_doc
+
+    puts "Checking for exactly 1 master"
+    critical_master_count xml_doc unless only_one_master? xml_doc
+
+    puts "Checking node state"
+    warn_nodes_not_ready xml_doc unless all_nodes_master_or_slave? xml_doc
+
+    ok "#{gossip_address} is gossiping with #{expected_nodes} nodes, all nodes are alive, exactly one master node was found and all other nodes are in the 'Slave' state."
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-eventstore
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Jamie Wroe