sensu-plugins-disk-checks 2.5.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3dcdf8a494bf31a521ed81f321701776a0787fe4f6904daace173daf3f9189ef
-  data.tar.gz: c6d016ba7250007408f4aacd211f423f2a00d65e3fceaef5fb48793883f5461f
+  metadata.gz: 7bf5513d304d4157a83a33571861bb105e35a3f47a867b0d77d6b2c0e0b54037
+  data.tar.gz: feafc7c7df2fbd162d34406fc199fa500ce646f41d74601347cc1c9991160936
 SHA512:
-  metadata.gz: e4b25651b43fb6a432bc92a6388307e8ef1f492e187049d86a5461cae608d764b64010d53c6f0fa3886b5667c3edc9769343257640f46a244a6f9cbf9f288945
-  data.tar.gz: f27e711a3201bfe66288a8e5c95e02223c4080706814cf19ef0d6086c7244334d06123dc7d9477da89ebbdaafa65f903eb134a55c2ddfba108ca5a410e259394
+  metadata.gz: 8a1536ade75fa3ac7f047fe7bfe8adcbcbea0adeef3c8bef27a32f5b264744934272b8c7c67195674d52002278d48bde7f59ca23a34d344261c85283fe1add10
+  data.tar.gz: ed3039e31f4c1ffff1226b9279ad1187e7cf26506395e16002a0d320243be8a934e5dab27d54c0ba1e757d14c1a3ddff988d82cd7f4939933a65e323cea2a47f

data/CHANGELOG.md

@@ -1,13 +1,24 @@
 # Change Log
 This project adheres to [Semantic Versioning](http://semver.org/).
 
-This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
+This CHANGELOG follows the format listed [here](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md)
 
 ## [Unreleased]
 
+## [3.0.0] - 2018-03-07
+### Security
+- updated rubocop dependency to `~> 0.51.0` per: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418. (@majormoses)
+
+### Breaking Changes
+- removed ruby `< 2.1` support (@majormoses)
+
+### Changed
+- updated the changelog location guidelines (@majormoses)
+- appeased the cops and created TODOs for refactoring (@majormoses)
+
 ## [2.5.1] - 2017-12-05
 ### Fixed
-- check-disk-usage.rb: now exits unknown instead of critical when retrieving mountpoints fail
+- check-disk-usage.rb: now exits unknown instead of critical when retrieving mountpoints fail (@exeral)
 
 ## [2.5.0] - 2017-08-28
 ### Changed
@@ -160,7 +171,8 @@ https://mathias-kettner.de/checkmk_filesystems.html
 ### Added
 - initial release
 
-[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/2.5.1...HEAD
+[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/3.0.0...HEAD
+[3.0.0]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/2.5.1...3.0.0
 [2.5.1]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/2.5.0...2.5.1
 [2.5.0]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/2.4.2...2.5.0
 [2.4.2]: https://github.com/sensu-plugins/sensu-plugins-disk-checks/compare/2.4.1...2.4.2

data/bin/check-disk-usage.rb

@@ -120,7 +120,7 @@ class CheckDisk < Sensu::Plugin::Check::CLI
   def fs_mounts
     begin
       mounts = Filesystem.mounts
-    rescue
+    rescue StandardError
       unknown 'An error occured getting the mount info'
     end
     mounts.each do |line|
@@ -131,7 +131,7 @@ class CheckDisk < Sensu::Plugin::Check::CLI
         next if config[:ignorepathre] && config[:ignorepathre].match(line.mount_point)
         next if config[:ignoreopt] && config[:ignoreopt].include?(line.options)
         next if config[:includemnt] && !config[:includemnt].include?(line.mount_point)
-      rescue
+      rescue StandardError
         unknown 'An error occured getting the mount info'
       end
       check_mount(line)
@@ -150,7 +150,7 @@ class CheckDisk < Sensu::Plugin::Check::CLI
   def check_mount(line)
     begin
       fs_info = Filesystem.stat(line.mount_point)
-    rescue
+    rescue StandardError
       @warn_fs << "#{line.mount_point} Unable to read."
       return
     end

data/bin/check-smart-status.rb

@@ -174,7 +174,7 @@ class SmartCheckStatus < Sensu::Plugin::Check::CLI
     unless config[:threshold].nil?
       thresholds = config[:threshold].split(',')
       # Check threshold parameter length
-      raise 'Invalid threshold parameter count' unless thresholds.size % 5 == 0
+      raise 'Invalid threshold parameter count' unless (thresholds.size % 5).zero?
 
       (0..(thresholds.size / 5 - 1)).each do |i|
         att_id = @smart_attributes.index { |att| att[:id] == thresholds[i + 0].to_i }
@@ -203,7 +203,8 @@ class SmartCheckStatus < Sensu::Plugin::Check::CLI
     output = {}
     warnings = []
     criticals = []
-    devices.each do |dev|
+    # TODO: refactor me
+    devices.each do |dev| # rubocop:disable Metrics/BlockLength
       puts "#{config[:binary]} #{parameters} #{dev.device_path}" if @smart_debug
       # check if debug file specified
       if config[:debug_file].nil?

data/bin/check-smart-tests.rb

@@ -59,7 +59,7 @@ class Device
 
   def selftest_results
     results = []
-    headers = %w(num test_description status remaining lifetime lba_of_first_error)
+    headers = %w[num test_description status remaining lifetime lba_of_first_error]
 
     `sudo #{@exec} -l selftest #{@name}`.split("\n").grep(/^#/).each do |test|
       test = test.gsub!(/\s\s+/m, "\t").split("\t")
@@ -146,7 +146,8 @@ class CheckSMARTTests < Sensu::Plugin::Check::CLI
       end
     end
 
-    unless config[:long_test_interval].nil?
+    # TODO: refactor me
+    unless config[:long_test_interval].nil? # rubocop:disable Style/GuardClause
       dev.str.each_with_index do |t, i|
         if t['test_description'] != 'Extended offline'
           if i == dev.str.length - 1

data/bin/check-smart.rb

@@ -1,5 +1,4 @@
 #! /usr/bin/env ruby
-#  encoding: UTF-8
 #
 #   check-smart
 #
@@ -110,14 +109,14 @@ class CheckSMART < Sensu::Plugin::Check::CLI
          description: 'Exit code when SMART is unavailable/disabled on a disk',
          proc: proc(&:to_sym),
          default: :unknown,
-         in: %i(unknown ok warn critical)
+         in: %i[unknown ok warn critical]
 
   option :no_smart_capable_disks,
          long: '--no-smart-capable-disks EXIT_CODE',
          description: 'Exit code when there are no SMART capable disks',
          proc: proc(&:to_sym),
          default: :unknown,
-         in: %i(unknown ok warn critical)
+         in: %i[unknown ok warn critical]
 
   option :binary,
          short: '-b path/to/smartctl',
@@ -170,10 +169,12 @@ class CheckSMART < Sensu::Plugin::Check::CLI
   # Main function
   #
   def run
-    exit_with(
-      config[:no_smart_capable_disks],
-      'No SMART capable devices found'
-    ) unless @devices.length > 0
+    unless @devices.length > 0
+      exit_with(
+        config[:no_smart_capable_disks],
+        'No SMART capable devices found'
+      )
+    end
 
     unhealthy_disks = @devices.select { |disk| disk.smart_capable? && !disk.healthy? }
     unknown_disks = @devices.reject(&:smart_capable?)

data/bin/metrics-disk-capacity.rb

@@ -1,5 +1,4 @@
 #! /usr/bin/env ruby
-#  encoding: UTF-8
 #
 #   disk-capacity-metrics
 #
@@ -78,7 +77,7 @@ class DiskCapacity < Sensu::Plugin::Metric::CLI::Graphite
             end
           end
         end
-      rescue
+      rescue StandardError
         unknown "malformed line from df: #{line}"
       end
     end
@@ -104,7 +103,7 @@ class DiskCapacity < Sensu::Plugin::Metric::CLI::Graphite
             end
           end
         end
-      rescue
+      rescue StandardError
         unknown "malformed line from df: #{line}"
       end
     end

data/bin/metrics-disk-usage.rb

@@ -1,5 +1,4 @@
 #! /usr/bin/env ruby
-#  encoding: UTF-8
 #
 #   disk-usage-metrics
 #

data/bin/metrics-disk.rb

@@ -1,5 +1,4 @@
 #! /usr/bin/env ruby
-#  encoding: UTF-8
 #
 #   disk-metrics
 #
@@ -66,7 +65,7 @@ class DiskGraphite < Sensu::Plugin::Metric::CLI::Graphite
   # Main function
   def run
     # http://www.kernel.org/doc/Documentation/iostats.txt
-    metrics = %w(reads readsMerged sectorsRead readTime writes writesMerged sectorsWritten writeTime ioInProgress ioTime ioTimeWeighted)
+    metrics = %w[reads readsMerged sectorsRead readTime writes writesMerged sectorsWritten writeTime ioInProgress ioTime ioTimeWeighted]
 
     File.open('/proc/diskstats', 'r').each_line do |line|
       stats = line.strip.split(/\s+/)

data/lib/sensu-plugins-disk-checks/version.rb

@@ -1,8 +1,8 @@
 module SensuPluginsDiskChecks
   module Version
-    MAJOR = 2
-    MINOR = 5
-    PATCH = 1
+    MAJOR = 3
+    MINOR = 0
+    PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-disk-checks
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Sensu-Plugins and contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sensu-plugin
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 0.51.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 0.51.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -212,7 +212,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -220,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Sensu plugins for disk checks