sensu-plugins-aws 10.1.1 → 10.1.2

data/bin/check-instance-health.rb

@@ -95,7 +95,7 @@ class CheckInstanceEvents < Sensu::Plugin::Check::CLI
           end
         end
       end
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred processing AWS EC2 API: #{e.message}"
     end
 

data/bin/check-instance-reachability.rb

@@ -89,7 +89,7 @@ class CheckInstanceReachability < Sensu::Plugin::Check::CLI
           end
         end
       end
-    rescue => e
+    rescue StandardError => e
       puts "Error: exception: #{e}"
       critical
     end

data/bin/check-instances-count.rb

@@ -76,7 +76,7 @@ class CheckInstanceCount < Sensu::Plugin::Check::CLI
       end
     end
     instances.length
-  rescue => e
+  rescue StandardError => e
     critical "There was an error reaching AWS - #{e.message}"
   end
 

data/bin/check-kms-key.rb

@@ -57,7 +57,7 @@ class CheckKMSKey < Sensu::Plugin::Check::CLI
     return kms_client.describe_key(key_id: id)['key_metadata']['enabled']
   rescue Aws::KMS::Errors::NotFoundException
     critical 'Key doesnt exist'
-  rescue => e
+  rescue StandardError => e
     unknown "Failed to check key #{id}: #{e}"
   end
 

data/bin/check-rds-events.rb

@@ -90,7 +90,7 @@ class CheckRDSEvents < Sensu::Plugin::Check::CLI
     maint_clusters = []
     aws_regions = rds_regions
 
-    unless config[:aws_region].casecmp('all') == 0
+    unless config[:aws_region].casecmp('all').zero?
       if aws_regions.include? config[:aws_region]
         aws_regions.clear.push(config[:aws_region])
       else
@@ -131,8 +131,7 @@ class CheckRDSEvents < Sensu::Plugin::Check::CLI
           cluster_name_long = "#{cluster_name} (#{r}) #{events_record[:events][-1][:message]}"
           maint_clusters.push(cluster_name_long)
         end
-
-      rescue => e
+      rescue StandardError => e
         unknown "An error occurred processing AWS RDS API (#{r}): #{e.message}"
       end
     end

data/bin/check-rds-pending.rb

@@ -52,7 +52,7 @@ class CheckRDSEvents < Sensu::Plugin::Check::CLI
       pending_record[:pending_maintenance_actions].each do |response|
         maint_clusters.push(response[:pending_maintenance_action_details])
       end
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred processing AWS RDS API: #{e.message}"
     end
 

data/bin/check-rds.rb

@@ -118,12 +118,12 @@ class CheckRDS < Sensu::Plugin::Check::CLI
          description: 'Continue if CloudWatch provides no metrics for the time period',
          default: false
 
-  %w(warning critical).each do |severity|
+  %w[warning critical].each do |severity|
     option :"availability_zone_#{severity}",
            long:        "--availability-zone-#{severity} AZ",
            description: "Trigger a #{severity} if availability zone is different than given argument"
 
-    %w(cpu memory disk connections iops).each do |item|
+    %w[cpu memory disk connections iops].each do |item|
       option :"#{item}_#{severity}_over",
              long:        "--#{item}-#{severity}-over N",
              proc:        proc(&:to_f),
@@ -335,16 +335,16 @@ class CheckRDS < Sensu::Plugin::Check::CLI
       warning:  false
     }
 
-    @severities.keys.each do |severity|
+    @severities.each_key do |severity|
       message += check_az severity, config[:"availability_zone_#{severity}"], instance if config[:"availability_zone_#{severity}"]
 
-      %w(cpu memory disk connections iops).each do |item|
+      %w[cpu memory disk connections iops].each do |item|
         result = send "check_#{item}", severity, config[:"#{item}_#{severity}_over"] if config[:"#{item}_#{severity}_over"]
         message += result unless result.nil?
       end
     end
 
-    if %w(cpu memory disk connections iops).any? { |item| %w(warning critical).any? { |severity| config[:"#{item}_#{severity}_over"] } }
+    if %w[cpu memory disk connections iops].any? { |item| %w[warning critical].any? { |severity| config[:"#{item}_#{severity}_over"] } }
       message += "(#{config[:statistics].to_s.capitalize} within #{config[:period]}s "
       message += "between #{config[:end_time] - config[:period]} to #{config[:end_time]})"
     end

data/bin/check-redshift-events.rb

@@ -81,7 +81,7 @@ class CheckRedshiftEvents < Sensu::Plugin::Check::CLI
 
   # throw unknown message if the user passed us a missing instance
   def check_missing_instances(instances)
-    missing_instances = instances.select { |i| !all_clusters.include?(i) }
+    missing_instances = instances.reject { |i| all_clusters.include?(i) }
     unknown("Passed instance(s): #{missing_instances.join(',')} not found") unless missing_instances.empty?
   end
 
@@ -110,7 +110,7 @@ class CheckRedshiftEvents < Sensu::Plugin::Check::CLI
       end
 
       maint_clusters = clusters_in_maint(all_clusters)
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred processing AWS Redshift API: #{e.message}"
     end
 

data/bin/check-route.rb

@@ -114,7 +114,7 @@ class CheckRoute < Sensu::Plugin::Check::CLI
           end
         end
       end
-    rescue => e
+    rescue StandardError => e
       critical "Error: exception: #{e}"
     end
     critical

data/bin/check-route53-domain-expiration.rb

@@ -55,8 +55,8 @@ class CheckRoute53DomainExpiration < Sensu::Plugin::Check::CLI
     begin
       domains = r53.list_domains.domains
       domains.each do |domain|
-        expiration = DateTime.parse(domain.expiry.to_s)
-        days_until_expiration = (expiration - DateTime.now).to_i
+        expiration = DateTime.parse(domain.expiry.to_s) # rubocop: disable Style/DateTime
+        days_until_expiration = (expiration - DateTime.now).to_i # rubocop: disable Style/DateTime
         if days_until_expiration <= config[:crit]
           crit_domains[domain] = days_until_expiration
         elsif days_until_expiration <= config[:warn]
@@ -71,8 +71,7 @@ class CheckRoute53DomainExpiration < Sensu::Plugin::Check::CLI
       else
         ok 'No domains are expiring soon'
       end
-
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred communicating with the Route53 API: #{e.message}"
     end
   end

data/bin/check-s3-bucket.rb

@@ -79,7 +79,7 @@ class CheckS3Bucket < Sensu::Plugin::Check::CLI
       ok "Bucket #{config[:bucket_name]} found"
     rescue Aws::S3::Errors::NotFound => _
       critical "Bucket #{config[:bucket_name]} not found"
-    rescue => e
+    rescue StandardError => e
       critical "Bucket #{config[:bucket_name]} - #{e.message}"
     end
   end

data/bin/check-s3-object.rb

@@ -168,14 +168,14 @@ class CheckS3Object < Sensu::Plugin::Check::CLI
         size = output.contents[0].size
       end
 
-      [:critical, :warning].each do |level|
+      %i[critical warning].each do |level|
         run_check('age', level, age, key_fullname, 'S3 object %s is %s seconds old (bucket %s)')
       end
 
       if size.zero?
         critical "S3 object #{key_fullname} is empty (bucket #{config[:bucket_name]})" unless config[:ok_zero_size]
       else
-        [:critical, :warning].each do |level|
+        %i[critical warning].each do |level|
           run_check('size', level, size, key_fullname, 'S3 %s object\'size : %s octets (bucket %s)')
         end
       end
@@ -183,7 +183,7 @@ class CheckS3Object < Sensu::Plugin::Check::CLI
       ok("S3 object #{key_fullname} exists in bucket #{config[:bucket_name]}")
     rescue Aws::S3::Errors::NotFound => _
       critical "S3 object #{key_fullname} not found in bucket #{config[:bucket_name]}"
-    rescue => e
+    rescue StandardError => e
       critical "S3 object #{key_fullname} in bucket #{config[:bucket_name]} - #{e.message} - #{e.backtrace}"
     end
   end

data/bin/check-s3-tag.rb

@@ -54,7 +54,7 @@ class CheckS3Tag < Sensu::Plugin::Check::CLI
         if keys.sort & tags.sort != tags.sort
           missing_tags.push bucket.name
         end
-      rescue => _
+      rescue StandardError
         missing_tags.push bucket.name
       end
     end
@@ -64,7 +64,7 @@ class CheckS3Tag < Sensu::Plugin::Check::CLI
     else
       critical("Missing tags in #{missing_tags}")
     end
-  rescue => e
+  rescue StandardError => e
     critical "Error: #{e.message} - #{e.backtrace}"
   end
 end

data/bin/check-ses-limit.rb

@@ -69,7 +69,7 @@ class CheckSESLimit < Sensu::Plugin::Check::CLI
     begin
       ses = Aws::SES::Client.new
       response = ses.get_send_quota
-    rescue => e
+    rescue StandardError => e
       unknown "An issue occured while communicating with the AWS SES API: #{e.message}"
     end
 

data/bin/check-subnet-ip-consumption.rb

@@ -93,7 +93,7 @@ class CheckSubnetIpConsumption < Sensu::Plugin::Check::CLI
 
       return '<no alias>' if iam_account_alias.empty? || iam_account_alias.nil?
       return iam_account_alias
-    rescue => e
+    rescue StandardError => e
       unknown "An error occured while using AWS IAM to collect the account alias: #{e.message}"
     end
   end
@@ -165,7 +165,7 @@ class CheckSubnetIpConsumption < Sensu::Plugin::Check::CLI
                                  vpc_friendly_name: vpc_friendly_name)
         end
       end
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred processing AWS EC2: #{e.message}"
     end
 
@@ -175,10 +175,12 @@ class CheckSubnetIpConsumption < Sensu::Plugin::Check::CLI
     else
       # Compose alert messages at the configured verbosity
       alert_msg = []
-
+      # TODO: Come back and re-asses Rubocop rule, following it's suggestion actually breaks the code
+      # rubocop:disable Style/FormatStringToken
       verbosity0 = '%{subnet} at %{percent}%% [%{vpc}]'
       verbosity1 = '%{subnet} at %{percent}%% (%{consumed}/%{total}) [%{vpc}]'
       verbosity2 = '%{subnet} (%{cidr} in %{az}) at %{percent}%% (%{consumed}/%{total}) [%{vpc}]'
+      # rubocop:enable Style/FormatStringToken
 
       case config[:verbosity]
       when 0
@@ -208,8 +210,11 @@ class CheckSubnetIpConsumption < Sensu::Plugin::Check::CLI
       end
 
       # Throw critical alert with optional account alias display
+      # TODO: Come back and re-asses Rubocop rule, following it's suggestion actually breaks the code
+      # rubocop:disable Style/FormatStringToken
       alert_prefix = '%{count} subnets in %{region} exceeding %{threshold}%% IP consumption threshold: %{alerts}'
       alert_prefix_with_alias = '%{count} subnets in %{alias} (%{region}) exceeding %{threshold}%% IP consumption threshold: %{alerts}'
+      # rubocop:enable Style/FormatStringToken
 
       case config[:show_account_alias]
       when true

data/bin/check-trustedadvisor-service-limits.rb

@@ -69,7 +69,7 @@ class CheckTrustedAdvisorServiceLimits < Sensu::Plugin::Check::CLI
         sl_msg = "#{sl_service} (#{sl_region}) #{sl_description} #{sl_usage} out of #{sl_limit}"
         service_limit_msg.push(sl_msg)
       end
-    rescue => e
+    rescue StandardError => e
       unknown "An error occurred processing AWS TrustedAdvisor API: #{e.message}"
     end
 

data/bin/check-vpc-nameservers.rb

@@ -65,7 +65,7 @@ class CheckVpcNameservers < Sensu::Plugin::Check::CLI
     options.dhcp_options.each do |option|
       option.dhcp_configurations.each do |map|
         next if map.key != 'domain-name-servers'
-        map.values.each do |value|
+        map.each_value do |value|
           ip = value.value
           config[:queries].each do |query|
             begin

data/bin/check-vpc-vpn.rb

@@ -65,13 +65,13 @@ class CheckAwsVpcVpnConnections < Sensu::Plugin::Check::CLI
     begin
       ec2 = Aws::EC2::Client.new
       vpn_info = ec2.describe_vpn_connections(vpn_connection_ids: [config[:vpn_id]]).vpn_connections
-      down_connections = vpn_info.first.vgw_telemetry.select { |x| x.status != 'UP' }
+      down_connections = vpn_info.first.vgw_telemetry.reject { |x| x.status == 'UP' }
       results = { down_count: down_connections.count }
       results[:down_connection_status] = down_connections.map { |x| "#{x.outside_ip_address} => #{x.status_message.empty? ? 'none' : x.status_message}" }
       results[:connection_name] = vpn_info[0].tags.find { |x| x.key == 'Name' }.value
     rescue Aws::EC2::Errors::ServiceError
       warning "The vpnConnection ID '#{config[:vpn_id]}' does not exist"
-    rescue => e
+    rescue StandardError => e
       warning e.backtrace.join(' ')
     end
     results

data/bin/handler-ec2_node.rb

@@ -184,7 +184,7 @@ class Ec2Node < Sensu::Handler
     ec2 = Aws::EC2::Client.new(region: region)
     settings['ec2_node'] = {} unless settings['ec2_node']
     instance_states = @event['client']['ec2_states'] || settings['ec2_node']['ec2_states'] || ['shutting-down', 'terminated', 'stopping', 'stopped']
-    instance_reasons = @event['client']['ec2_state_reasons'] || settings['ec2_node']['ec2_state_reasons'] || %w(Client.UserInitiatedShutdown Server.SpotInstanceTermination Client.InstanceInitiatedShutdown)
+    instance_reasons = @event['client']['ec2_state_reasons'] || settings['ec2_node']['ec2_state_reasons'] || %w[Client.UserInitiatedShutdown Server.SpotInstanceTermination Client.InstanceInitiatedShutdown]
 
     begin
       # Finding the instance

data/bin/handler-scale-asg-down.rb

@@ -97,10 +97,10 @@ class AsgScaler < Sensu::Handler
     resp = resp.sub(' UTC', '+00:00')
 
     # Time of last autoscaling event
-    aws = DateTime.iso8601(resp)
+    aws = DateTime.iso8601(resp) # rubocop: disable Style/DateTime
 
     # Current System Time
-    now = DateTime.now.new_offset(0)
+    now = DateTime.now.new_offset(0) # rubocop: disable Style/DateTime
     diff = (now - aws).to_f	# This produces time since last event in days
     diff = diff * 24 * 60	# This produces the time since last event in minutes
     diff > cooldown_period.to_f

data/bin/handler-scale-asg-up.rb

@@ -97,10 +97,10 @@ class AsgScaler < Sensu::Handler
     resp = resp.sub(' UTC', '+00:00')
 
     # Time of last autoscaling event
-    aws = DateTime.iso8601(resp)
+    aws = DateTime.iso8601(resp) # rubocop: disable Style/DateTime
 
     # Current System Time
-    now = DateTime.now.new_offset(0)
+    now = DateTime.now.new_offset(0) # rubocop: disable Style/DateTime
     diff = (now - aws).to_f	# This produces time since last event in days
     diff = diff * 24 * 60	# This produces the time since last event in minutes
     diff > cooldown_period.to_f

data/bin/handler-sns.rb

@@ -58,7 +58,7 @@ class SnsNotifier < Sensu::Handler
     }
 
     sns.publish(options)
-  rescue => e
+  rescue StandardError => e
     puts "Exception occured in SnsNotifier: #{e.message}", e.backtrace
   end
 end

data/bin/metrics-autoscaling-instance-count.rb

@@ -92,7 +92,7 @@ class AutoScalingInstanceCountMetrics < Sensu::Plugin::Metric::CLI::Graphite
           end
         output graphitepath, count
       end
-    rescue => e
+    rescue StandardError => e
       puts "Error: exception: #{e}"
       critical
     end

data/bin/metrics-billing.rb

@@ -89,8 +89,7 @@ class BillingMetrics < Sensu::Plugin::Metric::CLI::Graphite
         )
         output "#{config[:scheme]}.total.#{service_name}", r[:datapoints][0].maximum, r[:datapoints][0][:timestamp].to_i unless r[:datapoints][0].nil?
       end
-
-    rescue => e
+    rescue StandardError => e
       critical "Error: exception: #{e}"
     end
     ok

data/bin/metrics-ec2-count.rb

@@ -128,8 +128,7 @@ class EC2Metrics < Sensu::Plugin::Metric::CLI::Graphite
       elsif config[:type] == 'status'
         by_instances_status(client)
       end
-
-    rescue => e
+    rescue StandardError => e
       puts "Error: exception: #{e}"
       critical
     end

data/bin/metrics-ec2-filter.rb

@@ -88,7 +88,7 @@ class EC2Filter < Sensu::Plugin::Metric::CLI::Graphite
         end
       end
       output scheme + ".count.#{instance_ids.count}"
-    rescue => e
+    rescue StandardError => e
       puts "Error: exception: #{e}"
       critical
     end

data/bin/metrics-elasticache.rb

@@ -107,7 +107,8 @@ class ElasticMetrics < Sensu::Plugin::Metric::CLI::Graphite
   end
 
   def run
-    elasticaches.describe_cache_clusters.cache_clusters.each do |elasticache|
+    # TODO: come back and refactor
+    elasticaches.describe_cache_clusters.cache_clusters.each do |elasticache| # rubocop:disable Metrics/BlockLength)
       if elasticache.engine.include? 'redis'
         if config[:statistic] == ''
           default_statistic_per_metric = {

data/bin/metrics-elb-full.rb

@@ -137,7 +137,7 @@ class ELBMetrics < Sensu::Plugin::Metric::CLI::Graphite
           output graphitepath + ".#{key}", value[:sum] || value[:average], value[:timestamp].to_i
         end
       end
-    rescue => e
+    rescue StandardError => e
       critical "Error: exception: #{e}"
     end
     ok

data/bin/metrics-emr-steps.rb

@@ -54,7 +54,7 @@ class EMRStepMetrics < Sensu::Plugin::Metric::CLI::Graphite
     steps.count { |step| step.status.state == status }
   end
 
-  STATUS = %w(PENDING RUNNING COMPLETED CANCELLED FAILED INTERRUPTED).freeze
+  STATUS = %w[PENDING RUNNING COMPLETED CANCELLED FAILED INTERRUPTED].freeze
 
   def cluster_steps(emr, cluster_id, data)
     steps = emr.list_steps(

data/bin/metrics-rds.rb

@@ -132,7 +132,7 @@ class RDSMetrics < Sensu::Plugin::Metric::CLI::Graphite
         config[:scheme] + '.' + rdsname
       end
 
-    statistic_type.each do |key, _value|
+    statistic_type.each_key do |key, _value|
       r = cloud_watch_metric key, rdsname
       result[full_scheme + '.' + key] = r[:datapoints][0] unless r[:datapoints][0].nil?
     end

data/bin/metrics-s3.rb

@@ -46,6 +46,8 @@ class S3Metrics < Sensu::Plugin::Metric::CLI::Graphite
          long: '--scheme SCHEME',
          default: 'sensu.aws.s3.buckets'
 
+  def bucket_size(size_size = 'bytes'); end
+
   def run
     begin
       s3 = Aws::S3::Client.new(aws_config)
@@ -54,7 +56,8 @@ class S3Metrics < Sensu::Plugin::Metric::CLI::Graphite
       cw = Aws::CloudWatch::Client.new(aws_config)
 
       now = Time.now
-      list_buckets.buckets.each do |bucket|
+      # TODO: come back and refactor this
+      list_buckets.buckets.each do |bucket| # rubocop:disable Metrics/BlockLength)
         bucket_name = bucket.name.tr('.', '_')
         bucket_size_bytes = cw.get_metric_statistics(
           namespace: 'AWS/S3',
@@ -96,8 +99,7 @@ class S3Metrics < Sensu::Plugin::Metric::CLI::Graphite
         )
         output "#{config[:scheme]}.#{bucket_name}.number_of_objects", number_of_objects[:datapoints][0].average, now.to_i unless number_of_objects[:datapoints][0].nil?
       end
-
-    rescue => e
+    rescue StandardError => e
       critical "Error: exception: #{e}"
     end
     ok