sendle-api 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68b93ccc7a2f1762a621462360bfd3efaa0b9a1e
-  data.tar.gz: eac48906b5c093d3fe83547bebaa9ddd1c3585c4
+  metadata.gz: 939e17d825cb0f844980e6bc3ca323966e16f79b
+  data.tar.gz: 97c59b2cfe9d7f602abcb864d96726150d9cf3c9
 SHA512:
-  metadata.gz: 6d63dfb209cb35f600b6d3f30a4e2ead269245a9a0681a16ab69fbfeb6e062491313e536b5b48be5b9e296881aa496638801fadf6fe40994cdefa22a2227c861
-  data.tar.gz: 5ec6cfacd67a5494cda6335786500ca45aa7ba13f0a6a9118e3093283f0e9abf01b39a6685af28904ecd8edd74b191489e11b6da9ab06febc75ad61ac546519a
+  metadata.gz: 770c10b0e3cc0bcfd6c1882984d10124460bd85226de85791345a4769a892924ccbf20c87c7817aa91c2ae5e2b21361ae66e6f4e9e1695e61aac2a76be99ce03
+  data.tar.gz: 23ee31806fed88dccb02f27427c6bdb9150b2299e83f02d079ac5a07d6744e13ced10b06479987542caa0017cc2f59e153ec3ad3c725c9592b7c30f637423032

data/Changelog.md

@@ -1,5 +1,10 @@
 # Sendle::Api Changes
 
+## 0.0.12
+
+* Wrap constants defined in constants.rb inside module namespaces
+* Added constants for Order status
+
 ## 0.0.11
 
 * Initial release!

data/lib/sendle/api/actions/create.rb

@@ -19,12 +19,6 @@ module Sendle
           base.extend(Sendle::Api::Sugars::Create)
         end
 
-        protected
-
-          def http_method
-            :post
-          end
-
       end
     end
   end

data/lib/sendle/api/constants.rb

@@ -1,4 +1,21 @@
-PLAN_EASY = 'easy'
-PLAN_PREMIUM = 'premium'
-PLAN_PRO = 'pro'
-PLANS = [ PLAN_EASY, PLAN_PREMIUM, PLAN_PRO ]
+module Sendle
+  module Api
+    PLAN_EASY = 'easy'
+    PLAN_PREMIUM = 'premium'
+    PLAN_PRO = 'pro'
+    PLANS = [ PLAN_EASY, PLAN_PREMIUM, PLAN_PRO ]
+
+    ORDER_STATUS_PAYMENT = 'Payment'
+    ORDER_STATUS_PICKUP = 'Pickup'
+    ORDER_STATUS_IN_TRANSIT = 'In Transit'
+    ORDER_STATUS_DELIVERED = 'Delivered'
+    ORDER_STATUS_CANCELLED = 'Cancelled'
+    ORDER_STATUSES = [ ORDER_STATUS_PAYMENT,
+                       ORDER_STATUS_PICKUP,
+                       ORDER_STATUS_IN_TRANSIT,
+                       ORDER_STATUS_DELIVERED,
+                       ORDER_STATUS_CANCELLED 
+                      ]
+  end
+end
+

data/lib/sendle/api/quote.rb

@@ -21,7 +21,7 @@ class Sendle::Api::Quote < Sendle::Api::Resource
     # Checking for valid plan_name, if passed in
     if params[:plan_name]
       plan_name = params[:plan_name]
-      raise Sendle::Api::Errors::InvalidPlan.new(plan_name) unless PLANS.include?(plan_name)
+      raise Sendle::Api::Errors::InvalidPlan.new(plan_name) unless Sendle::Api::PLANS.include?(plan_name)
     end
   end
 

data/lib/sendle/api/version.rb

@@ -1,5 +1,5 @@
 module Sendle
   module Api
-    VERSION = "0.0.11"
+    VERSION = "0.0.12"
   end
 end

data/spec/sendle/api/quote_spec.rb

@@ -44,7 +44,7 @@ describe Sendle::Api::Quote do
 
     context "passing in a plan_name" do
       it "checks a valid plan name is passed in" do
-        PLANS.each do |plan|
+        Sendle::Api::PLANS.each do |plan|
           params[:plan_name] = plan
           expect(RestClient::Request).to receive(:execute).and_return(QUOTE_NO_PLAN_RESPONSE)
           Sendle::Api::Quote.execute(params)
@@ -64,12 +64,12 @@ describe Sendle::Api::Quote do
           headers: {
             accept: :json, 
             content_type: :json,
-            params: params.merge(plan_name: PLAN_EASY)
+            params: params.merge(plan_name: Sendle::Api::PLAN_EASY)
           }
         }
         expect(RestClient::Request).to receive(:execute).with(hash_including(expected_params)).and_return(QUOTE_NO_PLAN_RESPONSE)
 
-        Sendle::Api::Quote.execute(params.merge(plan_name: PLAN_EASY))
+        Sendle::Api::Quote.execute(params.merge(plan_name: Sendle::Api::PLAN_EASY))
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sendle-api
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Bobby Lei