sendgrid_actionmailer_adapter 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3459fa2cabe507129253244ce31666e7c613b4761f1d3209e9d42bd7a142b41
-  data.tar.gz: 7df639a0e08d5f906cdb64f2851b3157120fe253c2819ec293e0d45259858345
+  metadata.gz: cd86c4547fe8aa68707f63e6613531e67e0b8f9b08a454f2bb1d6c4977c2ebf3
+  data.tar.gz: 24d6b1d4aed6f1f359453e8686fec2cad0af806a9cad03b03624deb01798fa07
 SHA512:
-  metadata.gz: 03a37ec28980cafa9aaa7a7175fe7946b43cf8ac3b83ae4ff5ffed70f915b172f4982efe2404d3399199da77eda88f9f27ca7345a19934001b24adf7a2f89a45
-  data.tar.gz: 7c18f61dc83ca6eb4d8ed50e0de4d5092dd78d1c5de55064ed699c97159ab1d142d6e3010afa30618ad215c5de86f1654ec5bf852621552c4ec8b5d2eb6f8c0d
+  metadata.gz: ea3939b006d894a1e29841fd26642f61ac56b3310ad97c7919c7e59d325d3b11e8d0ce6264e25ccb453ddc5078183f603f045f334a9760e4519fe2b12526131a
+  data.tar.gz: 4ffb01e435809c556efa5290e0bcc2881cd31770c9df4a79cb2b6494a08e49e9c842524e1cec5ff305f386c09abf8661a6179ca574cbc02439fcdc885675acb8

data/lib/sendgrid_actionmailer_adapter/configuration.rb

@@ -7,7 +7,7 @@ module SendGridActionMailerAdapter
 
     class << self
       attr_accessor :api_key, :host, :request_headers, :version, :retry_max_count,
-                    :retry_wait_seconds, :return_response
+                    :retry_wait_seconds, :return_response, :logger
 
       # Set your configuration with block.
       def configure
@@ -30,6 +30,7 @@ module SendGridActionMailerAdapter
             wait_seconds: retry_wait_seconds || DEFAULT_RETRY_WAIT_SECONDS,
           },
           return_response: return_response,
+          logger: logger,
         }.freeze
       end
 
@@ -42,6 +43,7 @@ module SendGridActionMailerAdapter
         self.retry_max_count = nil
         self.retry_wait_seconds = nil
         self.return_response = nil
+        self.logger = nil
         @settings = nil
       end
     end

data/lib/sendgrid_actionmailer_adapter/converters/categories.rb

@@ -11,6 +11,7 @@ module SendGridActionMailerAdapter
       def convert(mail)
         categories_str = mail['categories']&.value
         return if categories_str.nil? || categories_str.empty?
+
         categories_str.split(', ').map { |c| ::SendGrid::Category.new(name: c) }
       end
 

data/lib/sendgrid_actionmailer_adapter/converters/reply_to.rb

@@ -11,6 +11,7 @@ module SendGridActionMailerAdapter
       def convert(mail)
         addr = mail[:reply_to]&.addrs&.first
         return if addr.nil?
+
         ::SendGrid::Email.new(email: addr.address, name: addr.display_name)
       end
 

data/lib/sendgrid_actionmailer_adapter/converters/send_at.rb

@@ -11,6 +11,7 @@ module SendGridActionMailerAdapter
       def convert(mail)
         send_at_str = mail['send_at']&.value
         return if send_at_str.nil? || send_at_str.empty?
+
         send_at_str.to_i
       end
 

data/lib/sendgrid_actionmailer_adapter/delivery_method.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'logger'
 require 'sendgrid/client'
 require_relative 'configuration'
 require_relative 'converter'
@@ -22,6 +23,7 @@ module SendGridActionMailerAdapter
     # @options settings [Integer, Float] :retry_wait_sec Wait seconds for next retry, Default is 1.
     def initialize(settings)
       @settings = ::SendGridActionMailerAdapter::Configuration.settings.merge(settings)
+      @logger = @settings[:logger] || ::Logger.new(nil)
     end
 
     # Deliver a mail via SendGrid Web API.
@@ -33,29 +35,54 @@ module SendGridActionMailerAdapter
     # @raise [SendGridActionMailerAdapter::ApiError] when SendGrid Web API returns error response.
     def deliver!(mail)
       sendgrid_mail = ::SendGridActionMailerAdapter::Converter.to_sendgrid_mail(mail)
-      body = sendgrid_mail.to_json
-      client = ::SendGrid::API.new(@settings[:sendgrid]).client.mail._('send')
+
+      if mail[:remove_from_bounces]
+        remove_to_addrs_from_bounces(sendgrid_mail)
+      end
 
       with_retry(@settings[:retry]) do
-        response = client.post(request_body: body)
+        @logger.info("Calling sendMail API, #{sendgrid_mail.inspect}")
+        response = sendgrid_client.mail._('send').post(request_body: sendgrid_mail.to_json)
+        @logger.info("End calling sendMail API, status_code: #{response.status_code}")
         handle_response!(response)
       end
     end
 
     private
 
+    def sendgrid_client
+      @sendgrid_client ||= ::SendGrid::API.new(@settings[:sendgrid]).client
+    end
+
+    # @param [::SendGrid::Mail]
+    def remove_to_addrs_from_bounces(sendgrid_mail)
+      sendgrid_mail.personalizations.each do |personalization|
+        personalization['to'].each do |to|
+          @logger.info("Calling deleteBounce API, #{to}")
+          # success => 204, not_found => 404
+          sendgrid_client.suppression.bounces._(to['email']).delete
+          @logger.info('End calling deleteBounce API')
+        end
+      end
+    end
+
     def with_retry(max_count:, wait_seconds:)
       tryable_count = max_count + 1
       begin
         tryable_count -= 1
         yield
-      rescue ::SendGridActionMailerAdapter::ApiClientError => _e
+      rescue ::SendGridActionMailerAdapter::ApiClientError => e
+        @logger.error(e)
         raise
-      rescue => _e
+      rescue StandardError => e
         if tryable_count > 0
+          @logger.warn("Retry mail sending, tryable_count: #{tryable_count}")
+          @logger.warn(e)
           sleep(wait_seconds)
           retry
         end
+        @logger.error('Give up retrying')
+        @logger.error(e)
         raise
       end
     end

data/lib/sendgrid_actionmailer_adapter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SendGridActionMailerAdapter
-  VERSION = '0.2.2'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sendgrid_actionmailer_adapter
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - ryu39
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-05 00:00:00.000000000 Z
+date: 2019-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sendgrid-ruby
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,49 +53,49 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ryu39cop
+  name: mail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: mail
+  name: ryu39cop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: actionmailer
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -163,8 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A ActionMailer adapter using SendGrid Web API v3