sendgrid-ruby 6.3.1 → 6.3.6

data/lib/sendgrid/helpers/mail/header.rb

@@ -1,21 +1,17 @@
+require 'json'
+
 module SendGrid
   class Header
+    attr_accessor :header
+
     def initialize(key: nil, value: nil)
       @header = {}
-      (key.nil? || value.nil?) ? @header = nil : @header[key] = value
-    end
-
-    def header=(header)
-      @header = header
-    end
-
-    def header
-      @header
+      key.nil? || value.nil? ? @header = nil : @header[key] = value
     end
 
     def to_json(*)
       {
-        'header' => self.header
+        'header' => header
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end

data/lib/sendgrid/helpers/mail/mail.rb

@@ -1,12 +1,14 @@
 # Build the request body for the v3/mail/send endpoint
 # Please see the examples/helpers/mail/example.rb for a demonstration of usage
+require 'json'
+
 module SendGrid
   class Mail
-
     attr_accessor :subject, :ip_pool_name, :template_id, :send_at, :batch_id
     attr_reader :personalizations, :contents, :attachments, :categories, :sections, :headers, :custom_args
+    attr_writer :from, :asm, :mail_settings, :tracking_settings, :reply_to
 
-    def initialize(from_email=nil, subj=nil, to_email=nil, cont=nil)
+    def initialize(from_email = nil, subj = nil, to_email = nil, cont = nil)
       @from = nil
       @subject = nil
       @personalizations = []
@@ -25,18 +27,14 @@ module SendGrid
       @tracking_settings = nil
       @reply_to = nil
 
-      if !(from_email.nil? && subj.nil? && to_email.nil? && cont.nil?)
-        self.from = from_email
-        self.subject = subj
-        personalization = Personalization.new
-        personalization.add_to(to_email)
-        self.add_personalization(personalization)
-        self.add_content(cont)
-      end
-    end
+      return if from_email.nil? && subj.nil? && to_email.nil? && cont.nil?
 
-    def from=(from)
-      @from = from
+      self.from = from_email
+      self.subject = subj
+      personalization = Personalization.new
+      personalization.add_to(to_email)
+      add_personalization(personalization)
+      add_content(cont)
     end
 
     def from
@@ -54,7 +52,7 @@ module SendGrid
     def check_for_secrets(patterns)
       contents = @contents.map { |content| content['value'] }.join(' ')
       patterns.each do |pattern|
-        raise SecurityError.new('Content contains sensitive information.') if contents.match(pattern)
+        raise SecurityError, 'Content contains sensitive information.' if contents.match(pattern)
       end
     end
 
@@ -81,58 +79,42 @@ module SendGrid
       @custom_args = @custom_args.merge(custom_arg['custom_arg'])
     end
 
-    def asm=(asm)
-      @asm = asm
-    end
-
     def asm
       @asm.nil? ? nil : @asm.to_json
     end
 
-    def mail_settings=(mail_settings)
-      @mail_settings = mail_settings
-    end
-
     def mail_settings
       @mail_settings.nil? ? nil : @mail_settings.to_json
     end
 
-    def tracking_settings=(tracking_settings)
-      @tracking_settings = tracking_settings
-    end
-
     def tracking_settings
       @tracking_settings.nil? ? nil : @tracking_settings.to_json
     end
 
-    def reply_to=(reply_to)
-      @reply_to = reply_to
-    end
-
     def reply_to
       @reply_to.nil? ? nil : @reply_to.to_json
     end
 
     def to_json(*)
       {
-        'from' => self.from,
-        'subject' => self.subject,
-        'personalizations' => self.personalizations,
-        'content' => self.contents,
-        'attachments' => self.attachments,
-        'template_id' => self.template_id,
-        'sections' => self.sections,
-        'headers' => self.headers,
-        'categories' => self.categories,
-        'custom_args' => self.custom_args,
-        'send_at' => self.send_at,
-        'batch_id' => self.batch_id,
-        'asm' => self.asm,
-        'ip_pool_name' => self.ip_pool_name,
-        'mail_settings' => self.mail_settings,
-        'tracking_settings' => self.tracking_settings,
-        'reply_to' => self.reply_to
-      }.delete_if { |_, value| value.to_s.strip == '' || value == [] || value == {}}
+        'from' => from,
+        'subject' => subject,
+        'personalizations' => personalizations,
+        'content' => contents,
+        'attachments' => attachments,
+        'template_id' => template_id,
+        'sections' => sections,
+        'headers' => headers,
+        'categories' => categories,
+        'custom_args' => custom_args,
+        'send_at' => send_at,
+        'batch_id' => batch_id,
+        'asm' => asm,
+        'ip_pool_name' => ip_pool_name,
+        'mail_settings' => mail_settings,
+        'tracking_settings' => tracking_settings,
+        'reply_to' => reply_to
+      }.delete_if { |_, value| value.to_s.strip == '' || value == [] || value == {} }
     end
   end
 end

data/lib/sendgrid/helpers/mail/mail_settings.rb

@@ -1,5 +1,9 @@
+require 'json'
+
 module SendGrid
   class MailSettings
+    attr_writer :sandbox_mode, :footer, :bcc, :spam_check, :bypass_list_management
+
     def initialize
       @bcc = nil
       @bypass_list_management = nil
@@ -8,53 +12,33 @@ module SendGrid
       @spam_check = nil
     end
 
-    def sandbox_mode=(sandbox_mode)
-      @sandbox_mode = sandbox_mode
-    end
-
     def sandbox_mode
       @sandbox_mode.nil? ? nil : @sandbox_mode.to_json
     end
 
-    def bypass_list_management=(bypass_list_management)
-      @bypass_list_management = bypass_list_management
-    end
-
     def bypass_list_management
       @bypass_list_management.nil? ? nil : @bypass_list_management.to_json
     end
 
-    def footer=(footer)
-      @footer = footer
-    end
-
     def footer
       @footer.nil? ? nil : @footer.to_json
     end
 
-    def bcc=(bcc)
-      @bcc = bcc
-    end
-
     def bcc
       @bcc.nil? ? nil : @bcc.to_json
     end
 
-    def spam_check=(spam_check)
-      @spam_check = spam_check
-    end
-
     def spam_check
       @spam_check.nil? ? nil : @spam_check.to_json
     end
 
     def to_json(*)
       {
-        'bcc' => self.bcc,
-        'bypass_list_management' => self.bypass_list_management,
-        'footer' => self.footer,
-        'sandbox_mode' => self.sandbox_mode,
-        'spam_check' => self.spam_check
+        'bcc' => bcc,
+        'bypass_list_management' => bypass_list_management,
+        'footer' => footer,
+        'sandbox_mode' => sandbox_mode,
+        'spam_check' => spam_check
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end

data/lib/sendgrid/helpers/mail/open_tracking.rb

@@ -1,30 +1,18 @@
+require 'json'
+
 module SendGrid
   class OpenTracking
-    def initialize(enable: nil, substitution_tag: nil)
-      @enable = enable
-      @substitution_tag = substitution_tag
-    end
+    attr_accessor :enable, :substitution_tag
 
-    def enable=(enable)
+    def initialize(enable: nil, substitution_tag: nil)
       @enable = enable
-    end
-
-    def enable
-      @enable
-    end
-
-    def substitution_tag=(substitution_tag)
       @substitution_tag = substitution_tag
     end
 
-    def substitution_tag
-      @substitution_tag
-    end
-
     def to_json(*)
       {
-        'enable' => self.enable,
-        'substitution_tag' => self.substitution_tag
+        'enable' => enable,
+        'substitution_tag' => substitution_tag
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end

data/lib/sendgrid/helpers/mail/personalization.rb

@@ -1,8 +1,11 @@
+require 'json'
+
 module SendGrid
   class Personalization
-
     attr_reader :tos, :ccs, :bccs, :headers, :substitutions, :custom_args,
-      :dynamic_template_data
+                :dynamic_template_data
+
+    attr_accessor :send_at, :subject
 
     def initialize
       @tos = []
@@ -17,23 +20,21 @@ module SendGrid
     end
 
     def add_to(to)
+      raise DuplicatePersonalizationError if duplicate?(to)
+
       @tos << to.to_json
     end
 
     def add_cc(cc)
+      raise DuplicatePersonalizationError if duplicate?(cc)
+
       @ccs << cc.to_json
     end
 
     def add_bcc(bcc)
-      @bccs << bcc.to_json
-    end
-
-    def subject=(subject)
-      @subject = subject
-    end
+      raise DuplicatePersonalizationError if duplicate?(bcc)
 
-    def subject
-      @subject
+      @bccs << bcc.to_json
     end
 
     def add_header(header)
@@ -55,26 +56,32 @@ module SendGrid
       @dynamic_template_data.merge!(dynamic_template_data)
     end
 
-    def send_at=(send_at)
-      @send_at = send_at
+    def to_json(*)
+      {
+        'to' => tos,
+        'cc' => ccs,
+        'bcc' => bccs,
+        'subject' => subject,
+        'headers' => headers,
+        'substitutions' => substitutions,
+        'custom_args' => custom_args,
+        'dynamic_template_data' => dynamic_template_data,
+        'send_at' => send_at
+      }.delete_if { |_, value| value.to_s.strip == '' || value == [] || value == {} }
     end
 
-    def send_at
-      @send_at
-    end
+    private
 
-    def to_json(*)
-      {
-        'to' => self.tos,
-        'cc' => self.ccs,
-        'bcc' => self.bccs,
-        'subject' => self.subject,
-        'headers' => self.headers,
-        'substitutions' => self.substitutions,
-        'custom_args' => self.custom_args,
-        'dynamic_template_data' => self.dynamic_template_data,
-        'send_at' => self.send_at
-      }.delete_if { |_, value| value.to_s.strip == '' || value == [] || value == {}}
+    def duplicate?(addition)
+      additional_email = addition.email.downcase
+
+      [@tos, @ccs, @bccs].flatten.each do |elm|
+        return true if elm&.dig('email') == additional_email
+      end
+
+      false
     end
   end
+
+  class DuplicatePersonalizationError < StandardError; end
 end

data/lib/sendgrid/helpers/mail/section.rb

@@ -1,21 +1,17 @@
+require 'json'
+
 module SendGrid
   class Section
+    attr_accessor :section
+
     def initialize(key: nil, value: nil)
       @section = {}
-      (key.nil? || value.nil?) ? @section = nil : @section[key] = value
-    end
-
-    def section=(section)
-      @section = section
-    end
-
-    def section
-      @section
+      key.nil? || value.nil? ? @section = nil : @section[key] = value
     end
 
     def to_json(*)
       {
-        'section' => self.section
+        'section' => section
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end

data/lib/sendgrid/helpers/mail/spam_check.rb

@@ -1,40 +1,20 @@
+require 'json'
+
 module SendGrid
   class SpamCheck
+    attr_accessor :enable, :threshold, :post_to_url
+
     def initialize(enable: nil, threshold: nil, post_to_url: nil)
       @enable = enable
       @threshold = threshold
       @post_to_url = post_to_url
     end
 
-    def enable=(enable)
-      @enable = enable
-    end
-
-    def enable
-      @enable
-    end
-
-    def threshold=(threshold)
-      @threshold = threshold
-    end
-
-    def threshold
-      @threshold
-    end
-
-    def post_to_url=(post_to_url)
-      @post_to_url = post_to_url
-    end
-
-    def post_to_url
-      @post_to_url
-    end
-
     def to_json(*)
       {
-        'enable' => self.enable,
-        'threshold' => self.threshold,
-        'post_to_url' => self.post_to_url
+        'enable' => enable,
+        'threshold' => threshold,
+        'post_to_url' => post_to_url
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end

data/lib/sendgrid/helpers/mail/subscription_tracking.rb

@@ -1,50 +1,22 @@
+require 'json'
+
 module SendGrid
   class SubscriptionTracking
-    def initialize(enable: nil, text: nil, html: nil, substitution_tag: nil)
-      @enable = enable
-      @text = text
-      @html = html
-      @substitution_tag = substitution_tag
-    end
+    attr_accessor :enable, :text, :html, :substitution_tag
 
-    def enable=(enable)
+    def initialize(enable: nil, text: nil, html: nil, substitution_tag: nil)
       @enable = enable
-    end
-
-    def enable
-      @enable
-    end
-
-    def text=(text)
       @text = text
-    end
-
-    def text
-      @text
-    end
-
-    def html=(html)
       @html = html
-    end
-
-    def html
-      @html
-    end
-
-    def substitution_tag=(substitution_tag)
       @substitution_tag = substitution_tag
     end
 
-    def substitution_tag
-      @substitution_tag
-    end
-
     def to_json(*)
       {
-        'enable' => self.enable,
-        'text' => self.text,
-        'html' => self.html,
-        'substitution_tag' => self.substitution_tag
+        'enable' => enable,
+        'text' => text,
+        'html' => html,
+        'substitution_tag' => substitution_tag
       }.delete_if { |_, value| value.to_s.strip == '' }
     end
   end