send_with_us 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6a246f1dd54a758295eb1b9ac7fd0d98daa6d0e5f7ffd7f6fa9a0216025ea79
-  data.tar.gz: 8cd25be4990e4c71b1670c9f6e643df17bf959503f51856c158b94e050d26ed6
+  metadata.gz: f67c0ceffafb13f25e0f582159853931f7ad80cb021c49839d42f3fe950057f9
+  data.tar.gz: fc33de35c98767fef56a58837cd00d80c8a9490e37fb90c7a7ad241854377585
 SHA512:
-  metadata.gz: 91d8aee785590e548f116dad433c0e04319eaa3fa293ae6c589f1d39e4b436630d6b14eed1c8dbe7d96c62cee379e93dd0bc0730ff4e28b1a813465a2e9ae3cd
-  data.tar.gz: dccfdd92058ab69d73856c885e3df260829ba326d5333c8842201fb8f149e8b71a32db80106b5b43112ff7fbd65829f7f769d868bd06315280a750b70c943773
+  metadata.gz: 247e986c2ed5785fd6c5a719448a57da298056a00ac6a41eb4f44813931456c749856e1ff0b026ad12225483ba4c3a70a8bfb20f7e9cd8209a1bba340919e60f
+  data.tar.gz: 1ea7ae022f32cae2ceb89da6828d3978540218f9a9a02fce7faa7fe5752ac54fa6c0ff8e6cd5977c65cb2408a9a700b319b09cd7ef7684150712fe10d6fa204c

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 4.4.0
+- **[#88](https://github.com/sendwithus/sendwithus_ruby/pull/88) Fix problematic `render` implementation.** `template_data` serves two purposes, defining template data and specifying the optional API parameter for `locale`. Previously, `locale` would be stripped out of `template_data` in the API request, preventing users from specifying variables named `locale` in their own template data.
+
 ## 4.3.0
 - Add optional `preheader` and `amp_html` fields to template calls
 

data/lib/send_with_us/api.rb

@@ -145,7 +145,7 @@ module SendWithUs
     alias list_templates emails
 
     def render(template_id, version_id = nil, template_data = {}, strict = false)
-      locale = template_data.delete(:locale)
+      locale = template_data[:locale]
 
       payload = {
         template: template_id,

data/lib/send_with_us/version.rb

@@ -1,3 +1,3 @@
 module SendWithUs
-  VERSION = '4.3.0'
+  VERSION = '4.4.0'
 end

data/test/lib/send_with_us/api_test.rb

@@ -99,4 +99,26 @@ describe SendWithUs::Api do
 
       it { subject.customer_get(email) }
   end
+
+  describe '#render' do
+    let(:locale) { 'fr-CA' }
+    let(:template_id) { 'template-id' }
+    let(:template_data) { { foo: 'bar', locale: locale } }
+    let(:strict) { true }
+    let(:version_id) { 'some-version-id' }
+
+    let(:payload) do
+      {
+        template: template_id,
+        template_data: template_data,
+        strict: strict,
+        version_id: version_id,
+        locale: locale,
+      }
+    end
+
+    before { SendWithUs::ApiRequest.any_instance.expects(:post).with(:render, payload.to_json) }
+
+    it { subject.render(template_id, version_id, template_data, strict) }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: send_with_us
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - Matt Harris
@@ -9,10 +9,10 @@ authors:
 - Nicholas Rempel
 - Gregory Schier
 - Brad Van Vugt
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-19 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -94,7 +94,7 @@ homepage: https://github.com/sendwithus/sendwithus_ruby
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -109,8 +109,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
-signing_key: 
+rubygems_version: 3.2.26
+signing_key:
 specification_version: 4
 summary: SendWithUs.com Ruby Client
 test_files: