semverve 0.3.0 → 0.4.0

data/lib/semverve/version_checks.rb

@@ -0,0 +1,518 @@
+# frozen_string_literal: true
+
+require_relative "error"
+require_relative "package_metadata"
+require_relative "rails_config_metadata"
+require_relative "version_code_references"
+require_relative "version_references"
+
+module Semverve
+  ##
+  # Registry and check adapters for version-maintenance surfaces.
+  module VersionChecks
+    class << self
+      ##
+      # Registers a core version check.
+      #
+      # @param [#name] check
+      #
+      # @return [#name]
+      def register(check)
+        core_checks[check.name] = check
+      end
+
+      ##
+      # All checks available to task dispatch and validation.
+      #
+      # @param [Array<#name>] extra_checks
+      #
+      # @return [Array<#name>]
+      def all(extra_checks: [])
+        (core_checks.values + extra_checks).each_with_object({}) do |check, checks|
+          checks[check.name] = check
+        end.values
+      end
+
+      ##
+      # Fetches a registered check by name.
+      #
+      # @param [Symbol, String] name
+      # @param [Array<#name>] extra_checks
+      #
+      # @return [#name]
+      def fetch(name, extra_checks: [])
+        normalized_name = normalize_name(name)
+        check = all(extra_checks: extra_checks).find { |candidate| candidate.name == normalized_name }
+        return check if check
+
+        raise Error, unknown_check_message([normalized_name], extra_checks: extra_checks)
+      end
+
+      ##
+      # Validates and normalizes configured check names.
+      #
+      # @param [Array<Symbol, String>] checks
+      # @param [Array<#name>] extra_checks
+      #
+      # @return [Array<Symbol>]
+      def normalize(checks, extra_checks: [])
+        normalized_checks = Array(checks).map { |check| normalize_name(check) }
+        valid_names = names(extra_checks: extra_checks)
+        return normalized_checks if normalized_checks.all? { |check| valid_names.include?(check) }
+
+        invalid_checks = normalized_checks.reject { |check| valid_names.include?(check) }
+        raise Error, unknown_check_message(invalid_checks, extra_checks: extra_checks)
+      end
+
+      ##
+      # Registered check names.
+      #
+      # @param [Array<#name>] extra_checks
+      #
+      # @return [Array<Symbol>]
+      def names(extra_checks: [])
+        all(extra_checks: extra_checks).map(&:name)
+      end
+
+      ##
+      # Default core version-maintenance surfaces for package projects.
+      #
+      # @return [Array<Symbol>]
+      def default_names
+        [:doc_references, :code_references, :package_metadata]
+      end
+
+      private
+
+      ##
+      # Core check registry.
+      #
+      # @return [Hash<Symbol, #name>]
+      def core_checks
+        @core_checks ||= {}
+      end
+
+      ##
+      # Normalizes a check name.
+      #
+      # @param [Object] name
+      #
+      # @return [Symbol, Object]
+      def normalize_name(name)
+        name.respond_to?(:to_sym) ? name.to_sym : name
+      end
+
+      ##
+      # Error message for invalid checks.
+      #
+      # @param [Array<Symbol>] invalid_checks
+      # @param [Array<#name>] extra_checks
+      #
+      # @return [String]
+      def unknown_check_message(invalid_checks, extra_checks:)
+        valid_check_names = names(extra_checks: extra_checks).map(&:inspect)
+        valid_checks = "#{valid_check_names[0...-1].join(", ")}, or #{valid_check_names.last}"
+        "Unknown version check #{invalid_checks.map(&:inspect).join(", ")}. Use #{valid_checks}."
+      end
+    end
+
+    ##
+    # Base behavior for check adapters. Public check objects must expose name,
+    # task_name, descriptions, labels, findings, and fix.
+    class Check
+      ##
+      # Whether focused task accepts an exact target version argument.
+      #
+      # @return [Boolean]
+      def targetable?
+        false
+      end
+
+      ##
+      # Whether findings should print a note when an exact target is already current.
+      #
+      # @return [Boolean]
+      def exact_target_fix_noop_notice?
+        false
+      end
+
+      ##
+      # Rake task argument names for the focused task.
+      #
+      # @return [Array<Symbol>]
+      def task_arguments
+        targetable? ? [:version] : []
+      end
+
+      ##
+      # Label used when reporting replacement counts.
+      #
+      # @return [String]
+      def fix_label
+        finding_label
+      end
+
+      ##
+      # Finds mismatches.
+      #
+      # @return [Array]
+      def findings(_configuration, _current_version, include_ignored: false, target_version: nil)
+        raise NotImplementedError
+      end
+
+      ##
+      # Fixes mismatches.
+      #
+      # @return [#changed_files, #replacement_count]
+      def fix(_configuration, _current_version, target_version: nil)
+        raise NotImplementedError
+      end
+    end
+
+    ##
+    # Documentation/reference version check.
+    class DocReferences < Check
+      ##
+      # Initializes the check.
+      #
+      # @param [Class] scanner
+      #
+      # @return [Semverve::VersionChecks::DocReferences]
+      def initialize(scanner: VersionReferences)
+        @scanner = scanner
+      end
+
+      ##
+      # Public check name used in +config.version_checks+.
+      #
+      # @return [Symbol]
+      def name
+        :doc_references
+      end
+
+      ##
+      # Focused Rake task suffix.
+      #
+      # @return [Symbol]
+      def task_name
+        :references
+      end
+
+      ##
+      # Focused check task description.
+      #
+      # @return [String]
+      def check_description
+        "Check configured files for stale version references"
+      end
+
+      ##
+      # Focused fix task description.
+      #
+      # @return [String]
+      def fix_description
+        "Replace stale version references in configured files"
+      end
+
+      ##
+      # Label printed for findings and replacement counts.
+      #
+      # @return [String]
+      def finding_label
+        "version reference"
+      end
+
+      ##
+      # Message printed when no findings or replacements exist.
+      #
+      # @return [String]
+      def clean_message
+        "Version references are current."
+      end
+
+      def targetable?
+        true
+      end
+
+      def exact_target_fix_noop_notice?
+        true
+      end
+
+      def findings(configuration, current_version, include_ignored: false, target_version: nil)
+        scanner.new(
+          configuration,
+          current_version,
+          include_ignored: include_ignored,
+          target_version: target_version
+        ).findings
+      end
+
+      def fix(configuration, current_version, target_version: nil)
+        scanner.new(configuration, current_version, target_version: target_version).fix
+      end
+
+      private
+
+      ##
+      # Scanner/fixer class used by the check.
+      #
+      # @return [Class]
+      attr_reader :scanner
+    end
+
+    ##
+    # Code literal version check.
+    class CodeReferences < Check
+      ##
+      # Initializes the check.
+      #
+      # @param [Class] scanner
+      #
+      # @return [Semverve::VersionChecks::CodeReferences]
+      def initialize(scanner: VersionCodeReferences)
+        @scanner = scanner
+      end
+
+      ##
+      # Public check name used in +config.version_checks+.
+      #
+      # @return [Symbol]
+      def name
+        :code_references
+      end
+
+      ##
+      # Focused Rake task suffix.
+      #
+      # @return [Symbol]
+      def task_name
+        :code
+      end
+
+      ##
+      # Focused check task description.
+      #
+      # @return [String]
+      def check_description
+        "Check configured code files for version literals"
+      end
+
+      ##
+      # Focused fix task description.
+      #
+      # @return [String]
+      def fix_description
+        "Replace safe code version literals in configured files"
+      end
+
+      ##
+      # Label printed for findings and replacement counts.
+      #
+      # @return [String]
+      def finding_label
+        "code version literal"
+      end
+
+      ##
+      # Message printed when no findings or replacements exist.
+      #
+      # @return [String]
+      def clean_message
+        "Code version literals are current."
+      end
+
+      def targetable?
+        true
+      end
+
+      def exact_target_fix_noop_notice?
+        true
+      end
+
+      def findings(configuration, current_version, include_ignored: false, target_version: nil)
+        scanner.new(
+          configuration,
+          current_version,
+          include_ignored: include_ignored,
+          target_version: target_version
+        ).findings
+      end
+
+      def fix(configuration, current_version, target_version: nil)
+        scanner.new(configuration, current_version, target_version: target_version).fix
+      end
+
+      private
+
+      ##
+      # Scanner/fixer class used by the check.
+      #
+      # @return [Class]
+      attr_reader :scanner
+    end
+
+    ##
+    # Package metadata version check.
+    class PackageMetadataCheck < Check
+      ##
+      # Initializes the check.
+      #
+      # @param [Class] scanner
+      #
+      # @return [Semverve::VersionChecks::PackageMetadataCheck]
+      def initialize(scanner: PackageMetadata)
+        @scanner = scanner
+      end
+
+      ##
+      # Public check name used in +config.version_checks+.
+      #
+      # @return [Symbol]
+      def name
+        :package_metadata
+      end
+
+      ##
+      # Focused Rake task suffix.
+      #
+      # @return [Symbol]
+      def task_name
+        :package_metadata
+      end
+
+      ##
+      # Focused check task description.
+      #
+      # @return [String]
+      def check_description
+        "Check package metadata for version mismatches"
+      end
+
+      ##
+      # Focused fix task description.
+      #
+      # @return [String]
+      def fix_description
+        "Fix safe package metadata version mismatches"
+      end
+
+      ##
+      # Package findings provide their own labels.
+      #
+      # @return [nil]
+      def finding_label
+        nil
+      end
+
+      def fix_label
+        "package metadata version"
+      end
+
+      ##
+      # Message printed when no findings or replacements exist.
+      #
+      # @return [String]
+      def clean_message
+        "Package metadata is current."
+      end
+
+      def findings(configuration, current_version, include_ignored: false, target_version: nil)
+        scanner.new(configuration, current_version).findings
+      end
+
+      def fix(configuration, current_version, target_version: nil)
+        scanner.new(configuration, current_version).fix
+      end
+
+      private
+
+      ##
+      # Scanner/fixer class used by the check.
+      #
+      # @return [Class]
+      attr_reader :scanner
+    end
+
+    ##
+    # Rails config metadata version check.
+    class RailsConfigMetadataCheck < Check
+      ##
+      # Initializes the check.
+      #
+      # @param [Class] scanner
+      #
+      # @return [Semverve::VersionChecks::RailsConfigMetadataCheck]
+      def initialize(scanner: RailsConfigMetadata)
+        @scanner = scanner
+      end
+
+      ##
+      # Public check name used in +config.version_checks+.
+      #
+      # @return [Symbol]
+      def name
+        :rails_config_metadata
+      end
+
+      ##
+      # Focused Rake task suffix.
+      #
+      # @return [Symbol]
+      def task_name
+        :rails_config_metadata
+      end
+
+      ##
+      # Focused check task description.
+      #
+      # @return [String]
+      def check_description
+        "Check Rails config metadata for version mismatches"
+      end
+
+      ##
+      # Focused fix task description.
+      #
+      # @return [String]
+      def fix_description
+        "Fix safe Rails config metadata version mismatches"
+      end
+
+      ##
+      # Label printed for Rails config metadata findings and replacements.
+      #
+      # @return [String]
+      def finding_label
+        "Rails config version"
+      end
+
+      ##
+      # Message printed when no findings or replacements exist.
+      #
+      # @return [String]
+      def clean_message
+        "Rails config metadata is current."
+      end
+
+      def findings(configuration, current_version, include_ignored: false, target_version: nil)
+        scanner.new(configuration, current_version).findings
+      end
+
+      def fix(configuration, current_version, target_version: nil)
+        scanner.new(configuration, current_version).fix
+      end
+
+      private
+
+      ##
+      # Scanner/fixer class used by the check.
+      #
+      # @return [Class]
+      attr_reader :scanner
+    end
+  end
+end
+
+Semverve::VersionChecks.register(Semverve::VersionChecks::DocReferences.new)
+Semverve::VersionChecks.register(Semverve::VersionChecks::CodeReferences.new)
+Semverve::VersionChecks.register(Semverve::VersionChecks::PackageMetadataCheck.new)

data/lib/semverve/version_code_references.rb

@@ -1,8 +1,11 @@
 # frozen_string_literal: true
 
-require_relative "configuration"
 require_relative "file_list_resolver"
+require_relative "finding"
+require_relative "fix_result"
 require_relative "semantic_version"
+require_relative "version_literal_rewriter"
+require_relative "version_match_policy"
 
 module Semverve
   ##
@@ -18,79 +21,7 @@ module Semverve
     # Ruby assignments that are safe enough to rewrite automatically.
     #
     # @return [Regexp]
-    RUBY_ASSIGNMENT_PATTERN = Configuration::DEFAULT_VERSION_CODE_REFERENCE_PATTERN
-
-    ##
-    # A code version literal found in a configured file.
-    class Finding
-      ##
-      # Path relative to the configured project root.
-      #
-      # @return [String]
-      attr_reader :path
-
-      ##
-      # One-based line number.
-      #
-      # @return [Integer]
-      attr_reader :line
-
-      ##
-      # One-based column number.
-      #
-      # @return [Integer]
-      attr_reader :column
-
-      ##
-      # Referenced semantic version.
-      #
-      # @return [Semverve::SemanticVersion]
-      attr_reader :version
-
-      ##
-      # Initializes a finding.
-      #
-      # @param [String] path
-      # @param [Integer] line
-      # @param [Integer] column
-      # @param [Semverve::SemanticVersion] version
-      #
-      # @return [Semverve::VersionCodeReferences::Finding]
-      def initialize(path:, line:, column:, version:)
-        @path = path
-        @line = line
-        @column = column
-        @version = version
-      end
-    end
-
-    ##
-    # Result of fixing code version literals.
-    class FixResult
-      ##
-      # Files changed by the fix.
-      #
-      # @return [Array<String>]
-      attr_reader :changed_files
-
-      ##
-      # Number of replacements made.
-      #
-      # @return [Integer]
-      attr_reader :replacement_count
-
-      ##
-      # Initializes a fix result.
-      #
-      # @param [Array<String>] changed_files
-      # @param [Integer] replacement_count
-      #
-      # @return [Semverve::VersionCodeReferences::FixResult]
-      def initialize(changed_files:, replacement_count:)
-        @changed_files = changed_files
-        @replacement_count = replacement_count
-      end
-    end
+    RUBY_ASSIGNMENT_PATTERN = /^\s*(?:(?:[A-Z]\w*::)*(?:[A-Z]\w*VERSION[A-Z0-9_]*|VERSION)|(?:[a-z_]\w*|self)\.version)\s*=\s*(?<quote>["'])(?<version>\d+\.\d+\.\d+)\k<quote>/
 
     ##
     # Initializes code version literal scanning.
@@ -109,7 +40,7 @@ module Semverve
     ##
     # Code version literal findings in configured files.
     #
-    # @return [Array<Semverve::VersionCodeReferences::Finding>]
+    # @return [Array<Semverve::Finding>]
     def findings
       files.flat_map { |path| findings_for_file(path) }
     end
@@ -117,7 +48,7 @@ module Semverve
     ##
     # Replaces found code version literals with the current version.
     #
-    # @return [Semverve::VersionCodeReferences::FixResult]
+    # @return [Semverve::FixResult]
     def fix
       changed_files = []
       replacement_count = 0
@@ -133,7 +64,7 @@ module Semverve
         replacement_count += count
       end
 
-      FixResult.new(changed_files: changed_files, replacement_count: replacement_count)
+      Semverve::FixResult.new(changed_files: changed_files, replacement_count: replacement_count)
     end
 
     private
@@ -194,7 +125,7 @@ module Semverve
     #
     # @param [String] path
     #
-    # @return [Array<Semverve::VersionCodeReferences::Finding>]
+    # @return [Array<Semverve::Finding>]
     def findings_for_file(path)
       lines = File.readlines(path)
 
@@ -207,7 +138,7 @@ module Semverve
         version = SemanticVersion.parse(match[:version])
         next unless report?(version)
 
-        Finding.new(
+        Semverve::Finding.new(
           path: relative_path(path),
           line: line_number,
           column: match.begin(:version) + 1,
@@ -268,14 +199,7 @@ module Semverve
     def report?(version)
       return version == target_version if target_version
 
-      case configuration.version_match_mode
-      when :older
-        version < current_version
-      when :non_current
-        version != current_version
-      else
-        raise Error, "Unknown version match mode #{configuration.version_match_mode.inspect}. Use :older or :non_current."
-      end
+      match_policy.report?(version)
     end
 
     ##
@@ -285,13 +209,7 @@ module Semverve
     #
     # @return [String]
     def replace_matched_version(line)
-      line.sub(pattern) do |matched_text|
-        match = Regexp.last_match
-        version_start = match.begin(:version) - match.begin(0)
-        version_end = match.end(:version) - match.begin(0)
-
-        "#{matched_text[0...version_start]}#{current_version}#{matched_text[version_end..]}"
-      end
+      literal_rewriter.rewrite(line)
     end
 
     ##
@@ -303,5 +221,25 @@ module Semverve
     def relative_path(path)
       path.delete_prefix("#{root}/")
     end
+
+    ##
+    # Version matching behavior for code literals.
+    #
+    # @return [Semverve::VersionMatchPolicy]
+    def match_policy
+      @match_policy ||= VersionMatchPolicy.new(
+        current_version: current_version,
+        match_mode: configuration.version_match_mode,
+        target_version: target_version
+      )
+    end
+
+    ##
+    # Safe literal rewriter for the configured pattern.
+    #
+    # @return [Semverve::VersionLiteralRewriter]
+    def literal_rewriter
+      @literal_rewriter ||= VersionLiteralRewriter.new(pattern: pattern, replacement: current_version)
+    end
   end
 end