semverve 0.2.1 → 0.4.0

data/lib/semverve/{version_metadata.rb → package_metadata.rb}

@@ -1,14 +1,15 @@
 # frozen_string_literal: true
 
-require "bundler"
 require "rubygems"
 
+require_relative "finding"
+require_relative "fix_result"
 require_relative "semantic_version"
 
 module Semverve
   ##
-  # Checks generated gem metadata against the configured version file.
-  class VersionMetadata
+  # Checks generated package metadata against the configured version file.
+  class PackageMetadata
     ##
     # Literal gemspec version assignments that can be safely rewritten.
     #
@@ -16,117 +17,29 @@ module Semverve
     GEMSPEC_LITERAL_PATTERN = /^(\s*\w+\.version\s*=\s*)(["'])(\d+\.\d+\.\d+)(\2)/
 
     ##
-    # A metadata version mismatch.
-    class Finding
-      ##
-      # Path relative to the configured project root.
-      #
-      # @return [String]
-      attr_reader :path
-
-      ##
-      # One-based line number.
-      #
-      # @return [Integer]
-      attr_reader :line
-
-      ##
-      # One-based column number.
-      #
-      # @return [Integer]
-      attr_reader :column
-
-      ##
-      # Metadata semantic version.
-      #
-      # @return [Semverve::SemanticVersion]
-      attr_reader :version
-
-      ##
-      # Output label for the finding.
-      #
-      # @return [String]
-      attr_reader :label
-
-      ##
-      # Initializes a finding.
-      #
-      # @param [String] path
-      # @param [Integer] line
-      # @param [Integer] column
-      # @param [Semverve::SemanticVersion] version
-      # @param [String] label
-      #
-      # @return [Semverve::VersionMetadata::Finding]
-      def initialize(path:, line:, column:, version:, label:)
-        @path = path
-        @line = line
-        @column = column
-        @version = version
-        @label = label
-      end
-    end
-
-    ##
-    # Result of fixing metadata version mismatches.
-    class FixResult
-      ##
-      # Files changed by the fix.
-      #
-      # @return [Array<String>]
-      attr_reader :changed_files
-
-      ##
-      # Number of literal replacements made.
-      #
-      # @return [Integer]
-      attr_reader :replacement_count
-
-      ##
-      # Whether bundle lock was run.
-      #
-      # @return [Boolean]
-      attr_reader :bundle_lock_ran
-
-      ##
-      # Initializes a fix result.
-      #
-      # @param [Array<String>] changed_files
-      # @param [Integer] replacement_count
-      # @param [Boolean] bundle_lock_ran
-      #
-      # @return [Semverve::VersionMetadata::FixResult]
-      def initialize(changed_files:, replacement_count:, bundle_lock_ran:)
-        @changed_files = changed_files
-        @replacement_count = replacement_count
-        @bundle_lock_ran = bundle_lock_ran
-      end
-    end
-
-    ##
-    # Initializes metadata version checking.
+    # Initializes package metadata version checking.
     #
     # @param [Semverve::ResolvedConfiguration] configuration
     # @param [Semverve::SemanticVersion] current_version
     #
-    # @return [Semverve::VersionMetadata]
+    # @return [Semverve::PackageMetadata]
     def initialize(configuration, current_version)
       @configuration = configuration
       @current_version = current_version
     end
 
     ##
-    # Metadata mismatches.
+    # Package metadata mismatches.
     #
-    # @return [Array<Semverve::VersionMetadata::Finding>]
+    # @return [Array<Semverve::Finding>]
     def findings
       [gemspec_finding, lockfile_finding].compact
     end
 
     ##
-    # Fixes safe metadata mismatches.
+    # Fixes safe package metadata mismatches.
     #
-    # @return [Semverve::VersionMetadata::FixResult]
+    # @return [Semverve::FixResult]
     def fix
       changed_files = []
       replacement_count = fix_gemspec_literal
@@ -135,7 +48,7 @@ module Semverve
 
       bundle_lock_ran = lockfile_finding ? run_bundle_lock : false
 
-      FixResult.new(
+      Semverve::FixResult.new(
         changed_files: changed_files,
         replacement_count: replacement_count,
         bundle_lock_ran: bundle_lock_ran
@@ -151,7 +64,7 @@ module Semverve
     attr_reader :configuration
 
     ##
-    # Current gem version.
+    # Current package version.
     #
     # @return [Semverve::SemanticVersion]
     attr_reader :current_version
@@ -167,14 +80,14 @@ module Semverve
     ##
     # Finding for a gemspec mismatch.
     #
-    # @return [Semverve::VersionMetadata::Finding, nil]
+    # @return [Semverve::Finding, nil]
     def gemspec_finding
       return unless gemspec_file && gemspec_version
       return if gemspec_version == current_version
 
       line, column = gemspec_position
 
-      Finding.new(
+      Semverve::Finding.new(
         path: relative_path(gemspec_file),
         line: line,
         column: column,
@@ -186,7 +99,7 @@ module Semverve
     ##
     # Finding for a lockfile mismatch.
     #
-    # @return [Semverve::VersionMetadata::Finding, nil]
+    # @return [Semverve::Finding, nil]
     def lockfile_finding
       return unless File.file?(lockfile_path)
 
@@ -196,7 +109,7 @@ module Semverve
 
       line, column = lockfile_position(version)
 
-      Finding.new(
+      Semverve::Finding.new(
         path: "Gemfile.lock",
         line: line,
         column: column,
@@ -210,6 +123,8 @@ module Semverve
     #
     # @return [String, nil]
     def gemspec_file
+      return unless configuration.gem_name
+
       @gemspec_file ||= begin
         files = Dir.glob(File.join(root, "*.gemspec"))
 
@@ -271,18 +186,14 @@ module Semverve
     #
     # @return [Semverve::SemanticVersion, nil]
     def lockfile_version
-      spec = lockfile_parser.specs.find { |candidate| candidate.name == configuration.gem_name }
-      return unless spec
+      return unless configuration.gem_name
 
-      SemanticVersion.parse(spec.version.to_s)
-    end
+      File.readlines(lockfile_path).each do |line|
+        match = line.match(lockfile_line_pattern)
+        return SemanticVersion.parse(match[:version]) if match
+      end
 
-    ##
-    # Parsed Gemfile.lock.
-    #
-    # @return [Bundler::LockfileParser]
-    def lockfile_parser
-      Bundler::LockfileParser.new(File.read(lockfile_path))
+      nil
     end
 
     ##
@@ -292,16 +203,25 @@ module Semverve
     #
     # @return [Array(Integer, Integer)]
     def lockfile_position(version)
-      pattern = /^\s*#{Regexp.escape(configuration.gem_name)}\s+\(#{Regexp.escape(version.to_s)}\)/
-
       File.readlines(lockfile_path).each_with_index do |line, index|
-        match = line.match(pattern)
+        match = line.match(lockfile_line_pattern(version))
         return [index + 1, line.index(version.to_s) + 1] if match
       end
 
       [1, 1]
     end
 
+    ##
+    # Gemfile.lock line pattern for the configured package.
+    #
+    # @param [Semverve::SemanticVersion, nil] version
+    #
+    # @return [Regexp]
+    def lockfile_line_pattern(version = nil)
+      version_pattern = version ? Regexp.escape(version.to_s) : "\\d+\\.\\d+\\.\\d+"
+      /^\s*#{Regexp.escape(configuration.gem_name)}\s+\((?<version>#{version_pattern})\)/
+    end
+
     ##
     # Fixes a literal gemspec version assignment.
     #

data/lib/semverve/presets.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require_relative "error"
+require_relative "adapters"
 
 module Semverve
   ##
-  # Framework-specific default configuration adapters.
+  # Backward-compatible framework preset lookup.
   module Presets
     ##
     # Returns defaults for a configured preset.
@@ -14,9 +14,7 @@ module Semverve
     #
     # @return [Hash]
     def self.defaults_for(name, configuration)
-      return {} unless name
-
-      fetch(name).defaults(configuration)
+      Adapters.defaults_for(name, configuration)
     end
 
     ##
@@ -26,101 +24,7 @@ module Semverve
     #
     # @return [#name, #defaults]
     def self.fetch(name)
-      case name.to_sym
-      when :rails
-        Rails.new
-      else
-        raise Error, "Unknown preset #{name.inspect}. Use :rails."
-      end
-    end
-
-    ##
-    # Rails application defaults.
-    class Rails
-      ##
-      # Preset name.
-      #
-      # @return [Symbol]
-      def name
-        :rails
-      end
-
-      ##
-      # Rails-specific Semverve defaults.
-      #
-      # @param [Semverve::Configuration] _configuration
-      #
-      # @return [Hash]
-      def defaults(_configuration)
-        root = rails_root || Dir.pwd
-
-        {
-          format: :simple,
-          module_name: rails_module_name || project_module_name(root),
-          root: root,
-          version_file: File.join("config", "version.rb")
-        }
-      end
-
-      private
-
-      ##
-      # Rails.root when Rails is available.
-      #
-      # @return [String, nil]
-      def rails_root
-        return unless rails_defined?
-        return unless ::Rails.respond_to?(:root)
-        return unless ::Rails.root
-
-        ::Rails.root.to_s
-      end
-
-      ##
-      # Application module name inferred from Rails.application.
-      #
-      # @return [String, nil]
-      def rails_module_name
-        return unless rails_defined?
-        return unless ::Rails.respond_to?(:application)
-        return unless ::Rails.application
-
-        application_class = ::Rails.application.class
-        return application_class.module_parent_name if application_class.respond_to?(:module_parent_name)
-
-        class_name = application_class.name
-        return unless class_name&.include?("::")
-
-        class_name.split("::").first
-      end
-
-      ##
-      # Module name fallback based on the project directory.
-      #
-      # @param [String] root
-      #
-      # @return [String]
-      def project_module_name(root)
-        camelize(File.basename(File.expand_path(root)))
-      end
-
-      ##
-      # Whether Rails is loaded.
-      #
-      # @return [Boolean]
-      def rails_defined?
-        Object.const_defined?(:Rails)
-      end
-
-      ##
-      # Converts a project directory into a Ruby module name.
-      #
-      # @param [String] value
-      #
-      # @return [String]
-      def camelize(value)
-        value.split(/[_-]/).map(&:capitalize).join
-      end
+      Adapters.fetch(name)
     end
   end
 end

data/lib/semverve/project_metadata.rb

@@ -4,7 +4,7 @@ require_relative "error"
 
 module Semverve
   ##
-  # Infers gem metadata from explicit configuration or project files.
+  # Infers project metadata from explicit configuration or project files.
   class ProjectMetadata
     ##
     # Initializes project metadata inference.
@@ -18,9 +18,12 @@ module Semverve
 
     ##
     # Gem name from explicit config, the version-file path, or the gemspec.
+    # App adapters can disable package-name inference.
     #
-    # @return [String]
+    # @return [String, nil]
     def gem_name
+      return explicit_gem_name || configured_gem_name unless configuration.infer_package_name?
+
       explicit_gem_name || configured_version_file_gem_name || gemspec_name
     end
 
@@ -57,7 +60,7 @@ module Semverve
     end
 
     ##
-    # Configured gem name after applying presets.
+    # Configured gem name after applying adapters.
     #
     # @return [String, nil]
     def configured_gem_name
@@ -73,7 +76,7 @@ module Semverve
     end
 
     ##
-    # Configured Ruby module name after applying presets.
+    # Configured Ruby module name after applying adapters.
     #
     # @return [String, nil]
     def configured_module_name
@@ -81,7 +84,7 @@ module Semverve
     end
 
     ##
-    # Configured version-file path after applying presets.
+    # Configured version-file path after applying adapters.
     #
     # @return [String, nil]
     def configured_version_file

data/lib/semverve/rails_config_metadata.rb

@@ -0,0 +1,176 @@
+# frozen_string_literal: true
+
+require "rake"
+
+require_relative "file_list_resolver"
+require_relative "finding"
+require_relative "fix_result"
+require_relative "semantic_version"
+require_relative "version_literal_rewriter"
+require_relative "version_match_policy"
+
+module Semverve
+  ##
+  # Finds and updates Rails-native config version literals.
+  class RailsConfigMetadata
+    ##
+    # Default Rails config file patterns that can expose an app version.
+    #
+    # @return [Array<String>]
+    DEFAULT_FILE_PATTERNS = [
+      "config/application.rb",
+      "config/environments/*.rb",
+      "config/initializers/**/*.rb"
+    ].freeze
+
+    ##
+    # Rails config version assignments that are safe to rewrite.
+    #
+    # @return [Regexp]
+    VERSION_PATTERN = /^\s*(?:Rails\.application\.)?config\.x\.version\s*=\s*(?<quote>["'])(?<version>\d+\.\d+\.\d+)\k<quote>/
+
+    ##
+    # Initializes Rails config metadata scanning.
+    #
+    # @param [Semverve::ResolvedConfiguration] configuration
+    # @param [Semverve::SemanticVersion] current_version
+    #
+    # @return [Semverve::RailsConfigMetadata]
+    def initialize(configuration, current_version)
+      @configuration = configuration
+      @current_version = current_version
+    end
+
+    ##
+    # Rails config metadata findings.
+    #
+    # @return [Array<Semverve::Finding>]
+    def findings
+      files.flat_map { |path| findings_for_file(path) }
+    end
+
+    ##
+    # Replaces safe stale Rails config version literals with the current version.
+    #
+    # @return [Semverve::FixResult]
+    def fix
+      changed_files = []
+      replacement_count = 0
+
+      files.each do |path|
+        content = File.read(path)
+        fixed, count = fixed_content(content)
+
+        next if count.zero?
+
+        File.write(path, fixed)
+        changed_files << relative_path(path)
+        replacement_count += count
+      end
+
+      Semverve::FixResult.new(changed_files: changed_files, replacement_count: replacement_count)
+    end
+
+    private
+
+    ##
+    # Resolved Semverve configuration.
+    #
+    # @return [Semverve::ResolvedConfiguration]
+    attr_reader :configuration
+
+    ##
+    # Current app version.
+    #
+    # @return [Semverve::SemanticVersion]
+    attr_reader :current_version
+
+    ##
+    # Absolute configured project root.
+    #
+    # @return [String]
+    def root
+      configuration.root
+    end
+
+    ##
+    # Absolute files to scan.
+    #
+    # @return [Array<String>]
+    def files
+      @files ||= FileListResolver.new(root: root, file_list: Rake::FileList[*DEFAULT_FILE_PATTERNS]).files
+    end
+
+    ##
+    # Findings for a single file.
+    #
+    # @param [String] path
+    #
+    # @return [Array<Semverve::Finding>]
+    def findings_for_file(path)
+      File.readlines(path).filter_map.with_index(1) do |line, line_number|
+        match = line.match(VERSION_PATTERN)
+        next unless match
+
+        version = SemanticVersion.parse(match[:version])
+        next unless match_policy.report?(version)
+
+        Semverve::Finding.new(
+          path: relative_path(path),
+          line: line_number,
+          column: match.begin(:version) + 1,
+          version: version
+        )
+      end
+    end
+
+    ##
+    # Fixed content and replacement count.
+    #
+    # @param [String] content
+    #
+    # @return [Array(String, Integer)]
+    def fixed_content(content)
+      replacement_count = 0
+
+      fixed = content.lines.map do |line|
+        match = line.match(VERSION_PATTERN)
+        next line unless match
+
+        version = SemanticVersion.parse(match[:version])
+        next line unless match_policy.report?(version)
+
+        replacement_count += 1
+        literal_rewriter.rewrite(line)
+      end.join
+
+      [fixed, replacement_count]
+    end
+
+    ##
+    # Path relative to the project root.
+    #
+    # @param [String] path
+    #
+    # @return [String]
+    def relative_path(path)
+      path.delete_prefix("#{root}/")
+    end
+
+    ##
+    # Rails config metadata always requires an exact current-version match.
+    #
+    # @return [Semverve::VersionMatchPolicy]
+    def match_policy
+      @match_policy ||= VersionMatchPolicy.new(current_version: current_version, match_mode: :non_current)
+    end
+
+    ##
+    # Safe literal rewriter for Rails config metadata.
+    #
+    # @return [Semverve::VersionLiteralRewriter]
+    def literal_rewriter
+      @literal_rewriter ||= VersionLiteralRewriter.new(pattern: VERSION_PATTERN, replacement: current_version)
+    end
+  end
+end

data/lib/semverve/railtie.rb

@@ -7,7 +7,7 @@ module Semverve
   # Rails integration for installing Semverve's Rake tasks.
   class Railtie < ::Rails::Railtie
     rake_tasks do
-      Semverve.configuration.preset = :rails unless Semverve.configuration.preset
+      Semverve.configuration.adapter = :rails unless Semverve.configuration.adapter
 
       require_relative "task"
       Semverve::Task.install