semver_dialects 3.4.2 → 3.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 710e6a3a8fe698a7871ead1a3226d6a60d5edd17a0308933cd32107d79811605
-  data.tar.gz: 46598d990561c189be8022b5edb3cffd96ba8d16ce83380da64f76fb35576295
+  metadata.gz: 155e773f43becb03ca24d66e5aef3db7c52a997e2ecbfe6e7d8c8405724fb8c8
+  data.tar.gz: 8bdd87a9dcfc0ba226c6e9730ad736613088ffd502ae77a17ca98cc9cd5a7e2d
 SHA512:
-  metadata.gz: ba99632bcf1df6b5e16b66c2f83800594df1a296605bca5b04fb2854856f6ad76bda1c6b43f2e5589f3b10b47542bbf3b9b59c3bd8a44c9b64c009622117c945
-  data.tar.gz: ee15977caaa5cd9ba22e752892795c9e2648b615c6deca5fc4b732b40ed655ad892a465d079dc6423cf4a7cc9715f4a648f2be1bf783b5670723437e66422a76
+  metadata.gz: d228adf7320bdfb6a418dfa8750305ab984c3abc2bbd992e2e027f942d16e983b2ba822d7504671be82ce0f5fe7ad8c51613233370965606b4b36b6d1d288971
+  data.tar.gz: cae052e840d2763415d9d725edc30f03437e71778aed69e3659b9e632ed9ba0b8826f9aab0fdf72a9f610778dbd648845a0a90ebbb6377180b2ad9e92d18c763

data/lib/semver_dialects/apk.rb

@@ -13,7 +13,7 @@ module SemverDialects
 
       attr_reader :tokens, :pre_release, :post_release, :revision
 
-      def initialize(tokens, pre_release: [], post_release: [], revision: [])
+      def initialize(tokens, pre_release: [], post_release: [], revision: []) # rubocop:todo Lint/MissingSuper
         @tokens = tokens
         @pre_release = pre_release
         @post_release = post_release
@@ -51,7 +51,7 @@ module SemverDialects
 
       # Token can be either integer or string
       # Precedence: numeric token > string token > no token
-      def compare_token_pair(a, b)
+      def compare_token_pair(a, b) # rubocop:todo Naming/MethodParameterName
         return 1 if !a.nil? && b.nil?
         return -1 if a.nil? && !b.nil?
 
@@ -64,7 +64,7 @@ module SemverDialects
 
       # Precedence: post-release > no release > pre-release
       # https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#pkgver
-      def compare_pre_release(a, b)
+      def compare_pre_release(a, b) # rubocop:todo Naming/MethodParameterName
         return 0 if a.empty? && b.empty?
         return -1 if !a.empty? && b.empty?
         return 1 if a.empty? && !b.empty?
@@ -74,7 +74,7 @@ module SemverDialects
 
       # Precedence: post-release > no release > pre-release
       # https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#pkgver
-      def compare_post_release(a, b)
+      def compare_post_release(a, b) # rubocop:todo Naming/MethodParameterName
         return 0 if a.empty? && b.empty?
         return 1 if !a.empty? && b.empty?
         return -1 if a.empty? && !b.empty?
@@ -86,7 +86,7 @@ module SemverDialects
       # Post-release precedence: cvs < svn < git < hg < p
       # Precedence for releases with number eg alpha1:
       # release without number < release with number
-      def compare_suffix(a, b, order)
+      def compare_suffix(a, b, order) # rubocop:todo Naming/MethodParameterName
         a_suffix = order[a[0]]
         b_suffix = order[b[0]]
 
@@ -102,7 +102,7 @@ module SemverDialects
         (a_value || 0) <=> (b_value || 0)
       end
 
-      def compare_revisions(a, b)
+      def compare_revisions(a, b) # rubocop:todo Naming/MethodParameterName
         return 0 if a.empty? && b.empty?
         return 1 if !a.empty? && b.empty?
         return -1 if a.empty? && !b.empty?
@@ -117,7 +117,7 @@ module SemverDialects
       end
     end
 
-    class VersionParser
+    class VersionParser # rubocop:todo Style/Documentation
       DASH = /-/
       ALPHABETS = /([a-zA-Z]+)/
       DIGITS = /([0-9]+)/
@@ -217,6 +217,8 @@ module SemverDialects
               @post_release << s.to_i
               return
             end
+          else
+            raise SemverDialects::InvalidVersionError, input
           end
         end
       end
@@ -234,6 +236,8 @@ module SemverDialects
           when (s = scanner.scan(DIGITS))
             @revision << s.to_i
             return
+          else
+            raise SemverDialects::InvalidVersionError, input
           end
         end
       end

data/lib/semver_dialects/base_version.rb

@@ -18,7 +18,7 @@
 # by implementing specific token classes.
 #
 module SemverDialects
-  class BaseVersion
+  class BaseVersion # rubocop:todo Style/Documentation
     include Comparable
 
     attr_reader :tokens, :addition
@@ -36,14 +36,14 @@ module SemverDialects
 
     def <=>(other)
       cmp = compare_tokens(tokens, other.tokens)
-      return cmp unless cmp == 0
+      return cmp unless cmp.zero?
 
       compare_additions(addition, other.addition)
     end
 
     # Returns true if the version tokens are equivalent to zero
     # and the addition is also equivalent to zero.
-    def is_zero?
+    def is_zero? # rubocop:todo Naming/PredicateName
       return false if compare_tokens(tokens, [0]) != 0
 
       return true if addition.nil?
@@ -57,7 +57,7 @@ module SemverDialects
       max_idx = [a.size, b.size].max - 1
       (0..max_idx).each do |idx|
         cmp = compare_token_pair(a[idx], b[idx])
-        return cmp unless cmp == 0
+        return cmp unless cmp.zero?
       end
       0
     end

data/lib/semver_dialects/boundary.rb

@@ -4,7 +4,7 @@
 # It can either be above all versions (infinity),
 # below all versions (negative infinity), or any version.
 module SemverDialects
-  class Boundary
+  class Boundary # rubocop:todo Style/Documentation
     include Comparable
 
     attr_accessor :semver
@@ -25,7 +25,7 @@ module SemverDialects
       semver <=> other.semver
     end
 
-    def is_initial_version?
+    def is_initial_version? # rubocop:todo Naming/PredicateName
       @semver.is_zero?
     end
   end
@@ -34,13 +34,13 @@ module SemverDialects
   # When used as the lower boundary of an interval, any version
   # that is smaller than the upper boundary is in the interval.
   class BelowAll < Boundary
-    def initialize; end
+    def initialize; end # rubocop:todo Lint/MissingSuper
 
     def to_s
       '-inf'
     end
 
-    def is_initial_version?
+    def is_initial_version? # rubocop:todo Naming/PredicateName
       false
     end
 
@@ -55,13 +55,13 @@ module SemverDialects
   # When used as the upper boundary of an interval, any version
   # that is greater than the lower boundary is in the interval.
   class AboveAll < Boundary
-    def initialize; end
+    def initialize; end # rubocop:todo Lint/MissingSuper
 
     def to_s
       '+inf'
     end
 
-    def is_initial_version?
+    def is_initial_version? # rubocop:todo Naming/PredicateName
       false
     end
 

data/lib/semver_dialects/commands/check_version.rb

@@ -7,7 +7,7 @@ module SemverDialects
   module Commands
     # The check version command implementation
     class CheckVersion < SemverDialects::Command
-      def initialize(type, version, constraint, options)
+      def initialize(type, version, constraint, options) # rubocop:todo Lint/MissingSuper
         @type = type
         @version = version
         @constraint = constraint

data/lib/semver_dialects/interval.rb

@@ -32,7 +32,7 @@ module SemverDialects
 
       # this look odd -- we have to use it here though, because it may be that placeholders are present inside
       # the version for which > and < would yield true
-      return EmptyInterval.new if !(@start_cut <= other_interval.end_cut) || !(other_interval.start_cut <= @end_cut)
+      return EmptyInterval.new if @start_cut > other_interval.end_cut || other_interval.start_cut > @end_cut
 
       start_cut_new = max(@start_cut, other_interval.start_cut)
       end_cut_new = min(@end_cut, other_interval.end_cut)
@@ -123,7 +123,9 @@ module SemverDialects
     end
 
     def universal?
-      (bit_set?(IntervalType::LEFT_OPEN) && bit_set?(IntervalType::RIGHT_OPEN) && @start_cut.instance_of?(BelowAll) && @end_cut.instance_of?(AboveAll)) || @start_cut.is_initial_version? && @end_cut.instance_of?(AboveAll)
+      (bit_set?(IntervalType::LEFT_OPEN) && bit_set?(IntervalType::RIGHT_OPEN) &&
+        @start_cut.instance_of?(BelowAll) && @end_cut.instance_of?(AboveAll)) ||
+        @start_cut.is_initial_version? && @end_cut.instance_of?(AboveAll)
     end
 
     def to_gem_s
@@ -181,7 +183,7 @@ module SemverDialects
                        IntervalType::RIGHT_OPEN)
     end
 
-    def compute_boundary(interval_a, interval_b, start_cut_new, end_cut_new, left_check, right_check)
+    def compute_boundary(interval_a, interval_b, start_cut_new, end_cut_new, left_check, right_check) # rubocop:disable Metrics/ParameterLists
       start_cut_a = interval_a.start_cut
       end_cut_a = interval_a.end_cut
       type_a = interval_a.type
@@ -211,7 +213,7 @@ module SemverDialects
       left_type | right_type
     end
 
-    def get_canoncial_s(delimiter = ' ', eq = '=')
+    def get_canoncial_s(delimiter = ' ', eq = '=') # rubocop:todo Naming/MethodParameterName
       if distinct?
         "#{eq}#{@start_cut}"
       else
@@ -250,8 +252,8 @@ module SemverDialects
     end
   end
 
-  class EmptyInterval < Interval
-    def initialize; end
+  class EmptyInterval < Interval # rubocop:todo Style/Documentation
+    def initialize; end # rubocop:todo Lint/MissingSuper
 
     def to_s
       'empty'

data/lib/semver_dialects/interval_parser.rb

@@ -15,9 +15,9 @@
 # that's been detected.
 #
 module SemverDialects
-  module IntervalParser
-    # A constraint is made of an operator followed by a version string.
-    # Use the regular expression of the SemanticVersion because this is the most generic one.
+  module IntervalParser # rubocop:todo Style/Documentation
+    # Version string validation is only validated not to be white space.
+    # All other version validation is delegated to the version parsers.
     CONSTRAINT_REGEXP = Regexp.new('(?<op>[><=]+)\s*(?<version>[^\s]+)').freeze
 
     def self.parse(typ, versionstring)

data/lib/semver_dialects/interval_set.rb

@@ -4,7 +4,7 @@
 # It can express a range like "[1.0,2.0],[3.0,4.0]" (Maven syntax),
 # that is between 1.0 and 2.0 (included) OR between 3.0 and 4.0 (included).
 module SemverDialects
-  class IntervalSet
+  class IntervalSet # rubocop:todo Style/Documentation
     attr_reader :intervals
 
     def initialize

data/lib/semver_dialects/interval_set_parser.rb

@@ -3,7 +3,7 @@
 # IntervalSetParser parses a string that represents an interval set
 # in a syntax that's specific to a package type.
 module SemverDialects
-  module IntervalSetParser
+  module IntervalSetParser # rubocop:todo Style/Documentation
     # parse parses a string and returns an IntervalSet.
     # The string is expected to be in a syntax that's specific the given package type.
     def self.parse(typ, interval_set_string)

data/lib/semver_dialects/maven.rb

@@ -11,7 +11,7 @@ module SemverDialects
     SNAPSHOT = -1
     SP = 'sp'
 
-    class Version < BaseVersion
+    class Version < BaseVersion # rubocop:todo Style/Documentation
       attr_accessor :addition
 
       # Return an array similar to the one Maven generates when parsing versions.
@@ -26,7 +26,7 @@ module SemverDialects
         tokens.clone.append(addition.to_a)
       end
 
-      def to_s(as_addition = false)
+      def to_s(as_addition = false) # rubocop:disable Style/OptionalBooleanParameter
         s = ''
         if tokens.any?
           s += '-' if as_addition
@@ -63,7 +63,7 @@ module SemverDialects
       # Special qualifier "sp" is right after GA and before any lexical or numeric token.
       # Strings should be converted to lower case before being compared by this method.
       # 1-a0 == 1-alpha < 1-0 == 1 == 1final == 1 ga < 1sp < 1-a < 1-1
-      def compare_token_pair(a = 0, b = 0)
+      def compare_token_pair(a = 0, b = 0) # rubocop:todo Naming/MethodParameterName
         a ||= 0
         b ||= 0
 
@@ -89,7 +89,7 @@ module SemverDialects
       end
     end
 
-    class VersionParser
+    class VersionParser # rubocop:todo Style/Documentation
       def self.parse(input)
         new(input).parse
       end
@@ -105,6 +105,9 @@ module SemverDialects
         @version = Version.new([])
         @result = @version
         parse_version(false)
+
+        raise InvalidVersionError, input if @result.to_a.empty?
+
         result
       end
 

data/lib/semver_dialects/rpm.rb

@@ -4,11 +4,11 @@ require 'strscan'
 
 module SemverDialects
   module Rpm
-    module TokenPairComparison
+    module TokenPairComparison # rubocop:todo Style/Documentation
       # Token can be either alphabets, integers or tilde.
       # Caret is currently not supported. More details here https://gitlab.com/gitlab-org/gitlab/-/issues/428941#note_1882343489
       # Precedence: numeric token > string token > no token > tilda (~)
-      def compare_token_pair(a, b)
+      def compare_token_pair(a, b) # rubocop:todo Naming/MethodParameterName
         return 1 if a != '~' && b == '~'
         return -1 if a == '~' && b != '~'
 
@@ -24,7 +24,8 @@ module SemverDialects
     end
 
     # This implementation references `go-rpm-version` https://github.com/knqyf263/go-rpm-version
-    # Which is based on the official `rpmvercmp` https://github.com/rpm-software-management/rpm/blob/master/rpmio/rpmvercmp.c implementation
+    # Which is based on the official `rpmvercmp`
+    # https://github.com/rpm-software-management/rpm/blob/master/rpmio/rpmvercmp.c implementation
     # rpm versioning schema can be found here https://github.com/rpm-software-management/rpm/blob/master/docs/manual/dependencies.md#versioning
     # Details on how the caret and tilde symbols are handled can be found here https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_handling_non_sorting_versions_with_tilde_dot_and_caret
     class Version < BaseVersion
@@ -32,7 +33,7 @@ module SemverDialects
 
       attr_reader :tokens, :addition, :epoch
 
-      def initialize(tokens, epoch: nil, release_tag: nil)
+      def initialize(tokens, epoch: nil, release_tag: nil) # rubocop:todo Lint/MissingSuper
         @tokens = tokens
         @addition = release_tag
         @epoch = epoch
@@ -67,20 +68,20 @@ module SemverDialects
 
       private
 
-      def compare_epochs(a, b)
+      def compare_epochs(a, b) # rubocop:todo Naming/MethodParameterName
         (a || 0) <=> (b || 0)
       end
     end
 
-    class ReleaseTag < BaseVersion
+    class ReleaseTag < BaseVersion # rubocop:todo Style/Documentation
       include TokenPairComparison
 
-      def initialize(tokens)
+      def initialize(tokens) # rubocop:todo Lint/MissingSuper
         @tokens = tokens
       end
     end
 
-    class VersionParser
+    class VersionParser # rubocop:todo Style/Documentation
       DASH = /-/
       ALPHABET = /([a-zA-Z]+)/
       TILDE = /~/

data/lib/semver_dialects/semantic_version.rb

@@ -57,7 +57,7 @@ module SemverDialects
         prefix_delimiter -= 1
       end
 
-      unless prefix_delimiter < 0
+      unless prefix_delimiter.negative?
         @prefix_segments = split_array[0..prefix_delimiter].map do |group_string|
           SemanticVersionSegment.new(group_string)
         end
@@ -96,7 +96,7 @@ module SemverDialects
       [first_array_prefix.concat(first_array_suffix), second_array_prefix.concat(second_array_suffix)]
     end
 
-    def is_zero?
+    def is_zero? # rubocop:todo Naming/PredicateName
       @prefix_segments.empty? || @prefix_segments.all?(&:is_zero?)
     end
 
@@ -143,12 +143,12 @@ module SemverDialects
     end
   end
 
-  class SemanticVersionSegment
+  class SemanticVersionSegment # rubocop:todo Style/Documentation
     include Comparable
 
     attr_accessor :normalized_group_string, :original_group_string, :is_post_release, :is_pre_release
 
-    @@group_suffixes = {
+    @@group_suffixes = { # rubocop:todo Style/ClassVars
       # pre-releases
       'PRE' => -16,
       'PREVIEW' => -16,
@@ -180,8 +180,8 @@ module SemverDialects
 
       if @@group_suffixes.key?(group_string_ucase)
         value = @@group_suffixes[group_string_ucase]
-        @is_post_release = value > 0
-        @is_pre_release = value < 0
+        @is_post_release = value.positive?
+        @is_pre_release = value.negative?
         @normalized_group_string = @@group_suffixes[group_string_ucase].to_s
       else
         @normalized_group_string = group_string_ucase
@@ -224,12 +224,12 @@ module SemverDialects
       normalized_group_string == 'X'
     end
 
-    def is_number?
+    def is_number? # rubocop:todo Naming/PredicateName
       normalized_group_string.number?
     end
 
-    def is_zero?
-      is_number? ? normalized_group_string.to_i == 0 : false
+    def is_zero? # rubocop:todo Naming/PredicateName
+      is_number? ? normalized_group_string.to_i.zero? : false
     end
   end
 end

data/lib/semver_dialects/semver2.rb

@@ -7,8 +7,8 @@ module SemverDialects
     # Represents a token that matches any major, minor, or patch number.
     ANY_NUMBER = 'x'
 
-    class Version < BaseVersion
-      def initialize(tokens, prerelease_tag: nil)
+    class Version < BaseVersion # rubocop:todo Style/Documentation
+      def initialize(tokens, prerelease_tag: nil) # rubocop:todo Lint/MissingSuper
         @tokens = tokens
         @addition = prerelease_tag
       end
@@ -41,14 +41,14 @@ module SemverDialects
       end
     end
 
-    class PrereleaseTag < BaseVersion
-      def initialize(tokens)
+    class PrereleaseTag < BaseVersion # rubocop:todo Style/Documentation
+      def initialize(tokens) # rubocop:todo Lint/MissingSuper
         @tokens = tokens
       end
 
       # Returns true if the prerelease tag is empty.
       # In Semver 2 1.2.3-0 is NOT equivalent to 1.2.3.
-      def is_zero?
+      def is_zero? # rubocop:todo Naming/PredicateName
         tokens.empty?
       end
 
@@ -63,7 +63,8 @@ module SemverDialects
             # Numeric identifiers always have lower precedence than non-numeric identifiers.
             return -1
           when nil
-            # A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.
+            # A larger set of pre-release fields has a higher precedence than a smaller set,
+            # if all of the preceding identifiers are equal.
             return 1
           end
         when String
@@ -72,16 +73,19 @@ module SemverDialects
             # Numeric identifiers always have lower precedence than non-numeric identifiers.
             return 1
           when nil
-            # A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.
+            # A larger set of pre-release fields has a higher precedence than a smaller set,
+            # if all of the preceding identifiers are equal.
             return 1
           end
         when nil
           case b
           when Integer
-            # A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.
+            # A larger set of pre-release fields has a higher precedence than a smaller set,
+            # if all of the preceding identifiers are equal.
             return -1
           when String
-            # A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.
+            # A larger set of pre-release fields has a higher precedence than a smaller set,
+            # if all of the preceding identifiers are equal.
             return -1
           end
         end
@@ -91,7 +95,7 @@ module SemverDialects
       end
     end
 
-    class VersionParser
+    class VersionParser # rubocop:todo Style/Documentation
       def self.parse(input)
         new(input).parse
       end

data/lib/semver_dialects/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SemverDialects
-  VERSION = '3.4.2'
+  VERSION = '3.4.4'
 end

data/lib/semver_dialects.rb

@@ -14,23 +14,25 @@ require 'semver_dialects/interval_set'
 require 'semver_dialects/interval_set_parser'
 require 'deb_version'
 
-module SemverDialects
+module SemverDialects # rubocop:todo Style/Documentation
   # Captures all errors that could be possibly raised
   class Error < StandardError
   end
 
-  class UnsupportedPackageTypeError < Error
-    def initialize(pkgType)
-      @pkgType = pkgType
+  class UnsupportedPackageTypeError < Error # rubocop:todo Style/Documentation
+    def initialize(pkg_type)
+      super
+      @pkg_type = pkg_type
     end
 
     def message
-      "unsupported package type '#{@pkgType}'"
+      "unsupported package type '#{@pkg_type}'"
     end
   end
 
-  class UnsupportedVersionError < Error
+  class UnsupportedVersionError < Error # rubocop:todo Style/Documentation
     def initialize(raw_version)
+      super
       @raw_version = raw_version
     end
 
@@ -39,8 +41,9 @@ module SemverDialects
     end
   end
 
-  class InvalidVersionError < Error
+  class InvalidVersionError < Error # rubocop:todo Style/Documentation
     def initialize(raw_version)
+      super
       @raw_version = raw_version
     end
 
@@ -49,8 +52,9 @@ module SemverDialects
     end
   end
 
-  class InvalidConstraintError < Error
+  class InvalidConstraintError < Error # rubocop:todo Style/Documentation
     def initialize(raw_constraint)
+      super
       @raw_constraint = raw_constraint
     end
 
@@ -59,10 +63,11 @@ module SemverDialects
     end
   end
 
-  class IncompleteScanError < InvalidVersionError
+  class IncompleteScanError < InvalidVersionError # rubocop:todo Style/Documentation
     attr_reader :rest
 
     def initialize(rest)
+      super
       @rest = rest
     end
 
@@ -128,7 +133,9 @@ module SemverDialects
       #
       # quoting https://go.dev/ref/mod#pseudo-versions
       #
-      # Each pseudo-version may be in one of three forms, depending on the base version. These forms ensure that a pseudo-version compares higher than its base version, but lower than the next tagged version.
+      # Each pseudo-version may be in one of three forms, depending on the base version.
+      # These forms ensure that a pseudo-version compares higher than its base version,
+      # but lower than the next tagged version.
       #
 
       # vX.0.0-yyyymmddhhmmss-abcdefabcdef is used when there is no known

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: semver_dialects
 version: !ruby/object:Gem::Version
-  version: 3.4.2
+  version: 3.4.4
 platform: ruby
 authors:
 - Julian Thome
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-08-01 00:00:00.000000000 Z
+date: 2024-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pastel
@@ -68,6 +68,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.1
+- !ruby/object:Gem::Dependency
+  name: unparser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.13
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.13
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
@@ -209,7 +223,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="