semian 0.11.4 → 0.11.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c988cdfecca00a6df20c29238464aa7abf607ff59064612015616b38a69e8ac0
-  data.tar.gz: 52682cddc76221d7e09c4d6e9c1074754afc2c648fcb7f19ffea05dfaff9a8f1
+  metadata.gz: 7b5e836c65bee18b5d62d92e165cd34c9beafa0d42c2c408138594d3720abb4d
+  data.tar.gz: 9ba054d5523c916729b2438cefad336305a1ec6818c57a21359f0e9645579050
 SHA512:
-  metadata.gz: e4c6a0b2e33e13abc45641774b7d79faf5bec85241a5704cb1cd9180be5ee99b726b769bf9bf64d77528584fe13b9b875f92c4a04d4f0ef32dd0f1875ee1b3c9
-  data.tar.gz: 75a3f87b1986daac3d4f4528aea225ff30c02637b693c668f6bd799506193c3d4517327f20a194b9251412a8c7c6322b8343656867b64407f22459c93e6dc8e2
+  metadata.gz: 370d75f2276562f2e4b0fda0732a0f2d9faa84259fd0ca8fb1f3eb4e11be98550e17f1dab5a9258333240f0db48316df6115b5e5b184344f2ec3f4438e421c37
+  data.tar.gz: d49a1d3abe581d78634986c3f735134a6d11a84721d97f8807cf205df76ee1a37e4864372927e6554826c8b5d74ca2d1286856a73a264e4e1e85c9e82c164902

data/ext/semian/resource.c

@@ -272,8 +272,11 @@ check_permissions_arg(VALUE permissions)
 static void
 check_tickets_xor_quota_arg(VALUE tickets, VALUE quota)
 {
-  if ((TYPE(tickets) == T_NIL && TYPE(quota) == T_NIL) ||(TYPE(tickets) != T_NIL && TYPE(quota) != T_NIL)){
-    rb_raise(rb_eArgError, "Must pass exactly one of ticket or quota");
+  if (tickets == Qnil && quota == Qnil) {
+    rb_raise(rb_eArgError, "Semian configuration require either the :ticket or :quota parameter, you provided neither");
+  }
+  if (tickets != Qnil && quota != Qnil) {
+    rb_raise(rb_eArgError, "Semian configuration require either the :ticket or :quota parameter, you provided both");
   }
 }
 

data/lib/semian/circuit_breaker.rb

@@ -7,10 +7,11 @@ module Semian
     attr_reader :name, :half_open_resource_timeout, :error_timeout, :state, :last_error
 
     def initialize(name, exceptions:, success_threshold:, error_threshold:,
-                         error_timeout:, implementation:, half_open_resource_timeout: nil)
+                         error_timeout:, implementation:, half_open_resource_timeout: nil, error_threshold_timeout: nil)
       @name = name.to_sym
       @success_count_threshold = success_threshold
       @error_count_threshold = error_threshold
+      @error_threshold_timeout = error_threshold_timeout || error_timeout
       @error_timeout = error_timeout
       @exceptions = exceptions
       @half_open_resource_timeout = half_open_resource_timeout
@@ -124,7 +125,7 @@ module Semian
     end
 
     def push_time(window, time: Time.now)
-      window.reject! { |err_time| err_time + @error_timeout < time.to_i }
+      window.reject! { |err_time| err_time + @error_threshold_timeout < time.to_i }
       window << time.to_i
     end
 

data/lib/semian/net_http.rb

@@ -43,6 +43,14 @@ module Semian
       ::SystemCallError, # includes ::Errno::EINVAL, ::Errno::ECONNRESET, ::Errno::ECONNREFUSED, ::Errno::ETIMEDOUT, and more
     ].freeze # Net::HTTP can throw many different errors, this tries to capture most of them
 
+    module ClassMethods 
+      def new(*args, semian: true)
+        http = super(*args)
+        http.instance_variable_set(:@semian_enabled, semian)
+        http
+      end
+    end
+
     class << self
       attr_accessor :exceptions
       attr_reader :semian_configuration
@@ -75,7 +83,7 @@ module Semian
     end
 
     def disabled?
-      raw_semian_options.nil?
+      raw_semian_options.nil? || @semian_enabled == false
     end
 
     def connect
@@ -115,3 +123,4 @@ module Semian
 end
 
 Net::HTTP.prepend(Semian::NetHTTP)
+Net::HTTP.singleton_class.prepend(Semian::NetHTTP::ClassMethods)

data/lib/semian/redis.rb

@@ -16,6 +16,14 @@ class Redis
     include ::Semian::AdapterError
   end
 
+  class ConnectionError < Redis::BaseConnectionError
+    # A Connection Reset is a fast failure and we don't want to track these errors in 
+    # semian
+    def marks_semian_circuits?
+      message != "Connection lost (ECONNRESET)"
+    end
+  end
+
   ResourceBusyError = Class.new(SemianError)
   CircuitOpenError = Class.new(SemianError)
   ResolveError = Class.new(SemianError)

data/lib/semian/version.rb

@@ -1,3 +1,3 @@
 module Semian
-  VERSION = '0.11.4'
+  VERSION = '0.11.8'
 end

data/lib/semian.rb

@@ -46,7 +46,7 @@ require 'semian/lru_hash'
 # resource the time to recover. If `error_threshold` errors happen in the span of `error_timeout`
 # then the circuit will be opened and every attempt to acquire the resource will immediately fail.
 #
-# Once in open state, after `error_timeout` is elapsed, the ciruit will transition in the half-open state.
+# Once in open state, after `error_timeout` is elapsed, the circuit will transition in the half-open state.
 # In that state a single error will fully re-open the circuit, and the circuit will transition back to the closed
 # state only after the resource is acquired `success_threshold` consecutive times.
 #
@@ -62,7 +62,7 @@ require 'semian/lru_hash'
 #
 # After 3 failures in the span of 10 seconds the circuit will be open.
 # After an additional 10 seconds it will transition to half-open.
-# And finally after 2 successulf acquisitions of the resource it will transition back to the closed state.
+# And finally after 2 successful acquisitions of the resource it will transition back to the closed state.
 #
 # ===== Using a resource
 #
@@ -257,6 +257,7 @@ module Semian
       name,
       success_threshold: options[:success_threshold],
       error_threshold: options[:error_threshold],
+      error_threshold_timeout: options[:error_threshold_timeout],
       error_timeout: options[:error_timeout],
       exceptions: Array(exceptions) + [::Semian::BaseError],
       half_open_resource_timeout: options[:half_open_resource_timeout],

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: semian
 version: !ruby/object:Gem::Version
-  version: 0.11.4
+  version: 0.11.8
 platform: ruby
 authors:
 - Scott Francis
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-01 00:00:00.000000000 Z
+date: 2022-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler
@@ -251,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: Bulkheading for Ruby with SysV semaphores