semantically-taggable 0.1.14 → 0.2.0

data/spec/schema.rb

@@ -28,6 +28,7 @@ ActiveRecord::Schema.define :version => 0 do
     t.string :description
     t.string :delimiter, :limit => 10, :default => ','
     t.boolean :polyhierarchical, :default => false
+    t.boolean :restrict_to_known_tags, :default => false
   end
 
   # Transitive closure table for multiple parent tags

data/spec/semantically_taggable/tag_spec.rb

@@ -1,8 +1,8 @@
 require "spec_helper"
 
 describe SemanticallyTaggable::Tag do
-  let(:scheme) { SemanticallyTaggable::Scheme.by_name(:dg_topics) }
-  let(:other_scheme) { SemanticallyTaggable::Scheme.by_name(:keywords) }
+  let(:dg_topics) { SemanticallyTaggable::Scheme.by_name(:dg_topics) }
+  let(:keywords) { SemanticallyTaggable::Scheme.by_name(:keywords) }
 
   before do
     reset_database!
@@ -21,21 +21,46 @@ describe SemanticallyTaggable::Tag do
       }.should raise_error(ActiveRecord::RecordNotFound)
     end
 
-    it "should save schemes with the tag" do
-      scheme = SemanticallyTaggable::Scheme.by_name(:dg_topics)
-      keyword = SemanticallyTaggable::Tag.create(:name => '1', :scheme => scheme)
-      keyword.scheme = scheme
-      keyword.save!
-      keyword = SemanticallyTaggable::Tag.find_by_name('1')
-      keyword.scheme.should == scheme
-    end
+    describe "creating tags within schemes" do
+      it "should save schemes with the tag" do
+        SemanticallyTaggable::Tag.create!(:name => '1') do |tag|
+          tag.scheme = dg_topics
+        end
 
-    it "should treat tags in different schemes as different tags" do
-      keyword = SemanticallyTaggable::Tag.create(:name => '1', :scheme => SemanticallyTaggable::Scheme.by_name(:dg_topics))
-      keyword.save!
-      lambda {
-        SemanticallyTaggable::Tag.find_or_create_all_with_like_by_name('1', '2', :keywords)
-      }.should change(SemanticallyTaggable::Tag, :count).by(2)
+        tag = SemanticallyTaggable::Tag.find_by_name('1')
+        tag.scheme.should == dg_topics
+      end
+
+      it "should treat tags in different schemes as different tags" do
+        SemanticallyTaggable::Tag.create(:name => '1') do |tag|
+          tag.scheme = dg_topics
+        end
+
+        lambda {
+          SemanticallyTaggable::Tag.find_or_create_all_with_like_by_name('1', '2', :keywords)
+        }.should change(SemanticallyTaggable::Tag, :count).by(2)
+      end
+
+      it "should not find tags in different schemes equal" do
+        topic = SemanticallyTaggable::Tag.create(:name => '1') do |tag|
+          tag.scheme = dg_topics
+        end
+        tag = SemanticallyTaggable::Tag.create(:name => '1') do |tag|
+          tag.scheme = keywords
+        end
+
+        topic.should_not == tag
+      end
+
+      it "should silently drop tags when the scheme is set to restrict_to_known_tags" do
+        tag = SemanticallyTaggable::Tag.create(:name => '1') do |tag|
+          tag.scheme = dg_topics
+        end
+
+        lambda {
+          SemanticallyTaggable::Tag.find_or_create_all_with_like_by_name('1', '2', :dg_topics).should == [tag]
+        }.should change(SemanticallyTaggable::Tag, :count).by(0)
+      end
     end
   end
 
@@ -43,9 +68,9 @@ describe SemanticallyTaggable::Tag do
     describe "Tag relationships" do
       describe "Bidirectional associations" do
         before do
-          @parent = scheme.create_tag(:name => 'Tax')
-          @child = scheme.create_tag(:name => 'Income Tax')
-          @unrelated = scheme.create_tag(:name => 'unrelated')
+          @parent = dg_topics.create_tag(:name => 'Tax')
+          @child = dg_topics.create_tag(:name => 'Income Tax')
+          @unrelated = dg_topics.create_tag(:name => 'unrelated')
         end
 
         describe "when assigning with narrower" do
@@ -68,27 +93,14 @@ describe SemanticallyTaggable::Tag do
           specify { @child.broader_tags.should include(@parent) }
           specify { @parent.narrower_tags.should include(@child) }
         end
-
-#        describe "when assigning from both ends, such as might happen in the import" do
-#          before do
-#            @parent.narrower_tags << @child
-#            @child.broader_tags << @parent
-#
-#            @child.save
-#            @parent.save
-#          end
-#
-#          specify { @parent.should have(1).narrower_tag }
-#          specify { @child.should have(1).broader_tag }
-#        end
       end
 
       describe "Related tags" do
         before do
-          @tax_tag = scheme.create_tag(:name => 'Tax')
-          @income_tax_tag = scheme.create_tag(:name => 'Income Tax')
-          @inheritance_tax_tag = scheme.create_tag(:name => 'Inheritance Tax')
-          @giraffes = scheme.create_tag(:name => 'giraffes')
+          @tax_tag = dg_topics.create_tag(:name => 'Tax')
+          @income_tax_tag = dg_topics.create_tag(:name => 'Income Tax')
+          @inheritance_tax_tag = dg_topics.create_tag(:name => 'Inheritance Tax')
+          @giraffes = dg_topics.create_tag(:name => 'giraffes')
 
           @tax_tag.related_tags << [@income_tax_tag, @inheritance_tax_tag]
           @tax_tag.save
@@ -129,8 +141,8 @@ describe SemanticallyTaggable::Tag do
   end
 
   describe "Tag synonyms" do
-    let(:benefits_tag) { scheme.create_tag(:name => 'Benefits') }
-    let(:benefits_keyword) { other_scheme.create_tag(:name => 'Benefits') }
+    let(:benefits_tag) { dg_topics.create_tag(:name => 'Benefits') }
+    let(:benefits_keyword) { keywords.create_tag(:name => 'Benefits') }
 
     it "should allow a tag to have synonyms" do
       benefits_tag.synonyms << SemanticallyTaggable::Synonym.new(:name => 'State Benefits')

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: semantically-taggable
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  hash: 23
+  prerelease: 
   segments: 
   - 0
-  - 1
-  - 14
-  version: 0.1.14
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Russell Garner
@@ -14,120 +15,128 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-28 00:00:00 +01:00
+date: 2011-06-01 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: rails
+  prerelease: false
+  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 3
         - 0
         version: "3.0"
-  type: :runtime
-  prerelease: false
+  name: rails
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: activerecord
+  prerelease: false
+  type: :runtime
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 3
         - 0
         version: "3.0"
-  type: :runtime
-  prerelease: false
+  name: activerecord
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: mysql
+  prerelease: false
+  type: :runtime
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  prerelease: false
+  name: mysql
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: nokogiri
+  prerelease: false
+  type: :runtime
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  prerelease: false
+  name: nokogiri
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  prerelease: false
+  type: :development
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 31
         segments: 
         - 2
         - 4
         - 0
         version: 2.4.0
-  type: :development
-  prerelease: false
+  name: rspec
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
-  name: bundler
+  prerelease: false
+  type: :development
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 23
         segments: 
         - 1
         - 0
         - 0
         version: 1.0.0
-  type: :development
-  prerelease: false
+  name: bundler
   version_requirements: *id006
 - !ruby/object:Gem::Dependency 
-  name: jeweler
+  prerelease: false
+  type: :development
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 1
         - 5
         - 2
         version: 1.5.2
-  type: :development
-  prerelease: false
+  name: jeweler
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
-  name: rcov
+  prerelease: false
+  type: :development
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  type: :development
-  prerelease: false
+  name: rcov
   version_requirements: *id008
 description: |-
   Based really very heavily on acts_as_taggable_on, but introduces tagging schemes and moves
@@ -192,7 +201,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 2677708864870805089
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -201,13 +210,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: A semantic tagging system for Rails 3