semantic_puppet 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3b8c9749c1289e2571d5252ea6bd1a464545d9f
-  data.tar.gz: c73441801b17011eb978062596b86216bcb224f1
+  metadata.gz: cc232fb3f2d16e77531d2a52282d78b6e2c020c0
+  data.tar.gz: 2692a3f0c579ea9ddc068ea79a973d8765b3c407
 SHA512:
-  metadata.gz: 5bf4ca513a1edde4040868602fb1ff4b92d849681547cfb11a8e7f274c1b169ff61eec066fcfd1c5ba9b9178fd6c3cfa91b508bf126706163ea73ccd6836bc95
-  data.tar.gz: 72d5a7cf4727fc5d84adff17884d433de4ee0d985bcccd4cab1170a33346d3bea81ed69df5f7c9b8f75161acc5ed812bf259db1ef915e82626b2649b6f4a97f8
+  metadata.gz: 913af8f7fa2657363468237d267f2f4de79246f285273a2aaf328038f1f2ff11488001c8bee281ad989ded8401227c878c422963ed208aa14a178084e904cd7a
+  data.tar.gz: e32a58891d6b026a47dce06b5cd9eec259c3706cf4b30a3ba34345e4ec887df2e04041929c3df8dbc34607b32396fdafee0388350b3adc9fa82147399818ec68

data/.travis.yml

@@ -1,14 +1,29 @@
 ---
 language: ruby
+
 cache: bundler
+
+before_install:
+  - bundle -v
+  - rm Gemfile.lock || true
+  - gem update --system
+  - gem update bundler
+  - gem --version
+  - bundle -v
+
 script: "bundle exec rspec --color --format documentation spec/unit"
+
 notifications:
   email: false
+
 sudo: false
+
 rvm:
-  - "2.3.1"
+  - "2.4.1"
   - "2.1.9"
+  - "2.0.0"
   - "1.9.3"
   - "jruby-19mode"
+
 jdk:
   - oraclejdk8

data/CHANGELOG.md

@@ -2,8 +2,14 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.0.2 - 2018-03-13
+- Removed i18n/gettext configuration and string externalization. After further consideration we have decided that
+  as a library, semantic_puppet should not be attempting to configure global localization state and the localization
+  of error messages etc. is the responsibility of the consuming application.
+- Added Appveyor CI configuration
+
 ## 1.0.1 - 2017-07-01
-- Fix bug causing pre-release identifiers being considered invalid when they contained letters but started with a zero 
+- Fix bug causing pre-release identifiers being considered invalid when they contained letters but started with a zero
 
 ## 1.0.0 - 2017-04-05
 - Complete rewrite of the VersionRange to make it compatible with Node Semver

data/README.md

@@ -12,10 +12,6 @@ Versions and Version Ranges and to query and resolve module dependencies.
 
 For sparse, but accurate documentation, please see the docs directory.
 
-Note that this is a 0 release version, and things can change. Expect that the
-version and version range code to stay relatively stable, but the module
-dependency code is expected to change.
-
 This library is used by a number of Puppet Labs projects, including
 [Puppet](https://github.com/puppetlabs/puppet) and
 [r10k](https://github.com/puppetlabs/r10k).
@@ -23,9 +19,8 @@ This library is used by a number of Puppet Labs projects, including
 Requirements
 ------------
 
-Semantic_puppet will work on several ruby versions, including 1.9.3, 2.0.0, and
-2.1.0. Ruby 1.8.7 is immediately deprecated as it is in
-[r10k](https://github.com/puppetlabs/r10k).
+Semantic_puppet will work on several ruby versions, including 1.9.3,
+2.0.0, 2.1.9 and 2.4.1. Please see the exact matrix in `.travis.yml`.
 
 No gem/library requirements.
 
@@ -48,40 +43,22 @@ install it out of a git repository:
 Usage
 -----
 
-SemanticPuppet is intended to be used as a library. 
+SemanticPuppet is intended to be used as a library.
 
 ### Version Range Operator Support
 
-SemanticPuppet will support the same version range operators as those used when
-publishing modules to [Puppet Forge](https://forge.puppetlabs.com) which is
-documented at 
-[Publishing Modules on the Puppet Forge](https://docs.puppetlabs.com/puppet/latest/reference/modules_publishing.html#dependencies-in-metadatajson).
-
-### i18n
-
-When adding new error or log messages please follow the instructions for
-[writing translatable code](https://github.com/puppetlabs/gettext-setup-gem#writing-translatable-code).
-
-The SemanticPuppet gem will default to outputing all error messages in English, but you may set the locale
-using the `FastGettext.set_locale` method. If translations do not exist for the language you request then the gem will
-default to English. The `set_locale` method will return the locale, as a string, that FastGettext will now
-use to report PuppetForge errors.
-
-``` ruby
-# Assuming the German translations exist, this will set the reporting language
-# to German
-
-locale = FastGettext.set_locale "de_DE"
-
-# If it successfully finds Germany's locale, locale will be "de_DE"
-# If it fails to find any German locale, locale will be "en"
-```
+SemanticPuppet will support the same version range operators as those
+used when publishing modules to [Puppet
+Forge](https://forge.puppetlabs.com) which is documented at [Publishing
+Modules on the Puppet
+Forge](https://docs.puppetlabs.com/puppet/latest/reference/modules_publishing.html#dependencies-in-metadatajson).
 
 Contributors
 ------------
 
-Pieter van de Bruggen wrote the library originally, with additions by Alex
-Dreyer, Jesse Scott and Anderson Mills.
+Pieter van de Bruggen wrote the library originally. See
+[https://github.com/puppetlabs/semantic_puppet/graphs/contributors](https://github.com/puppetlabs/semantic_puppet/graphs/contributors)
+for a list of contributors.
 
 ## Maintenance
 
@@ -90,4 +67,5 @@ Maintainers:
 * Jesse Scott, jesse@puppet.com
 * Anderson Mills, anderson@puppet.com
 
-Tickets: File at https://tickets.puppet.com/browse/FORGE
+Tickets: File at
+[https://tickets.puppet.com/browse/FORGE](https://tickets.puppet.com/browse/FORGE)

data/Rakefile

@@ -56,12 +56,3 @@ begin
 rescue LoadError
   warn "[Warning]: Could not load `bundler/gem_tasks`."
 end
-
-# Gettext tasks
-begin
-  spec = Gem::Specification.find_by_name 'gettext-setup'
-  load "#{spec.gem_dir}/lib/tasks/gettext.rake"
-  GettextSetup.initialize(File.absolute_path('locales', File.dirname(__FILE__)))
-rescue LoadError
-  warn "[Warning]: Could not load gettext tasks."
-end

data/appveyor.yml

@@ -0,0 +1,18 @@
+version: 1.0.1.{build}
+clone_depth: 10
+environment:
+  matrix:
+    - RUBY_VERSION: 193
+    - RUBY_VERSION: 23-x64
+    - RUBY_VERSION: 21-x64
+matrix:
+  fast_finish: true
+install:
+  - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - bundle install --jobs 4 --retry 2
+build: off
+test_script:
+  - ruby -v
+  - gem -v
+  - bundle -v
+  - bundle exec rspec --format documentation --color spec/unit

data/lib/semantic_puppet.rb

@@ -1,8 +1,4 @@
-require 'gettext-setup'
-
 module SemanticPuppet
-  GettextSetup.initialize(File.absolute_path('../locales', File.dirname(__FILE__)))
-
   autoload :Version, 'semantic_puppet/version'
   autoload :VersionRange, 'semantic_puppet/version_range'
   autoload :Dependency, 'semantic_puppet/dependency'

data/lib/semantic_puppet/gem_version.rb

@@ -1,3 +1,3 @@
 module SemanticPuppet
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/lib/semantic_puppet/version.rb

@@ -15,7 +15,7 @@ module SemanticPuppet
     def self.parse(ver)
       match, major, minor, patch, prerelease, build = *ver.match(REGEX_FULL_RX)
 
-      raise ValidationFailure, _("Unable to parse '%{version}' as a semantic version identifier") % {version: ver} unless match
+      raise ValidationFailure, "Unable to parse '#{ver}' as a semantic version identifier" unless match
 
       new(major.to_i, minor.to_i, patch.to_i, parse_prerelease(prerelease), parse_build(build)).freeze
     end
@@ -42,7 +42,7 @@ module SemanticPuppet
       return nil unless prerelease
       prerelease.split('.').map do |x|
         if x =~ /^\d+$/
-          raise ValidationFailure, _('Numeric pre-release identifiers MUST NOT contain leading zeroes') if x.length > 1 && x.start_with?('0')
+          raise ValidationFailure, 'Numeric pre-release identifiers MUST NOT contain leading zeroes' if x.length > 1 && x.start_with?('0')
           x.to_i
         else
           x

data/lib/semantic_puppet/version_range.rb

@@ -74,7 +74,7 @@ module SemanticPuppet
           # Split on whitespace
           simples = range.split(RANGE_SPLIT).map do |simple|
             match_data = SIMPLE_EXPR.match(simple)
-            raise ArgumentError, _("Unparsable version range: \"%{range}\"") % { range: range_string } unless match_data
+            raise ArgumentError, "Unparsable version range: \"#{range_string}\"" unless match_data
             operand = match_data[2]
 
             # Case based on operator
@@ -104,7 +104,7 @@ module SemanticPuppet
 
     def self.parse_partial(expr)
       match_data = PARTIAL_EXPR.match(expr)
-      raise ArgumentError, _("Unparsable version range: \"%{expr}\"") % { expr: expr } unless match_data
+      raise ArgumentError, "Unparsable version range: \"#{expr}\"" unless match_data
       match_data
     end
     private_class_method :parse_partial
@@ -332,7 +332,7 @@ module SemanticPuppet
     # @return [VersionRange] the common subset
     # @api public
     def intersection(other)
-      raise ArgumentError, _("value must be a %{type}") % { :type => self.class.name } unless other.is_a?(VersionRange)
+      raise ArgumentError, "value must be a #{self.class.name}" unless other.is_a?(VersionRange)
       result = @ranges.map { |range| other.ranges.map { |o_range| range.intersection(o_range) } }.flatten
       result.compact!
       result.uniq!

data/semantic_puppet.gemspec

@@ -22,8 +22,6 @@ spec = Gem::Specification.new do |s|
   # Dependencies
   s.required_ruby_version = '>= 1.9.3'
 
-  s.add_dependency "gettext-setup", ">= 0.3"
-
   s.add_development_dependency "json", "~> 1.8.3" if RUBY_VERSION < '2.0'
   s.add_development_dependency "rake"
   s.add_development_dependency "rspec"

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: semantic_puppet
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-01 00:00:00.000000000 Z
+date: 2018-03-13 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: gettext-setup
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -125,6 +111,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- appveyor.yml
 - lib/semantic_puppet.rb
 - lib/semantic_puppet/dependency.rb
 - lib/semantic_puppet/dependency/graph.rb
@@ -135,7 +122,6 @@ files:
 - lib/semantic_puppet/gem_version.rb
 - lib/semantic_puppet/version.rb
 - lib/semantic_puppet/version_range.rb
-- locales/config.yaml
 - semantic_puppet.gemspec
 - spec/spec_helper.rb
 - spec/unit/semantic_puppet/dependency/graph_node_spec.rb
@@ -166,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Useful tools for working with Semantic Versions.

data/locales/config.yaml

@@ -1,21 +0,0 @@
----
-# This is the project-specific configuration file for setting up
-# fast_gettext for your project.
-gettext:
-  # This is used for the name of the .pot and .po files; they will be
-  # called <project_name>.pot?
-  project_name: 'semantic_puppet'
-  # This is used in comments in the .pot and .po files to indicate what
-  # project the files belong to and should bea little more desctiptive than
-  # <project_name>
-  package_name: Semantic Puppet Gem
-  # The locale that the default messages in the .pot file are in
-  default_locale: en
-  # The email used for sending bug reports.
-  bugs_address: docs@puppetlabs.com
-  # The holder of the copyright.
-  copyright_holder: Puppet, Inc.
-  # Patterns for +Dir.glob+ used to find all files that might contain
-  # translatable content, relative to the project root directory
-  source_files:
-    - 'lib/**/*.rb'