semantic_puppet 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6cc51e7ab0b07b0b4c1979c14793404659c9720a
-  data.tar.gz: 3227968773bf344fc65892aad90f6f0fd05647ae
+  metadata.gz: f3b8c9749c1289e2571d5252ea6bd1a464545d9f
+  data.tar.gz: c73441801b17011eb978062596b86216bcb224f1
 SHA512:
-  metadata.gz: 08852e7be254e66d9ca6c3b577535d127326132f63b13c9c1989092057398e5e9a4471264f85219b884b0b16eceef7e6873bbaee4ea6bdf6b0d6bb2f4c79a3c9
-  data.tar.gz: 2be83a97af2b3533fdf0b77c9bbf85d6216e66a3ef88c721d60843411541dc1c36493e6ea75acca75cd72ddac0a7929106a44f3118c28e0c60f4163898e6c406
+  metadata.gz: 5bf4ca513a1edde4040868602fb1ff4b92d849681547cfb11a8e7f274c1b169ff61eec066fcfd1c5ba9b9178fd6c3cfa91b508bf126706163ea73ccd6836bc95
+  data.tar.gz: 72d5a7cf4727fc5d84adff17884d433de4ee0d985bcccd4cab1170a33346d3bea81ed69df5f7c9b8f75161acc5ed812bf259db1ef915e82626b2649b6f4a97f8

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.0.1 - 2017-07-01
+- Fix bug causing pre-release identifiers being considered invalid when they contained letters but started with a zero 
+
 ## 1.0.0 - 2017-04-05
 - Complete rewrite of the VersionRange to make it compatible with Node Semver
 - General speedup of Version (hash, <=>, and to_s in particular)

data/lib/semantic_puppet/gem_version.rb

@@ -1,3 +1,3 @@
 module SemanticPuppet
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/semantic_puppet/version.rb

@@ -30,7 +30,7 @@ module SemanticPuppet
         false
       else
         prerelease = match[4]
-        prerelease.nil? || prerelease.split('.').all? { |x| !(x =~ /^0\d+/) }
+        prerelease.nil? || prerelease.split('.').all? { |x| !(x =~ /^0\d+$/) }
       end
     end
 

data/spec/unit/semantic_puppet/version_spec.rb

@@ -351,22 +351,199 @@ describe SemanticPuppet::Version do
   end
 
   describe '.valid?' do
-    # All the specific variations are tested in the .parse tests, so these are just basic
-    # smoke tests.
-
     def subject(str)
       SemanticPuppet::Version.valid?(str)
     end
 
-    it 'recognizes valid versions' do
-      expect(subject('1.0.1')).to be true
-      expect(subject('1.0.3-p324')).to be true
+    context 'Spec v2.0.0' do
+      context 'Section 2' do
+        # A normal version number MUST take the form X.Y.Z where X, Y, and Z are
+        # non-negative integers, and MUST NOT contain leading zeroes. X is the
+        # major version, Y is the minor version, and Z is the patch version.
+
+        it 'rejects versions that contain too few parts' do
+          expect(subject('1.2')).to be false
+        end
+
+        it 'rejects versions that contain too many parts' do
+          expect(subject('1.2.3.4')).to be false
+        end
+
+        it 'rejects versions that contain non-integers' do
+          expect(subject('x.2.3')).to be false
+          expect(subject('1.y.3')).to be false
+          expect(subject('1.2.z')).to be false
+        end
+
+        it 'rejects versions that contain negative integers' do
+          expect(subject('-1.2.3')).to be false
+          expect(subject('1.-2.3')).to be false
+          expect(subject('1.2.-3')).to be false
+        end
+
+        it 'rejects version numbers containing leading zeroes' do
+          expect(subject('01.2.3')).to be false
+          expect(subject('1.02.3')).to be false
+          expect(subject('1.2.03')).to be false
+        end
+
+        it 'permits zeroes in version number parts' do
+          expect(subject('0.2.3')).to be true
+          expect(subject('1.0.3')).to be true
+          expect(subject('1.2.0')).to be true
+        end
+      end
+
+      context 'Section 9' do
+        # A pre-release version MAY be denoted by appending a hyphen and a
+        # series of dot separated identifiers immediately following the patch
+        # version. Identifiers MUST comprise only ASCII alphanumerics and
+        # hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric
+        # identifiers MUST NOT include leading zeroes. Pre-release versions
+        # have a lower precedence than the associated normal version. A
+        # pre-release version indicates that the version is unstable and
+        # might not satisfy the intended compatibility requirements as denoted
+        # by its associated normal version.
+        # Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.
+
+        it 'rejects prerelease identifiers with non-alphanumerics' do
+          expect(subject('1.2.3-$100')).to be false
+          expect(subject('1.2.3-rc.1@me')).to be false
+        end
+
+        it 'rejects empty prerelease versions' do
+          expect(subject('1.2.3-')).to be false
+        end
+
+        it 'rejects empty prerelease version identifiers' do
+          expect(subject('1.2.3-.rc1')).to be false
+          expect(subject('1.2.3-rc1.')).to be false
+          expect(subject('1.2.3-rc..1')).to be false
+        end
+
+        it 'rejects numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-01')).to be false
+          expect(subject('1.2.3-rc.01')).to be false
+        end
+
+        it 'permits numeric prerelease identifiers of zero' do
+          expect(subject('1.2.3-0')).to be true
+          expect(subject('1.2.3-rc.0')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers' do
+          expect(subject('1.2.3-DEADBEEF')).to be true
+          expect(subject('1.2.3-DE.AD.BE.EF')).to be true
+          expect(subject('2.1.0-12-BE-EF')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-0xDEADBEEF')).to be true
+          expect(subject('1.2.3-rc.0x10c')).to be true
+          expect(subject('2.1.0-0016-13fae4a9')).to be true
+        end
+      end
+
+      context 'Section 10' do
+        # Build metadata MAY be denoted by appending a plus sign and a series
+        # of dot separated identifiers immediately following the patch or
+        # pre-release version. Identifiers MUST comprise only ASCII
+        # alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty.
+        # Build metadata SHOULD be ignored when determining version precedence.
+        # Thus two versions that differ only in the build metadata, have the
+        # same precedence.
+        # Examples: 1.0.0-alpha+001, 1.0.0+20130313144700,
+        # 1.0.0-beta+exp.sha.5114f85.
+
+        it 'rejects build identifiers with non-alphanumerics' do
+          expect(subject('1.2.3+$100')).to be false
+          expect(subject('1.2.3+rc.1@me')).to be false
+        end
+
+        it 'rejects empty build metadata' do
+          expect(subject('1.2.3+')).to be false
+        end
+
+        it 'rejects empty build identifiers' do
+          expect(subject('1.2.3+.rc1')).to be false
+          expect(subject('1.2.3+rc1.')).to be false
+          expect(subject('1.2.3+rc..1')).to be false
+        end
+
+        it 'permits numeric build identifiers with leading zeroes' do
+          expect(subject('1.2.3+01')).to be true
+          expect(subject('1.2.3+rc.01')).to be true
+        end
+
+        it 'permits numeric build identifiers of zero' do
+          expect(subject('1.2.3+0')).to be true
+          expect(subject('1.2.3+rc.0')).to be true
+        end
+
+        it 'permits non-numeric build identifiers with leading zeroes' do
+          expect(subject('1.2.3+0xDEADBEEF')).to be true
+          expect(subject('1.2.3+rc.0x10c')).to be true
+        end
+      end
     end
 
-    it 'does not recognize invalid versions' do
-      expect(subject('1.0')).to be false      # too few segments
-      expect(subject('1.0.3.6')).to be false  # too many segments
-      expect(subject('1.03.14')).to be false  # leading zero in segment
+    context 'Spec v1.0.0' do
+      context 'Section 2' do
+        # A normal version number MUST take the form X.Y.Z where X, Y, and Z
+        # are integers. X is the major version, Y is the minor version, and Z
+        # is the patch version.
+
+        it 'rejects versions that contain too few parts' do
+          expect(subject('1.2')).to be false
+        end
+
+        it 'rejects versions that contain too many parts' do
+          expect(subject('1.2.3.4')).to be false
+        end
+
+        it 'rejects versions that contain non-integers' do
+          expect(subject('x.2.3')).to be false
+          expect(subject('1.y.3')).to be false
+          expect(subject('1.2.z')).to be false
+        end
+
+        it 'permits zeroes in version number parts' do
+          expect(subject('0.2.3')).to be true
+          expect(subject('1.0.3')).to be true
+          expect(subject('1.2.0')).to be true
+        end
+      end
+
+      context 'Section 4' do
+        # A pre-release version number MAY be denoted by appending an arbitrary
+        # string immediately following the patch version and a dash. The string
+        # MUST be comprised of only alphanumerics plus dash [0-9A-Za-z-].
+        # Pre-release versions satisfy but have a lower precedence than the
+        # associated normal version. Precedence SHOULD be determined by
+        # lexicographic ASCII sort order.
+        # For instance: 1.0.0-alpha1 < 1.0.0-beta1 < 1.0.0-beta2 < 1.0.0-rc1
+
+        it 'rejects prerelease identifiers with non-alphanumerics' do
+          expect(subject('1.2.3-$100')).to be false
+          expect(subject('1.2.3-rc.1@me')).to be false
+        end
+
+        it 'rejects empty prerelease versions' do
+          expect(subject('1.2.3-')).to be false
+        end
+
+        it 'rejects numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-01')).to be false
+        end
+
+        it 'permits numeric prerelease identifiers of zero' do
+          expect(subject('1.2.3-0')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-0xDEADBEEF')).to be true
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: semantic_puppet
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-26 00:00:00.000000000 Z
+date: 2017-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gettext-setup